FancyBox 4 SMF

[Bugo]

Recently I discovered the following bug:
A post has multiple images. If I click on one, then it is displayed in normal size, as before. But the arrows on the left and right edge to switch to the next / previous image are missing. Instead, I have to close the tab and click the next image in the post.

SMF2.1.3, PHP8

Are these images all in the same post, or are they in different posts but in the same topic?

[Rick53]

All these images are in the same post.

[Bugo]

Can you provide a link for testing?

[Rick53]

Sorry, it's not a forum post. I need to speak to my programmer.

[Bugo]

OK, another question then - do you want the images attached to the post to be in the same gallery along with the images inserted via attach and img tags?

[Rick53]

We have found the error. It wasn't due to SMF, but to a self-programming
But thanks for your quick reaction!

[Bugo]

v1.2

Code Select Expand

* Fixed found issues
* Added possibility to enable/disable processing of attached images
* Created a translation project on the Crowdin


[Darknico]

Hi @Bugo
after install the 1.2, show this error:

Fatal error: Uncaught TypeError: FancyBox::attachBbcValidate(): Argument #5 ($disabled) must be of type array, null given, called in /xxx/forum/Sources/Subs.php on line 5766 and defined in /xxx/forum/Sources/Class-FancyBox.php:154 Stack trace: #0 /xxx/forum/Sources/Subs.php(5766): FancyBox->attachBbcValidate() #1 /xxx/forum/Sources/Subs.php(1815): call_integration_hook() #2 /xxx/forum/Sources/Subs.php(3643): {closure}() #3 /xxx/forum/Sources/Optimus/Subs.php(33): parse_bbc() #4 /xxx/forum/Sources/Optimus/app.php(29): Bugo\Optimus\Subs::getTeaser() #5 /xxx/forum/Sources/Optimus/Topics.php(178): op_teaser() #6 /xxx/forum/Sources/Optimus/Topics.php(96): Bugo\Optimus\Topics->makeDescriptionFromFirstMessage() #7 /xxx/forum/Sources/Subs.php(5766): Bugo\Optimus\Topics->menuButtons() #8 /xxx/forum/Sources/Subs.php(5571): call_integration_hook() #9 /xxx/forum/Sources/Subs.php(4357): setupMenuContext() #10 /xxx/forum/Sources/Subs.php(4514): setupThemeContext() #11 /xxx/forum/Sources/Subs.php(4157): template_header() #12 /xxx/forum/index.php(201): obExit() #13 {main} thrown in /xxx/forum/Sources/Class-FancyBox.php on line 154

PHP: 8.0.14, SMF 2.0.13

in attach, the Italian translation

[Bugo]

https://crowdin.com/project/fancybox-4-smf

[Darknico]

https://crowdin.com/project/fancybox-4-smf

Added 

[Darknico]

@Bugo
I tested last commit
https://github.com/dragomano/FancyBox-4-SMF/commit/f79cbed270c1c7e5341ca2560a6d0484d3fa12a6

Now work correctly 
Thanks

[peter_mein]

Hello
It wouldn't be bad if you clicked on an image
and the contribution was then displayed.
So he jumps to the contribution.

[brynn]

I'm sorry. After posting my results from the test requested in this message I have not clearly understood the subsequent posts.

Does this message mean there is a whole new version of this mod?

If so, is that code on the crowdin site the same that is now on the SMF mod site?

Thanks again.

[Bugo]

Crowdin stores translations only.

[brynn]

Oh ok.

Well, it looked to me like there is a new version of this mod on the SMF mod site, so I installed it.  But it's still throwing the same error.  Now it reports the error is on line 172, but it seems like the same error to me.  Here's a screenshot of the error.  Please let me know if I can provide any additional info.

You cannot view this attachment.

[Bugo]

That's right, because this mod is not responsible for this error, you need to edit SMF files.

[brynn]

We did make that edit, and it did not help.

https://www.simplemachines.org/community/index.php?msg=4150718

https://www.simplemachines.org/community/index.php?msg=4150564

Is there some way I can prove to you that we made the edit?  Unfortunately, our site is not online yet (maintenance mode).  But I could retrieve a file for you.

[Darknico]

That's right, because this mod is not responsible for this error, you need to edit SMF files.

Same error
I think this issue
https://github.com/SimpleMachines/SMF/issues/7625
Right?

Ok waiting

[Bugo]

I think 1 more fix is needed. But it's hard to fix errors when neither the mod settings nor the messages that cause errors are shown to me

[brynn]

Of course I could show you the messages, but it's a testing forum right now. I hesitate to make it public because we've been posting things that we would not normally post in a public forum. 

Would the source code from the messages work for you?

I could provide source code plus screenshots for individual messages, if that would help.

What's the best way to send you the mod settings?

Maybe the backtrace would help?

As I said, I'll be glad to send whatever you need.  It's just that I don't know much about coding, so I don't already know what you need.

Please tell me what you need