Spoiler Tag

[AzaToth]

Fixed a small bug, (a typo in a variable), not needed to upgrade, but you mig get some errors if using a custom theme

[Elijah Bliss]

Ok, a quick change, in 0.2.1, splitted the permissions so there are both for show spoilers and to post them.
Because of this you can have a group that can post spoilers, but can not show them (not my fault if you so have ), but it's more logical that you have a group that can show spoilers but can't post new ones.

/Carl

also, if you want to prevent people from quoting spoilers:

Code (Find in Posts.php) Select Expand


}
// Posting a reply without a quote?


Code (Add before) Select Expand


    allowedTo('admin_forum') ? '' : $form_message = preg_replace(array('~\n?\[spoiler.*?\].+?\[/spoiler\]\n?~is', '~^\n~', '~\[/spoiler]~'), '', $form_message);


already done tht I think, but admin_forum?

Administrators should be allowed to quote spoilers and other custom permission based tags.

[AzaToth]

Ok, a quick change, in 0.2.1, splitted the permissions so there are both for show spoilers and to post them.
Because of this you can have a group that can post spoilers, but can not show them (not my fault if you so have ), but it's more logical that you have a group that can show spoilers but can't post new ones.

/Carl

also, if you want to prevent people from quoting spoilers:

Code (Find in Posts.php) Select Expand


}
// Posting a reply without a quote?


Code (Add before) Select Expand


    allowedTo('admin_forum') ? '' : $form_message = preg_replace(array('~\n?\[spoiler.*?\].+?\[/spoiler\]\n?~is', '~^\n~', '~\[/spoiler]~'), '', $form_message);


already done tht I think, but admin_forum?

Administrators should be allowed to quote spoilers and other custom permission based tags.

The definition of allowedTo defines:

Code Select Expand

bool allowedTo(string permission, array boards = current)
- checks whether the user is allowed to do permission. (ie. post_new.)
- if boards is specified, checks those boards instead of the current
  one.
- always returns true if the user is an administrator.
- returns true if he or she can do it, false otherwise.
Or did you refere to some other admin?

[Elijah Bliss]

Ok, a quick change, in 0.2.1, splitted the permissions so there are both for show spoilers and to post them.
Because of this you can have a group that can post spoilers, but can not show them (not my fault if you so have ), but it's more logical that you have a group that can show spoilers but can't post new ones.

/Carl

also, if you want to prevent people from quoting spoilers:

Code (Find in Posts.php) Select Expand


}
// Posting a reply without a quote?


Code (Add before) Select Expand


    allowedTo('admin_forum') ? '' : $form_message = preg_replace(array('~\n?\[spoiler.*?\].+?\[/spoiler\]\n?~is', '~^\n~', '~\[/spoiler]~'), '', $form_message);


already done tht I think, but admin_forum?

Administrators should be allowed to quote spoilers and other custom permission based tags.

The definition of allowedTo defines:

Code Select Expand

bool allowedTo(string permission, array boards = current)
- checks whether the user is allowed to do permission. (ie. post_new.)
- if boards is specified, checks those boards instead of the current
  one.
- always returns true if the user is an administrator.
- returns true if he or she can do it, false otherwise.
Or did you refere to some other admin?

Well my global moderators have forum administration permissions. You can always swap out allowedTo('admin_forum') to $user_info['is_admin']. 

[AzaToth]

Ok, a quick change, in 0.2.1, splitted the permissions so there are both for show spoilers and to post them.
Because of this you can have a group that can post spoilers, but can not show them (not my fault if you so have ), but it's more logical that you have a group that can show spoilers but can't post new ones.

/Carl

also, if you want to prevent people from quoting spoilers:

Code (Find in Posts.php) Select Expand


}
// Posting a reply without a quote?


Code (Add before) Select Expand


    allowedTo('admin_forum') ? '' : $form_message = preg_replace(array('~\n?\[spoiler.*?\].+?\[/spoiler\]\n?~is', '~^\n~', '~\[/spoiler]~'), '', $form_message);


already done tht I think, but admin_forum?

Administrators should be allowed to quote spoilers and other custom permission based tags.

The definition of allowedTo defines:

Code Select Expand

bool allowedTo(string permission, array boards = current)
- checks whether the user is allowed to do permission. (ie. post_new.)
- if boards is specified, checks those boards instead of the current
  one.
- always returns true if the user is an administrator.
- returns true if he or she can do it, false otherwise.
Or did you refere to some other admin?

Well my global moderators have forum administration permissions. You can always swap out allowedTo('admin_forum') to $user_info['is_admin']. 

I thought doing this was enough:

Code Select Expand

if(!allowedTo('spoiler_show') || !allowedTo('spoiler_post'))
$form_message = preg_replace(array('~\n?\[spoiler.*?\].+?\[/spoiler\]\n?~is', '~^\n~', '~\[/spoiler\]~'), '', $form_message);

[Yamake]

Eheheheh, nicely coded.  Now all you need is a [me] command to go with it! XD

[Elijah Bliss]

Ok, a quick change, in 0.2.1, splitted the permissions so there are both for show spoilers and to post them.
Because of this you can have a group that can post spoilers, but can not show them (not my fault if you so have ), but it's more logical that you have a group that can show spoilers but can't post new ones.

/Carl

also, if you want to prevent people from quoting spoilers:

Code (Find in Posts.php) Select Expand


}
// Posting a reply without a quote?


Code (Add before) Select Expand


    allowedTo('admin_forum') ? '' : $form_message = preg_replace(array('~\n?\[spoiler.*?\].+?\[/spoiler\]\n?~is', '~^\n~', '~\[/spoiler]~'), '', $form_message);


already done tht I think, but admin_forum?

Administrators should be allowed to quote spoilers and other custom permission based tags.

The definition of allowedTo defines:

Code Select Expand

bool allowedTo(string permission, array boards = current)
- checks whether the user is allowed to do permission. (ie. post_new.)
- if boards is specified, checks those boards instead of the current
  one.
- always returns true if the user is an administrator.
- returns true if he or she can do it, false otherwise.
Or did you refere to some other admin?

Well my global moderators have forum administration permissions. You can always swap out allowedTo('admin_forum') to $user_info['is_admin']. 

I thought doing this was enough:

Code Select Expand

if(!allowedTo('spoiler_show') || !allowedTo('spoiler_post'))
$form_message = preg_replace(array('~\n?\[spoiler.*?\].+?\[/spoiler\]\n?~is', '~^\n~', '~\[/spoiler\]~'), '', $form_message);

Now I remember why I used that conditional, I originally used it top the quoting of html from members who didn't have html permissions, which was everyone except global moderators.

[xenovanis]

I installed version 0.2.2 and got these errors in my log:

8: Undefined index: spoiler_tag_hover
File: .../testforum/Sources/Subs.php
Line: 910

8: Undefined index: spoiler_tag_click
File: .../testforum/Sources/Subs.php
Line: 901


Fix: In Subs.php

Code (find) Select Expand


$txt['spoiler_tag_hover']


Code (replace) Select Expand


$txt['spoiler_tag_hover_info']


Code (find) Select Expand


$txt['spoiler_tag_click']


Code (replace) Select Expand


$txt['spoiler_tag_click_info']


Nice mod, btw 

[AzaToth]

I installed version 0.2.2 and got these errors in my log:

8: Undefined index: spoiler_tag_hover
File: .../testforum/Sources/Subs.php
Line: 910

8: Undefined index: spoiler_tag_click
File: .../testforum/Sources/Subs.php
Line: 901


Fix: In Subs.php

Code (find) Select Expand


$txt['spoiler_tag_hover']


Code (replace) Select Expand


$txt['spoiler_tag_hover_info']


Code (find) Select Expand


$txt['spoiler_tag_click']


Code (replace) Select Expand


$txt['spoiler_tag_click_info']


Nice mod, btw 

Strange, I thought I had fix that for 0.2.2 (found it in 0.2.1), must check it if I used right files....

[xtremecruiser]

I just DL the latest one and also get

Undefined index: spoiler_tag_click in /XXX/Sources/Subs.php on line 892

Undefined index: spoiler_tag_click in /XXX/Sources/Subs.php on line 901

The Hoover is fine

I also do not have the classic theme ( many dont ) and it looks for it in the install.

[AzaToth]

I just DL the latest one and also get

Undefined index: spoiler_tag_click in /XXX/Sources/Subs.php on line 892

Undefined index: spoiler_tag_click in /XXX/Sources/Subs.php on line 901

The Hoover is fine

I also do not have the classic theme ( many dont ) and it looks for it in the install.

Classic theme is installed by default, thats why I made it for it, but if you say is true that many remove the classic, I can easly add check for it.

[xtremecruiser]

I just DL the latest one and also get

Undefined index: spoiler_tag_click in /XXX/Sources/Subs.php on line 892

Undefined index: spoiler_tag_click in /XXX/Sources/Subs.php on line 901

The Hoover is fine

I also do not have the classic theme ( many dont ) and it looks for it in the install.

Classic theme is installed by default, thats why I made it for it, but if you say is true that many remove the classic, I can easly add check for it.

Is that why I get the
Undefined index: spoiler_tag_click in /XXX/Sources/Subs.php on line 892

Undefined index: spoiler_tag_click in /XXX/Sources/Subs.php on line 901

errors ?  Or is there another fix ?

[AzaToth]

I just DL the latest one and also get

Undefined index: spoiler_tag_click in /XXX/Sources/Subs.php on line 892

Undefined index: spoiler_tag_click in /XXX/Sources/Subs.php on line 901

The Hoover is fine

I also do not have the classic theme ( many dont ) and it looks for it in the install.

Classic theme is installed by default, thats why I made it for it, but if you say is true that many remove the classic, I can easly add check for it.

Is that why I get the
Undefined index: spoiler_tag_click in /XXX/Sources/Subs.php on line 892

Undefined index: spoiler_tag_click in /XXX/Sources/Subs.php on line 901

errors ?  Or is there another fix ?

No, that I now fixed in 0.2.3, I forgot to add _info to a few indexes.

[xtremecruiser]

I just DL the latest one and also get

Undefined index: spoiler_tag_click in /XXX/Sources/Subs.php on line 892

Undefined index: spoiler_tag_click in /XXX/Sources/Subs.php on line 901

The Hoover is fine

I also do not have the classic theme ( many dont ) and it looks for it in the install.

Classic theme is installed by default, thats why I made it for it, but if you say is true that many remove the classic, I can easly add check for it.

Is that why I get the
Undefined index: spoiler_tag_click in /XXX/Sources/Subs.php on line 892

Undefined index: spoiler_tag_click in /XXX/Sources/Subs.php on line 901

errors ?  Or is there another fix ?

No, that I now fixed in 0.2.3, I forgot to add _info to a few indexes.

Installed and works fine.
Thanks

[xtremecruiser]

Hum, just installed on my main site and the spoiler only shows for the admins ?
RC1.1
No my default theme is a different one than normal one.

ERR set the permissions for each profile and they still can not see it 

Gave every groups acess to it, even the guests. Only the admins can see it.

if a regular member tries to quote the post they get nothing instead of the

Code Select Expand

[spoiler]boo[/spoiler]
OMG I found the issue.
I have local permissions on some boards to keep the "lower" membergroup from posting in them
Its gonna be a long afternoon redoing this

[AzaToth]

Hum, just installed on my main site and the spoiler only shows for the admins ?
RC1.1
No my default theme is a different one than normal one.

ERR set the permissions for each profile and they still can not see it 

Gave every groups acess to it, even the guests. Only the admins can see it.

if a regular member tries to quote the post they get nothing instead of the

Code Select Expand

[spoiler]boo[/spoiler]
OMG I found the issue.
I have local permissions on some boards to keep the "lower" membergroup from posting in them
Its gonna be a long afternoon redoing this

hehe, hope you fix it the mod uses allowedTo() to check if the member (membergroup) is allowed to post OR show spoiler (not XOR), if this is somewhat confusing, please tell me so

[xtremecruiser]

Hum, just installed on my main site and the spoiler only shows for the admins ?
RC1.1
No my default theme is a different one than normal one.

ERR set the permissions for each profile and they still can not see it 

Gave every groups access to it, even the guests. Only the admins can see it.

if a regular member tries to quote the post they get nothing instead of the

Code Select Expand

[spoiler]boo[/spoiler]
OMG I found the issue.
I have local permissions on some boards to keep the "lower" membergroup from posting in them
Its gonna be a long afternoon redoing this

hehe, hope you fix it the mod uses allowedTo() to check if the member (membergroup) is allowed to post OR show spoiler (not XOR), if this is somewhat confusing, please tell me so

I have it now, I just use local permissions on some boards so changing the members permissions does nothing to effect access, I have to do each one

[Ben_S]

Thanks, one of the very few mods I have installed.

[Hawkes]

Great mod!  I have it installed with 1.1 RC1 and the Helios Multi mod.  I had some editing to do, but all-in-all it works great.

One suggestion, ability to modify the colors of the spolier box.... both background and text without having to customize the .css sheet.

[Omar Bazavilvazo]

Thanks...

AMAZING job... Just what I needed...

This is 1 of the 2 mods installed in my forum

Gracias!