Advertisement:

Author Topic: Post and PM Inline Attachments  (Read 182590 times)

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,767
  • Mod King
    • XPtsp.com Community
Post and PM Inline Attachments
« on: July 26, 2014, 09:14:08 PM »
Link to Mod

v6.14 - September 18th, 2018
o Fixed issue that prevented attachments being inserted inline (and which actually de-selected attachments) when a previously saved post that already had the maximum number of attachments allowed was being modified to insert the attachments inline.
o Commented out check in ./Sources/Subs-InlineAttachmentsAdmin.php for later version of ILA as domain www.xptsp.com has expired and version check was causing 'Inline Attachments' menu option to hang/timeout.
o Temporarily removed support for SMF 2.1 Beta 3 because mod wasn't working as expected (this will be reinstated when time permits).

v6.13 - June 9th, 2018
o Added message for PM preview to indicate attachment has not been uploaded yet.
o Updated installation code for SMF 2.0.x to enable this mod to be installed and/or uninstalled before and/or after the Automatic Attachment Rotation (and Resize) mod without generating errors in Display.php.

v6.12 - April 28th, 2018
o Per @rjen - added Dutch language files.
o Added UTF8 language files for English.

v6.11 - April 27th, 2018
o As per pepa's post fixed issue that was causing change of Should first attachment should be numbered "1"? option to throw error for SQL query.
o For SMF 2.0: Re-added code to display a label if an attachment in a post which is being modified is awaiting approval.

v6.10 - April 3rd, 2018
o Per GL700Wing's post, modified Custom Views of Attachments mod to match attachment viewing modifications.

v6.9 - March 20th, 2018
o Changed HTML download count building code, based on GL700's post.

v6.8 - March 15th, 2018
o Included updated Subs-InlineAttachments.php file.
o Updated Spanish Latin translation by Rock Lee.

v6.7 - March 15th, 2018
o Per GL700Wing: Add space on either side of each new inline attachment tag.
o Per GL700Wing: Fixed buffer issue in Sources/Subs-CustomView.php.
o Added CSS and code for a fix for truncating long filenames to picture width.
o Removed obsolete ILA.css file from the mod file list.
o Removed obsolete popup language strings.
o Added code to filter HTML tags from TXT files.
o Added admin option to disable filtering HTML from TXT files.

v6.6 - March 4th, 2018
o Made changes to admin tag adjustment code for better Postgres compatibility.
o Fixed an issue where text after inline attachment was a hyperlink.

v6.5 - March 1st, 2018
o Fixed error relating to unavailable mime_content_type function.
o Added fallback code to use finfo_file when mime_content_type isn't available.

v6.4 - February 17th, 2018
o Implemented GL700Wing's fixes, as shown here.

v6.3 - January 7th, 2018
o Fixed coding syntax error in Subs-InlineAttachments.php.

v6.2 - December 18th, 2017
o Fixed errors generated by NULL being was passed to in_array function.
o Fixed code fragment using ILA_mime_type in Display.php.

v6.1 - December 15th, 2017
o Fixed installer where ILA actions are inserted.

v6.0 - December 8th, 2017
o Per GL700Wing: Fixed issue where inserting a PM attachment inline doesn't work.
o Per GL700Wing: Fixed issue where inline PM attachments were being displayed as unapproved.
o Per GL700Wing: Fixed install issue with PM Attachments mod regarding ManageAttachments.php.
o Per GL700Wing: Fixed issue where inline PM attachments are shown again under PM text.
o Per GL700Wing: Fixed issue where inline PM attachments can't be downloaded.
o Per GL700Wing: Fixed issue where no option to clear/remove the first attachment when composing a new message.
o Per GL700Wing: Fixed issue where [attachthumb] is an expandable thumbnail.
o Per GL700Wing: Fixed issue so that inline attachments can be quoted in Tapatalk.
o Per GL700Wing: Fixed another issue code so that inline attachments can be quoted in Tapatalk.
o Per GL700Wing: Fixed issue with Custom Attachment View mod where all attachments are shown.
o Copied mime detection code from my Play Media Attachments mod.

v5.13 - November 26th, 2017
o Added support for the Tapatalk mod.
o Fixed undefined variable error when HS4SMF mod is installed and enabled.

v5.12 - November 14th, 2017
o Modified code to enclose ILA tag with "display: inline-block" CSS style, based on @rjen's code snipet..
o Fixed attachment not inline after editing post, per GL700Wing's instructions.
o Fixed download link/counter code for display, per GL700Wing's instructions.

v5.11 - October 18th, 2017
o Modified code to return already-build attachment context array if available.
o Fixed reporting invalid attachment when viewing attachments on board wasn't possible.

v5.10 - September 8th, 2017
o Fixed the HTML building code so various parameters work properly.
o Fixed undefined array element error in Subs-InlineAttachments.php.

v5.9 - August 31st, 2017
o Completed SMF 2.1 Beta 3 template edits. Javascript edits still needed.
o Replaced IFNULL with COALESCE in database queries for better Postgres support.

v5.8 - July 8th, 2017
o Updated source code for SMF 2.1 Beta 1 & 2. Templates are still unedited.
o Removed support for SMF 2.1 Beta 1 & 2.
o Attempt fix for issue where incomplete information was pulled for attachments.

v5.7 - July 5th, 2017
o Fixed 2 undefined index errors found by GL700Wing. Thanks, GL700Wing!
o Resolved undefined array element errors coming from Automatic Attachment Rotation mod. Thanks, GL700Wing!!

v5.6 - March 15th, 2017
o Fixed regex expressions so that code & quote tags are processed correctly.

v5.5 - March 11th, 2017
o Fixed "(more attachments)" issue. Thanks, LG965!

v5.4 - March 10th, 2017
o Fixed readme compatibility note about HS4SMF mod being installed first.
o Fixed issue where topic ID was changed by code pulling attachments.
o Fixed issue where ILA tags within code tags were incorrectly translated.
o Fixed issue with Highslide mods and maximum width/height settings.
o Fixed incompatibility with URL Popup mod.
o Fixed error where unable to load language file after uninstalling.

v5.3.1 - March 5th, 2017
o Removed debug statement accidentally left in the mod.

v5.3 - March 4th, 2017
o Fixed code that returns the image dimensions to the HTML building code.
o Removed ILA popup window with ILA parameters. Will be replaced by new stuff....

v5.2 - February 24th, 2017
o Fixed issue where popup option wasn't linked to anything....
o Fixed responsive CSS image stuff that I added in version 5.0.
o Fixed scale parameter to disable/enable responsive stuff on request.
o Added admin option to enable responsive CSS image stuff.
o Added bbcode option to scale parameter to invert responsive settings.

v5.1 - February 23rd, 2017
o Added an operation to copy ILA.css to proper folder.

v5.0 - February 17th, 2017
o Added help link and popup window to the Post screen.
o Rewrote bbcode handling code to properly handle each bbcode.
o Modified Sources/Help.php operation to use different line to look for.
o Fixed issue where PMs with inline attachments only showed "[ Attachment ]"
o Fixed issue where SimplePortal didn't display embedded attachments.
o Fixed undefined index error in Subs-InlineAttachments.php when using HS4SMF mod.
o Fixed several undefined variable errors in Subs-InlineAttachments.php.
o Fixed incompatibility with PM Attachments version 2.0 Beta 1.
o Fixed PM issue where "[attachment id=0 msg=new]" returns "[ Attachment ]".
o Changed inline TXT files so that they are parsed (for security reasons!)

v4.16 - October 16th, 2016
o Added maximum display width and height fields to ILA settings page.
o Added ILA insert format selector to ILA settings page.
o Modified code so that insert ILA code inserts requested format ILA tag into post.
o Modified code so that ILA maximum display values are used instead of attachment settings values.
o Modified code so that ILA maximum display values take priority over user-specified values.
o Modified admin code that didn't correctly cache update mod query response to website.
o Removed all href="javascript:void(0)" references from all XML files.
o Merge language XML files with language PHP files.
o Fixed changelog so that versions before 3.1 are accounted for.

v4.15 - April 15th, 2016
o Added Spanish Latin translation by Rock Lee [BC].

v4.14 - November 21st, 2015
o Added support for the "Boilerplates for Posts" mod to update ILA tags used.
o Modified ILA_Admin_Adjust to attempt to avoid incorrect of post messages.

v4.13 - November 15th, 2015
o Rewrote ILA admin page so that hopefully the ILA tags are modified correctly.
o Fixed potential issue with adjusting ILA tags with attachment IDs greater than 9.
o Made changes suggested by dcmouser to code using HighSlide for SMF (HS4SMF) mod.
o Added message during post preview to indicate attachment has not been uploaded yet.
o Adjusted admin page because some servers error on trying to retrieve latest mod version.
o Modified permission checking code so that the board permissions can be properly used.
o Fixed issue where global language variable was overwritten by ILA_Invalid_Tags function.
o Fixed a few typecasting issues found which caused a few problems on some servers.
o Fixed error message where array was passed instead of integer value in loop.

v4.12 - November 11th, 2015
o Fixed the ILA_Admin_Adjust function so that it doesn't screw up posts with ILA tags.

v4.11 - November 10th, 2015
o Fixed undefined index error in PersonalMessage.template.php, reported by brynn.
o Modified renumbering function to avoid "hacking attempt" error message.

v4.10 - November 5th, 2015
o "Allow quoted attachments from another post" is ignored if Tapatalk mod is detected.
o "Allow quoted attachments from another post" is now unchecked and disabled when Tapatalk mod is detected.
o Modified ILA admin area so that video options are disabled if embedding video option is not checked.
o Added help strings to the ILA admin area to attempt to clearly define what the options do.
o Added Javascript validation functions to the ILA admin area so that invalid data cannot be entered.
o Fixed issue with scaling ILA option where maximum image size was used instead all the time.

v4.9 - October 30th, 2015
o Fixed double Javascript function declaration issue, found by asmith.
o Fixed undefined index error where apparently no attachments were available for the post.
o Fixed undefined variable error that detects whether SCEditor is installed.
o SMF 2.1: Fixed code-breaking syntax error that was found by asmith.

v4.8 - October 24th, 2015
o Fixed issue where Javascript not inserted when no or only one more attachment is allowed in post.

v4.7 - October 17th, 2015
o SMF 2.1: Fixed two undefined errors within install_21.xml.
o SMF 2.1: Fixed issue where additional attachments couldn't be added during post edit.
o Fixed several undefined errors within Subs-InlineAttachments.php.

v4.6 - October 4th, 2015
o Fixed erroneous v4.5 update where ILA tag parameters were removed.

v4.5 - October 3rd, 2015
o Fixed undefined offset error within "fix param order" function.

v4.4 - September 11th, 2015
o Rewrote the code that puts the download counter and link underneath the inline attachment.
o Fixed issue where thumbnail image is still shown under post regardless of setting.
o Fixed issue where text under image is still shown under inline image regardless of setting.

v4.3 - September 9th, 2015
o Added MIME types for AVI and WMV files.
o SMF 2.1: Fixed Javascript issue where option to upload additional files wasn't available.
o SMF 2.1: Fixed formatting issue for download/viewed counts underneath inline attachments.
o SMF 2.1: Fixed missing clip icon underneath inline attachment in download/viewed counts.

v4.2 - September 4th, 2015
o Operation that calls "fix parameter order" function now skipped for nightly SMF 2.1 Beta 2.

v4.1 - August 29th, 2015
o Added option to switch between using HTML5 video tags with flash fallback and using flash only.
o Fixed minor issue where the forum crashes on the Post page.
o Fixed install-time error in add_remove_hooks.php when .htaccess doesn't exist.

v4.0 - August 28th, 2015
o Added code to adjust the inline attachment IDs when "one-based numbering" option is changed.
o For post author, admin and moderators, unapproved image attachments are shown as partly transparent.
o Fixed issue with links in ILA download info not being formed correctly.
o Fixed issue with ILA download info not showing the original image size correctly.
o Seperated admin functions from general bbcode functions and placed in new file.
o Reorganized ILA options so that their organization makes more sense (at least to me).
o Revised the video playing code so that hopefully it works better now.
o Added default video width and height options. Defaults to 640x400.
o Added support for SVG files as inline attachments and option to enable it.
o Added support for TXT files as inline attachments and option to enable it. Inserts as part of post.
o Added support for PDF files as inline attachments and option to enable it. Defaults to 500x600.
o Added option to control unapproved image opacity percentage. 0 returns "unapproved" message.
o Made "Highslide" option visible, but disabled when no supported Highslide mods are installed.
o Made "EXIF" option visible, but disabled when EXIF mod isn't installed.
o Modified install code so that only mod settings that aren't already set are set.

v3.17 - August 10th, 2015
o Fixed issue with the post preview display of inline attachments.
o Fixed issue with download counter being display with image styles being applied.
o Modified code to make "Inline Attachment" string more language-friendly....

v3.16 - July 30th, 2015
o Performance increase due to modification of parse_bbc function to deal with memory issue found.
o Rewrote to make "border-style" mandatory for use with "border-width" and "border-color".
o Added ILA tags without "border-style", "border-width", or "border-color" parameters.
o Fixed issue where that borders weren't displayed correctly without float/margin paramters.

v3.15 - July 26th, 2015
o Added "border-style", "border-width" and "border-color" ILA parameters.
o Rewrote code that controls which image is shown to the user using the ILA tags.
o Added option in ILA settings to set inserted tag using the "Insert Attachment" link.
o Resurrected template change to use version 2.0 bbcodes to insert inline attachments code.
o Fixed code that reorganizes the ILA tags when insert new attachment and deleting existing attachment.
o Fixed issue where attachments weren't in the correct order in the Edit Post screen.
o Modified code to put the message ID in any ILA tags that don't have it upon posting.

v3.14 - July 13th, 2015
o Fixed the "attach bbcode same as attachment" option so that it works as expected.
o Fixed incorrectly closed tag with SCEditor.

v3.13 - July 12th, 2015
o Added "margin-left", "margin-right", "margin-top" and "margin-bottom" ILA parameters.
o Rewrote code to apply float and margin parameters to all ILA tags used.
o Fixed a few undefined errors within Subs-InlineAttachments.php.
o Fixed issue when quoted ILA tags were disabled, normal ILA tags didn't work either.
o Fixed issue where download link/counter didn't line up with image when margin was used.

v3.12 - July 12th, 2015
o Resurrected some changes from v3.9 that somehow disappeared in v3.10.
o Fixed the ILA settings page so that it correctly saves the settings.
o Fixed ILA_Fix_Param_Order so that it doesn't drop all the parameters.
o Minor change to make sure internal message ID variable is set.
o Fixed some invalid regular expressions to make sure they get the message ID.
o Fixed error-creating operation within PersonalMessage.php.

v3.11 - July 10th, 2015
o Added code to internally transform closed ILA tags ([attach]) into proper ILA tags. Thanks, dcmouser!
o Moved settings from Modification Settings to the Attachments and Avatars section.
o Fixed an undefined variable error in PersonalMessage.php.
o Made some performance optimization changes.

v3.10 - July 5th, 2015
o Fixed issue where msg parameter was added twice to ILA tags in new posts.
o Fixed ILA_Fix_Param_Order so that extraneous " " weren't added to the created link.
o Fixed ILA_Fix_Param_Order so that it doesn't reuse parameters from another ILA tag.
o Altered msg parameter to accept "new" as an acceptable parameter input for preview purposes.

v3.9 - July 4th, 2015
o Fixed the ILA float parameter so that float=center works as expected.
o Added code to make sure ILA tag parameters are in the correct order.
o Added code to add the message ID to quoted inline attachments BEFORE the user sees it.
o Removed the option added in v3.8 to stop adding message ID to quoted inline attachments.
o Altered templates to use version 2.0 bbcodes to insert inline attachments code.
o Altered templates to add the message ID to the insert inline attachments code.

v3.8 - July 3rd, 2015
o Fixed issue with post preview reporting not allowed to view attachments.
o Added override of "Display attachments as pictures under post" option to show pictures when disabled.
o Added an option to stop adding message ID to quoted inline attachments.
o Added an option to allow playing attached videos within the post.
o Added support for playing attached MP4, OGG and WebM video files (requires HTML5 browser or QuickTime).
o Added support for playing attached WMV files (requires Windows Media Player).
o Added support for playing attached AVI and DivX video files (requires DivX codec to be installed).
o Fixed undefined variable errors when certain mod settings don't get set during install.

v3.7 - June 6th, 2015
o Fixed syntax error in PersonalMessage.template.php.
o Fixed undefined index error within Subs-InlineAttachments.php

v3.6 - June 5th, 2015
o Fixed language loading issue within Sources/Post.php.

v3.5 - April 14th, 2015
o Fixed issue where error generated on post with attachments, but no inline images.
o Fixed issue where insert attachment link didn't work if post had one less than maximum attachments.

v3.4 - April 14th, 2015
o Fixed topic display issue when using Recent Forum Topics Boardindex mod.
o Fixed inline attachment display issue when quoting inline attachments from another post.
o Fixed issue with quoting inline attachments that changed the bbcode to an unusable bbcode.
o Added check to make sure image attachment has been approved before displaying it.

v3.3.2 - May 3rd, 2015
o Minor font size adjustment to the code displaying the EXIF information.

v3.3.1 - May 2nd, 2015
o Fixed code that shows the Highslide and EXIF option in the ILA settings.

v3.3 - May 2nd, 2015
o Added checkbox to enable the display of EXIF information (when available) to ILA settings.
o Modified Subs-InlineAttachments.php to display EXIF information when option is enabled.
o Modified code to optimize memory usage within Sources/Display.php.

v3.2 - May 2nd, 2015
o Modified inserting attachment javascript code so that it works with SMF 2.1 Beta 1....
o Modified inserting attachment javascript code so that it works with SMF 2.0 with SCEditor mod installed.
o Fixed bug relating to referring to inline attachments from another message.
o All settings reset to their default settings upon installation or upgrade.

v3.1.2 - April 27th, 2015
o Fixed missing variable declaration on ILA settings page.

v3.1.1 - April 25th, 2015
o Added code to cache the mod version check for 1 day between checks.
o Fixed code regarding times download and download link without float/margin parameter.

v3.1 - April 24th, 2015
o Fixed a bug preventing previewing posts from working correctly.
o Viewing inline attachments now works for guests when viewing PM attachments permission is granted.
o Edited posts will be changed to use the new "Version 3.0"-style tags.
o Changed inserted inline attachment tag from "[attachment=n][/attachment]" to "[attachment=n]".
o Added some forgotten template changes to make the "One-based numbering" option work correctly.
o Fixed a bug so that quotes without message ID no longer remove inline attachments with message ID specifed.
o Fixed bug so that floating inline attachment had a download link & counter beneath it when option is set.
o Fixed a few undefined errors within Subs-InlineAttachments.php.
o Fixed multiple bugs in ILA_Fix_Tags function.
o Fixed undefined element error within Sources/Display.php.
o ILA settings moved into a seperate area under Modification Settings, includes online version check.

v3.0 - April 17th, 2015
o Added "msg" parameter so that attachments from other posts can be included/quoted.
o Added code to allow inline attachments used in a post to be properly quoted.
o Added code to internally change the "[attach=n]" form to "[attach=n][/attach]" without modifying posts.
o Added code to remove text between brackets, aka "[attach=0]This file[/attach]" without modifying posts.
o Added option to use "One-based numbering" instead of "Zero-based numbering".
o Modified ID parameter so that invalid ID numbers are errored out instead of zeroed.
o Added option to make "[attach=n]" as same as "[attachment=n]" bbcodes.
o Fixed ILA_Remove_Tags function so that it removes the other 11 ILA bbcodes forms.
o Fixed ILA_Remove_Attachment function so that it removes the other 11 ILA bbcodes forms.
o Removed BBC buttton introduced in v2.8beta2 from the editor.
o Language strings are in seperate file and now loaded from Subs-InlineAttachments.php.
o Moved code responsible for setting topic ID (2.8beta3 fix) into Subs-InlineAttachments.php.

v2.8beta3 - April 13th, 2015
o Fixed display code in unread and unreadreplies action, as well as show posts in profile area.

v2.8beta2 - April 6th, 2015
o Added BBC button to the editor to make attachments inline.

v2.8beta1 - April 6th, 2015
o Updated for SMF 2.1 Beta 1
o Fixed some visual bugs for SMF 2.0 installs.

v2.7 - March 12th, 2015
o Changed some code to correctly count the number of existing attachments.

v2.6 - February 13th, 2014
o Added an option to disable the nosniff header until a better solution is found....
o Fixed a bug in the Post.template.php and PersonalMessage.template.php templates regarding adding more attachments.
o Fixed a bug that added "Insert Attachment 1" where "Insert Attachment 2" should have been.

v2.5 - January 19th, 2015
o License change to Simplified BSD. No functionality change.

v2.4 - January 11th, 2015
o Fixed undefined index error within Subs-InlineAttachments.php...

v2.3 - December 28th, 2014
o Performance enhancement due to storing permission check after first check.
o Fixed spacing issues between picture and download counter/link. Thanks, RSI!

v2.2 - December 22th, 2014
o New BBCode added: attachurl
o margin parameter allowed to be used seperate from the float parameter.
o Fixed the code creating the float parameter so that it works (again)
o Fixed attachmini bbcode to return a blank string if attachment is not an image.
o Added scale parameter to v2.x bbcodes, accepting false, true, yes, and no.

v2.1 - December 19th, 2014
o New BBCodes added: attach, attachthumb, and attachmini.
o Some reorganization of the code to accommodate the new BBCodes.
o Image not scaled if both width and height are specified.
o Parameter validation functions fixed to prevent negative values from being passed.
o No highslide features if image size is smaller than specified max image dimensions.
o Fixed image placement code by removing "block_level" requirements from all BBcodes...

v2.0 - December 7th, 2014
o Added new form of the attachment bbcode, as explained above.
o Fixed preview capability in non-WYSIWYG mode for already saved attachments in posts...
o Changed code that scales image to use global settings only if no size is specified by the user.
o Modified link building code for HS4SMF so that it properly groups the attachments.
o Added support for Highslide Image Viewer.
o Added support for JQLightBox.

v1.5 - December 6th, 2014
o Fixed attachments not being hidden after use in post with Custom View of Attachments installed.

v1.4 - August 23th, 2014
o Fixed multiple issues in the inline attachment validation function.

v1.3 - August 17th, 2014
o Fixed javascript code for issue with pressing "More Attachments" in Posts.

v1.2 - August 11th, 2014
o Fixed some undefined language string errors found in mod
o Modified code to insert attachments after pressing "More Attachments" in Posts and PMs

v1.1 - July 28th, 2014
o Fixed two undeclared array element errors in PersonalMessage.template.php...

v1.0 - July 21th, 2014
o Initial Release of the mod
« Last Edit: January 19, 2015, 09:42:22 AM by dougiefresh »

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,767
  • Mod King
    • XPtsp.com Community
Re: Post and PM Inline Attachments
« Reply #1 on: July 28, 2014, 06:44:18 PM »
Uploaded v1.1 - July 28th, 2014
o Fixed two undeclared array element errors in PersonalMessage.template.php...

EDIT: Fixed inccorect year in release info....
« Last Edit: August 11, 2014, 12:23:34 PM by dougiefresh »

Offline grimmoire

  • Newbie
  • *
  • Posts: 4
Re: Post and PM Inline Attachments
« Reply #2 on: July 30, 2014, 01:39:36 PM »
Hello!

Thank you for this mod.

But i have one problem after installation. When i create new topic, i can insert inline attachment only for first attachment, for others link is not displayed:



If i create topic or message and edit it later, everything all right.

Highslide4SMF is installed.

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,767
  • Mod King
    • XPtsp.com Community
Re: Post and PM Inline Attachments
« Reply #3 on: August 01, 2014, 07:53:18 PM »
Hello!

Thank you for this mod.

But i have one problem after installation. When i create new topic, i can insert inline attachment only for first attachment, for others link is not displayed:



If i create topic or message and edit it later, everything all right.

Highslide4SMF is installed.
I'm gonna have to figure out why this is happening....

Offline nuberry

  • Semi-Newbie
  • *
  • Posts: 11
Re: Post and PM Inline Attachments
« Reply #4 on: August 04, 2014, 07:50:03 AM »
Hi there
looks like a great mod, however when i load it says  - Test failed (Ignore Errors)

is this okay , should i ignore or is there a conflict

many thanks
andrew

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,767
  • Mod King
    • XPtsp.com Community
Re: Post and PM Inline Attachments
« Reply #5 on: August 04, 2014, 07:47:13 PM »
Not having the PM attachments mod installed will result in the "Test Failed (Ignore Errors)" message.  The Post Inline Attachments will work, but PM Inline Attachments won't work without PM Attachments mod installed.

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,767
  • Mod King
    • XPtsp.com Community
Re: Post and PM Inline Attachments
« Reply #6 on: August 11, 2014, 04:05:41 PM »
Hello!

Thank you for this mod.

But i have one problem after installation. When i create new topic, i can insert inline attachment only for first attachment, for others link is not displayed:



If i create topic or message and edit it later, everything all right.

Highslide4SMF is installed.
I'm gonna have to figure out why this is happening....
I apologize about the late response....

UPDATE: I've got the Post inline attachments working correctly, however, the PM inline attachments is giving me trouble.  Will keep at it until I get it fixed....

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,767
  • Mod King
    • XPtsp.com Community
Re: Post and PM Inline Attachments
« Reply #7 on: August 11, 2014, 05:35:50 PM »
Uploaded v1.2 - Auguset 11th, 2014
o Fixed some undefined language string errors found in mod
o Modified code to insert attachments after pressing "More Attachments" in Posts and PMs

Offline Sweetwater

  • Semi-Newbie
  • *
  • Posts: 90
  • Gender: Male
    • SWFishing on Facebook
    • @SweetWaterFish on Twitter
    • Sweetwater Fishing Australia
Re: Post and PM Inline Attachments
« Reply #8 on: August 16, 2014, 08:46:48 AM »
A great idea for a mod. However I'm having same problem as above after installing v1.2 on smf 2.08

Can only add one attachment now, but the first attachment inserts exactly as described. Attempt to add more attachments it jumps to top of page and nothing else. Same as when editting a post and trying to add another attachment.

A great attempt at a good idea, thanks for your efforts but will need to uninstall on my forum.

Kind regards

Offline saurabh1938

  • Semi-Newbie
  • *
  • Posts: 85
    • Gotripperz
Re: Post and PM Inline Attachments
« Reply #9 on: August 16, 2014, 06:04:25 PM »
This is the MOD that is most important for my forum. I am eagerly waiting for the bug fix... Currently after the fresh install, when I click on more attachment, it takes me to somewhere else. I am looking forward for the bug fix and refreshing this page every couple of hours. Please let me know by when you would be able to fix this thing.... but superb effort and appreciate your help.
Visit my forum : www.gotripperz.com

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,767
  • Mod King
    • XPtsp.com Community
Re: Post and PM Inline Attachments
« Reply #10 on: August 16, 2014, 09:22:13 PM »
Sigh...  :o Damn....  I thought I took care of this issue  ???  Lemme look into it again.....

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,767
  • Mod King
    • XPtsp.com Community
Re: Post and PM Inline Attachments
« Reply #11 on: August 17, 2014, 08:32:05 AM »
Uploaded v1.3 - August 17th, 2014
o Fixed javascript code for issue with pressing "More Attachments" in Posts.

Thank you for the bug reports, grimmoire, Sweetwater and saurabh1938!!  I overlooked one stupid little variable in Post.template.php, which was why it wasn't working.  Amazingly, I had fixed it on my localhost forum, but forgot to transcribe my changes back into the install.xml file....

Offline saurabh1938

  • Semi-Newbie
  • *
  • Posts: 85
    • Gotripperz
Re: Post and PM Inline Attachments
« Reply #12 on: August 17, 2014, 05:23:57 PM »
Thanks for the fix! It is working great

One thing I want point out here is: It is working great on Internet Explorer ... but it is not working on Chrome.

On Chrome when I click on (Insert Attachment n), Nothing happens. Please look into this issue as well, as most of the users use chrome these days..

Anyways I want to thank you for this MOD as my forum is based on Photos and its a very important MOD for me.
Visit my forum : www.gotripperz.com

Offline marcosdjcm

  • Newbie
  • *
  • Posts: 5
Re: Post and PM Inline Attachments
« Reply #13 on: August 19, 2014, 07:39:10 AM »
Hi,

I like the idea of this mod but I am getting inline links instead of inline images:





Am I doing something wrong? Would like the image to be displayed inline like I have done in this post. Thanks.

Offline saurabh1938

  • Semi-Newbie
  • *
  • Posts: 85
    • Gotripperz
Re: Post and PM Inline Attachments
« Reply #14 on: August 19, 2014, 11:33:48 AM »
when you post this message you will see the image, while in edit mode, it looks like this only.

Btw which browser are you using?
Hi,

I like the idea of this mod but I am getting inline links instead of inline images:





Am I doing something wrong? Would like the image to be displayed inline like I have done in this post. Thanks.
Visit my forum : www.gotripperz.com

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,767
  • Mod King
    • XPtsp.com Community
Re: Post and PM Inline Attachments
« Reply #15 on: August 20, 2014, 04:39:00 PM »
Can you attach the image in question?  This way, I can look at the problem with that particular attachment.....
« Last Edit: August 22, 2014, 07:15:10 PM by dougiefresh »

Offline saurabh1938

  • Semi-Newbie
  • *
  • Posts: 85
    • Gotripperz
Re: Post and PM Inline Attachments
« Reply #16 on: August 20, 2014, 06:28:57 PM »
Can you attach the image in question?  This way, I can look at the problem with that particular attachment.....

Hi, would you be able to look at the issue of this mod not working on Chrome or Firefox. When I click on Insert Attachment, nothing happens but on IE it works like a charm

Thanks,
Saurabh
Visit my forum : www.gotripperz.com

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,767
  • Mod King
    • XPtsp.com Community
Re: Post and PM Inline Attachments
« Reply #17 on: August 20, 2014, 06:46:32 PM »
I will look into it.  Sorry about not responding to your earlier message....

Offline saurabh1938

  • Semi-Newbie
  • *
  • Posts: 85
    • Gotripperz
Re: Post and PM Inline Attachments
« Reply #18 on: August 21, 2014, 04:14:31 PM »
I will look into it.  Sorry about not responding to your earlier message....

Thanks in advance, for taking out the time and looking into the issue. As I mentioned earlier, this MOD and hence your help is very crucial for my forum. I am eagerly awaiting a fix.
Visit my forum : www.gotripperz.com

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,767
  • Mod King
    • XPtsp.com Community
Re: Post and PM Inline Attachments
« Reply #19 on: August 21, 2014, 05:04:41 PM »
Hi,

I like the idea of this mod but I am getting inline links instead of inline images:

Am I doing something wrong? Would like the image to be displayed inline like I have done in this post. Thanks.
This mod uses the attachment data provided by the core forum software in order to decide how to display the attachment.  If the attachment is NOT an image, what you get is the text/link that you got.  If the attachment IS an image, then you should see the image in the post.  However, my code is not responsible for determining whether or not the attachment is an image or not.  That responsibility falls to the core forum software.  The fact that the core forum software does not recognize the image as such suggests that the image in question is corrupt OR not encoded in such a way that the core forum software can process it as an image.