Advertisement:

Author Topic: Post and PM Inline Attachments  (Read 159163 times)

Offline @rjen

  • Jr. Member
  • **
  • Posts: 187
  • Gender: Male
    • FJR-club Nederland
Re: Post and PM Inline Attachments
« Reply #700 on: December 11, 2017, 03:53:33 PM »
I would hope the mod author has checked the suggestions made before incorporating them in the package? I’ll wait for the next update and will try again.
Running SMF 2.0 with Tinyportal 1.3R at www.fjr-club.nl
Testing SMF 2.1 beta 3 with Tinyportal 2.0 at http://test2.fjr-club.nl/

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,502
    • XPtsp.com Community
Re: Post and PM Inline Attachments
« Reply #701 on: December 11, 2017, 04:17:01 PM »
Dammit, I dropped the ball on testing it....  I'll fix it tonight after work.
NOTICE:  My website is back up!

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,502
    • XPtsp.com Community
Re: Post and PM Inline Attachments
« Reply #702 on: December 15, 2017, 02:41:04 PM »
Uploaded v6.1 - December 15th, 2017
o Fixed installer where ILA actions are inserted.
NOTICE:  My website is back up!

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!

Offline jakes_t

  • Semi-Newbie
  • *
  • Posts: 12
Re: Post and PM Inline Attachments
« Reply #703 on: December 22, 2017, 01:25:42 PM »
Thanks for your efforts with this. May I ask what will happen when 2.1 gets released? Would 2.1 be able to handle posts made with this mod?

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,502
    • XPtsp.com Community
Re: Post and PM Inline Attachments
« Reply #704 on: December 22, 2017, 05:21:46 PM »
This mod is designed to work with both SMF 2.0.x and SMF 2.1 Beta 3.  Once you upgrade to SMF 2.1 Final, you will need to install this mod on that install.  Once you do, this mod SHOULD work like before....  But I will customize the mod per SMF 2.1 install to make sure it installs correctly....
NOTICE:  My website is back up!

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!

Offline @rjen

  • Jr. Member
  • **
  • Posts: 187
  • Gender: Male
    • FJR-club Nederland
Re: Post and PM Inline Attachments
« Reply #705 on: December 27, 2017, 05:11:42 PM »
Just noticed that since the last update whenever someone clicks on a regular attached image (so not even placed inline) below error messages gets written to the log...

https://www.fjr-club.nl/index.php?action=dlattach;topic=14573.0;attach=10488
8: Use of undefined constant file_ext - assumed 'file_ext'
Bestand: /home/deb77453/domains/fjr-club.nl/public_html/Sources/Display.php
Regel: 1443

I suspect it is caused by this mod, correct?

The line itself is:
   elseif (ILA_Mime_Type($filename, file_ext, $mime_type))
Running SMF 2.0 with Tinyportal 1.3R at www.fjr-club.nl
Testing SMF 2.1 beta 3 with Tinyportal 2.0 at http://test2.fjr-club.nl/

Offline @rjen

  • Jr. Member
  • **
  • Posts: 187
  • Gender: Male
    • FJR-club Nederland
Re: Post and PM Inline Attachments
« Reply #706 on: December 30, 2017, 08:56:22 AM »
Ok, changing this code

   elseif (ILA_Mime_Type($filename, file_ext, $mime_type))

to this

   elseif (ILA_Mime_Type($filename, $file_ext, $mime_type))

solves the problem.
Running SMF 2.0 with Tinyportal 1.3R at www.fjr-club.nl
Testing SMF 2.1 beta 3 with Tinyportal 2.0 at http://test2.fjr-club.nl/

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,502
    • XPtsp.com Community
Re: Post and PM Inline Attachments
« Reply #707 on: December 30, 2017, 11:42:07 AM »
Uploaded v6.2 - December 18th, 2017
o Fixed errors generated by NULL being was passed to in_array function.
o Fixed code fragment using ILA_mime_type in Display.php.



@@rjen:  Thank you for reporting the bug!  It's been fixed for this version!
NOTICE:  My website is back up!

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!

Offline @rjen

  • Jr. Member
  • **
  • Posts: 187
  • Gender: Male
    • FJR-club Nederland
Re: Post and PM Inline Attachments
« Reply #708 on: December 30, 2017, 12:46:45 PM »
Uploaded v6.2 - December 18th, 2017
o Fixed errors generated by NULL being was passed to in_array function.
o Fixed code fragment using ILA_mime_type in Display.php.



@@rjen:  Thank you for reporting the bug!  It's been fixed for this version!


Installing version 6.2 on my test site results in HTTP ERROR 500
Running SMF 2.0 with Tinyportal 1.3R at www.fjr-club.nl
Testing SMF 2.1 beta 3 with Tinyportal 2.0 at http://test2.fjr-club.nl/

Offline BellGab.com

  • Jr. Member
  • **
  • Posts: 181
    • BellGab.com
Re: Post and PM Inline Attachments
« Reply #709 on: January 07, 2018, 02:18:14 AM »
Uploaded v6.2 - December 18th, 2017
o Fixed errors generated by NULL being was passed to in_array function.
o Fixed code fragment using ILA_mime_type in Display.php.



@@rjen:  Thank you for reporting the bug!  It's been fixed for this version!


Installing version 6.2 on my test site results in HTTP ERROR 500

same here.

Offline Gryzor

  • Sr. Member
  • ****
  • Posts: 738
  • Gender: Male
  • CPCwiki.eu - The Amstrad CPC Encyclopaedia!
    • CPCWiki
Re: Post and PM Inline Attachments
« Reply #710 on: January 07, 2018, 04:21:06 AM »
I didn't catch the exact error before manually uninstalling in a hurry, but my browser told me the server wouldn't respond...

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,502
    • XPtsp.com Community
Re: Post and PM Inline Attachments
« Reply #711 on: January 07, 2018, 10:23:09 PM »
Uploaded v6.3 - January 7th, 2018
o Fixed coding syntax error in Subs-InlineAttachments.php.



@Everybody:  Hopefully this fixes the bug reports that have been reported....
NOTICE:  My website is back up!

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!

Offline Gryzor

  • Sr. Member
  • ****
  • Posts: 738
  • Gender: Male
  • CPCwiki.eu - The Amstrad CPC Encyclopaedia!
    • CPCWiki
Re: Post and PM Inline Attachments
« Reply #712 on: January 08, 2018, 02:09:29 AM »
Ooh thanks, will try it later today hopefully :)

Offline Gryzor

  • Sr. Member
  • ****
  • Posts: 738
  • Gender: Male
  • CPCwiki.eu - The Amstrad CPC Encyclopaedia!
    • CPCWiki
Re: Post and PM Inline Attachments
« Reply #713 on: January 13, 2018, 10:50:38 AM »
Hello!

So I installed it, it installed fine, but when users (others reported it, too) click on "insert attachment" nothing happened...

Any idea where to start checking? No entries appear in the log...

Thanks!

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,502
    • XPtsp.com Community
Re: Post and PM Inline Attachments
« Reply #714 on: January 14, 2018, 08:41:45 PM »
I'll look into this bug (again)....
NOTICE:  My website is back up!

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!

Offline Gryzor

  • Sr. Member
  • ****
  • Posts: 738
  • Gender: Male
  • CPCwiki.eu - The Amstrad CPC Encyclopaedia!
    • CPCWiki
Re: Post and PM Inline Attachments
« Reply #715 on: January 15, 2018, 12:42:17 AM »
Cheers, let me know if I can help in any way to debug.

Offline bharat

  • Jr. Member
  • **
  • Posts: 301
Re: Post and PM Inline Attachments
« Reply #716 on: January 18, 2018, 09:38:45 AM »
Can you please explain me how does this mod work? I unstalled it on my forum but don't see any option to insert attachment, where should it be?

Offline Gryzor

  • Sr. Member
  • ****
  • Posts: 738
  • Gender: Male
  • CPCwiki.eu - The Amstrad CPC Encyclopaedia!
    • CPCWiki
Re: Post and PM Inline Attachments
« Reply #717 on: January 18, 2018, 09:50:59 AM »
Next to the attachment button, though it does nothing in my case...

Offline bharat

  • Jr. Member
  • **
  • Posts: 301
Re: Post and PM Inline Attachments
« Reply #718 on: January 18, 2018, 10:21:08 AM »
I can see it but if I click on it nothing happen that's why I was wondering maybe I am doing something wrong.

Offline bharat

  • Jr. Member
  • **
  • Posts: 301
Re: Post and PM Inline Attachments
« Reply #719 on: January 18, 2018, 10:22:35 AM »
Actually I am getting this message all the time: [ Attachment has not been uploaded yet ]