News:

SMF 2.1.4 has been released! Take it for a spin! Read more.

Main Menu

Post and PM Inline Attachments

Started by dougiefresh, July 26, 2014, 09:14:08 PM

Previous topic - Next topic

@rjen

I would hope the mod author has checked the suggestions made before incorporating them in the package? I'll wait for the next update and will try again.
Running SMF 2.1 with latest TinyPortal at www.fjr-club.nl

dougiefresh

Dammit, I dropped the ball on testing it....  I'll fix it tonight after work.

dougiefresh

Uploaded v6.1 - December 15th, 2017
o Fixed installer where ILA actions are inserted.

jakes_t

Thanks for your efforts with this. May I ask what will happen when 2.1 gets released? Would 2.1 be able to handle posts made with this mod?

dougiefresh

This mod is designed to work with both SMF 2.0.x and SMF 2.1 Beta 3.  Once you upgrade to SMF 2.1 Final, you will need to install this mod on that install.  Once you do, this mod SHOULD work like before....  But I will customize the mod per SMF 2.1 install to make sure it installs correctly....

@rjen

Just noticed that since the last update whenever someone clicks on a regular attached image (so not even placed inline) below error messages gets written to the log...

https://www.fjr-club.nl/index.php?action=dlattach;topic=14573.0;attach=10488
8: Use of undefined constant file_ext - assumed 'file_ext'
Bestand: /home/deb77453/domains/fjr-club.nl/public_html/Sources/Display.php
Regel: 1443

I suspect it is caused by this mod, correct?

The line itself is:
   elseif (ILA_Mime_Type($filename, file_ext, $mime_type))
Running SMF 2.1 with latest TinyPortal at www.fjr-club.nl

@rjen

Ok, changing this code

   elseif (ILA_Mime_Type($filename, file_ext, $mime_type))

to this

   elseif (ILA_Mime_Type($filename, $file_ext, $mime_type))

solves the problem.
Running SMF 2.1 with latest TinyPortal at www.fjr-club.nl

dougiefresh

Uploaded v6.2 - December 18th, 2017
o Fixed errors generated by NULL being was passed to in_array function.
o Fixed code fragment using ILA_mime_type in Display.php.




@@rjen:  Thank you for reporting the bug!  It's been fixed for this version!

@rjen

Quote from: dougiefresh on December 30, 2017, 11:42:07 AM
Uploaded v6.2 - December 18th, 2017
o Fixed errors generated by NULL being was passed to in_array function.
o Fixed code fragment using ILA_mime_type in Display.php.




@@rjen:  Thank you for reporting the bug!  It's been fixed for this version!


Installing version 6.2 on my test site results in HTTP ERROR 500
Running SMF 2.1 with latest TinyPortal at www.fjr-club.nl

BellGab.com

Quote from: @rjen on December 30, 2017, 12:46:45 PM
Quote from: dougiefresh on December 30, 2017, 11:42:07 AM
Uploaded v6.2 - December 18th, 2017
o Fixed errors generated by NULL being was passed to in_array function.
o Fixed code fragment using ILA_mime_type in Display.php.




@@rjen:  Thank you for reporting the bug!  It's been fixed for this version!


Installing version 6.2 on my test site results in HTTP ERROR 500

same here.

Gryzor

I didn't catch the exact error before manually uninstalling in a hurry, but my browser told me the server wouldn't respond...

dougiefresh

Uploaded v6.3 - January 7th, 2018
o Fixed coding syntax error in Subs-InlineAttachments.php.




@Everybody:  Hopefully this fixes the bug reports that have been reported....

Gryzor

Ooh thanks, will try it later today hopefully :)

Gryzor

Hello!

So I installed it, it installed fine, but when users (others reported it, too) click on "insert attachment" nothing happened...

Any idea where to start checking? No entries appear in the log...

Thanks!

dougiefresh

I'll look into this bug (again)....

Gryzor

Cheers, let me know if I can help in any way to debug.

bharat

Can you please explain me how does this mod work? I unstalled it on my forum but don't see any option to insert attachment, where should it be?

Gryzor

Next to the attachment button, though it does nothing in my case...

bharat

I can see it but if I click on it nothing happen that's why I was wondering maybe I am doing something wrong.

bharat

Actually I am getting this message all the time: [ Attachment has not been uploaded yet ]

Advertisement: