Advertisement:

Author Topic: [GH#3027] [img] with alt/height/width combines alt and height parameters  (Read 8105 times)

Offline Joshua Dickerson

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 12,775
  • Gender: Male
    • joshuaadickerson on GitHub
    • joshuaadickerson on LinkedIn
Code: [Select]
[img alt=Test height=100 width=100]http://avatars.simplemachinesweb.com/smf/avatar_23_1337883444.png[/img]

Test height=100

Code: [Select]
<img src="http://avatars.simplemachinesweb.com/smf/avatar_23_1337883444.png" alt="Test height=100" width="100" class="bbc_img resized" style="cursor: pointer;">
What would be expected is:
Code: [Select]
<img src="http://avatars.simplemachinesweb.com/smf/avatar_23_1337883444.png" alt="Test" height="100" width="100" class="bbc_img resized" style="cursor: pointer;">
« Last Edit: September 15, 2015, 07:03:15 AM by Antes »
Need help? See the wiki. Want to help SMF? See the wiki!

Did you know you can help develop SMF? See us on Github.

How have you bettered the world today?

Offline sǝๅqɯɐɥS

  • SMF Hero
  • ******
  • Posts: 4,510
  • Gender: Male
    • i30 Owners Club
Re: [img] with alt/height/width combines alt and height parameters
« Reply #1 on: September 04, 2015, 04:20:53 PM »
I was under the impression that 'alt' text had to be enclosed within quotes to start with...?

Code: [Select]
[img alt="Test"...]

Offline Joshua Dickerson

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 12,775
  • Gender: Male
    • joshuaadickerson on GitHub
    • joshuaadickerson on LinkedIn
Re: [img] with alt/height/width combines alt and height parameters
« Reply #2 on: September 04, 2015, 04:26:28 PM »
Nope, but thanks for reminding me. That's another part of the bug.

Code: (input) [Select]
[img alt="Test" height=100 width=100]http://avatars.simplemachinesweb.com/smf/avatar_23_1337883444.png[/img]
Code: (output) [Select]
<img src="http://avatars.simplemachinesweb.com/smf/avatar_23_1337883444.png" alt="&quot;Test&quot; height=100" width="100" class="bbc_img resized" style="cursor: pointer;">
Code: (expected) [Select]
<img src="http://avatars.simplemachinesweb.com/smf/avatar_23_1337883444.png" alt="Test" height="100" width="100" class="bbc_img resized" style="cursor: pointer;">
Need help? See the wiki. Want to help SMF? See the wiki!

Did you know you can help develop SMF? See us on Github.

How have you bettered the world today?

Offline Ninja ZX-10RR

  • SMF Hero
  • ******
  • Posts: 2,135
  • Gender: Male
  • Sniper Legends
    • Flavio93Zena on Facebook
    • Virtual Interactive Games Entertainment Forum
Re: [img] with alt/height/width combines alt and height parameters
« Reply #3 on: September 05, 2015, 02:28:42 AM »
* Ninja ZX-10RR follows
Quote from: BeastMode topic=525177.msg3720020#msg3720020
It's so powerful that on this post and even in the two PMs you sent me,you still answered my question very quickly and you're apologizing for the delay. You're the #1 support I've probably ever encountered man, so much respect for that. Thank you, and get better soon.

I'll keep this in my siggy for a while just to remind me that someone appreciated what I did while others didn't.
♥ Jess ♥

STOP EDITING MY PROFILE

Offline Oldiesmann

  • Developer
  • SMF Super Hero
  • *
  • Posts: 24,814
  • Gender: Male
  • Ask me about the function DB :)
    • oldiesmann on Facebook
    • Oldiesmann on GitHub
    • http://www.linkedin.com/in/michaeleshom on LinkedIn
    • @oldiesmann on Twitter
    • Archie Comics Fan Forum
Re: [img] with alt/height/width combines alt and height parameters
« Reply #4 on: September 05, 2015, 02:09:26 PM »
Michael Eshom
Webmaster / SMF Lead Developer
oldiesmann@simplemachines.org

Offline Ninja ZX-10RR

  • SMF Hero
  • ******
  • Posts: 2,135
  • Gender: Male
  • Sniper Legends
    • Flavio93Zena on Facebook
    • Virtual Interactive Games Entertainment Forum
Re: [3027] [img] with alt/height/width combines alt and height parameters
« Reply #5 on: September 05, 2015, 02:46:20 PM »
Can this be included into 2.0.11 as well please? :)
Quote from: BeastMode topic=525177.msg3720020#msg3720020
It's so powerful that on this post and even in the two PMs you sent me,you still answered my question very quickly and you're apologizing for the delay. You're the #1 support I've probably ever encountered man, so much respect for that. Thank you, and get better soon.

I'll keep this in my siggy for a while just to remind me that someone appreciated what I did while others didn't.
♥ Jess ♥

STOP EDITING MY PROFILE

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 55,106
  • Gender: Male
    • Kindred-999 on GitHub
Re: [3027] [img] with alt/height/width combines alt and height parameters
« Reply #6 on: September 05, 2015, 03:56:55 PM »
maybe....  however, it's such an unused feature that it has taken years for anyone to report it...
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

Offline Joshua Dickerson

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 12,775
  • Gender: Male
    • joshuaadickerson on GitHub
    • joshuaadickerson on LinkedIn
Re: [3027] [img] with alt/height/width combines alt and height parameters
« Reply #7 on: September 05, 2015, 05:50:35 PM »
Yeah and I didn't find a fix yet so it would take time for them to fix it. If/when I find the fix, it will be easier to include it in the next release.
Need help? See the wiki. Want to help SMF? See the wiki!

Did you know you can help develop SMF? See us on Github.

How have you bettered the world today?

Offline Illori

  • Project Manager
  • SMF Master
  • *
  • Posts: 48,063
Re: [3027] [img] with alt/height/width combines alt and height parameters
« Reply #8 on: September 05, 2015, 06:28:18 PM »
seem strange to anyone?

Code: [Select]
array(
'tag' => 'img',
'type' => 'unparsed_content',
'parameters' => array(
'alt' => array('optional' => true),
'title' => array('optional' => true),
'width' => array('optional' => true, 'value' => ' width="$1"', 'match' => '(\d+)'),
'height' => array('optional' => true, 'value' => ' height="$1"', 'match' => '(\d+)'),
),
'content' => '<img src="$1" alt="{alt}" title="{title}"{width}{height} class="bbc_img resized">',

and in the resulting page source you see it in a different order?

Code: [Select]
<img class="bbc_img resized" width="100" title="" alt="Test height=100" src="http://avatars.simplemachinesweb.com/smf/avatar_23_1337883444.png" style="cursor: pointer;">
what is changing the order? alt should be before title then width and height with the class last.

Offline Joshua Dickerson

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 12,775
  • Gender: Male
    • joshuaadickerson on GitHub
    • joshuaadickerson on LinkedIn
Re: [GH#3027] [img] with alt/height/width combines alt and height parameters
« Reply #9 on: September 20, 2015, 10:40:58 PM »
Uh, not sure how you're getting that output but I don't see it.
Need help? See the wiki. Want to help SMF? See the wiki!

Did you know you can help develop SMF? See us on Github.

How have you bettered the world today?

Offline Ninja ZX-10RR

  • SMF Hero
  • ******
  • Posts: 2,135
  • Gender: Male
  • Sniper Legends
    • Flavio93Zena on Facebook
    • Virtual Interactive Games Entertainment Forum
Re: [GH#3027] [img] with alt/height/width combines alt and height parameters
« Reply #10 on: September 21, 2015, 12:27:25 AM »
Me neither...
Quote from: BeastMode topic=525177.msg3720020#msg3720020
It's so powerful that on this post and even in the two PMs you sent me,you still answered my question very quickly and you're apologizing for the delay. You're the #1 support I've probably ever encountered man, so much respect for that. Thank you, and get better soon.

I'll keep this in my siggy for a while just to remind me that someone appreciated what I did while others didn't.
♥ Jess ♥

STOP EDITING MY PROFILE

Offline Antes

  • Evil Black Cat
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 8,646
  • Gender: Male
  • Black cat rulz!
    • Antes on GitHub
    • merta on LinkedIn
    • @antesistan on Twitter
    • Lunarfall
Re: [GH#3027] [img] with alt/height/width combines alt and height parameters
« Reply #11 on: September 21, 2015, 04:49:37 AM »
Another bug of chrome-based browsers?
Active Project(s): [ SimpleDesk ] # [ Lunarfall ] # [ CoreStore ]

Past Project(s): [ ezPortal ]

Offline Illori

  • Project Manager
  • SMF Master
  • *
  • Posts: 48,063
Re: [GH#3027] [img] with alt/height/width combines alt and height parameters
« Reply #12 on: September 21, 2015, 05:09:01 AM »
that was in firefox, so not a chrome bug.

also antes that is for bbc not for an avatar. so different things using different code.

Offline Ninja ZX-10RR

  • SMF Hero
  • ******
  • Posts: 2,135
  • Gender: Male
  • Sniper Legends
    • Flavio93Zena on Facebook
    • Virtual Interactive Games Entertainment Forum
Re: [GH#3027] [img] with alt/height/width combines alt and height parameters
« Reply #13 on: September 21, 2015, 05:54:08 AM »
I was using Chrome in that screenshot, too :)
Quote from: BeastMode topic=525177.msg3720020#msg3720020
It's so powerful that on this post and even in the two PMs you sent me,you still answered my question very quickly and you're apologizing for the delay. You're the #1 support I've probably ever encountered man, so much respect for that. Thank you, and get better soon.

I'll keep this in my siggy for a while just to remind me that someone appreciated what I did while others didn't.
♥ Jess ♥

STOP EDITING MY PROFILE

Offline Antes

  • Evil Black Cat
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 8,646
  • Gender: Male
  • Black cat rulz!
    • Antes on GitHub
    • merta on LinkedIn
    • @antesistan on Twitter
    • Lunarfall
Re: [GH#3027] [img] with alt/height/width combines alt and height parameters
« Reply #14 on: September 21, 2015, 11:48:15 AM »
that was in firefox, so not a chrome bug.

also antes that is for bbc not for an avatar. so different things using different code.

the screenshot Ninja posted your avatar with chrome,
the screenshot I posted your avatar with firefox.
Active Project(s): [ SimpleDesk ] # [ Lunarfall ] # [ CoreStore ]

Past Project(s): [ ezPortal ]

Offline Illori

  • Project Manager
  • SMF Master
  • *
  • Posts: 48,063
Re: [GH#3027] [img] with alt/height/width combines alt and height parameters
« Reply #15 on: September 21, 2015, 11:50:52 AM »
the issue i am reporting is with an image posted in a TOPIC, it has NOTHING at all to do with any other image that shows up anywhere else.

this bug is reported on the img bbc tag.

Offline margarett

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 19,761
  • Gender: Male
Re: [GH#3027] [img] with alt/height/width combines alt and height parameters
« Reply #16 on: September 21, 2015, 12:24:37 PM »
Over the discussion about the BBC parsing which might cause a huge memory consumption, I seem to remember someone (Spuds?) finding out that the current implementation doesn't return all possible permutations of the arguments. Maybe this is related?
Se forem conduzir, não bebam. Se forem beber... CHAMEM-ME!!!! :D

Quote
Over 90% of all computer problems can be traced back to the interface between the keyboard and the chair

Offline Ninja ZX-10RR

  • SMF Hero
  • ******
  • Posts: 2,135
  • Gender: Male
  • Sniper Legends
    • Flavio93Zena on Facebook
    • Virtual Interactive Games Entertainment Forum
Re: [GH#3027] [img] with alt/height/width combines alt and height parameters
« Reply #17 on: September 21, 2015, 05:33:52 PM »
Could be, it's just way too old and would need to be somehow made "up-to-date" entirely, lol.
Quote from: BeastMode topic=525177.msg3720020#msg3720020
It's so powerful that on this post and even in the two PMs you sent me,you still answered my question very quickly and you're apologizing for the delay. You're the #1 support I've probably ever encountered man, so much respect for that. Thank you, and get better soon.

I'll keep this in my siggy for a while just to remind me that someone appreciated what I did while others didn't.
♥ Jess ♥

STOP EDITING MY PROFILE

Offline Antes

  • Evil Black Cat
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 8,646
  • Gender: Male
  • Black cat rulz!
    • Antes on GitHub
    • merta on LinkedIn
    • @antesistan on Twitter
    • Lunarfall
Re: [GH#3027] [img] with alt/height/width combines alt and height parameters
« Reply #18 on: January 06, 2017, 06:39:15 AM »
Issue closed/resolved. If you are having such issues please open new topic while using latest build.
Active Project(s): [ SimpleDesk ] # [ Lunarfall ] # [ CoreStore ]

Past Project(s): [ ezPortal ]

Offline Joshua Dickerson

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 12,775
  • Gender: Male
    • joshuaadickerson on GitHub
    • joshuaadickerson on LinkedIn
Re: [GH#3027] [img] with alt/height/width combines alt and height parameters
« Reply #19 on: January 07, 2017, 02:44:43 PM »
Test height=100

What version is it updated in?
Need help? See the wiki. Want to help SMF? See the wiki!

Did you know you can help develop SMF? See us on Github.

How have you bettered the world today?