Advertisement:

Author Topic: Possible bug in upgrade.php  (Read 2056 times)

Offline Sir Osis of Liver

  • SMF Hero
  • ******
  • Posts: 7,073
  • 'Tis the gift to be simple
Possible bug in upgrade.php
« on: October 29, 2017, 06:18:55 PM »
Per this topic, upgrade from 1.1.21 -> 2.0.14 ran normally, no errors, failed to upgrade smf_categories.  Table still had 1.1 field names and parameters.

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 55,098
  • Gender: Male
    • Kindred-999 on GitHub
Re: Possible bug in upgrade.php
« Reply #1 on: October 29, 2017, 10:04:42 PM »
Despite hundreds of upgrades, this is the first time we have heard this report...   so, I tend to suspect user or host error
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

Offline Sir Osis of Liver

  • SMF Hero
  • ******
  • Posts: 7,073
  • 'Tis the gift to be simple
Re: Possible bug in upgrade.php
« Reply #2 on: October 29, 2017, 11:11:11 PM »
First time I've seen it.  Odd that upgrade ran without error.  OP ran it couple of times, I had same result.  Clean instalI, no mods or customizations.  I have a 1.1 backup table, will post it tomorrow if it looks interesting.

Do you know what max value is for id_cat in 1.1?

Offline DAN_B

  • Newbie
  • *
  • Posts: 6
Re: Possible bug in upgrade.php
« Reply #3 on: October 29, 2017, 11:54:13 PM »
Kind of same issue, the warning one, need to remove "upgrade.php" red banner, its pretty but distracting,
yes, I did loose tweeks I had to the style sheet.
I've read the remove upgrade.php archive thread. I did update using scrofulous. 
The problem is I can't find such a file , I see everything in the directory, all of the .php files
there are 4 "upgrade .sql"  files, archive thread said delete those also, maybe do the name change see what happens.
Its been a while since I've messed with a directory.
Any thoughts/suggestion would be great, thanks, Dan

um, apologies', went into the cpanel/file manager, found it there, pretty red banner gone   ;D

Still can't hurt to remove "upgrade.sql" files?
« Last Edit: October 30, 2017, 12:26:19 AM by DAN_B »

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 68,034
    • Arantor on GitHub
Re: Possible bug in upgrade.php
« Reply #4 on: October 30, 2017, 04:39:11 AM »
The upgrade tries to, if it can't that usually means your host has things set in a weird way that SMF can't just work around for you.
To assume is to hope that those who came before had the presence of mind and capacity to implement the dreams of those who would come after.

You either die a hero or live long enough to see yourself become the villain. It seems you have chosen which, and now I must do the same.

Offline Sir Osis of Liver

  • SMF Hero
  • ******
  • Posts: 7,073
  • 'Tis the gift to be simple
Re: Possible bug in upgrade.php
« Reply #5 on: October 30, 2017, 12:57:49 PM »
It only missed the one table, everything else appears to be fine.  Have no idea how id_cat for the three categories were all 400+.  That's an auto incremented value that starts at 1.  It's a small forum, clean install, can't imagine they created over 400 categories.  That seems to be what borked the table upgrade.  phpmyadmin will not allow a value >255 in id_cat field.  smf_categories did not upgrade, and smf_boards upgraded but had all id_cat fields set to 255.  Something to do with mysql configuration?

Offline Sir Osis of Liver

  • SMF Hero
  • ******
  • Posts: 7,073
  • 'Tis the gift to be simple
Re: Possible bug in upgrade.php
« Reply #6 on: October 30, 2017, 12:58:30 PM »
Still can't hurt to remove "upgrade.sql" files?

Yes, remove all upgrade files.