Moving Calendar Colors from settings to template...

[[Unknown]]

Is anyone against this?  If so, can anyone give a strong argument for keeping them where they are?

-[Unknown]

[MrCue]

i think its a good idea.
So would moving the member group colours, because what looks good in one theme may be very hard to read in another.

[Gobalopper]

Yes, I echo what MrCue says.

[Killer Possum]

You mean moving them into the CSS or actually coding the colors into the template.

I know that's a stupid question and you will probably be putting it in the CSS, but I thought I would ask.

Anyway I think it would just fine to move it

Disregard my post... I didn't think things through before I answered

It would be fine to move it though.

[bostasp]

Yes, please... move it

[Ben_S]

Yes move it, makes no sence where it is now.

[[Unknown]]

Wait, wait, let me clarify:

I do *not* mean moving it to the css.  Is that okay?

-[Unknown]

[MrCue]

why not?

[bostasp]

I presume it'll be moved to either the individual theme settings or the calender template file...

[David]

I've never understood why the calendar is not CSS based, it should be.

[[Unknown]]

Well, I might add one thing to the css, but not everything.  Some things - like caption color - are only used once, and it makes no sense for them to be in style.css.

-[Unknown]

[David]

It makes sense for everything to be in CSS!  Even if it is only used once the idea is to move to using CSS for websites.  What is the harm in putting it in the stylesheet?

[[Unknown]]

If I moved every style information ever used in any of the templates to style.css, it would be at least 25 kb.

-[Unknown]

[David]

... It is cached, in the grand scheme of things these days that isn't that big.  Maybe a goal would be to break up the style.css file like the templates have been.

[andrea]

All what I am missing is the possibility to adapt the current day color to a specific theme. An alternate suggestion at the bottom.

Is it by intention, by mistake, or just an intermediate state that the "current day color" is hardcoded in the default template in the file "Calendar.template.php"? Is it already planned to introduce a css class for the current day color in the "style.css" file which is interpreted by the default calendar template? If not I would like to post this as feature request.

My question refers to beta 4.1, havent checked the current cvs, maybe it's already different there?

P.S. I have seen that the current month title is now the "titlebg" class which is a very good improvement.

Most of calendar colors are taken already from the css. Which is perfectly fine as is now. It would alternatively be fine for me if for example the "quote" class background color would be taken for the current day color. That could be hardcoded in the default "Calendar.template.php". And so the day color were adapted to the theme and the style.css would not increase in size as well.

[Grudge]

Ummmm... I wouldn't want to make quote to class for the calendar, but you could get away with around a 10 byte increase by making style.css read:

Code Select Expand


.quote
{
color: #000000;
background-color: #C3B8D0;
border: 1px solid #000000;
margin: 1px;
padding: 1px;
font-size: x-small;
}


Equal:

Code Select Expand


.quote, currentDay
{
color: #000000;
background-color: #C3B8D0;
border: 1px solid #000000;
margin: 1px;
padding: 1px;
font-size: x-small;
}


Anyway - Andrea - the point is the colour is NOT hard coded to a theme. If you just stick a Calendar.template.php file in to any other theme directory then you can change it in there. However, I guess this does make themes a lot bigger if you just want to change one color

[andrea]

the colour is NOT hard coded to a theme.

It is hardcoded in that sense that the color code is explicitely in the default "Calendar.template.php". That means if I want to change this color I have to duplicate this file hence theme maintenance is made more work intense, one theme file more which will have to be redone with the next SMF version.

[bostasp]

one theme file more which will have to be redone with the next SMF version.

You can't expect things to be created or fixed perfectly first time round, or any time round infact.

[andrea]

That is not what the discussion is about.

[bostasp]

It's related to the themeing of the calendar, of which has been moved out of the settings in the database to the themes. With respect, you made a comment about it adding one more file to work with, I pointed out that you can't expect it to be perfect. It is on the same grounds as this discussion.

At least the calendar settings are not hardcoded anymore, nor placed within the database, but in the themes. Whether they're put in the css or the theme files makes no difference.