News:

Wondering if this will always be free?  See why free is better.

Main Menu

Footnotes v1.08 is out!

Started by Nao 尚, April 15, 2009, 04:40:25 AM

Previous topic - Next topic

Vyache

Within: ./Sources/Subs.php

I get an install error, it doesn't find this:
static $disabled;

AjaxChat - SMF 2.0 RC2 Edition Download.
mrtrc266 ~AJAX Chat Intergration FAQ's & Tips-N-Tricks~

dannbass

Do you have Simple Portal? 'cause it modifies that same line...  install and then search in that file and replace what you have with this $disabled, $feet = 0, $parse_tag_cache; only if you have Simple Portal installed.

Vyache

Quote from: dannbass on November 19, 2009, 10:03:30 PM
Do you have Simple Portal? 'cause it modifies that same line...  install and then search in that file and replace what you have with this $disabled, $feet = 0, $parse_tag_cache; only if you have Simple Portal installed.

What should I search for? $disabled, $feet = 0, $parse_tag_cache;
I don't see that line either...

AjaxChat - SMF 2.0 RC2 Edition Download.
mrtrc266 ~AJAX Chat Intergration FAQ's & Tips-N-Tricks~

dannbass


Vyache

Quote from: dannbass on November 19, 2009, 10:12:32 PM
Do you have Simple Portal?

Yes, I have 2.3.1 installed. I don't see that line should I add it some where?

AjaxChat - SMF 2.0 RC2 Edition Download.
mrtrc266 ~AJAX Chat Intergration FAQ's & Tips-N-Tricks~

dannbass

Ok, just open your Subs.php
Code (find) Select
$disabled, $parse_tag_cache;

Code (replace) Select
$disabled, $feet = 0, $parse_tag_cache;

Vyache

#86
Quote from: dannbass on November 19, 2009, 10:16:58 PM
Ok, just open your Subs.php
Code (find) Select
$disabled, $parse_tag_cache;

Code (replace) Select
$disabled, $feet = 0, $parse_tag_cache;

I see it, should I just add that variable and install it? The installer is looking for:
static $disabled; 

I get a error even after adding that line...

Thank You, SOLVED

AjaxChat - SMF 2.0 RC2 Edition Download.
mrtrc266 ~AJAX Chat Intergration FAQ's & Tips-N-Tricks~

dannbass

Sure, install it and then just open it and add the variable.

Nao 尚

Lol... And yet again, a conflict with Simple Portal! ;)
The problem with the parse_bbc() function is that it's a central function, it's the core of all message parsing, and there aren't many places where you can 'hook' your own code. It seems that SP changes a lot of it. Unfortunately, all of my mods (Aeva, SMG and Footnotes) also make changes to the function.

It would probably be a good thing to discuss this with the SP team, if they're willing to do it. Maybe we could arrange our code together so that it doesn't conflict constantly.

Since I'm merging Aeva and SMG for my next mod, I may also add Footnotes to it, to make sure all three of my mods never conflict again (if you use them all, I mean). Then it would already be slightly easier for SP not to conflict with my stuff. I have a policy of making as little change to the install scripts as possible after a major version is out (ideally, no single change), so that users can upgrade simply by overwriting existing files with the newer versions. This has been done successfully with Aeva in the past, less successfully for SMG, but I hope Aeva Media will be better in that area. Ideally, then, SP and AM could work together on using different hooks in parse_bbc(), and then try no to do any more changes. e.g. implementing a hook that directly calls another function in a separate file would be best.
I will not make any deals with you. I've resigned. I will not be pushed, filed, stamped, indexed, briefed, debriefed or numbered.

Aeva Media rocks your life.

Nao 尚

I modified the Aeva Media install script to only hook the non-Footnotes-related hook for its code. The 'sift out the BBC' code will no longer be used as a hook. As a result, Footnotes should be perfectly compatible with Aeva Media and thus I won't need to merge it with it ;)
I will not make any deals with you. I've resigned. I will not be pushed, filed, stamped, indexed, briefed, debriefed or numbered.

Aeva Media rocks your life.

Arantor

Uh, 1.05 doesn't install on RC1.2 correctly, though it tries to; the edit to Subs-Editor.php doesn't take, because it's looking for RC2 style edits, not RC1x style.

No biggie, just thought I'd point it out.
Holder of controversial views, all of which my own.


Nao 尚

Hmm 'mkay, updated the mod page ;)
I will not make any deals with you. I've resigned. I will not be pushed, filed, stamped, indexed, briefed, debriefed or numbered.

Aeva Media rocks your life.

Arantor

Holder of controversial views, all of which my own.


rexusdiablos

Can anyone tell me why I'm told to:

Find (at the end of the file): ?>

in ./Themes/default/css/index.css when it does not exist?

Am I correct to assume that I simply copy and paste the mod css to end of the document?
"You just can't make this stuff up!" - Alex Jones | www.infowars.com

Arantor

Yes, you do.

Basically, the mod site is very limited in that respect.
Holder of controversial views, all of which my own.


rexusdiablos

#95
Yeah, I was thinking that. It would be useful to note the distinction between the following two paths in the instructions:

./Themes/default/style.css

./Themes/default/css/index.css


I know it might seem trivial but a coding novice might simply misconstrue it is a missing file and opt not to install it.

In any case, I've installed it and it work's great. I can't wait to style it. :D
"You just can't make this stuff up!" - Alex Jones | www.infowars.com

Nao 尚

Glad you like it :)
I'd love it to be included in SMF by default. (Small, fast, doesn't need updates, and really adds something for users who like talking for hours. Lol.)
I will not make any deals with you. I've resigned. I will not be pushed, filed, stamped, indexed, briefed, debriefed or numbered.

Aeva Media rocks your life.

KensonPlays


Owner of Mesozoic Haven

Nao 尚

You're worthy!
(© Wayne's World.)
4200 posts and a geek reference. I'm finished!
I will not make any deals with you. I've resigned. I will not be pushed, filed, stamped, indexed, briefed, debriefed or numbered.

Aeva Media rocks your life.

Bugo

Russian translation:

// Footnotes
$txt['noisen_footnote'] = 'Сноска';

Advertisement: