Battle

[Arananthi]

Hi, just came across Battle on some forums I frequent, and was so frustrated by some things that I had to come here and log on to mention them.  Keep in mind, I don't know which of these are due to the way that my forum admin implemented the system, and which are coding issues, so please forgive if any of these are not your fault.

1) Getting gold in this game sucks.  Killing monsters gives none, killing players gives none...so it basically only comes from random encounters with creepy old men offering you purely luck-based chances to earn money?  This is particularly annoying because it's very easy to outlevel your own money supply and sit around with a Defense of 20/45 for a long time while you save up to buy those stats up to their maximum.

2) Explore costs 2 energy.  I have 2 Energy.  I cannot Explore.  What gives?

3) Having to press a button to level up is...strange. Why not have it happen automatically?

4) The fact that monsters out of your range can catch you offguard and kill you dead in one hit -- and then tell you that you're out of range and need to come back later -- that's just wrong.

5) The ease and frequency with which the above happens makes the whole permanetly-dead graveyard thing a really annoying 'feature'.  Is there an option for HP/energy/stamina regen over time?

6) PVP in this game is crazy.  I logged off for the night with full HP, and came back to find that a higher-level player basically just attacked me endlessly until I was dead...and now what?  Can we have like a "you can't be PVP'd until you (try to) attack another player first" kind of option? 

7) Speaking of the Old Men, you can activate their luck-based powers even if you don't have enough money on hand to do so.  That's actually a saving grace, because it means it's easier to get out of the no-money predicament, but it's still a rather disconcerting bug.

8 ) It would be really nice if the basic options menu told you how much of what stat would be removed by a particular action (such as -2 Energy/-1 Stamina per Explore, or whatever.)

9) The fact that you gain experience per round of battle (rather than per kill) means that it's much, much more profitable to only stay and fight creatures that have low ATK/high DEF than it is to take massive damage and only get 1 XP for a high ATK/low DEF creature. 

10) If a non-combat event brings you below 0 HP, your HP actually goes negative.  To compound the problem, while you can't attack an enemy with negative HP, you can still Explore and have non-combat events happen normally.  If you get Surprised Attacked by a monster, your HP resets to 0 and everything works normally, but that's the only thing that can keep you from Exploring indefinitely

This game has the potential to be seriously addictive, but the basic balance level needs some pretty serious attention before any more bells and whistles get added.

[Joker002]

New errors

Code Select Expand

http://**.com/forum/index.php?action=battle;sa=search;open=1

8: Undefined index: just_attacked

File: /home/**/public_html/forum/Sources/Battle/Battle_Explore.php
Line: 138

Code Select Expand

http://**.com/forum/index.php?action=battle;sa=upgrade;done

8: Undefined index: done

File: /home/**/public_html/forum/Themes/default/Battle.template.php
Line: 494

Code Select Expand

http://**.com/forum/index.php?action=admin;area=battle;sa=quest_edit;quest=2

8: Undefined index: is_final

File: /home/**/public_html/forum/Sources/Battle/Battle_Admin.php
Line: 501

Code Select Expand

http://**.com/forum/index.php?action=admin;area=battle;save;sa=quest_save

The database value you're trying to insert does not exist: is_final
Function: battle_quest_add_edit

File: /home/**/public_html/forum/Sources/Battle/Battle_Admin.php
Line: 470

Code Select Expand

http://**.com/forum/index.php?action=admin;area=battle;save;sa=quest_save

8: Undefined index: is_final

File: /home/**/public_html/forum/Sources/Battle/Battle_Admin.php
Line: 468

[Kratty256]

All the errors for is_final have been cleared up now.

Battle RC7 released!

   
•     +Added Final Quest
•     +Added Leaders
•     +Added hooks for less edits
•     !Fixed test failure for core theme
•     !Language file tweaks
•     !Fixed hard coded text from previous revision

Rev223

   
•     !Fixed links according to new host
•     !Fixed only being able to heal buddies, now anyone can be healed
•     +Added success text for when healing someone
•     +Added readme file
•     +Added redirect prior to install

[Joker002]

Thanks.
New errors in Rev223:

Code Select Expand

http://*.*/forum/index.php?action=battle;sa=leaders

8: Undefined index: battle_champs

File: /home/*/public_html/forum/Themes/default/Battle.template.php
Line: 317

Code Select Expand

http://*.*/forum/index.php?action=battle;sa=leaders

2: Invalid argument supplied for foreach()

File: /home/*/public_html/forum/Themes/default/Battle.template.php
Line: 317

[Kratty256]

Check in your database to see if the table "battle_champs" exists after installing this package.

You need to uninstall any previous versions of Battle before installing this one, if you just upgrade it won't create the new tables.

[Joker002]

Table "battle_champs" - exists (id_champ int(11), id_member int(11), times_champ int(11), date int(11)), but empty.

[SA™]

fixed package updated

you have 2 choices uninstall and reinstall the update or download the package and extraced the contence and upload the battle.template.php to themes/default

Thanks.
New errors in Rev223:

Code Select Expand

http://*.*/forum/index.php?action=battle;sa=leaders

8: Undefined index: battle_champs

File: /home/*/public_html/forum/Themes/default/Battle.template.php
Line: 317

Code Select Expand

http://*.*/forum/index.php?action=battle;sa=leaders

2: Invalid argument supplied for foreach()

File: /home/*/public_html/forum/Themes/default/Battle.template.php
Line: 317

[Joker002]

New version:

Code Select Expand

http://*/forum/index.php?action=battle;sa=upgrade;done

8: Undefined index: done

File: /home/*/public_html/forum/Themes/default/Battle.template.php
Line: 993

[Reptil]

I really love Battle Mod. Im going to install RC7 just now!!!!

[anakmacan]

GENIUS!! ill try this mod in my forum! )

[SilverKnight]

I have a suggestion. Can you make a item which colors the users name with a glow effect when they buy it. Obviously it would be very expensive but give the users something to play for. Kinda like achievements. Another could be allowing the user to have a custom title or have access to a forum.

[SA™]

I have a suggestion. Can you make a item which colors the users name with a glow effect when they buy it. Obviously it would be very expensive but give the users something to play for. Kinda like achievements. Another could be allowing the user to have a custom title or have access to a forum.

hmm did you post in the wrong topic?

[Kratty256]

Mod updated for SMF 2.0.

[serjok]

Hi,
i report this problem.
Probably is only a "my" problem.
The battle button menu seems to disable the other remaining button (such as Admin, Users, Private Message, Exit...etc...).
This is for the Core Theme but also for the Default Theme...

I' ve search in the BattleHooks file but I don't know php language: i think that this problem is related to this passage:

Code Select Expand


// Buttons/tabs
function battle_menu_buttons(&$menu_buttons)
{
global $context, $modSettings, $scripturl, $txt;

/*The menu button hook is called AFTER smf cycles through the existing array and does
permissions checks You will need to do them yourself in your hook
if($context['allow_arcade']){
//button code
}
so ive moved the admin tab*/

// Insert after Profile tab.
battle_array_insert($menu_buttons, 'search',
array(
'battle' => array(
'title' => $txt['battle_tab'],
'href' => $scripturl . '?action=battle',
'show' =>  true,
'sub_buttons' => array(
),
'active_button' => false,
),
)
);



What does it mean?

Thank you!!

[Kratty256]

I haven't hear anything about the hooks messing up tabs like that. What version of SMF are you using?

[serjok]

Version 2.0 Gold

[Kratty256]

Are you getting any errors in the error log?

[serjok]

I'm watching...
Anyway I see that also in the Administration Panel i get errors: in the attachment you can see that there are non visible many functions, such has Permission, Maintenance etc...

If I modify the hook file disabling (with //)the code, the menu returns visible.

Now i'm verifing errors, wait...

[serjok]

No errors with the code disabled. (with //)

If i enable the code, i can't no enter the Maintenance Area: i click on Maintenance but nothing happens!

[SA™]

preserve_keys parameter is for php 5.03+ only and the use of null as a length is incorrect (may however work in a windows environment).


in sources/battlle/battlehooks.php

find

Code Select Expand

$input = array_merge(
array_slice($input, 0, $position, true),
$insert,
array_slice($input, $position, null, true)
);

replace with

Code Select Expand

$input = array_merge(
array_slice($input, 0, $position),
$insert,
array_slice($input, $position)
);