News:

Join the Facebook Fan Page.

Main Menu

Say Thanks

Started by kelvincool, August 30, 2014, 05:16:29 PM

Previous topic - Next topic

gevv

I understand. it would be nice to update  Thanks.
ElkArte is a modern, powerful community building forum software. https://www.elkarte.net/

Steve

Hmmm ... I get an error in the admin log when I click the thanks button. And nothing appears on the post.
action=thank;msg=217272;member=2;topic=12034;ajax=1;xml=1
Sources/SayThanks.php (Line 800)
DO NOT pm me for support!

jsx

@kelvincool

Thank you so much for updating this mod to 2.1.1 - Now SMF 2.1 is richer because it has just that mod.

After updating the forum to SMF 2.1.1 how to import the distributed thanks to SMF 2.1.1?


kelvincool

@Steve is there any other info on that error in the log? If you have access to your database, can you check if the table messages_thanks exists.

Another thing that will help is this, before clicking on the Say Thanks button do this first:

right click -> inspect -> network

Now click say thanks button

Notice the request should appear in the log, click on the request that matches the thank url (the one with action=thank or withdrawthanks)

Click on response tab on the right hand side and post the result here.

@jsx not sure what you mean by distributed thanks, you mean from v1.3.6? If so, you don't need to do anything, the tables haven't changed, as long as you didn't delete the tables when uninstalling the previous version the data will still be there.

jsx

Quote from: kelvincool on April 19, 2022, 06:31:59 AM@jsx not sure what you mean by distributed thanks, you mean from v1.3.6? If so, you don't need to do anything, the tables haven't changed, as long as you didn't delete the tables when uninstalling the previous version the data will still be there.

Yes, I mean thanks from version 1.3.6

Thanks for the clarification.

Steve

Quote from: kelvincool on April 19, 2022, 06:31:59 AM@Steve is there any other info on that error in the log? If you have access to your database, can you check if the table messages_thanks exists.

Another thing that will help is this, before clicking on the Say Thanks button do this first:

right click -> inspect -> network

Now click say thanks button

Notice the request should appear in the log, click on the request that matches the thank url (the one with action=thank or withdrawthanks)

Click on response tab on the right hand side and post the result here.
My mod guy says it uploaded to the wrong location somehow, though he didn't tell me where that was. He installed it manually and it works perfectly.

If you still want me to do those tests, let me know. I'll have to do it later as I'm limited on my typing time due to surgery yesterday.
DO NOT pm me for support!

kelvincool

Don't think there's any need to do those tests if it's working now.

Steve

But it's only working because it was installed manually. Doing it via Package Manager caused the error. But it's your call.  :)
DO NOT pm me for support!

kelvincool

#468
Ah I see, I wasn't sure what you meant by manually installing it. It would be interesting to see if you get the same error if you uninstalled it, deleted the tables and re-installed via package manager. I checked the database script with another mod and it looks pretty standard stuff so not sure exactly what's happened. Are you on postgres or mysql?

Don't feel obliged to do that test, if you got it installed manually and it's working it should be fine going forwards, database changes are pretty rare so any updates should install without issue.

Steve

He said the SayThanks.php file wasn't present in my Sources folder for some reason.

As long as no one else is having a problem I think I'll leave things as they are.

Great update, btw.  ;D
DO NOT pm me for support!

kelvincool

Hide Content mod is now available for SMF 2.1.1 so this mod has also been updated to support the latest version of that mod.

gevv

Thanks  @kelvincool

Turkish translation

Note: "Thanked:" text in the profile does not change even though I translate it
ElkArte is a modern, powerful community building forum software. https://www.elkarte.net/

kelvincool

Just released v2.2.0, main changes for this release are:

  • Turkish translation (thanks @gevv)
  • Fix for the translation not being used on profile page
  • Updated the formatting to use commas just like the post count
  • A few background changes to how things work to enable better capatablity with my new mod Top Replies

I won't bother posting on the Hide Content topic but I released a new version of that too to include your Turkish translation @gevv. Thanks for the translation.

gevv

@kelvincool   thanks for the update  👍
ElkArte is a modern, powerful community building forum software. https://www.elkarte.net/

hungarianguy

Can you tie this mod with the alerts? If someone thanks my posts I receive an alert that my post was thanked by this user.

kelvincool

@hungarianguy Coincidentally enough I was thinking about that yesterday, I'll have a look into it.

hungarianguy

Quote from: kelvincool on May 08, 2022, 04:49:37 PM@hungarianguy Coincidentally enough I was thinking about that yesterday, I'll have a look into it.

Thanks for considering it.

Diego Andrés

Could you also add a custom hook in thank action for possible integrations with other mods?

Example: https://github.com/SychO9/smf-best-answer/blob/bc5752acd8cc86da8a03132da340c92765ab5ab9/Sources/BestAnswer/Actions.php#L121

SMF Tricks - Free & Premium Responsive Themes for SMF.

kelvincool

@Diego Andrés I'll add some in for the next release

hungarianguy

When can we expect the next release?

Advertisement: