feather

[Diego Andrés]

@TwitchisMental close enough, this theme got something going with the z-index 

[QQP-Patrick]

You both are indeed SMF-hero's!

I never considered to grow the height, i think because the old theme of the 2.0.19 version of the forum was using image files instead of dynamically generated gradients and such.

Made the changes and it works beautifully for the main menu.
The left side menu that is vertical however is hardcoded at its top location, so that can start to interfere when the menu drops down, but that is a small adjust i can make. 

Also your explanation what code line determines when the menu switches to the drop down is very helpful. as i have tried both approaches and i like the grown menu more, although i can now tweak when it switches also 

will test further tomorrow, as its now 03:25 here, but again thank you both very much!

[QQP-Patrick]

Thinking i had only one bug left to fix and what do you know, 2 more pop up 
But before i spend more then the 3 hours of searching that i have done so far and wreck more then i fix, i would like to run this by you hero's again.

The first is something i had seen before in my site, but never thought of being a bug, but looking back at the multiple screenshots in this support topic, i can clearly see something is wrong with mine.

And that is the grey block (pointed at with the red arrow) above the main content. Its classified as the #main_content_section as far as i can find. And at first i found where its being setup in the index.css file and can make it almost disappear, but looking at your screenshots and the original screenshots of Mick, it seems the content that is under the block (pointed at with the green arrow) should have been inside this block. 

So seems that something is maybe wrong with the index_template file.
I naturally played around with the file trying to fix it and multiple times made it so it would not load anymore 


And a second question i have is hopefully even easier, and that is i enabled the like feature of the new SMF like is available here on this forum and it works. But when you click the link to see who liked the post, here it opens in a nice popup in the forum, on my site using feather it opens in a full page replacing the entire forum. the close button does not work and i need to use the go back button of the browser to get back.
Are you having this also and if yes, is there a fix for this?

[Diego Andrés]

If you could link the forum we could identify the first issue faster.
And it could possibly be in the BoardIndex.template.php too, do you know if this issue happens inside a board too? If not, then it's definitely the boardindex template.

For the second issue I haven't tested it with this theme, will have a look.

[QQP-Patrick]

It indeed happens inside a board too and also in posts, so basically everywhere. Also on the tinyportal homepage i use. (see attachments)

Linking to the forum however is difficult, as the test version is hosted on a server running in a virtual machine on a proxmox installation that i have not linked to the outside, so Google does not find it and the members don't get messages from the test instance 

[Diego Andrés]

Alright then attach the index.template.php and I'll try to find the issue

[QQP-Patrick]

Thank you for al this great help.

Oh and yes the file is modified because of my header logo.
But funny think was i had replaced it with i think was a clean version and it killed my header, but i still saw the template issue.
So its in the original also, or something different is causing it now i think about it. 

[TwitchisMental]

Thinking i had only one bug left to fix and what do you know, 2 more pop up 
But before i spend more then the 3 hours of searching that i have done so far and wreck more then i fix, i would like to run this by you hero's again.

The first is something i had seen before in my site, but never thought of being a bug, but looking back at the multiple screenshots in this support topic, i can clearly see something is wrong with mine.

And that is the grey block (pointed at with the red arrow) above the main content. Its classified as the #main_content_section as far as i can find. And at first i found where its being setup in the index.css file and can make it almost disappear, but looking at your screenshots and the original screenshots of Mick, it seems the content that is under the block (pointed at with the green arrow) should have been inside this block. 

So seems that something is maybe wrong with the index_template file.
I naturally played around with the file trying to fix it and multiple times made it so it would not load anymore 


And a second question i have is hopefully even easier, and that is i enabled the like feature of the new SMF like is available here on this forum and it works. But when you click the link to see who liked the post, here it opens in a nice popup in the forum, on my site using feather it opens in a full page replacing the entire forum. the close button does not work and i need to use the go back button of the browser to get back.
Are you having this also and if yes, is there a fix for this?

Do you by chance have the hero option enabled in the theme settings?

Pretty sure that is what you are seeing. 

When used properly it looks something more like -

You cannot view this attachment.

[Diego Andrés]

Yeah I just tested it locally and it seems to be the hero option, it doesn't check if it actually has anything configured.

[QQP-Patrick]

Oh we are getting somewhere, but no its not activated.
And now to make it even more spectacular when i activate it and give is a test text it results in the following screenshot:

Just to be sure, i have also included the index.css file as that one is also pretty much modified at this point 

[Diego Andrés]

What about the messageindex (again). Is it the same?
Could you attach the boardindex.template.php too?

I tried both your files already but wasn't able to see or break anything yet.

[QQP-Patrick]

Oh thats very peculiar, that it does not break thing on your end.

With hero activated it breaks everywhere, so inside a post, board index, main page.

files attached.

[TwitchisMental]

Looks like you were trying to comment out some sections improperly causing parse errors.

Small note some of these errors are there either way, but not parse ones.

You cannot view this attachment.

[QQP-Patrick]

ahh so probably indeed something i did to get my logo to work.
As that was something the original did not do. the centering, and also at first it jumped a bit when the browser window got smaller like on mobile devices.

and then to think i was so proud of myself to get the logo banner to work after multiple days of tinkering. 

This validation was for the index.css i think?
If yes, then restoring it to the original does not fix it. 

[Diego Andrés]

For me it didn't change either, still looks fine... Which is basically your result.
So I think now we could start to point a finger to a mod or a setting you changed?

The likes work perfectly fine too, so another thing is interfering with it.

[QQP-Patrick]

Okay thank you guys!

Clearly something is messing with it outside of the theme then. Although i just found out that my logo is not working on chrome anymore. whoohoo 

I think i will make notes of all things i changed, then rebuild the test site from a fresh backup and run through the entire upgrade again, as i always planned to do the entire upgrade again to see if i had not missed anything. and then test the theme and all from step 1 again.

But now its bedtime again as its almost 4 am, and the alarm will sound at 8    Oops

[QQP-Patrick]

It took some time but i finally found out what was causing the problems with the popup window that should show who liked the post. Indeed that it has nothing to do with the team itself, and even none of my mods.

Its the Minimise CSS- and JavaScript-files setting in the main forum settings. When that is turned on it messes it up somehow. Even on a clean install of this theme.

Furthermore i found out that this same setting is also what causes the quick edit button to stop working. So turning the setting off fixed both issues for me.

So hopefully this can help others that use this team also. 

[Diego Andrés]

I couldn't reproduce the issue and I tried a vanilla forum with the latest feather package.
It could definitely be a mod that is not minimizing the css file correctly and thus overwriting something it shouldn't.

If you wish, you could share the list and when I have some spare time I could try to find what caused it.

[QQP-Patrick]

Oh that still could be it and who knows maybe its even my test server that causes it.
As i also found out that Chrome and Firefox would not load the CSS styles and safari did. And as i am a mac user primarily i tend to use safari.

Luckily i found out it was caused by the fact my test server does not use a SSL certificate, and the theme was trying to point to https and thus tripping up Chrome and Firefox.

Thanks again Diego, for now i will just continue as that minimizing setting was not present in the old version as far as i could see. And then when live in the original site, i will check if it works, if yes then i can switch it to on 

[landyvlad]

I'm running Feather on SMF 2.1 RC4 
Looking to upgrade the site to 2.1.2.
I assume the currently available version of the mod (v1.1 here https://custom.simplemachines.org/index.php?theme=2977 )  is the 2.1.2 compatible and fully functional one? i.e. should work with no issues?

site is ytyak.com in case it matters

Thanks