Simple Audio Video Embedder

[Arantor]

Your site is HTTPS, it can't possibly embed non-HTTPS links in HTTPS sites. The browser won't let it.

[Kindred]

    the link you provided loaded a PDF for me....



and it *IS* about what the browser shows.  The browser literally WILL NOT LOAD content called over an http connection for a page that is loaded with an https connection.

[peter_mein]

Once again. It's about the mod here.
Maybe I did not express myself correctly.
The mod shows a preview of pdf files.
The preview works with this link: https://ww1.microchip.com/downloads/en/devicedoc/41190c.pdf
And not with this link: https://www.vishay.com/docs/82459/tsop48.pdf
Is the preview displayed for someone with both links?

[Kindred]

please provide a link to a page demonstrating the PROBLEM - not the PDFs themselves....  your forum page in which you indicate that they are not loading.

[peter_mein]

Here is a direct link to the page: https://www.pic-microcontroller.de/elektronik-allgemein/fernsteuerung-10-meter/msg1486/#msg1486
This one doesn't work.
And here is a link that works: https://www.pic-microcontroller.de/compiler-software/library-fur-oled-sh1106-fur-mikroc-for-pic/msg54/#msg54
You can see the preview of the pdf file.

[Kindred]

that's what we needed to see....

and -- if you look at the generated code of the page and the console output...

Code Select Expand

The loading of "https://www.vishay.com/docs/82459/tsop48.pdf" in a frame is denied by "X-Frame-Options" directive set to "SAMEORIGIN".

it's not necessarily a problem with the mod

[vbgamer45]

Yeah frame security options are stronger today. Workaround could be to proxy the content but that involves code changes and probably not something I would do.

[peter_mein]

Ok I understand.
It's a shame it's not possible, but there's nothing you can do about it

Thanks for your answer.

[@rjen]

Just tracked down an error message to this mod. Version 701

SMF 2.1.3: when I embed an image (jpg) in a post AND I set a width, the following error is written to the log

https://localhost/vanilla/index.php?action=post;msg=385625;topic=28589.0
 C:/xampp/htdocs/vanilla/Sources/Subs.php (Line 1809)  Backtrace information

Type of error: Undefined
Error messageSelect
2: Undefined array key "href"


The image is a .jpg image
Theme is default Curve2.

I tested with and with without the width
The error is issued width this code for the image

Code Select Expand

now with attached image

[attach id=26347 width=200]2023-03-20_222349.jpg[/attach]

removing the width=200 and the issue is gone

Code Select Expand

now with attached image

[attach id=26347]2023-03-20_222349.jpg[/attach]

[vbgamer45]

There is no links or any bbc code around the attach image on the post?
I am trying on my test site. The mod looks anything in href tags for a match

[@rjen]

No there is not, but the error systematically occurs when the mod is installed

And it stops when removing the mod

[vbgamer45]

Whats on your line 1809?

I have

Code Select Expand

// No image. Show a link.
else
$returnContext .= '<a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a>';



[@rjen]

With the mod installed?

[vbgamer45]

Yes but it looks like its same even with installed or not installed. Meaning $currentAttachment['href'] is not defined.

[@rjen]

This

Code Select Expand

                    // No image. Show a link.
1808:                        else
==>1809:                            $returnContext .= '<a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a>';
1810: 
It only errors when the mod is installed though

[Sudhakar Arjunan]

Need 2.1.3

[Steve]

It works just fine on 2.1.3.

[Sir Osis of Liver]

Just installed 7.0.1 in 2.0.19.  Works fine in pc view but isn't responsive, doesn't resize for mobile.  Is this fixable?

[vbgamer45]

Probably not. As it varies widely on the embed code by default I copy of the embed code from each media site and use that as the base.

[Sir Osis of Liver]

Seems to work responsively in Ohara, but having all kinds of errors with current version and am trying yours.  Will play with css a bit when I get a chance.