Post and PM Inline Attachments

[GL700Wing]

Will try it tonight.  May have had emulation set to 2.1.4 for another mod and forgot to revert, which made it worse.

Okay - now I'm confused because in the first post in which you mentioned this issue you referred to 2.0.19 ...

Just seeing errors now in post template from autorotation mod.  I'll uninstall and install both in correct order.

You must install the ILA mod before the AARR mod.  Also, if you're upgrading from 2.1.3 to 2.1.4 you must uninstall the AARR mod before you apply the update - if you don't do this you will break the forum and end up with a WSOD.

pm = package manager

What are the 'Test failed (Ignore Errors)'?

This mod integrates with several other mods but if one or more of those mods are not already installed this mod cannot/does not make the integration code changes.  If you inspect the code change for the failure in most instances you should see a comment about which mod the code change is for.

[Sir Osis of Liver]

This is a 2.0.19 forum.  I installed a newer version of Users Online Today, doesn't give me install option unless I emulate 2.1.4.  Surprised it worked, but installed without errors.  Don't know what the mod does, so don't know if it's doing it.  Looks like I'll have to uninstall all the mods (again) and go with clean files.  I had copied NightBreeze theme, which he's been using for couple of years, so he could make a holiday version, mostly with css.  For reasons unknown, display template is different in the two themes.  Don't have a clean copy of the theme, so I have to mess around trying to fix things.

[GL700Wing]

This is a 2.0.19 forum.  I installed a newer version of Users Online Today, doesn't give me install option unless I emulate 2.1.4. Surprised it worked, but installed without errors.

Okay - I misunderstood the reference to 2.1.4 ...  I've attached the previous version of the UOT mod which installs and works without any issues on 2.0.19.

Don't know what the mod does, so don't know if it's doing it.

The mod adds a list of all users that were online on the current day to the 'Info Center'.  Screenshots without and with the mod ...
You cannot view this attachment. You cannot view this attachment. You cannot view this attachment.

Don't have a clean copy of the theme, so I have to mess around trying to fix things.

The latest version (August 2021) is here and I have a copy of the previous version (September 2020) - let me know if you want a copy of that.

[Sir Osis of Liver]

Yeah, I had the older version (2.1), installed ok.  Forum is really fussy about order of install, Gallery Pro caused wsod when installed after ILA and AARR.  Had to start over and install gallery first.  Everything is in now, will keep an eye on error log.  Thanks for the help.

[GL700Wing]

Yeah, I had the older version (2.1), installed ok.  Forum is really fussy about order of install, Gallery Pro caused wsod when installed after ILA and AARR.  Had to start over and install gallery first.  Everything is in now, will keep an eye on error log.  Thanks for the help.

You're welcome - glad you've got it sorted. 

I put a lot of effort into integration for the mods I maintain/develop (plus others I always use) and it does sometimes mean they need to be installed/uninstalled in a specific order.

[Sir Osis of Liver]

https://www.simplemachines.org/community/index.php?topic=587131.msg4161651#msg4161651

[GL700Wing]

https://www.simplemachines.org/community/index.php?topic=587131.msg4161651#msg4161651

Currently travelling with only limited internet but will look at this when I'm home again next week.

[Sir Osis of Liver]

Not a big rush, it's on a test forum, not production.  Trying to rerun 2.1 upgrade but having other problems with server.

[GL700Wing]

Not a big rush, it's on a test forum, not production.  Trying to rerun 2.1 upgrade but having other problems with server.

Based on the BBCode information you provided those BBCodes were added using either the In Line Attachments -- ILA mod (which has not been updated since late 2011) or a very early version of the Post and PM Inline Attachments mod (the message number was added to the BBCode in v3.0 of the mod which was released in April 2015).

For missing attachments I can correct the error message to show the actual BBCode in the body of the message and the mod option 'Should first attachment be numbered 1?' can be toggled to display the correct attachment if the numbering is out by one (ie, this option is disabled but the first attachment in a message is numbered '1', or vice versa).

Just a question - in the message you referred to here are any/all of the attachments shown below the message body?

[Sir Osis of Liver]

2.1.4 install is running Post and PM Inline Attachments 7.09, 2.0.19 is running 6.3.

2.0.19 - https://www.tradgang.com/tgsmf/index.php?topic=180567.msg3021129#msg3021129
2.1.4 - https://www.tradgang.net/tgsmf/index.php?topic=180567.msg3021129#msg3021129

This is in message body in 2.1 and 2.0 databases -

Code Select Expand

better versions of ourselves when we're walking with a bow.<br /><br />[attachment=1]<br />[attachment=2]<br />[attachment=3]<br />[attachment=4]<br />

It's the only mod installed in 2.1.4.

[GL700Wing]

2.1.4 install is running Post and PM Inline Attachments 7.09, 2.0.19 is running 6.3.

2.0.19 - https://www.tradgang.com/tgsmf/index.php?topic=180567.msg3021129#msg3021129
2.1.4 - https://www.tradgang.net/tgsmf/index.php?topic=180567.msg3021129#msg3021129

This is in message body in 2.1 and 2.0 databases -

Code Select Expand

better versions of ourselves when we're walking with a bow.<br /><br />[attachment=1]<br />[attachment=2]<br />[attachment=3]<br />[attachment=4]<br />

It's the only mod installed in 2.1.4.

OK - I suspect the association of attachments with their messages has somehow been lost in the SMF 2.1.4 migration.  If you modify the message in SMF 2.1.4 do you see the attachments listed in the attachments window?

[Sir Osis of Liver]

No attachments are shown in post editor, just this in post text -

[attachment=1]
[attachment=2]
[attachment=3]
[attachment=4]

Been trying to import the 2.0 db into the 2.1 forum to rerun upgrade, but it's quite large, they're on different servers, and it won't import.  Host account is a mess, and my access is limited.  It's possible the original upgrade didn't complete successfully, .dat extension was missing from attachment files, had to add it with script.  Maybe try importing it to test install on my server and see if it works.

[GL700Wing]

No attachments are shown in post editor, just this in post text -

[attachment=1]
[attachment=2]
[attachment=3]
[attachment=4]

That's what I suspected because on my test SMF 2.1.4 forum messages that use those BBCodes display the attachments inline correctly.

Been trying to import the 2.0 db into the 2.1 forum to rerun upgrade, but it's quite large, they're on different servers, and it won't import.  Host account is a mess, and my access is limited.  It's possible the original upgrade didn't complete successfully, .dat extension was missing from attachment files, had to add it with script.  Maybe try importing it to test install on my server and see if it works.

Hope you can get it sorted!

[digger]

v7.09 - June 10, 2023
o SMF 2.0:
  - Fixed bug introduced in v7.06 that prevented new attachments from being inserted inline when an existing message was modified.

Can you point which code v7.08 was patched to fix this bug? Version 7.0.9 does not work for me on SMF 2.0.19 - doesn't show inserted attachments, only bbcodes.

[GL700Wing]

Version 7.10 - Nov 09, 2023
o Per digger - fixed bug introduced in v7.09 that prevented some attachments from being shown inline.
o Fixed bug introduced in v7.09 that prevented PM attachments from being shown below the PM message body (only relevant if PM Attachments mod is installed).
o Fixed minor 'Print Page' issue that resulted in images also being displayed below the message body even if they were already shown inline.

Note
SMF 2.0 and SMF 2.1 : Upgrade option available for v7.07 onwards.

v7.09 - June 10, 2023
o SMF 2.0:
  - Fixed bug introduced in v7.06 that prevented new attachments from being inserted inline when an existing message was modified.

Can you point which code v7.08 was patched to fix this bug? Version 7.0.9 does not work for me on SMF 2.0.19 - doesn't show inserted attachments, only bbcodes.

@digger - I just discovered this issue on one of my forums a few days ago for some ILA tags - fixed in v7.10.

[digger]

o Per digger - fixed bug introduced in v7.09 that prevented some attachments from being shown inline.

This fixed, v7.10 works now.

o SMF 2.0:
  - Fixed bug introduced in v7.06 that prevented new attachments from being inserted inline when an existing message was modified.

Still have this bug with v7.10

[GL700Wing]

Version 7.11 - Nov 10, 2023
o Fixed bug introduced in v7.10 that prevented new attachments from being inserted inline when an existing message was modified (bug that was in v7.06 crept back in).

Note
SMF 2.0 and SMF 2.1 : Upgrade option available for v7.07 onwards.

o SMF 2.0:
  - Fixed bug introduced in v7.06 that prevented new attachments from being inserted inline when an existing message was modified.

Still have this bug with v7.10

Sorry about that - fixed in v7.11.

[Dave J]

Hi GL

I know this might seem like a strange request but is there a way to separate the PM section from the Posts. As you know by default SMF2.1.4 already has the ability to post attachments inline but I would like the option of just the PM attachments.

Don't worry GL for some reason I can't even get the pm attachments to work with this mod on 2.1.4

[GL700Wing]

Hi GL

I know this might seem like a strange request but is there a way to separate the PM section from the Posts. As you know by default SMF2.1.4 already has the ability to post attachments inline but I would like the option of just the PM attachments.

For SMF 2.1 this mod still needs to support displaying inline attachment tags that were created by this mod in SMF 2.0 forums that have been upgraded to SMF 2.1.

However, and in relation to this mod only working with PM attachments for SMF 2.1, I'll look into doing what you've asked but I think for SMF 2.1 I'd prefer to just add the functionality to the PM Attachments mod. That said, and as neither of the current mod authors seem to have been active here since mid 2019, I'll have to find out about being added as an author to that mod.

[Dave J]

Hi GL

I know this might seem like a strange request but is there a way to separate the PM section from the Posts. As you know by default SMF2.1.4 already has the ability to post attachments inline but I would like the option of just the PM attachments.

For SMF 2.1 this mod still needs to support displaying inline attachment tags that were created by this mod in SMF 2.0 forums that have been upgraded to SMF 2.1.

However, and in relation to this mod only working with PM attachments for SMF 2.1, I'll look into doing what you've asked but I think for SMF 2.1 I'd prefer to just add the functionality to the PM Attachments mod. That said, and as neither of the current mod authors seem to have been active here since mid 2019, I'll have to find out about being added as an author to that mod.

Thanks for the reply GL

My original site used to use the ILA mod which is basically what your mod is replacing so the images all show correctly in 2.1.

When I created my latest site I didn't have a need for post inline attachments but I did want PM attachments

Yes I did ask in the PM Attachments mod topic and as yet no reply. If you are able to fix anyhting that works for PM's that would be great.