News:

Want to get involved in developing SMF, then why not lend a hand on our github!

Main Menu

SMF Media Gallery (SMG) - 2.0.5 is out! (December 2)

Started by SMGTeam, September 09, 2008, 03:14:05 PM

Previous topic - Next topic

Immortalk

Host? what do you mean? isnt ftp my host?
TIKLAYIN!

Unutamayacağınız Bir Serüvene Hazır Olun

Dragooon

Host as in whom you're hosting your site with.

Nao 尚

Quote from: Dragooon on March 19, 2009, 02:55:32 AM
OK it reproduces in 1.1.8.
Arg... Spent an hour or so reinstalling stuff to get this to reproduce...

And of course, it didn't <_< (with v1.6, which has only few changes in the SMG tag area.)
I will not make any deals with you. I've resigned. I will not be pushed, filed, stamped, indexed, briefed, debriefed or numbered.

Aeva Media rocks your life.

Dragooon

It doesn't works for me in 1.1.8 with the latest revision. I entered the topic as Test's and body as [smg id=1]

Nao 尚

Oh... The title! Lol, I thought it was in the body. Okay good, I'll have a look then.
I will not make any deals with you. I've resigned. I will not be pushed, filed, stamped, indexed, briefed, debriefed or numbered.

Aeva Media rocks your life.

Nao 尚

Dragooon? I managed to trace it back to the problem.

The SMG tag calls loadMgal_settings() to retrieve the contents of $mgalSettings which is needed for later.
In turn, loadMGal_settings() will, on SMF1 only, call this in MGalCompat():

$_POST = stripslashes__recursive($_POST);

I'm guessing this is the reason for the crash (and indeed it no longer crashes when I comment that line out). $_POST['subject'] is supposed to be htmlspecialchars'ed at this point.

So I'm leaving it as is for now -- I'm leaving you with the responsibility to check whether that line should be left out or not because I didn't write this function and I can't say for sure why it's done. Maybe MGalCompat() should be skipped altogether when called from within smg_show_thumbnail() or something?
I will not make any deals with you. I've resigned. I will not be pushed, filed, stamped, indexed, briefed, debriefed or numbered.

Aeva Media rocks your life.

Dragooon


Nao 尚

Quote from: Dragooon on March 19, 2009, 07:42:19 AM
I'll take care of it later.
I see you submitted a fix...
It still doesn't tell what the stripslashes stuff is there for, lol ;)

I modified the fix to be a bit shorter and more logical. (MGalCompat() didn't need an extra parameter, did it?)
I will not make any deals with you. I've resigned. I will not be pushed, filed, stamped, indexed, briefed, debriefed or numbered.

Aeva Media rocks your life.

Dragooon

It was for a bug that was appearing in SMF 1.1 having slashes behind quotes.

Nao 尚

Oh yeah... That one, eheh.

Oh, while I have you there...

rev 786
* Moved all per-album permission strings from install-*.xml to MGallery language files
! Don't show "null" when asked for number of members in the guest group... Just say nothing (MGallery-Admin.php)
! Fixed undefined id that broke links in per-album permissions (MGallery.template.php)

Uh no you're gone already. Oh, who cares anyway ;)
I will not make any deals with you. I've resigned. I will not be pushed, filed, stamped, indexed, briefed, debriefed or numbered.

Aeva Media rocks your life.

Immortalk

Thats really bad. I changed all of these files' CHMOD to 777 but it still doesnt work. Please someone help!
TIKLAYIN!

Unutamayacağınız Bir Serüvene Hazır Olun

Immortalk

Sorry for the double post, is there any way to solve this problem?
TIKLAYIN!

Unutamayacağınız Bir Serüvene Hazır Olun

Soms

I have used the search function to filter through all the pages. I could not find any related question/answer. Sometimes when a user places a new picture in his gallery, it shows the quote here as the posted date!
QuotePosted   01 January 1970, 01:00:00

Please how can this be rectified?

Kindred

Soms,

I suspect that is not a problem with the gallery, but a problem with the user's picture.
if you have "Use EXIF data as post date" turned on, then the system will take whatever the Photo's EXIF data is.

Yes, this means if they have screwed up their camera's date function, it could say 1970.
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Xavi-Nena

I hate to sound redundant but I am willing to donate to help get the code mod needed to display created slideshows in TP blocks and articles.

Dragooon

Well I can't do it because of lack of time, if someone else does it then I'm fine.

Soms

Quote from: Kindred on March 20, 2009, 06:58:55 PM
Soms,

I suspect that is not a problem with the gallery, but a problem with the user's picture.
if you have "Use EXIF data as post date" turned on, then the system will take whatever the Photo's EXIF data is.

Yes, this means if they have screwed up their camera's date function, it could say 1970.

Thanks for that.

SgtMic

I have the latest version of SMG.

Is there a fix for this yet?
There is nothing more deadly than a US Marine and his rifle.
A close second is a US Marine and his K-BAR.
2/5 Fox Co.  (BlackHearts)
FAST Co. 5th Plt. (FIDO)

Akyhne

Quote from: SgtMic on March 21, 2009, 01:44:53 PM
I have the latest version of SMG.

Is there a fix for this yet?

I didn't notice if it was still there, but that css error was at there from 1.5.2

SgtMic

Quote from: akyhne on March 21, 2009, 03:47:18 PM
Quote from: SgtMic on March 21, 2009, 01:44:53 PM
I have the latest version of SMG.

Is there a fix for this yet?

I didn't notice if it was still there, but that css error was at there from 1.5.2

I still have it with the newest version. Was there a fix for the older version?
There is nothing more deadly than a US Marine and his rifle.
A close second is a US Marine and his K-BAR.
2/5 Fox Co.  (BlackHearts)
FAST Co. 5th Plt. (FIDO)

Advertisement: