TinyPortal

[@rjen]

Not so easy to fix I think: in 2.1 TP is all hooks. This is added by adding a string in the buffer; making the span a li element may require a template change. We do not want that...

[Antechinus]

Can't see why it would. It'd be bonkers for SMF to force a span directly inside a ul tag, so if SMF isn't doing it then it must be coming straight from TP. In which case you just edit the TP code and it should be fine. Or if SMF is doing it then that's a bug in 2.1 anyway, so should be fixed. Either way it should be fixable without too much drama, AFAICT.

[@rjen]

Like I said: no pc atm so I will look into into it later... thanks for the tip though

[Sverige]

So now i'm on PHP 7.1 and SMF Default Theme Curve  version 2.0.15 TP version 1.6.3 and i still get this error:

Call to undefined function loadCSSFile()

any help how i can get this to work? or can i use another version of TP?

edit: 1.6.2 do not work either!

[@rjen]

Why the shouting?

Have never heard of this issue before. Another TP version is most likely not going to change anything...

[@rjen]

What mods do you have installed apart from TinyPortal?

[vbgamer45]

loadcssfile is par of SMF 2.1

[@rjen]

It may be that the OP has a certain mod running that removes SMF version. Since tp uses the variable to determine if it is running on 2.0 or 2.1 that may cause the code to incorrectly call a 2.1 function.

To know that we need to know what other mods he is running

[lurkalot]

It may be that the OP has a certain mod running that removes SMF version. Since tp uses the variable to determine if it is running on 2.0 or 2.1 that may cause the code to incorrectly call a 2.1 function.

To know that we need to know what other mods he is running

That is exactly what's happening then, because the OP is using a mod to hide the SMF version.

[Arantor]

And this is fixable on TP's side by changing whatever "is this 2.1?" test to look if loadCSSFile exists or not

[@rjen]

It may be that the OP has a certain mod running that removes SMF version. Since tp uses the variable to determine if it is running on 2.0 or 2.1 that may cause the code to incorrectly call a 2.1 function.

To know that we need to know what other mods he is running

That is exactly what's happening then, because the OP is using a mod to hide the SMF version.

How do you know that? Did he post a link to his site somewhere?

[@rjen]

And this is fixable on TP's side by changing whatever "is this 2.1?" test to look if loadCSSFile exists or not

Probably, but the version check is used a lot more often, also for many other things...

[Arantor]

And this is fixable on TP's side by changing whatever "is this 2.1?" test to look if loadCSSFile exists or not

Probably, but the version check is used a lot more often, also for many other things...

Version checking is why Windows skipped Windows 9. It is honestly far more trouble than doing feature detection.

[lurkalot]

It may be that the OP has a certain mod running that removes SMF version. Since tp uses the variable to determine if it is running on 2.0 or 2.1 that may cause the code to incorrectly call a 2.1 function.

To know that we need to know what other mods he is running

That is exactly what's happening then, because the OP is using a mod to hide the SMF version.

How do you know that? Did he post a link to his site somewhere?

I asked for a link, so we could ascertain what version of SMF was running and noticed the SMF version was missing from the copyright, and the TP copyright. Was told a mod is being used to hide the SMF version.

[@rjen]

Guess it is this one then: https://custom.simplemachines.org/mods/index.php?mod=1046

That mod and TP cannot be used together...

[lurkalot]

Guess it is this one then: https://custom.simplemachines.org/mods/index.php?mod=1046

That mod and TP cannot be used together...

Wasn't told exactly what mod it was, all I know it was downloaded from here, and it hides the SMF version.  Maybe Sverige will come back and confirm.   I'm big and ugly enough to confess I didn't even think about the version check causing the problem. 

[Arantor]

I'd forgotten the version hide mod even existed, because it doesn't do anything for security whatsoever, it just breaks things elsewhere like why TP is trying to use a 2.1 only function on 2.0 because it doesn't know it's 2.0.

[lurkalot]

I'd forgotten the version hide mod even existed, because it doesn't do anything for security whatsoever, it just breaks things elsewhere like why TP is trying to use a 2.1 only function on 2.0 because it doesn't know it's 2.0.

I'll raise you.  I didn't know it existed at all, and also didn't know it would cause this problem.  It's the first time I have come across this particular scenario involving TP.

[Arantor]

I ran into something like this during LevGal's development when I first added 2.1 support to it since I had to solve the same problem - and I think I even ended up using loadCSSFile as my guinea pig.

[@rjen]

I'd forgotten the version hide mod even existed, because it doesn't do anything for security whatsoever, it just breaks things elsewhere like why TP is trying to use a 2.1 only function on 2.0 because it doesn't know it's 2.0.

I'll raise you.  I didn't know it existed at all, and also didn't know it would cause this problem.  It's the first time I have come across this particular scenario involving TP.

Actually, we had one report before on this TinyPortal.net.
Problem was similar, but not with Loadcssfile.. funny that it seems to give different errors...