News:

SMF 2.1.4 has been released! Take it for a spin! Read more.

Main Menu

Stop Spammer

Started by M-DVD, December 31, 2008, 07:31:43 AM

Previous topic - Next topic

live627

Quote from: Matthias on February 25, 2021, 08:55:50 AM
I have updated this mod:

- Fixed error message "Undefined index: stopspammer_faildb_sub"
- Changes to make the installation work for version 2.0.17
- Changes to make the mod work with php 7.3
- Fixed: The "Check this member" link was visible to everyone in their own profile. Now it is only visible for moderators
- Added css class to the buttons
- Changed text string "Check these members" to "Check Selected Members"
- Changed text string "Report these members" to "Report Selected Members"

https://custom.simplemachines.org/mods/index.php?mod=1547
Which files have changed?  need to create an upgrade path for myself because several tests fail when I try to uninstall. My goal here is to eliminate  all failed tests from the dozens fo mods installed since 2011.

GL700Wing

I have been struggling for hours today to get version 2.4.0 of this mod installed on four different forums (all on different shared servers) which have all been running version 2.3.9 without any issues.

The package file would upload without any issues but the installation kept timing out after 30-40 seconds when I clicked on the 'Install Mod' button in the Package Manager - no error messages logged in the forum, the system error log or the cPanel error log.  Weirdly I could reinstall version 2.3.9 immediately and without any issues on all four forums ...

I persisted with installing version 2.4.0 and basically I had to click the 'Install Mod' button in the Package Manager multiple times before the 'Install Mod' screen would display and even when it did there was sometimes an 'Modification parse error' error display for each of the package XML files (see attached image) - when this happened I then had to refresh the browser screen several times before the 'Modification parse error' error would disappear after which the mod would install within a couple of seconds without any further issues.

Having finally got version 2.4.0 installed on all four forums I then decided to try and work out what the difference was in the installation process for version 2.3.9 compared to version 2.4.0 and I discovered it was actually the 'readme' file for version 2.4.0 that was causing the timeout issues.

To show the supported languages the 'readme' file for version 2.4.0 loads the following 25 country flag image files from the Simple Machines website and I'm guessing the timeout issues are occurring because my forum servers are on the other side of the world - and across a very large, deep, and watery ditch - from the Simple Machines servers.







This is the code from the 'readme' file for version 2.4.0 that is causing the installation timeout issues:

[tr][td][b]Languages:[/b][/td][td][img]http://www.simplemachines.org/site_images/lang/english.gif[/img] [img]http://www.simplemachines.org/site_images/lang/english_british.gif[/img] [img]http://www.simplemachines.org/site_images/lang/spanish.gif[/img] [img]http://www.simplemachines.org/site_images/lang/spanish_latin.gif[/img] [img]http://www.simplemachines.org/site_images/lang/arabic.gif[/img] [img]http://www.simplemachines.org/site_images/lang/french.gif[/img]
[img]http://www.simplemachines.org/site_images/lang/bulgarian.gif[/img] [img]http://www.simplemachines.org/site_images/lang/portuguese_pt.gif[/img] [img]http://www.simplemachines.org/site_images/lang/portuguese_brazilian.gif[/img] [img]http://www.simplemachines.org/site_images/lang/dutch.gif[/img] [img]http://www.simplemachines.org/site_images/lang/indonesian.gif[/img] [img]http://www.simplemachines.org/site_images/lang/italian.gif[/img]
[img]http://www.simplemachines.org/site_images/lang/danish.gif[/img] [img]http://www.simplemachines.org/site_images/lang/turkish.gif[/img] [img]http://www.simplemachines.org/site_images/lang/russian.gif[/img] [img]http://www.simplemachines.org/site_images/lang/ukrainian.gif[/img] [img]http://www.simplemachines.org/site_images/lang/chinese-simplified.gif[/img] [img]http://www.simplemachines.org/site_images/lang/chinese-traditional.gif[/img]
[img]http://www.simplemachines.org/site_images/lang/swedish.gif[/img] [img]http://www.simplemachines.org/site_images/lang/german.gif[/img] [img]http://www.simplemachines.org/site_images/lang/polish.gif[/img] [img]http://www.simplemachines.org/site_images/lang/croatian.gif[/img] [img]http://www.simplemachines.org/site_images/lang/hungarian.gif[/img] [img]http://www.simplemachines.org/site_images/lang/norwegian.gif[/img]
[img]http://www.simplemachines.org/site_images/lang/finnish.gif[/img] [/td][/tr]


By comparison, the 'readme' file for version 2.3.9 does not load these images which probably explains why I was able to reinstall that version quickly and without any issues.

I strongly recommend that the 'readme' file for this mod be updated to simply list the supported languages rather than showing the country flags ...

That's about four hours of my life I'll never get back ...
Life doesn't have to be perfect to be wonderful ...

landyvlad

I've asked a general question elsewhere - but is there any chance of a 2.1 version being developed for this mod?
"Put as much effort into your question as you'd expect someone to give in an answer"

Please do not PM, IM or Email me with questions on astrophysics or theology.  You will get better and faster responses by asking homeless people in the street. Thank you.

Be the person your dog thinks you are.

Alpay

#2123
Hello,
   Very nice mod.. How can scan all members at once?

Quote from: Kindred on July 29, 2013, 12:13:54 PM
there is no way to do that....    and submitting 4000 pages of requests (at 50 per page, that would be 20,000 requests) would probably be a violation of the SFS database ToS. (In other words, don't do it... don't try to do it)

though a trigger would slowly test the back road with a worklist ?
maybe ... Forum Maintenance?

Tomcraft

Where can I find version 2.4.0 of the mod? It is currently not available to download at the mod site.

You cannot view this attachment.

izotz

Any update? It looks like the attachment is gone, and I can't download the MOD.

KittyGalore

Quote from: izotz on August 29, 2021, 01:49:50 PMAny update? It looks like the attachment is gone, and I can't download the MOD.
Looks like it could have been deleted since the site was update to 2.1 RC4 was there before that.
SMF Curve 2.0x

Tomcraft

Does anybody still have the version 2.4.0 to share with us?

KittyGalore

#2128
Quote from: Tomcraft on September 01, 2021, 05:45:48 AMDoes anybody still have the version 2.4.0 to share with us?
Here you go not sure why it was deleted.
SMF Curve 2.0x

Kindred

attachment removed.  Mod file was restored to the mod page. :)
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

landyvlad

I haven't asked for a couple of months so -
Any plans for this to be updated to be 2.1.x compatible?
"Put as much effort into your question as you'd expect someone to give in an answer"

Please do not PM, IM or Email me with questions on astrophysics or theology.  You will get better and faster responses by asking homeless people in the street. Thank you.

Be the person your dog thinks you are.

landyvlad

Hmm I see that Matthias (the champion) hasn't been online since August, Snoopy since February and M-DVD since 2010 :)


Hopefully Matthias will pop in again sometime and let us know how things are going viz
SMF 2.1
PHP 7.4 +
IPv6
 
"Put as much effort into your question as you'd expect someone to give in an answer"

Please do not PM, IM or Email me with questions on astrophysics or theology.  You will get better and faster responses by asking homeless people in the street. Thank you.

Be the person your dog thinks you are.

DarkAngel612

I just upgraded one of my forums and after I did it the install link is missing from Package Manager, should I use the Advanced link as if I was installing an older version?
Fantasy Attic ::  Fantasies Realm Market :: SMF 2.0+ with various mods and TinyPortal

Diego Andrés

Quote from: DarkAngel612 on January 06, 2022, 01:37:29 AMI just upgraded one of my forums and after I did it the install link is missing from Package Manager, should I use the Advanced link as if I was installing an older version?

Yes, just make sure you test/backup if you have to

SMF Tricks - Free & Premium Responsive Themes for SMF.

Avid Gamer

This is a great mod but only works on 2.0.18 are you going to support 2.0.19 and the up coming 2.1 versions. Also PHP 7.4, 8x

As previously stated not much activity from the mod writer's and that is worrying as to the future of this mod, I hope it gets supported soon even if I have to donate/pay/get a pro version.


Keep up the good work.
Mess with the Best
Die like the Rest.

Shambles

Quote from: Avid Gamer... great mod but only works on 2.0.18 are you going to support 2.0.19 ...

It works fine on 2.0.19

spiros

Has anybody tested it with php 8? I get Call to undefined function create_function() when accessing Members (using 2.3.9, when I tried to uninstall it shoes 3 errors in 2 files)
https://www.simplemachines.org/community/index.php?topic=580270.new#new

Arantor

Lack of create_function is clearly a PHP 8 problem. Try https://custom.simplemachines.org/index.php?mod=4300 to get around that.

spiros

Interesting, I see security/performance issues lead to its demise... https://lindevs.com/function-create_function-has-been-removed-in-php-8-0/

Arantor

The security angle is only an issue if user input is fed into the function's definition, if not the security angle is literally no different to a regular closure. (In other words, like eval.)

As for performance that's also a shade misleading. Yes, eval is used to execute the code but the net result is that only the parsing step is actually slower; create_function creates a regular function that exists in global scope (like any other SMF function that isn't a class), with a fancy prefix with a hidden character at the start (and is excluded by get_defined_functions).

As long as you're not declaring create_function instances in a loop you should be fine. (Incremental cost of adding new functions is significantly higher than adding new instances of Closure. 2.0.7 had some issues with this for example, fixed in 2.0.8.)

The manual words it the way it does for the general case because we've had better options for years but legacy code with old-school support means that it's hard to move on.

Advertisement: