News:

Want to get involved in developing SMF, then why not lend a hand on our github!

Main Menu

Stop Spammer

Started by M-DVD, December 31, 2008, 07:31:43 AM

Previous topic - Next topic

shadav

Quote from: SugarD-x on September 16, 2019, 10:30:10 AM
Quote from: shadav on September 15, 2019, 08:39:31 PM
got an error with this mod installed
2.0.15

so I go to view the members on my forum in my admin
admin >members
and I have an error

syntax error, unexpected '||' (T_BOOLEAN_OR)
Any other mods installed? Where is the error happening and in what file? There may be a conflict somewhere.

admin/?area=viewmembers

:laugh: a lot of mods installed....

Emoji Parser
Relative Time And Date
Replace Board Title With Image
Footnotes
Welcome Topic Mod   
Quick Buddies   
BBC You   
FancyPosts
RSS Images   
Better Profile Menu   
Board Stats   
Say Thanks   
BBC Message Boxes   
Karma Description Mod   
Member Color   
Reason For Editing Mod   
Characters remaining of post   
Sorted Package Manager Listing   
BBC In Custom Title   
reCAPTCHA for SMF   
List Of Users In Forum/Board/Topic   
Modified No Topics Message (SMF 2.0+)   
Board Notes   
[BBCode] Dotted Underline   
'Read the Rules' Link Above Post Button   
Add Social Media Icons To Profiles   
Optimus
SMF Articles   
Post Anonymously In Topic   
Drafts
Social Login   
Who Downloaded Attachment   
DisplayPostedTopicsMod   
Stupid bouncy BBC   
Auto Respond   
NiceTooltips
Multiple Smiley Aliases   
Ban List   
Move Posts addon   
Show JDALLAUI in Post and PM   
Board Message Icon   
Enhanced Dropdown   
Word Censor List   
More Spiders   
Glossary
Like Posts   
[BBCode] Overline   
Adk Blog   
Referrals System   
Who Quoted Me   
ETNTPT - Edited Time Next To Posted Time   
ShowBannedMessage   
Enhancements to purge inactive members   
FeatureUser
Left-To-Right and Right-To-Left BBcode Buttons   
Menu without limit level   
Treasury
Custom Report Mod   
Additional Membergroups on Profile   
Best Answer Intergration   
Nickname to Reply   
SA KB   
Avatars on Board/MessageIndex   
Log Karma Actions   
Board-color-and-icons   
Admin Ban Button in Post   
Forum Visitors   
Downloads System   
Topic_Locked_Message   
Pretty URLs   
Add Stars To Profile   
Lazy Moderator Menu   
Smush.it! For SMF   
Add Avatar To Who Is Online Version 1.2   
BBCode with style   
Recount Member Posts   
Tabbed smileys   
Lazy Admin Menu   
AdditionalMembergroups   
Enhancements to recent posts   
httpBL   
Quick Translation   
Fix Message Empty Error For Embed Video Mods   
404 on Missing Topics/Boards   
Google Tagged   
Play Media Attachment   
ENotify
Anti-Spam Links   
AMSP - Add Member's Signature Permission   
Additional Topic Authors   
Dynamic_Memberlist
SMF Gallery Lite   
List-Unsubscribe   
Topic Viewers   
Yet Another Spoiler Mod   
6 Custom buttons / tabs with Sub Menus (4)   
Posting_Announcement   
Date_Registerd on post   
Post and PM Inline Attachments   
Quick Ban on Account Delete   
Membergroup Signature Permissions   
AJAX Recent Topics   
Default Avatar   
New Hooks   
Menu_Icons   
Download Attachment   
Bookmarks   
Alert
Related Topics   
Buddies With Me (aka Followers)   
Spiders Don't Increase Topic Views
Auto Merge Double Post   
@mention members   
Alternative Menu With Top Menu Icon & Button Remover   
Unknown Actions   
Force Topic Read On Login Mod   
Country Flags
Auto Refresh Who Index   
Change Report Text To Image   
Profile Views   
Font AweaZome   
AWSP - Add WebSite Permission   
Image Floating to Left or Right BBCode   
Prevent Topic View Increase by Author   
Better Messages Menu   
Event Reminder Mod for SMF2   
Today Registrations   
Signature Area BBCode Buttons   
Make modified post unread   
Images with Margins and Borders   
Number of Unapproved Posts and Topics in Header   
Join Reason   
Member NotePad   
Open Embed   
Hall Of Fame   
RSS Feed Icon   
Buddy Page   
Event Registration Mod for SMF2   
Joinable Groups   
Activity Bar   
Topic Descriptions   
Custom BBCodes Manager   
PM Attachments   
Working top level links for drop menus   
SMF Staff Page   
SMF Links   
Topics Created And Participated In   
Current Signature Mod   
Buy me A drink   
Audio and Video BBCodes
Responsive Curve

Nodaz

having an issue updating from 2.0.14 to 2.0.15,

https://www.simplemachines.org/community/index.php?topic=570655.0
am told it is likely and issue with Stop Spammer and to look here, but cant find anything specific to help fix it.
Any direction?


SD-X

Quote from: Nodaz on November 27, 2019, 04:33:10 PM
having an issue updating from 2.0.14 to 2.0.15,

https://www.simplemachines.org/community/index.php?topic=570655.0
am told it is likely and issue with Stop Spammer and to look here, but cant find anything specific to help fix it.
Any direction?
I would recommend uninstalling it first before updating your forum. Then you'll be able to see the exact line that is causing the conflict when you try to add it again. Make sure you're also using the latest version of Stop Spammer available.

Edit: https://www.simplemachines.org/community/index.php?msg=3957547

Nodaz

Quote from: SugarD-x on November 27, 2019, 06:29:48 PM
Quote from: Nodaz on November 27, 2019, 04:33:10 PM
having an issue updating from 2.0.14 to 2.0.15,

https://www.simplemachines.org/community/index.php?topic=570655.0
am told it is likely and issue with Stop Spammer and to look here, but cant find anything specific to help fix it.
Any direction?
I would recommend uninstalling it first before updating your forum. Then you'll be able to see the exact line that is causing the conflict when you try to add it again. Make sure you're also using the latest version of Stop Spammer available.

Edit: https://www.simplemachines.org/community/index.php?msg=3957547
Ok i will do that a check back.

Nodaz

I would recommend uninstalling it first before updating your forum. Then you'll be able to see the exact line that is causing the conflict when you try to add it again. Make sure you're also using the latest version of Stop Spammer available.

[/quote]
Ok, uninstalled stop spammer and the update installed without a hitch.

Deletedd oldstop spammer package( which was same as current), downloaded new.
Tested install and get this:
*    1.    Execute Modification    ./Sources/ManageRegistration.php    Test successful
*    2.    Execute Modification    ./Sources/ManageMembers.php    Test failed
      1.    Add After    ./Sources/ManageMembers.php    Test successful
      2.    Replace    ./Sources/ManageMembers.php    Test successful
      3.    Replace    ./Sources/ManageMembers.php    Test successful
      4.    Replace    ./Sources/ManageMembers.php    Test successful
      5.    Replace    ./Sources/ManageMembers.php    Test successful
      6.    Replace    ./Sources/ManageMembers.php    Test successful
      7.    Replace    ./Sources/ManageMembers.php    Test successful
      8.    Replace    ./Sources/ManageMembers.php    Test successful
      9.    Add Before    ./Sources/ManageMembers.php    Test successful
      10.    Add Before    ./Sources/ManageMembers.php    Test successful
      11.    Add Before    ./Sources/ManageMembers.php    Test successful
      12.    Add Before    ./Sources/ManageMembers.php    Test successful
      13.    Replace    ./Sources/ManageMembers.php    Test failed
*    3.    Execute Modification    ./Sources/Register.php    Test successful
*    4.    Execute Modification    ./Sources/Subs.php    Test successful
*    5.    Execute Modification    ./Sources/Subs-Members.php    Test successful
*    6.    Execute Modification    ./Sources/Profile.php    Test successful
*    7.    Execute Modification    ./Themes/default/languages/Modifications.english.php    Test successful
   8.    Execute Modification    ./Themes/default/languages/Modifications.english_british.php    Skipping file
   9.    Execute Modification    ./Themes/default/languages/Modifications.spanish.php    Skipping file
   10.    Execute Modification    ./Themes/default/languages/Modifications.spanish_es.php    Skipping file
   11.    Execute Modification    ./Themes/default/languages/Modifications.spanish_latin.php    Skipping file
   12.    Execute Modification    ./Themes/default/languages/Modifications.english-utf8.php    Skipping file
   13.    Execute Modification    ./Themes/default/languages/Modifications.english_british-utf8.php    Skipping file
   14.    Execute Modification    ./Themes/default/languages/Modifications.spanish-utf8.php    Skipping file
   15.    Execute Modification    ./Themes/default/languages/Modifications.spanish_es-utf8.php    Skipping file
   16.    Execute Modification    ./Themes/default/languages/Modifications.spanish_latin-utf8.php    Skipping file
   17.    Extract File    ./Sources/StopSpammer.php    
   18.    Extract File    ./Themes/default/images/icons/spammer.gif    
   19.    Extract File    ./Themes/default/images/icons/suspect.gif    
   20.    Extract File    ./Themes/default/images/icons/moreinfo.gif    
   21.    Adapt Database    install_2.php

Arantor

Holder of controversial views, all of which my own.

Nodaz

I
Quote from: Arantor on November 29, 2019, 04:49:55 PM
And the link mentioned is how you fix it - https://www.simplemachines.org/community/index.php?topic=283309.msg3957547#msg3957547
I have opened the sources/managemembers.php file and searched for that string as listed in the link you posted:
Cannot find it or any part of it...


SD-X

Quote from: Nodaz on November 29, 2019, 06:20:49 PM
I
Quote from: Arantor on November 29, 2019, 04:49:55 PM
And the link mentioned is how you fix it - https://www.simplemachines.org/community/index.php?topic=283309.msg3957547#msg3957547
I have opened the sources/managemembers.php file and searched for that string as listed in the link you posted:
Cannot find it or any part of it...
Since you uninstalled Stop Spammer already, you may need to look for the opposite code so you can re-add it manually. Just to be safe, also do a search for anything related to StopSpammer in those files before installing again in case you ended up with duplicate code or something that wasn't properly removed.

Nodaz

Quote from: SugarD-x on November 29, 2019, 07:03:29 PM
Quote from: Nodaz on November 29, 2019, 06:20:49 PM
I
Quote from: Arantor on November 29, 2019, 04:49:55 PM
And the link mentioned is how you fix it - https://www.simplemachines.org/community/index.php?topic=283309.msg3957547#msg3957547
I have opened the sources/managemembers.php file and searched for that string as listed in the link you posted:
Cannot find it or any part of it...
Since you uninstalled Stop Spammer already, you may need to look for the opposite code so you can re-add it manually. Just to be safe, also do a search for anything related to StopSpammer in those files before installing again in case you ended up with duplicate code or something that wasn't properly removed.
Im not sure what you mean by opposite code...
  I scanned the entire document using a search function for anything spammer related and there is nothing.

Thank you BTW for assisting me with this, i do appreciate your help.

Nodaz

still unable to proceed in updating to 2.0.15 still running into this after uninstalling Stop Spammer:

1.    Execute Code    $auto_0.php    
*    2.    Execute Modification    ./index.php    Test successful
*    3.    Execute Modification    ./proxy.php    Test successful
*    4.    Execute Modification    ./SSI.php    Test successful
*    5.    Execute Modification    ./Themes/default/Login.template.php    Test successful
*    6.    Execute Modification    ./Sources/Class-CurlFetchWeb.php    Test successful
*    7.    Execute Modification    ./Sources/SendTopic.php    Test successful
*    8.    Execute Modification    ./Sources/DbPackages-mysql.php    Test successful
*    9.    Execute Modification    ./Sources/SearchAPI-Custom.php    Test successful
*    10.    Execute Modification    ./Sources/SearchAPI-Fulltext.php    Test successful
*    11.    Execute Modification    ./Sources/ManageServer.php    Test successful
*    12.    Execute Modification    ./Sources/Stats.php    Test successful
*    13.    Execute Modification    ./Sources/DbExtra-mysql.php    Test successful
*    14.    Execute Modification    ./Sources/DbExtra-postgresql.php    Test successful
*    15.    Execute Modification    ./Sources/DbExtra-sqlite.php    Test successful
*    16.    Execute Modification    ./Sources/Subs-Admin.php    Test successful
*    17.    Execute Modification    ./Sources/Admin.php    Test successful
*    18.    Execute Modification    ./Sources/ManageMembers.php    Test failed
      1.    Replace    ./Sources/ManageMembers.php    Test successful
      2.    Replace    ./Sources/ManageMembers.php    Test failed
      3.    Replace    ./Sources/ManageMembers.php    Test successful
*    19.    Execute Modification    ./Sources/Subs-Boards.php    Test successful
*    20.    Execute Modification    ./Themes/default/Admin.template.php    Test successful
*    21.    Execute Modification    ./Sources/PersonalMessage.php    Test successful
*    22.    Execute Modification    ./Sources/Subs-Auth.php    Test successful

I found THIS in the managemembers .php file:
Im not sure what excatly to delete( if i should delete)

   // Default to sub action 'index' or 'settings' depending on permissions.
$_REQUEST['sa'] = isset($_REQUEST['sa']) && isset($subActions[$_REQUEST['sa']]) ? $_REQUEST['sa'] : 'all';

// Load Stop Spammer Functions
if ('all' == $_REQUEST['sa'] || 'browse' == $_REQUEST['sa'] || 'query' == $_REQUEST['sa'] || 'approve' == $_REQUEST['sa'])
{
global $sourcedir;
require_once($sourcedir . '/StopSpammer.php');
}

// We know the sub action, now we know what you're allowed to do.
isAllowedTo($subActions[$_REQUEST['sa']][1]);


Kindred

you did not fully uninstall the mod.
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Nodaz

#2071
Quote from: Kindred on December 02, 2019, 05:54:02 PM
you did not fully uninstall the mod.
I uninstalled it from package manager...it must have left this, What part should i delete?
// Default to sub action 'index' or 'settings' depending on permissions.
$_REQUEST['sa'] = isset($_REQUEST['sa']) && isset($subActions[$_REQUEST['sa']]) ? $_REQUEST['sa'] : 'all';

// Load Stop Spammer Functions
if ('all' == $_REQUEST['sa'] || 'browse' == $_REQUEST['sa'] || 'query' == $_REQUEST['sa'] || 'approve' == $_REQUEST['sa'])
{
global $sourcedir;
require_once($sourcedir . '/StopSpammer.php');
}

// We know the sub action, now we know what you're allowed to do.
isAllowedTo($subActions[$_REQUEST['sa']][1]);

// Load the essentials.
loadLanguage('ManageMembers');
loadTemplate('ManageMembers');

// Get counts on every type of activation - for sections and filtering alike.
$request = $smcFunc['db_query']('', '
SELECT COUNT(*) AS total_members, is_activated
FROM {db_prefix}members
WHERE is_activated != {int:is_activated}
GROUP BY is_activated',
array(
'is_activated' => 1,
)
);
$context['activation_numbers'] = array();
$context['awaiting_activation'] = 0;
$context['awaiting_approval'] = 0;
while ($row = $smcFunc['db_fetch_assoc']($request))
$context['activation_numbers'][$row['is_activated']] = $row['total_members'];
$smcFunc['db_free_result']($request);

foreach ($context['activation_numbers'] as $activation_type => $total_members)
{
if (in_array($activation_type, array(0, 2)))
$context['awaiting_activation'] += $total_members;
elseif (in_array($activation_type, array(3, 4, 5)))
$context['awaiting_approval'] += $total_members;
}

Kindred

per the parse of the mod, it added


// Load Stop Spammer Functions
if ('all' == $_REQUEST['sa'] || 'browse' == $_REQUEST['sa'] || 'query' == $_REQUEST['sa'] || 'approve' == $_REQUEST['sa'])
{
global $sourcedir;
require_once($sourcedir . '/StopSpammer.php');
}




but if one thing was left behind, there might be more...     
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Nodaz

Quote from: Kindred on December 02, 2019, 08:13:33 PM
per the parse of the mod, it added


// Load Stop Spammer Functions
if ('all' == $_REQUEST['sa'] || 'browse' == $_REQUEST['sa'] || 'query' == $_REQUEST['sa'] || 'approve' == $_REQUEST['sa'])
{
global $sourcedir;
require_once($sourcedir . '/StopSpammer.php');
}




but if one thing was left behind, there might be more...     

Would there be a reference to stop spammer in each instance?
The one i posted is the only thing that appears with a search for "stop spammer"
Ill remove that instance and see if anything changes.

Kindred

go to the mod page
parse the mod for manual installation
see the code changes
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Nodaz

#2075
I deleted that first piece of code, still get the error,when i click the "information" icon on the  ]far left of the line with the error i get the following.
can i run the update, then find and replace what i see manually?
what is this telling me exactly?


Code: (Find) [Select]

if ($context['sub_action'] == 'query' && !empty($_REQUEST['params']) && empty($_POST))
$_POST += safe_unserialize(base64_decode($_REQUEST['params']));

Code: (Replace) [Select]

if ($context['sub_action'] == 'query' && empty($_POST))
{
if (!empty($_REQUEST['params']))
{
$_POST += safe_unserialize(base64_decode($_REQUEST['params']));
}
elseif ($context['browser']['is_ie'] && !empty($_SESSION['params']))
{
$_POST += $_SESSION['params'];
unset($_SESSION['params']);
}
}



EDIT:
so i couldnt find this code in the managemembers.php

if ($context['sub_action'] == 'query' && !empty($_REQUEST['params']) && empty($_POST))
$_POST += safe_unserialize(base64_decode($_REQUEST['params']));


added it, uploaded and the update ran without a hitch.


Nodaz

But after installing the 2.0.15 update i get the following error when trying to reinstall stop spammer

1. Execute Modification install_2.xml Modification parse error
2. Execute Modification install_2.xml Modification parse error
3. Execute Modification languages.xml Modification parse error
4. Execute Modification languages.xml Modification parse error
5. Execute Modification languages_utf8.xml Modification parse error
6. Execute Modification languages_utf8.xml Modification parse error
7. Extract File ./Sources/StopSpammer.php
8. Extract File ./Themes/default/images/icons/spammer.gif
9. Extract File ./Themes/default/images/icons/suspect.gif
10. Extract File ./Themes/default/images/icons/moreinfo.gif
11. Adapt Database install_2.php

Nodaz

thanks for the patience, i really dont spend a lot of time with this type of back end stuff i am just trying to make sure i understand what i should do before i do it.
So, do i understand correctly that i should run the stop spammer install even with the errors , THEN go back in, and modify the files as directed in the instructions that have been given?

Kindred

essentially, yes

except you are seeing way too many errors. You should only see ONE failure because there is only one bit of code that needs manual editing
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Nodaz

Quote from: Kindred on December 06, 2019, 08:43:50 AM
essentially, yes

except you are seeing way too many errors. You should only see ONE failure because there is only one bit of code that needs manual editing
So perhaps a fresh install is the best course of action?
i just dont want to lose the forum data

Advertisement: