Advertisement:

Author Topic: Deleting a theme actually deletes the theme.  (Read 25710 times)

kat

  • Guest
Deleting a theme actually deletes the theme.
« on: June 03, 2013, 03:29:44 PM »
Deleting a theme leaves all files onsite. Shouldn't deleting a theme delete it, properly?

(Apologies if this has already been discussed)

Offline Burke ♞ Knight

  • SMF Hero
  • ******
  • Posts: 3,534
Re: Deleting a theme actually deletes the theme.
« Reply #1 on: June 03, 2013, 03:46:32 PM »
I had been wondering the same thing. I've deleted themes to help on disk space and transfers, yet was shocked to see they were still there. That kind of makes deleting pointless. I agree that it should delete all files and the directory, too.

Offline live627

  • Development Contributor
  • SMF Hero
  • *
  • Posts: 5,629
  • Gender: Male
    • live627 on Facebook
    • live627 on GitHub
    • live627 on LinkedIn
    • @live627 on Twitter
    • livemods
Re: Deleting a theme actually deletes the theme.
« Reply #2 on: June 04, 2013, 12:53:24 AM »
Files stay there??


Offline shadow82x

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 11,279
  • Gender: Male
    • cmblaber on LinkedIn
Re: Deleting a theme actually deletes the theme.
« Reply #3 on: June 04, 2013, 01:40:20 AM »
I agree. It's illogical too.
Colin B
Former Spammer, Customize, & Support Team Member

kat

  • Guest
Re: Deleting a theme actually deletes the theme.
« Reply #4 on: June 04, 2013, 04:30:39 AM »
Come to think of it, I'd actually like to see a patch for v2.0.4 that does this, not just in any new versions.

Offline Burke ♞ Knight

  • SMF Hero
  • ******
  • Posts: 3,534
Re: Deleting a theme actually deletes the theme.
« Reply #5 on: June 04, 2013, 04:37:45 AM »
I'm actually surprised that no one has brought up this issue before.
Also, that no one has made a mod to do so.
But, the main question is, why is this an issue in the first place?
Unless the team decided to have the delete function delete only from the theme list, and not the files in case people decided they wanted the theme back again.

Offline Shambles

  • SMF Hero
  • ******
  • Posts: 5,290
  • Gender: Male
    • i30 Owners Club
Re: Deleting a theme actually deletes the theme.
« Reply #6 on: June 04, 2013, 04:41:53 AM »
I guess in a way it's similar to modifications. When you uninstall a mod it also leaves the package hanging around until you delete it (via pacman or ftp).

I don't install so many themes to be a problem for me ;)

kat

  • Guest
Re: Deleting a theme actually deletes the theme.
« Reply #7 on: June 04, 2013, 04:46:48 AM »
It does seem kinda odd, don't you think?

Maybe an option to either delete the files, or not, would be best?

Offline Shambles

  • SMF Hero
  • ******
  • Posts: 5,290
  • Gender: Male
    • i30 Owners Club
Re: Deleting a theme actually deletes the theme.
« Reply #8 on: June 04, 2013, 05:19:11 AM »
Yes, that is an oversight I guess.

Offline Burke ♞ Knight

  • SMF Hero
  • ******
  • Posts: 3,534
Re: Deleting a theme actually deletes the theme.
« Reply #9 on: June 04, 2013, 05:21:59 AM »
It does seem kinda odd, don't you think?

Maybe an option to either delete the files, or not, would be best?

That's what I think. However, I think it would be wise to set it to not allowing the deletion of the default theme.

Offline Shambles

  • SMF Hero
  • ******
  • Posts: 5,290
  • Gender: Male
    • i30 Owners Club
Re: Deleting a theme actually deletes the theme.
« Reply #10 on: June 04, 2013, 05:24:02 AM »
Quote from: BurkeKnight
...I think it would be wise to set it to not allowing the deletion of the default theme.
Why not? It's just taking up valuable filestore.


Oh, wait...

Offline Burke ♞ Knight

  • SMF Hero
  • ******
  • Posts: 3,534
Re: Deleting a theme actually deletes the theme.
« Reply #11 on: June 04, 2013, 05:30:23 AM »
Quote from: BurkeKnight
...I think it would be wise to set it to not allowing the deletion of the default theme.
Why not? It's just taking up valuable filestore.


Oh, wait...

Thanks...



Poor cat....





Poor cup of ice coffee....

Offline live627

  • Development Contributor
  • SMF Hero
  • *
  • Posts: 5,629
  • Gender: Male
    • live627 on Facebook
    • live627 on GitHub
    • live627 on LinkedIn
    • @live627 on Twitter
    • livemods
Re: Deleting a theme actually deletes the theme.
« Reply #12 on: June 04, 2013, 06:55:08 AM »
i needz img kthx

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 58,752
  • Gender: Male
    • Kindred-999 on GitHub
Re: Deleting a theme actually deletes the theme.
« Reply #13 on: June 04, 2013, 10:30:08 AM »
actually, I can see the point of doing it the way we do (and I don't think it was an oversight. I believe that it is intentional)


you may be removing a theme but want it back later
you may have made custom edits or included custom images that you didn't mean to delete.
etc etc

requiring the user to manually remove the theme directory seems like a valid "protection against stupidity" to me...
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

Offline Irisado

  • Una Luz Brillante en la Oscuridad
  • Doc Coordinator
  • SMF Super Hero
  • *
  • Posts: 10,356
  • Soñando debajo del arco iris
Re: Deleting a theme actually deletes the theme.
« Reply #14 on: June 04, 2013, 11:47:25 AM »
requiring the user to manually remove the theme directory seems like a valid "protection against stupidity" to me...

I was actually trying to come up with a counter to that, but I can't  :D.

While deleting the theme in the way K@ suggests would be my personal preference, what Kindred's saying also seems very logical to me, so I guess that it's best just to leave things as they are.
Soñando con una playa donde brilla el sol, un arco iris ilumina el cielo, y el mar espejea iridescentemente

kat

  • Guest
Re: Deleting a theme actually deletes the theme.
« Reply #15 on: June 04, 2013, 02:04:10 PM »
So, why not have a "Do you want to delete the actual files from the server" option?

Or, at least, a message saying that the files won't be deleted and will have to be deleted manually?

It seems extremely silly just to leave them there and, possibly, leave the admin with no idea that the files are there, taking-up valuable space.

Offline Burke ♞ Knight

  • SMF Hero
  • ******
  • Posts: 3,534
Re: Deleting a theme actually deletes the theme.
« Reply #16 on: June 04, 2013, 02:36:00 PM »
It seems extremely silly just to leave them there and, possibly, leave the admin with no idea that the files are there, taking-up valuable space.

How about at least telling the people that the dir/files are not actually being deleted?

kat

  • Guest
Re: Deleting a theme actually deletes the theme.
« Reply #17 on: June 04, 2013, 02:42:23 PM »
My point, exactly. :)

Or, at least, a message saying that the files won't be deleted and will have to be deleted manually?

Offline Antechinus

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 24,858
  • Master of BBC Abuse
Re: Deleting a theme actually deletes the theme.
« Reply #18 on: June 05, 2013, 01:08:59 AM »
Yeah, because any competent admin will never check the contents of their directories.

Oh, wait.......... :D

IMO it would make sense to change the wording in admin, so that it does not say the theme is going to be deleted, but instead says the theme wll be uninstalled (which is what actually happens).

It's consistent with the behaviour of the package manager when uninstalling mods. The files stay put in case you want to reinstall later.

Offline NanoSector

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 10,500
  • Gender: Male
  • VC321xb47@aperture:~#
    • Yoshi2889 on GitHub
Re: Deleting a theme actually deletes the theme.
« Reply #19 on: June 05, 2013, 01:37:47 AM »
What about doing the same thing as the PM, separate uninstall and delete?
My Mods / Mod Builder - A tool to easily create mods / Blog
"I've heard from a reliable source that the Answer is 42. But, still no word on what the question is."