November Update

[Akyhne]

I understand. But maybe you could do the detection system and some other can pick up on a proper theme.

[Arantor]

Why would we do that, though? There's no point us adding something that we're not using in the core.

[emanuele]

Actually mobile detection is already in core (see Class-BrowserDetect.php).

[Arantor]

I knew there was browser detection but I didn't realise it covered mobile (mostly because there's no need for such in the core the rest of the time) - SMF is a huge code base

[maxg]

sorry I late, try to study more the web code!

A side from what's mentioned above on detection:

I also did some testing on the responsiveness of the 2.1 alpha 1 ; default, and it appears to be working real nice thus far. looks like the Mobile and various Browsers should pretty much be satisfied for now.

Note that themers can select and or change menus to fit their needs and long as they coded responsive ( I think) at least I tested them on the older SMF 2.0.5 version. I think bloc has been working this also for some time now

In short I feel the Dev's need not be concerned any more with this for now Moving On>>! JMO

regards,
Maxx

[emanuele]

I knew there was browser detection but I didn't realise it covered mobile (mostly because there's no need for such in the core the rest of the time)

Well, when 2.1 started the mobile theme was part of the goals, there *was* a reason to have mobile detection.

SMF is a huge code base

I know. O:-)

[Arantor]

Ahhh, I see. There's still a lot for me to catch up with in the last couple of years' work...

[Akyhne]

So the code is there, it's just not used for mobile detection?

[Arantor]

So it would appear. I'm still trying to get up to speed on some things (a few weeks is not nearly long enough to pick up all the nuances of everything that's changed in 2 years)

But there's no mobile theme that I'm aware of, which does make it somewhat redundant.

[Akyhne]

Hmm, the ?wap2 still Works in 2.1. But the link isn't anywhere in the new theme.

[margarett]

Nop, the link was removed from the footer, but index.php still works with it:

Code Select Expand


// Determine if this is using WAP, WAP2, or imode.  Technically, we should check that wap comes before application/xhtml or text/html, but this doesn't work in practice as much as it should.
if (isset($_REQUEST['wap']) || isset($_REQUEST['wap2']) || isset($_REQUEST['imode']))
unset($_SESSION['nowap']);
elseif (isset($_REQUEST['nowap']))
$_SESSION['nowap'] = true;
elseif (!isset($_SESSION['nowap']))
{
if (isset($_SERVER['HTTP_ACCEPT']) && strpos($_SERVER['HTTP_ACCEPT'], 'application/vnd.wap.xhtml+xml') !== false)
$_REQUEST['wap2'] = 1;
elseif (isset($_SERVER['HTTP_ACCEPT']) && strpos($_SERVER['HTTP_ACCEPT'], 'text/vnd.wap.wml') !== false)
{
if (strpos($_SERVER['HTTP_USER_AGENT'], 'DoCoMo/') !== false || strpos($_SERVER['HTTP_USER_AGENT'], 'portalmmm/') !== false)
$_REQUEST['imode'] = 1;
else
$_REQUEST['wap'] = 1;
}
}


And there is yet a Wireless.template.php so yes, it still works (probably won't last much longer...)

[Akyhne]

Ok

[bloc]

I find it a bit amusing that the lead developer don't know what user agents are detected or not lol..its even a check for android/iphone in SMF 2.04, and has been for a quite a while. That it hasn't been used is of course due to no-one on the SMF team actually works with themes and therefore could not care less about it...or so it would seem.

[Arantor]

Funny, last I checked my badge and title did not say lead developer.

That and trying to pick up on the *vast* number of changes between 2.0 and 2.1 in a few weeks... I wonder if you would be able to do the same with all the changes that have happened.

You'll forgive me if I don't remember every change that occurs across a 130k line code base.

[bloc]

Well, don't speak with such certainty about it then.

I've been following SMF code base for quite some years, I don't know all of it, BUT, I follow it quite easy because its a structure I have looked at and changed numerous times. You can't tell me you haven't done the same working on Wedge? 2.1 might be different..but its not THAT different.

But hey, its ok. You don't know everything, and neither does the rest of us.

[Arantor]

I didn't, actually. I said a full mobile environment is not going to happen, and that I didn't see us adding something to the core we weren't using... I still don't see why we have browser detection that detects mobile browsers when we don't seem to be doing anything with them.

I follow the code better than most, but the problem is I don't remember every little detail everywhere in the codebase.

And yes, of course I forgot how Wedge's codebase worked on occasion, so much of it changed over the three years that I would forget things a few weeks after they were written, especially if they got rewritten more than once.

The thing is, there is a surprising amount of difference in the details - the generalities are easy to remember, but the specifics - like what browsers are detected - is a little harder to remember

I don't know everything, nor do I claim to. I have said this on more than one occasion that SMF's code is simply too big for any one person to know every single detail about it, and yes, it's that I'm going to forget details.

On the other hand I do not appreciate the mispresentation that I'm SMF's lead developer (because I'm not) and the assertion that I might not be up to such a job because a piece of code I've never seen doesn't operate exactly how I was under the logical impression it might.

[Akyhne]

I didn't, actually. I said a full mobile environment is not going to happen, and that I didn't see us adding something to the core we weren't using...

... which is a bit sad as mobile/tablet themes or apps to popular online software is very asked for as well as being part of most other forum software.

[Arantor]

Which would you rather have, an update in the next six months or wait another year?

The more people add in, the more everyone has to wait for the release.

[vbgamer45]

Six Months faster updates better.

[Akyhne]

I can make a proper mobile theme in a week or two.