Post and PM Inline Attachments

[GL700Wing]

I am also getting this error from what I believe is the auto-rotate mod once I installed this mod...

Based on the line number in ./Subs-AutoRotation.php it looks like you're not using the latest version of the Automatic Attachment Rotation and (Resize) mod - if you get a chance would you please upgrade to v6.13 and let me know if the issue persists ...

[FrizzleFried]

Will try that now...

EDIT: Actually... gotta pick up dinner then we're watching a movie so it'll be later tonight when I can install and test...

I will report back.

[FrizzleFried]

Unfortunately I can report that with the 6.13 version of the Auto-Rotation mod installed I am still getting the error generated while this mod is installed AND I am not getting any of the images actually appearing in-line unfortunately.

[FrizzleFried]

Code Select Expand

Type of error: Undefined
Error messageSelect
8: Undefined index: thumb_mime
35

 Today at 07:33:48 PM
 FrizzleFried
 xxx
 992d2a039e0fa1c801da5b724d06182a
 https://www.NOFOLLOW.com/index.php?topic=4.16360
 /home/ahaforum/public_html/Sources/Subs-AutoRotation.php (Line 507)  Backtrace information


Backtrace:

#0: smf_error_handler()
Called from /home/ahaforum/public_html/Sources/Subs-AutoRotation.php on line 507
#1: AutoRotation_DisplayDownload()
Called from /home/ahaforum/public_html/Sources/Subs-Attachments.php on line 1281
#2: loadAttachmentContext()
Called from /home/ahaforum/public_html/Sources/Subs-InlineAttachments.php on line 334
#3: ILA_Post_Attachments()
Called from /home/ahaforum/public_html/Sources/Subs-InlineAttachments.php on line 166
#4: ILA_Setup()
Called from /home/ahaforum/public_html/Sources/Subs.php on line 2577
#5: parse_bbc()
Called from /home/ahaforum/public_html/Sources/Display.php on line 1533
#6: prepareDisplayContext()
Called from /home/ahaforum/public_html/Themes/default/Display.template.php on line 267
#7: template_main()
Called from /home/ahaforum/public_html/Sources/Load.php on line 2757
#8: loadSubTemplate()
Called from /home/ahaforum/public_html/Sources/Subs.php on line 4156
#9: obExit()
Called from /home/ahaforum/public_html/index.php on line 190


Different...

[FrizzleFried]

...and again,  when the ILA mod is uninstalled,  the errors go away it seems.

[GL700Wing]

...and again,  when the ILA mod is uninstalled,  the errors go away it seems.

Working on it ...

[GL700Wing]

Deleted v7.06 release as it was not playing nicely with the [attach] tag introduced in  SMF 2.1 when editing messages ...

Back to the drawing board ...

[GL700Wing]

Version v7.06 - April 27, 2022
o Added support for SMF 2.1 (NOTE:  SMF 2.1 will NOT be supported for inserting attachments inline by this mod):
  - Provide backward display and print page compatability for ILA BBCodes in existing posts of forums that used this mod prior to being upgraded from SMF 2.0; and
  - Add Print Page image layout/formatting the same as when this mod was installed on SMF 2.0.

o SMF 2.1: Important note for forums that used this mod with SMF 2.0
  - Unfortunately, and because a message may contain a mix of ILA BBCodes and native SMF 2.1 BBCodes for attachments that are inserted inline, it is not possible to remove an obsolete ILA BBCode (eg, [attach id=4 msg=5678]) from the body of a message when an attachment is deleted.
    Therefore, if an attachment that was inserted inline into a message by this mod is subsequently deleted the message must be saved and then edited again to remove the ILA BBCode that refers to the deleted attachment (eg, [attach id=4 msg=5678]) before more attachment are added to the message.
    If this procedure isn't followed the text "[ Invalid Attachment ]" may appear when the message is displayed/printed and/or if another attachment is added it will be displayed/printed in the message using the ILA BBCode (eg, [attach id=4 msg=5678]) that refers to the deleted attachment.

o Fixed bug introduced in v7.03 that prevented the (Insert Attachment N) link being displayed for second and subsequent attachments in PMs (only relevant if PM Attachments mod is installed).

o Fix for 'Undefined index: webm' error in ./Sources/Subs-InlineAttachments.php.

o Added support for 'SCEditor Integration for SMF 2.0.x' mod.


Note
For SMF 2.0 forums using versions 7.04 or 7.05 there are upgrade options to version 7.06 - it is not necessary to uninstall these versions (ie, 7.04 or 7.05) beforehand.

[FrizzleFried]

First...

The GOOD News... No errors that I am encountering.


The BAD News... Inline attachments are not happening... tags are still visible... images are still down bottom.



Do I have to run this operation to get things to work?

Should first attachment be numbered 1?
Important note if this mod has previously been installed on this forum:
Saving a change to this setting will cause inline attachment tags in all existing messages to be renumbered so you MUST put the forum into maintenance mode beforehand to ensure new inline attachments are not added to messages until after the renumbering process has finished!

FWIW I noticed that the first attachment on each post IS numbered 1...

EDIT: I also have to point out that this is on a forum that used to be 2.0.x running this mod and now runs 2.1.x... I can't test this particular mod in my sandbox because I have no old ILA tags on that system to test with...   

My current site is running 24 mods... some being other embed type mods.  There could be a conflict I assume.

[GL700Wing]

First...

The GOOD News... No errors that I am encountering.

The BAD News... Inline attachments are not happening... tags are still visible... images are still down bottom.

OK - I've just repeated the process of migrating a forum from SMF 2.0.19 to SMF 2.1.1 and I cannot reproduce the issue you reported ...
SMF 2.0.19 with ILA v7.06
You cannot view this attachment.

SMF 2.1.1 without ILA
You cannot view this attachment.

SMF 2.1.1 with ILA v7.06
You cannot view this attachment. 

Do I have to run this operation to get things to work?

Nope - nothing needs to be changed.

My current site is running 24 mods... some being other embed type mods.  There could be a conflict I assume.

If you let me know which other mods you're using I'll try and reproduce the issue and then work out if I can resolve it ...

[FrizzleFried]

Hello...

I am heading in to a short vacation for 3 days...   Will be back Saturday evening...

Here is a quick CUT/PASTE of the mods I am running.

1 Fix for Ignore boards function in 2.1.1
2 Stupid bouncy BBC 2.0
3 Quick Reply Attachments Button
4 Post and PM Inline Attachments
5 Alert Behaviours 1.0
6 Happy Birthday 0.4
7 FancyBox 4 SMF 1.1.1
8 Smart Pagination 1.2
9 Automatic Attachment Rotation (and Resize) 6.13
10 Forum Width Setting 1.2
11 Custom Greeting 3.0
12 Voter Visibility 2.1
13 SMF Arcade 2.6.7
14 Awesome Post Ratings 2.0.3
15 Users Online Today 2.1.1
16 Badge Awards2.6.2a
17 TinyPortal 2.2.1
18 Activity Bar 2.0.1
19 Arantor Sidebar 1.0.1
20 Avatars Display Integration 1.5.1
21 Curve2 Color Changer 1.4
22 Quick Spoiler 1.5
23 Link Previews 1.0.2
24 Similar Topics 1.2.1
25 SMFPacks Media Embedder 1.0.9
26 PM Attachments 2.12
27 Display Signatures Only Once Per Page 1.0.3

I suspect the culprits could be the Link Previews 1.0.2 mod or the SMF Packs Media Embedder...

But what do I know?

[GL700Wing]

I suspect the culprits could be the Link Previews 1.0.2 mod or the SMF Packs Media Embedder...

Not sure I can help - I'd have to buy a copy of both those mods in order to be able to test them ...

[GL700Wing]

I suspect the culprits could be the Link Previews 1.0.2 mod or the SMF Packs Media Embedder...

@live627 - wondering if I can get a copy of the Link Previews mod for troubleshooting the ILA issue @FrizzleFried is having.

@Nibogo - wondering if I can get a copy of the SMFPacks Auto Media Embedder mod for troubleshooting the ILA issue @FrizzleFried is having.

Note:  If you provide me with a copy of these mods I will only install them on my test site and use them for compatibility testing/troubleshooting purposes (they will not be installed on any of my production sites/forums).  Also, I will uninstall these mods once I have finished with them for troubleshooting this ILA issue.

[FrizzleFried]

Back from California's Great America amusement park and in pain (evidently 50 years old is too old for roller coasters)...

One thing I can do to trouble shoot is uninstall each mod individually on my site to see if the ILA's start working.  If I uninstall one and they start working... BOOM,  that's the problematic mod.

I'll start with the two paid mods above.

[FrizzleFried]

Unfortunately it is NEITHER of those two paid mods.   Both removed... same situation.  Images showing at bottom... tags showing in posts...



I guess I will have to go through each of them to try to determine which it is.

[FrizzleFried]

I did find these error in my log from yesterday...

Code Select Expand

CrazyKongFan
 172.58.140.70
 72ad4a1d63d57a3feebe1bd182a74911
 https://www.NOFOLLOW.com/index.php?action=profile;area=showposts;sa=attach;u=26;sort=posted;desc;start=15
 /home/ahaforum/public_html/Sources/Subs-InlineAttachments.php (Line 1267)  Backtrace information

Type of error: General
Error messageSelect
2: Invalid argument supplied for foreach()
22

 Yesterday at 06:35:15 AM
 CrazyKongFan
 172.58.140.70
 72ad4a1d63d57a3feebe1bd182a74911
 https://www.NOFOLLOW.com/index.php?action=profile;area=showposts;sa=attach;u=26;sort=posted;desc;start=15
 /home/ahaforum/public_html/Sources/Subs-InlineAttachments.php (Line 1267)  Backtrace information

Type of error: Undefined
Error messageSelect
8: Undefined index: attachment
Backtraces:

#0: smf_error_handler()
Called from /home/ahaforum/public_html/Sources/Subs-InlineAttachments.php on line 1267
#1: ILA_Below_Post_Show()
Called from /home/ahaforum/public_html/Sources/Subs.php on line 5768
#2: call_integration_hook()
Called from /home/ahaforum/public_html/Sources/Subs-List.php on line 40
#3: createList()
Called from /home/ahaforum/public_html/Sources/Profile-View.php on line 1331
#4: showAttachments()
Called from /home/ahaforum/public_html/Sources/Profile-View.php on line 870
#5: showPosts()
Called from /home/ahaforum/public_html/Sources/Profile.php on line 844
#6: ModifyProfile()
Called from /home/ahaforum/public_html/index.php on line 187

[GL700Wing]

I did find these error in my log from yesterday...

OK - that's a simple one and it seems to only occur in SMF 2.1 when attachments are being viewed via the member profile.

Simple fix which I'll add to the next release and which won't impact you ability to uninstall the mod if you need to.

In ./Sources/Subs-InlineAttachments.php
Find:

Code Select Expand

function ILA_Below_Post_Show(&$message)
{
    global $context, $modSettings, $scripturl, $settings, $sourcedir, $txt, $user_info;

Add After:

Code Select Expand


    if (empty($message['attachment']))
        return;

Unfortunately this doesn't explain why attachments aren't being displayed inline in posts though - will send you a PM ...

[Sebastiii]

Hello
I'm testing this Mod on a local copy of the forum and I can install it and try, but not when doing this on an online forum.
As soon as (it takes time to figure out the culprit) the file is copied in \Sources folder, the website goes to HTTP Error 500.

I have no clue why it happens, but for sure there is a cause.
Thanks.

[Sebastiii]

Hello again

Did I forget to past the name of the file, it seems so :

./Sources/Subs-InlineAttachments.php

Thanks.

As soon as (it takes time to figure out the culprit) the file is copied in \Sources folder, the website goes to HTTP Error 500.

[Sebastiii]

Installing version 6.2 on my test site results in HTTP ERROR 500

Hi,
Did you know/remember what happen for this error ?
Thanks.