SMF Media Gallery (SMG) - 2.0.5 is out! (December 2)

[leighlife]

Moving pictures fails with "Leave thumbnail URLs in clear view" set - line 2543 in MGallery-Sub.php is lacking a true value for the third parameter to getEncryptedFilename() for the source.  This line works ok:

Code Select Expand

                        $success = rename($mgalSettings['data_dir_path'].'/'.$item_data['thumb_dir'].'/'.getEncryptedFilename($item_data['thumb_file'], $item_data['id_thumb'], true), $new_dir.'/'.getEncryptedFilename($item_data['thumb_file'], $item_data['id_thumb'], true));


[Nao 尚]

Hmm yes indeed. Only, that's not at line 2543, rather around 160
Thanks! It was obviously due to how long the line was. I've just split it into several lines so that I can see clearer next time I have to change this

[LHW]

Getting these errors in the SMF error log when I run a check for orphan files in SMG maintenance:

8: unserialize(): Argument is not a string
File: /home/content/a/l/c/xxxxxxxxx/html/forum/Sources/MGallery-Admin.php
Line: 1751

8: Undefined index: orphans
File: /home/content/a/l/c/xxxxxxxxx/html/forum/Sources/MGallery-Admin.php
Line: 1751

For the record, it doesn't find any orphan files.

@blinker, no you shouldn't have to do that... Anyway, I don't see why your orphens variable is empty. What's in your smf_mgallery_settings table? Can you find the orphans variable in it?

If it helps, I get the same error as Blinker...well, just the second one...when I run the Maintenance Routine.  My orphans variable is set to a:0:{}.

EDIT: SMF: v1.1.10
SMG: v2b5 build 1050

[Nao 尚]

Lord, I fixed the problem (hopefully!) in a commit earlier today. Have a look at the latest rev since you're a beta tester now
However, as I said over at smf-media.com, I'll probably rewrite the task to be more efficient and less unstable.

[leighlife]

Hmm yes indeed. Only, that's not at line 2543, rather around 160

Doh!  Sorry about that, there's 2543 lines in the file and I copied the wrong thing .

[leighlife]

If an album thumbnail has been set from an item and later a new thumbnail is uploaded for that album
then the preview for that item is lost - record and file - and a 'no access' image is shown at the top of the album, presumably because the bigicon value for the album still holds the removed _mgallery_files record id.

Ouch.

[Nao 尚]

Okay if you're going to submit multiple bug reports, I would appreciate that you create an account at smf-media.com, I'll switch you to Beta tester and you'll be able to report bugs in the correct places, and download/try the latest revisions.

PS: I'm not sure I understand your report though... Please give an example

[leighlife]

OK, it was a bit brief, I wanted to try to repair it asap as well as leave a note here.  Here's a longer attempt:

• define an album icon by editing an item in the album, checking the Use this item's thumbnail as the album icon option and saving
• replace this icon with an uploaded thumbnail by editing the album itself
• select the album and observe the image at the top: I get an error image reading Sorry, you are not allowed to view this file. Make sure you are connected to the server.

Checking the database revealed that the bigicon value for the album was the id_file value for the preview item selected as album icon in step 1, and that both the smf_mgallery_files table row with that id and the corresponding file were gone.

[In addition, attempting to re-upload the broken item failed, perhaps due to the invalid preview row, so I restored it from a database backup.  Uploading the item then worked with the preview image recreated.]

Any better? 

I do have an account at smf-media - leighlife - so if you prefer me to report over there that's fine.

[Pinball Nation]

Hello im using smf 1.1.10 an i have the gallery mod by vgamer installed.Do i have to uninstall the gallery mod to install this one?I tried to install but got error messages

[SMGTeam]

@pinball> no. @leighlife> Please test with the new beta.

Version 2.0 beta 6                             September 22, 2009
-----------------------------------------------------------------

Miscellaneous additions/fixes:

* Renamed "hide album" option to "disable browsing" to prevent confusion and enable me to turn them into pseudo-categories in the future.
+ Giving admins the ability to mass upload in any user album, because, well... They're the boss after all.
+ Added mgal_has_preview flag to videos shown through the smg tag, so that they can also show
  their fullsize preview inside the player instead of a small thumbnail
! Don't use sesc as session var input when editing an item, if SMF version is 1.x
! Don't delete previews when forcing a new thumbnail, except where needed
! When deleting thumbnail files, don't bother running a SQL query if the parameter is an array filled with generic icons
! Fixed a typo that was there since v2.0 beta 1, where unapproved albums would still be returned by getAlbums() when they shouldn't
! Added a check for unbrowsable albums when calling getAlbums() and requiring to return children albums as well
! Thumbnails weren't being moved with the Move feature, because of the clean filenames feature
! Big icon wasn't correctly being removed from the database when removing the file it was based on.
  Instead of resetting the big icon entry, I chose to keep the preview instead.

Installer fixes:

! Database installer was using $permission (undefined) variable instead of $perm for SMF 1.x
! Latest SMF revision changed the way some database functions are handled, so I had to update the installer to try and fit all versions...

FFMpeg additions/fixes:

! Thumbnails created by FFMpeg will now have a JPG extension and be recognized as pictures rather than movies
! Don't create a FFMpeg object if we're showing an old-style FFMpeg-created thumbnail
+ Create a preview for newly uploaded videos if FFMpeg is installed
! Improved Regeneration task to enable regeneration of FFMpeg-created thumbnails and previews
! getInfo() could generate errors if called on audio files when FFMpeg is installed

Admin task additions/fixes:

! Fixed various places in admin where the session ID was put twice into the URL
! When regenerating previews after max preview size was increased, pictures that no longer needed a preview wouldn't delete the preview ID in the database
! smg_insert_file_id() function didn't save directory and album ID when updating an item (mostly in Regenerate task)
! Fixed Regenerate task to recreate thumbnails whenever possible if they were assigned to a generic icon
! Stupid Internet Explorer doesn't support meta refresh for URLs that have a semicolon in them,
  so SMG will now replace these with ampersands before asking IE to refresh to them
* Rewrote the Orphans task from scratch, to be more efficient and fix all bugs. It should now be able to run on huge galleries.
+ Added language strings needed by the Orphans task changes

! Plenty of minor fixes, as usual

[Akyhne]

Nice! And the regeneration of thumbs and previews works great. So if you got ffmpeg installed, you can now get previews from your videos!

[SAFAD]

Huge Project You Got There
Gratz

[Lolafish]

Those are 2 different mods, cannot upgrade you need to convert

Yes, sorry about the language.  I converted today, and it's running perfectly!  Woo hoo!!
I still don't know how to put the latest photos (like 5-9) from the gallery on my forum index. 

How would I do that?  What would/could I edit?

[Soms]

I still don't know how to put the latest photos (like 5-9) from the gallery on my forum index. 

How would I do that?  What would/could I edit?

Look here: http://www.simplemachines.org/community/index.php?topic=260821.msg2231492#msg2231492

and here: http://www.simplemachines.org/community/index.php?topic=260821.msg2232992#msg2232992

[Nao 尚]

@lolafish> there are plenty of samples over at smf-media.com

Nice! And the regeneration of thumbs and previews works great. So if you got ffmpeg installed, you can now get previews from your videos!

And thanks for your help in this matter. Without your server I'd never have been able to test my work in real life conditions

[jmil]

I was looking all over but kind find the changes from 1.5.4 (220 Pages - whewwww) (My current Version) to 1.5.6. Is there a log of changes so I can view them? Only reason I ask is that I may wait until Beta 2.0... is done.

Thanks all!

[jmil]

Found it!!

[Nao 尚]

All I can say is, I think 2.0b6 is much more stable than 1.5.6.
I stopped working on the 1.5.x branch long ago. Dragooon himself stopped working on it back in March or April. All of the bugs fixed since then were fixed in the 2.0 branch only.

BTW, it seems like Dragooon is back, at least today he fixed a few minor bugs in the admin permissions area. His first actual bug fixes since June, I think! Oh my, hopefully he'll stay around this time.

[jmil]

All I can say is, I think 2.0b6 is much more stable than 1.5.6.
I stopped working on the 1.5.x branch long ago. Dragooon himself stopped working on it back in March or April. All of the bugs fixed since then were fixed in the 2.0 branch only.

BTW, it seems like Dragooon is back, at least today he fixed a few minor bugs in the admin permissions area. His first actual bug fixes since June, I think! Oh my, hopefully he'll stay around this time.

So Not to put you on the Spot  - You feel the Beta is the better way to go Either way? 

[Nao 尚]

Yes, really.
I don't think I'll be adding new features anyway so it won't be long before it's out of beta. I'd say it'll be released in October or so. So if you want to wait, either way it's fine. Just make sure you update when 2.0 is out, whatever your current version.