Advertisement:

Author Topic: Odds and sods  (Read 6744 times)

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 73,189
Re: Odds and sods
« Reply #40 on: July 21, 2019, 05:09:04 AM »
Moderation security has nothing to do with admin security (it didn't in 2.0), but I'll try disabling it.

<sigh> Still wants admin password with both disabled.  Same thing on out-of-box and modded installs.


Just because it didn't in 2.0 doesn't mean it doesn't in 2.1 - in 2.1, both admin and moderation have separate security protocols (thus, separate putting in the passwords for both), and they both use the same code to do it.

When you say 'out of the box', out of the box *what*? RC1, RC2, a specific GitHub revision?
No good deed goes unpunished
All helpful urges should be circumvented

Offline Sir Osis of Liver

  • SMF Super Hero
  • *******
  • Posts: 10,967
  • We were all equal in the end.
Re: Odds and sods
« Reply #41 on: July 21, 2019, 04:11:12 PM »
RC2 github download from 7 July.

Just out of interest, was your Moderation Security enabled by default?F2.1/issues/5481

Yes it was.
“The best laid schemes o' mice an' men / Gang aft a-gley.” - Robert Burns

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 73,189
Re: Odds and sods
« Reply #42 on: July 21, 2019, 04:59:55 PM »
So there's still two different possible versions it could have been depending on *when* on 7th July you pulled it... when you download from GitHub you get a string of letters and numbers, this can be used to identify very specifically what version of 2.1 you have if you are not using an RC build.

Makes it much quicker for anyone to investigate what's going on...
No good deed goes unpunished
All helpful urges should be circumvented

Offline Sir Osis of Liver

  • SMF Super Hero
  • *******
  • Posts: 10,967
  • We were all equal in the end.
Re: Odds and sods
« Reply #43 on: July 21, 2019, 05:27:05 PM »
Ok, did clean install with today's github package, clean database.  Works like it should.  Where is the github id code?

Settings.php is different, all comments have been removed.  When/why was this done?


Just out of interest, was your Moderation Security enabled by default?F2.1/issues/5481

Default settings are admin security enabled, moderation security disabled.
“The best laid schemes o' mice an' men / Gang aft a-gley.” - Robert Burns

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 73,189
Re: Odds and sods
« Reply #44 on: July 21, 2019, 05:52:41 PM »
Hmm, I thought the filename contained the GitHub hash, because it does if downloading off a master branch (like everything I download off GitHub normally) but if you're on a non-master branch, you're a bit out of luck. However when you download it, you can see the identifier next to the download button - it's usually worth making a note of this. See attachment.

As for Settings.php, the master version - https://github.com/SimpleMachines/SMF2.1/blob/release-2.1/other/Settings.php - has comments, so either they're stripped by the upgrader or they're stripped by whatever you're doing to get the comments. Not sure whether you're copying the version from other/ into the root before installing a fresh install. If you're upgrading, you'll have whatever version you had before - which won't have the comments since 2.0's didn't have lots of comments.

This also assumes you're not using albertlast's nightly build, where things might be different again. (And this is why it's really useful to know exactly what build you're referring to because these things can change)

Quote
Default settings are admin security enabled, moderation security disabled.

This makes sense, the moderation security check didn't exist in 2.0.
No good deed goes unpunished
All helpful urges should be circumvented

Offline Sir Osis of Liver

  • SMF Super Hero
  • *******
  • Posts: 10,967
  • We were all equal in the end.
Re: Odds and sods
« Reply #45 on: July 21, 2019, 06:00:44 PM »
I see the last commit code now.  Often don't notice things like that unless I know to look for them (eyes are shot).  The stripped Settings.php was created from scratch by installer in current d/l (e0848c8).  I've always used the download button in your screenshot to get current package.
“The best laid schemes o' mice an' men / Gang aft a-gley.” - Robert Burns

Offline Illori

  • Lead Support Specialist
  • SMF Legend
  • *
  • Posts: 52,881
Re: Odds and sods
« Reply #46 on: July 21, 2019, 07:54:31 PM »
if you did not copy the Settings.php file over, it is possible the installer would create one for you which would be missing all the comments.

Offline Sir Osis of Liver

  • SMF Super Hero
  • *******
  • Posts: 10,967
  • We were all equal in the end.
Re: Odds and sods
« Reply #47 on: July 21, 2019, 11:46:13 PM »
It's a complete scratch install.  Earlier RC2 install created Settings.php with comments, as per earlier versions, current package creates stripped file.  Don't know if intentions are to stay with stripped file, but that would make things difficult for supporting new users.
“The best laid schemes o' mice an' men / Gang aft a-gley.” - Robert Burns

Offline shawnb61

  • Developer
  • SMF Hero
  • *
  • Posts: 3,136
    • sbulen on GitHub
Re: Odds and sods
« Reply #48 on: July 22, 2019, 12:09:22 AM »
Yes, if you do not provide the template, the upgrader will save a bare bones settings.php with no comments or logic - settings only.  It will do this on pure vanilla installs.
Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp

Online albertlast

  • Development Contributor
  • Full Member
  • *
  • Posts: 646
Re: Odds and sods
« Reply #49 on: July 22, 2019, 12:20:52 AM »
You will got a better live when you use the nightly download.

Offline Sir Osis of Liver

  • SMF Super Hero
  • *******
  • Posts: 10,967
  • We were all equal in the end.
Re: Odds and sods
« Reply #50 on: July 22, 2019, 12:39:26 AM »
Where is it?
“The best laid schemes o' mice an' men / Gang aft a-gley.” - Robert Burns

Online albertlast

  • Development Contributor
  • Full Member
  • *
  • Posts: 646

Offline Sir Osis of Liver

  • SMF Super Hero
  • *******
  • Posts: 10,967
  • We were all equal in the end.
Re: Odds and sods
« Reply #52 on: July 22, 2019, 12:59:16 AM »
Ok, thanks.
“The best laid schemes o' mice an' men / Gang aft a-gley.” - Robert Burns

Offline JeanCremers

  • Semi-Newbie
  • *
  • Posts: 15
Re: Odds and sods
« Reply #53 on: August 31, 2019, 07:08:24 AM »
hi, i have the member approval count bug. This is suggested as fix:

> You can fix it by switching back to Admin Approval, and then recounting the stats from the maintenance routine area

But i can't find a way to recount stats, where is that please?

Offline JeanCremers

  • Semi-Newbie
  • *
  • Posts: 15
Re: Odds and sods
« Reply #54 on: August 31, 2019, 11:35:45 AM »
never mind, found it, sorry.