Simple Machines Community Forum

Customizing SMF => Modifications and Packages => Topic started by: emanuele on January 15, 2011, 02:32:43 PM

Title: Tabbed smileys
Post by: emanuele on January 15, 2011, 02:32:43 PM
The mod distributed on this site may be outdated.
The latest version of this mod can always be found at the following address:
https://github.com/emanuele45/Tabbed-Smileys/releases


Link to Mod (http://custom.simplemachines.org/mods/index.php?mod=2782)

The mod adds a "tabbed interface" to the post form. The smileys are organized in "tabs": the first tab contains all the smileys configured to appear in the post form, the "additional tabs" are defined based on the number of rows of smileys present in the popup (one row = one tab). You can add new rows of smileys from the admin panel, in set smiley order.
With this mod it is possible to use all the available smileys without leave the posting browser window to reach the popup and keep low the number of smileys shown over the post form.

If you want to help, feel free!
The mod is now available at github:
https://github.com/emanuele45/Tabbed-Smileys
with a brand now BSD license attached to it! :P



NOTE: version 0.3.99b is a BETA version!
In this version I added the possibility to move (almost) all the elements of the posting interface into "tabs". It means that the formatting buttons, the attachments, the "other settings" are all moved on top of the post area each in a separated tab.
Once installed you will find a new drop down box in admin > Forum > Posts and Topics > Post Settings with 3 options:
Once selected the last option, a new checkbox will appear giving the possibility to chose to show the smileys' tabs in a separated row.
It should work, but I didn't test it that much, so feel free to use it, but be ready to face problems. ;)
That said: I wait your feedback: is it useful? Is it useless? Feel free to test it and report problems or suggestions to improve it!
The changes affect only SMF 2.0, I won't bring them to SMF 1.1.x.



Configuration
The number of tabs is defined by the number of rows of smileys in the popup: every row corresponds to a tab.
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimg253.imageshack.us%2Fimg253%2F9926%2Fnewrow.th.png&hash=7730678c87570507c74a9c58c1974276b7c608be) (http://img253.imageshack.us/i/newrow.png/)
Doing like in the picture will create a third tab: the "basic" (with all the smileys in the post form), the first line of the popup (the :'( in the picture) and the newly added.
It's possible to change the tab a smiley belongs to by changing the position both in "edit smileys" or in "set smiley order".
It's also possible to define a custom name for each tab and change the css style directly in the admin panel, section "set smiley order".

Change log
Title: Re: Tabbed smileys
Post by: kat on January 15, 2011, 02:42:54 PM
For anyone who's wondering, this is compatible with SMF versions 1.1.11, 1.1.12, 2.0 RC3 and 2.0 RC4.

:)
Title: Re: Tabbed smileys
Post by: Matthew K. on January 15, 2011, 02:47:08 PM
Nice work...looks good!
Title: Re: Tabbed smileys
Post by: emanuele on January 17, 2011, 12:21:36 PM
Thanks! :)

I'm now working on make it a little bit more flexible (i.e. give the possibility to decide in which tab a smiley should go).
Title: Re: Tabbed smileys
Post by: !RFAN on January 19, 2011, 08:17:26 PM
works fine
thumbs up
just one problem with custom theme

i  cant see tab titles.. any recommendations?

Title: Re: Tabbed smileys
Post by: emanuele on January 21, 2011, 10:59:47 AM
Yes...I used "hard-coded" text colour, you can edit "Subs.php" and search for this block:
<style type="text/css">
ul#tabs { overflow:auto;list-style-type: none; margin: 30px 0 0 0; padding: 1px 0 0 0; }
ul#tabs li { float:left;margin:0.3em 0.2em; }
ul#tabs li a { color: #000;border: 1px solid #ADADAD; border-bottom: none; padding: 0.3em; text-decoration: none; }
div.tabContent {border: 1px solid #ADADAD; width:95%; }
div.hide { display: none; }
</style>

there you can replace the (link) text colour by changing:

ul#tabs li a { color: #000;

In your case you can use for example a white:

ul#tabs li a { color: #FFF;

or anything else.
Title: Re: Tabbed smileys
Post by: Omebolle on January 21, 2011, 11:35:33 AM
downloaded and installed the mod and I get this...
Title: Re: Tabbed smileys
Post by: emanuele on January 21, 2011, 11:52:55 AM
Witch version of SMF are you using?

Did you get any error during the installation?
Title: Re: Tabbed smileys
Post by: impreza on January 21, 2011, 12:53:01 PM
Cool addition, I tested and it looks very good
Title: Re: Tabbed smileys
Post by: Omebolle on January 21, 2011, 01:12:40 PM
I use 2.0 RC4 and no errors during install, are there more settings I have to adjust in "Smileys and Message Icons" ?

Do I leave the smiley packs in the Smiley folder?
Title: Re: Tabbed smileys
Post by: emanuele on January 21, 2011, 04:22:32 PM
No, the only new (optional) setting is the one in Smileys and Message Icons -> settings (to define the number of tabs you want). (not true for version 0.3.0)

Yes, you don't need to touch any folders or any other settings.

Looking at the picture it seems you don't have any smiley in the popup (I don't see the "[more]" button), am I right?
That could explain why all the smileys are in only one "tab", but that doesn't explain why you don't see the pictures...
Title: Re: Tabbed smileys
Post by: !RFAN on January 22, 2011, 01:49:38 AM
thanks... now everything visible :)
Title: Re: Tabbed smileys
Post by: Omebolle on January 22, 2011, 08:34:00 AM
PM'd you Emanuelle, never had the "More" button even-though I had more than one Smileypack installed :o

I found this in my logs: /customers/XXXXXX/Themes/babylon/Display.template.php (main sub template - eval?)
Title: Re: Tabbed smileys
Post by: Omebolle on January 22, 2011, 01:44:23 PM
Thanks emanuele... :-*
Title: Re: Tabbed smileys
Post by: emanuele on January 26, 2011, 05:18:47 AM
Quote from: kaung on January 25, 2011, 05:18:55 PM
I apologize for directly PMing regarding this.
I apologize for putting the PM in the support thread, but it could be useful to others as well.

Quote from: kaung on January 25, 2011, 05:18:55 PM
I read in the support thread about the Tabbed Smiley that
QuoteNo, the only new (optional) setting is the one in Smileys and Message Icons -> settings (to define the number of tabs you want).

I am not seeing anything in settings nor other Smiley and Message Icons tabs to choose how many tabs I want.
I am using RC4 default theme.
You are right, in fact about 24 hours after I wrote this sentence I completely changed the way the tabs are managed...

Quote from: kaung on January 25, 2011, 05:18:55 PM
Post form tab and only 1 additional tab is showing under edit smileys, as well.
No options to add new rows.
If you go in "set smiley order", you can select a smiley and than you can move it to a new row, see:
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimg253.imageshack.us%2Fimg253%2F9926%2Fnewrow.th.png&hash=7730678c87570507c74a9c58c1974276b7c608be) (http://img253.imageshack.us/i/newrow.png/)
and you can continue for the third, fourth and so on row.
Title: Re: Tabbed smileys
Post by: kaung on January 27, 2011, 12:27:22 AM
Thank you very much! :)
Title: Re: Tabbed smileys
Post by: haroldpl on February 03, 2011, 01:46:07 PM
I am using 1.1.12 and just installed the mod. It seems to have all gone right, no errors etc.

But it only gives me an option for 1 tab other than the basic. I have over 200 smilies and wanted to divide them among 5 tabs.

What have I done wrong or need to change to get it to work right??

Thanks
Title: Re: Tabbed smileys
Post by: Omebolle on February 03, 2011, 06:08:37 PM
maybe you can change the settings here? 
the only new (optional) setting is the one in Smileys and Message Icons -> settings (to define the number of tabs you want).
Title: Re: Tabbed smileys
Post by: haroldpl on February 04, 2011, 10:01:51 AM
Quote from: Omebolle on February 03, 2011, 06:08:37 PM
maybe you can change the settings here? 
the only new (optional) setting is the one in Smileys and Message Icons -> settings (to define the number of tabs you want).

Already tried that and it only has option for a single extra tab along with the default. It might work that way in 2.0 but not in 1.1.12, it looks like an excellent mod just not all the options in 1.1.12. Unless I am a total moron with this one. I have uninstalled it till we can figure it out.

Thanks
Title: Re: Tabbed smileys
Post by: emanuele on February 05, 2011, 08:02:48 AM
Please have a look at my previous message (http://www.simplemachines.org/community/index.php?topic=417533.msg2928446#msg2928446), not the one you were looking at, but the one right after). ;)

I'll update the description as well.
Title: Re: Tabbed smileys
Post by: henrik1782 on February 06, 2011, 05:57:25 PM
Hi...

Installed the mod without errors but I can find the setting for the mod in admin panel...

For SmartCat...  I am running SMF 2.0 RC4  ;)

Best regards
Henrik Poulsen
Title: Re: Tabbed smileys
Post by: emanuele on February 07, 2011, 09:54:35 AM
First you have to create new rows of smiley in the popup: if you go in "set smiley order", you can select a smiley and than you can move it to a new row, see:
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimg253.imageshack.us%2Fimg253%2F9926%2Fnewrow.th.png&hash=7730678c87570507c74a9c58c1974276b7c608be) (http://img253.imageshack.us/i/newrow.png/)
and you can continue for the third, fourth and so on row.

Each row corresponds to a new tab, then you'll be able to move more smileys at the same time through the edit smiley page (checking the smiley you want to move and select where you want to move them from the drop-down box at the end of the page.
Title: Re: Tabbed smileys
Post by: henrik1782 on February 07, 2011, 10:46:53 AM
Hi emanuele...

Sorry for not being specific. I can not find the "set smiley order" and what pop-up.

Title: Re: Tabbed smileys
Post by: emanuele on February 07, 2011, 01:49:52 PM
Then most likely you don't really need this modification at all... :P ;)
If you don't see the "set smiley order" it means you are not using customized smileys and then the modification is completely useless. ;)
Title: Re: Tabbed smileys
Post by: drhamza on February 15, 2011, 07:49:05 PM
now this is a beautiful mod, thank you very much man
Title: Re: Tabbed smileys
Post by: Dumpy on February 16, 2011, 09:39:29 AM
Fantastic mod - does exactly what it says and the smileys are far better organised; thank you for making life easier for everyone using lots of smileys.

One very quick question - how do you change the color of the tabs?  I've tried adding a background color to each of the css elements but it doesn't do what is expected lol; could just be me being thick lol
Title: Re: Tabbed smileys
Post by: emanuele on February 16, 2011, 06:13:48 PM
Glad you like it! :)

Quote from: Dumpy on February 16, 2011, 09:39:29 AM
One very quick question - how do you change the color of the tabs?  I've tried adding a background color to each of the css elements but it doesn't do what is expected lol; could just be me being thick lol
If you mean the place where you click when you want to select a different tab I'm not sure if it is possible at all...I'm not very familiar with css, I tried a bit but I didn't get any result...sorry.

Instead, if you mean the place where the smiley are then you can use the IDs of each "tab" that are in the form tabX_elem where "X" is a number starting from 0 for the "basic smile" tab.
Title: Re: Tabbed smileys
Post by: Dumpy on February 17, 2011, 05:01:06 AM
Thanks emanuele - it was the tabs themselves that I was wanting to change the colour of.  I'll have a play around with the css and code and see if I can do it.  If I can I'll come back here and post.  Fantastic mod though, really helpful  ;D
Title: Re: Tabbed smileys
Post by: emanuele on February 18, 2011, 04:54:14 AM
I tried this one and seems to work.
It depends on your version of SMF, but for 1.1.x you can do:
1) in post.template.php
a) search for class="titlebg selected" and replace it with class="selected"
b) search for class="catbg unselected" and replace it iwht class="unselected"
2) then, in subs.php
a) search for \'titlebg selected\'; and replace it with \'selected\';
b) search for \'catbg unselected\' and replace it with \'unselected\'

Now you can use the css classes "selected" and "unselected" to (hopefully) fully control the appearance of your tabs! ;D

It should be almost the same with SMF 2, except that you have to search in genericontrols.template.php instead of post.template.php.
Title: Re: Tabbed smileys
Post by: Dumpy on February 18, 2011, 05:40:13 AM
Absolutely fantastic emanuele - it worked a charm.  For anyone not sure what to put in the css section just add this;

.selected {
background-color: #3FF;
}
.unselected {
background-color: #FFFF00;
}


I also added this under the ul#tabs li a section to make the text stand out more.

                font-weight: bold;

Excellent work my friend - I  modified this on RC5 so it works brilliant.
Title: Re: Tabbed smileys
Post by: Rifugio on February 21, 2011, 09:35:24 AM
I'm having a small problem with a large number of smileys using this mod.  I can see when I open a reply form that ALL of the smileys are being loaded.  Not just the Main ones but all the pop up ones from the tabs as well.

This makes opening the tabs fast when they 400+ icons have loaded but each time I open a new reply box it downloads all 400+ icons again.

Is it possible to set the mod load the additional icons when people actually click on the tabs. 

I also appear to have two [more] boxes being displayed.  One just under the post form smiles within the box and the other under the pop-up smileys.  I am wondering if this could be causing the load issue.
Title: Re: Tabbed smileys
Post by: emanuele on February 22, 2011, 04:38:35 PM
Quote from: Rifugio on February 21, 2011, 09:35:24 AM
Is it possible to set the mod load the additional icons when people actually click on the tabs. 
Try the new version (0.3.2) it should do what you asked. ;)

Quote from: Rifugio on February 21, 2011, 09:35:24 AM
I also appear to have two [more] boxes being displayed.  One just under the post form smiles within the box and the other under the pop-up smileys.  I am wondering if this could be causing the load issue.
Which versione of SMF?
On SMF 1.1.x it should not even touch the more button, while on SMF 2 it should not work if the more button appear twice...I think...
Title: Re: Tabbed smileys
Post by: Rifugio on February 23, 2011, 05:43:19 AM
Wow that was a very fast response.  The new version is updating a lot better thank you.  :D
I'm using SMF 2.0 RC5. 
Attached screen shot shows the double [more]'s which only appears on the first TAB the Extras tab displays correctly.
Title: Re: Tabbed smileys
Post by: emanuele on February 23, 2011, 08:03:24 AM
Also with the new version?
Ok, this is a bug, I'll check! (javascript is my enemy >:( )

The only problem is that I cannot reproduce the problem...
Can you post your GenericControls.template.php so I can have a look?
Title: Re: Tabbed smileys
Post by: Rifugio on February 23, 2011, 01:48:55 PM
Sure, please find attached. 
The icon load only when tab is opened works well from what testing I have done.  Very noticeable on slower connections.

UPDATE
Just realised extra [more] does not appear in FireFox only in IE.  FireFox looks fine
Title: Re: Tabbed smileys
Post by: emanuele on February 24, 2011, 03:19:15 PM
Thanks for the finding! :D
Fixed.

In the future I'll try to remember that IE still exists. :P
Title: Re: Tabbed smileys
Post by: Rifugio on February 25, 2011, 09:54:00 AM
Excellent work - that's got it :)  Thank you for putting this togther.
Title: Re: Tabbed smileys
Post by: RAULVK on February 25, 2011, 05:59:42 PM
Hi, sorry for my English is very bad.

I installed the version 0.3.3 and since then tags from the second does not work the smileys, do not appears the pointer of mouse, and can not be added to post the smiley. Only work, tab 1 and 2.
Title: Re: Tabbed smileys
Post by: emanuele on February 26, 2011, 07:49:12 AM
You are right... :(

I'll upload again the previous version, and I'll start study javascript to find a proper way to solve the issue.

I apologize. :-[
Title: Re: Tabbed smileys
Post by: RAULVK on February 26, 2011, 10:38:42 AM
do not worry, you're doing well is a great mod  ;)
Title: Re: Tabbed smileys
Post by: PZSHOSTING on February 26, 2011, 02:02:19 PM
Great mod! But in my situation, I need to keep the "on demand" loading of the smileys. I have too many smileys to have them all load at once. It causes the Internet Explorer to blink if they all load at once. Which is not the mod's fault. It's my members fault. They are smiley fanatics. So, I can't upgrade to 3.4 if it removes the "on demand" feature.

Thank you for this mod!
Title: Re: Tabbed smileys
Post by: emanuele on February 26, 2011, 03:11:56 PM
Please note that if you keep 0.3.3 you will be able to use only the smiley in the first two tabs (if you are with SMF 2). Of course if you are using only two tabs is ok. ;)
Title: Re: Tabbed smileys
Post by: PZSHOSTING on February 26, 2011, 03:21:31 PM
Hmmm... I must be doing something wrong because I'm using 3.3 with 7 tabs so far :o
Title: Re: Tabbed smileys
Post by: emanuele on February 26, 2011, 05:16:59 PM
Please try 0.3.5 it should work now. :)
Title: Re: Tabbed smileys
Post by: becometa on February 26, 2011, 05:27:47 PM
Do you accept additional translations?
Below is polish ;)

Modifications.polish-utf8.php

//Begin tabbed smileys
$txt['additional_smileys'] = 'Dodatkowe emotikony';
$txt['basic_smileys'] = 'Podstawowe emotikony';
$txt['smiley_number_of_tabs'] = 'Ilość kart przeznaczonych na dodatkowe emotikony';
$txt['smiley_number_of_tabs_note'] = 'Wpisz 0 bądź pozostaw pole puste, aby skrypt automatycznie przystosowywał liczbę kart do liczby emotikon';
$txt['tabbed_smileys_tabsnames'] = 'Wygląd i nazwy kart';
$txt['tabbed_smileys_tabsnames_description'] = 'Tutaj zdefiniujesz wygląd i nazwy kart przeznaczonych na dodatkowe emotikony, wyświetlanych podczas pisania nowej wiadomości';
$txt['tabbed_smileys_row'] = 'rząd';
$txt['tabbed_smileys_tab'] = 'karta';
$txt['tabbed_smileys_style'] = 'Wygląd kart';
$txt['hide_more_smiley'] = 'Ukryj przycisk "więcej"';
//End tabbed smileys
Title: Re: Tabbed smileys
Post by: Arantor on February 26, 2011, 05:30:55 PM
Btw, as it stands right now, the changes to Modifications.english_british.php would be identical to Modifications.english.php - another language you can add :)

You probably should also add UTF-8 versions if possible.
Title: Re: Tabbed smileys
Post by: PZSHOSTING on February 26, 2011, 05:34:35 PM
I'm waiting for some comments from my members, but it looks even better when I tested it Than 3.3. Keeping my fingers crossed. And thank you again for your extra effort! This is a major mod for my Forum. We can't seem to express ourself in words alone. We're lost without tons of smileys ;)  And this mod makes the difference. Thanks!
Title: Re: Tabbed smileys
Post by: emanuele on February 27, 2011, 03:31:05 AM
Quote from: becometa on February 26, 2011, 05:27:47 PM
Did you agree additional translations?
Yes of course! :D

Quote from: becometa on February 26, 2011, 05:27:47 PM
If yes, I threw below polish ;)
I'll add it together with english-british and all related UTF8 as suggested by Arantor. :)

Quote from: PZSHOSTING on February 26, 2011, 05:34:35 PM
I'm waiting for some comments from my members, but it looks even better when I tested it Than 3.3.
Perfect!
Let me know if you encounter any problem! (and also if you don't so I can remove 0.3.4 from the downloads)
What I did is simply create all the html without images and then add the images only when needed...if I'm lucky I didn't broke anything else... :-[
Title: Re: Tabbed smileys
Post by: TTCDebs on March 03, 2011, 04:29:23 PM
One of the best modifications going, I am smiley mad, as is one of my admin, and this is an absolute blessing, thumbs up for this modification  8)
Title: Re: Tabbed smileys
Post by: PZSHOSTING on March 03, 2011, 05:58:40 PM
My members are pleased :)
Title: Re: Tabbed smileys
Post by: BaghdadGhost on March 04, 2011, 05:45:28 AM
Quote from: henrik1782 on February 06, 2011, 05:57:25 PM
Hi...

Installed the mod without errors but I can find the setting for the mod in admin panel...

For SmartCat...  I am running SMF 2.0 RC4  ;)

Best regards
Henrik Poulsen

same exact problem here. I read your answers and no help. How to use the customized smiley ???

 
Title: Re: Tabbed smileys
Post by: emanuele on March 05, 2011, 03:27:22 PM
Please note that this isn't a smiley set (just be sure we are talking about the same thing ;)).
If you are looking for how to enable customized smiley, mayby this could help (http://docs.simplemachines.org/index.php?board=58.0).
Title: Re: Tabbed smileys
Post by: BaghdadGhost on March 05, 2011, 03:32:59 PM
Could you please explain how to make it work. I understand it is not a smiley set. It is a modification. in both cases when you install something in your forum you should see some changes somewhere !!!!



thanks in advance
Title: Re: Tabbed smileys
Post by: emanuele on March 05, 2011, 03:56:50 PM
Sorry if I misunderstood.

In order to see the changes you first have to enable enable customized smiley (you can find all the details in the documentation (http://docs.simplemachines.org/index.php?board=58.0), you can start from Settings (http://docs.simplemachines.org/index.php?topic=283) ;)) and then go to in "set smiley order" and "edit smiles" to create tabs and move the smiley to the different tabs.
Title: Re: Tabbed smileys
Post by: BaghdadGhost on March 05, 2011, 04:53:29 PM
thanks, I will try that.

appreciate your patience with me  :)
Title: Re: Tabbed smileys
Post by: abraamz on March 06, 2011, 09:23:24 AM
usefull mod!
I installed it with no errors and it works fine in default theme but not in a custom theme i use. i tryied to add stuff manually but my theme doesnt have a custom file named GenericControls.template.php or ManageSmileys.template.php
Any suggestions?
Title: Re: Tabbed smileys
Post by: Arantor on March 06, 2011, 09:24:35 AM
If your theme doesn't have those files, it will use the default theme's. The issue suggests your theme doesn't play nicely with Javascript.
Title: Re: Tabbed smileys
Post by: BaghdadGhost on March 06, 2011, 09:29:57 AM
thanks emanuele for the support. I got it working. I just wanna highlight something. I use Arabic-utf8 as the default language for my forum. when I started to upload the smileys everything was fine until I reached a point where the content of the topics, posts, news and PM disappeared. the count was still wright but no words.


after five hours of searching and changing things the solution was to delete some of the smileys that I uploaded.


thanks again 
Title: Re: Tabbed smileys
Post by: emanuele on March 06, 2011, 09:35:23 AM
Quote from: abraamz on March 06, 2011, 09:23:24 AM
I installed it with no errors and it works fine in default theme but not in a custom theme i use. i tryied to add stuff manually but my theme doesnt have a custom file named GenericControls.template.php or ManageSmileys.template.php
Any suggestions?
Is the theme available somewhere or is a theme you made by yourself?

I think (since I don't like javascript and I don't know this language very well I cannot be sure) that if the "normal" smiley work in your theme also that modification should work properly.

If possible can you provide me a link and maybe an account to your forum so I can have a look? (send me a PM)
Title: Re: Tabbed smileys
Post by: emanuele on March 06, 2011, 09:37:07 AM
Quote from: BaghdadGhost on March 06, 2011, 09:29:57 AM
after five hours of searching and changing things the solution was to delete some of the smileys that I uploaded.
Are you using SMF 1 or 2?
Do you remember the codes you assigned to that smiley? (and maybe the filenames?)
Title: Re: Tabbed smileys
Post by: abraamz on March 06, 2011, 09:47:26 AM
Thanks Arantor for the hint. Actually the theme is impulse2 by Bloc. It uses mootools for the menus as far as i know.
Maybe impulse2 has its own way to show smileys with javascript. 
*update*
With a search in impulse2 theme directory searcing for "smiley" i found 3 images, and files scripts/editor.js and index.css
File script/editor.js is the same with the one in default theme
could this be  a css problem?
Title: Re: Tabbed smileys
Post by: Arantor on March 06, 2011, 09:50:05 AM
No... SMF does the showing of smileys, specifically its own code that doesn't have any external dependencies. This mod doesn't have any external dependencies but something in the Javascript is causing it to be disliked, somewhere between the JS in Mootools and this mod and your browser.
Title: Re: Tabbed smileys
Post by: abraamz on March 06, 2011, 12:29:32 PM
when i checked "do not use mootools" menu option for impulse2 the mod works almost fine. (everything is ok but instead of 4 tabs only the current tab title is visible)
Posted a message to Bloc's theme site. Maybe someone there can troubleshoot this.
screenshot1: impulse2 at first
screenshot2: impulse2 after click to a tab
screenshot1: impulse2 mootools menu disabled looks almost fine!
Title: Re: Tabbed smileys
Post by: 72 454 on March 06, 2011, 03:18:29 PM
SMF 2.0 RC5 here. Using your 0.3.5. Changed to default theme, did everything U said, and still cannot find any way to add a new tab. Ugh. I'll just check back for a newer version in a couple of months. Great idea though!
Title: Re: Tabbed smileys
Post by: BaghdadGhost on March 06, 2011, 08:38:22 PM
Quote from: emanuele on March 06, 2011, 09:37:07 AM
Quote from: BaghdadGhost on March 06, 2011, 09:29:57 AM
after five hours of searching and changing things the solution was to delete some of the smileys that I uploaded.
Are you using SMF 1 or 2?
Do you remember the codes you assigned to that smiley? (and maybe the filenames?)

SMF2 RC4 updated

I renamed the smileys to emotions, names, separators .... etc and the codes where assigned automatically like Emotion (1) file would get :emotion (1):

Title: Re: Tabbed smileys
Post by: BaghdadGhost on March 16, 2011, 03:13:28 AM
am I the only one with a problem viewing the added smileys and the BB codes with ie ???? like attached


I think its a script issue as someone earlier mentioned??!
Title: Re: Tabbed smileys
Post by: Welovea1 on March 27, 2011, 11:43:19 AM
We just tried out this mod in our test forum and it's working perfectly.  We intend to install it in our real forum in the next few days and know our members will love using it.  One thing that would make it even better is if it could be incorporated into our SMFPacks Shoutbox, so that when a user clicks on "more" they'd see the tabs rather than all of the popups.  Is this something that could be considered for the future?   Thanks for all the work you've put into development of this excellent mod.

Welovea1
Title: Re: Tabbed smileys
Post by: emanuele on April 03, 2011, 04:55:08 PM
Sorry if I didn't reply before...probably I missed the notification of new posts... :-[

Quote from: BaghdadGhost on March 16, 2011, 03:13:28 AM
am I the only one with a problem viewing the added smileys and the BB codes with ie ???? like attached


I think its a script issue as someone earlier mentioned??!
It was an issue, but with the configuration of the smileys in the board (the other one, don't know in your case). I've to admit I don't remember exactly what the problem was...

Quote from: ncvettes on March 06, 2011, 03:18:29 PM
SMF 2.0 RC5 here. Using your 0.3.5. Changed to default theme, did everything U said, and still cannot find any way to add a new tab. Ugh. I'll just check back for a newer version in a couple of months. Great idea though!
No idea what the problem could be unless you didn't enabled the custom smileys...sorry.
Indeed the method used to create new tabs is a bit "ugly"...I've to think about something new...

Quote from: Welovea1 on March 27, 2011, 11:43:19 AM
One thing that would make it even better is if it could be incorporated into our SMFPacks Shoutbox, so that when a user clicks on "more" they'd see the tabs rather than all of the popups.  Is this something that could be considered for the future?
I already received few requests for chats, I'll try to have a look, but no idea if I can do something...
Title: Re: Tabbed smileys
Post by: mgrmgr on April 04, 2011, 02:45:06 PM
Thank you for this modification, works like a charm both on our 1.1.13 production forum as well as on our 2.0 (RC3 :( ) test forum.

I just ran into a little problem:

When setting the smiley oder it is problematic to set the order after you have already several rows and have to sort other smileys in (thematic ordered) existing rows. I guess a simple line break at the end of a smiley-row is not really enough to find out if the new position is in the correct row (unless you print out the smiley form and mark the single rows manually.

Is it possible to keep the single rows in that form a bit better separated (for example a hrule between the single rows) ? That would reduce my work considerably especially since I have to upload more than 200 smileys into the (up to now 7 - no idea how many will finally exist) rows.

BTW: I use mod 0.3.5 on SMF 1.1.3 as well as on SMF 2.0 RC3 (going to upgrade to RC5 soon).
Title: Re: Tabbed smileys
Post by: emanuele on April 04, 2011, 03:26:38 PM
Yes, I think I understand...even if I try to limit as much as possible template changes, here I already modifed a lot this page, so it would be not so dramatic another small change...I'll put it in the next version (that will be ready soon).

BTW did you try the "edit smiley" page? There you can tick the check box next to each smiley you want to move in a defined tab and then use the dropdown box at the end of the page to change the position of all the selected smileys.
This way should be much easier than move the smileys one by one. ;)
Title: Re: Tabbed smileys
Post by: mgrmgr on April 04, 2011, 05:45:14 PM
Thanks so much :)

As to your BTW: :blush: :ashamed: I didn't find this one up to your remark - sorry. It's working well, better than I assumed. I found (on the edit page) the description (Popup ... ) but that is not a link. I probably overlooked the drop down box because I have to scroll horizontally to see also the right border of that page (1024 x 768 px seems to small for that form :( )
Title: Re: Tabbed smileys
Post by: Yngwiedis on April 10, 2011, 02:58:54 AM
Hello...

I have one question...

Is there any way to change the order of the tabs ?

Thank you.
Title: Re: Tabbed smileys
Post by: emanuele on April 10, 2011, 04:59:34 AM
Quote from: Yngwiedis on April 10, 2011, 02:58:54 AM
Is there any way to change the order of the tabs ?
The only one I'm aware of right now is changing the order of all the smileys and renaming the tabs...but maybe in the next few days... :P
Title: Re: Tabbed smileys
Post by: Yngwiedis on April 10, 2011, 05:16:12 AM
I will wait for the next version then :)

Thank you.
Title: Re: Tabbed smileys
Post by: 72 454 on April 10, 2011, 11:39:47 AM
It's working. Tnx!
Title: Re: Tabbed smileys
Post by: Inti31 on April 14, 2011, 03:19:18 PM
It works fine - but there is one thing...
How do I remove the tags are shown under the smiley bar? I don't like them...

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.picture-reflex.de%2F%3Fimg%3D31302808539.jpg&hash=a23a8e9470b72f3513b4f6b07e83430d0a378d93)

My forum is RC5 with 30 mods integrated

It's a car forum for Chevy Epica: hxxp://epica-forum.de/

cheers, Inti31
Title: Re: Tabbed smileys
Post by: emanuele on April 14, 2011, 03:30:28 PM
Are those smileys that should go in the other tabs?
Title: Re: Tabbed smileys
Post by: Inti31 on April 17, 2011, 06:43:28 AM
Quote from: emanuele on April 14, 2011, 03:30:28 PM
Are those smileys that should go in the other tabs?
???
I've 4 tabs named Standard, Extra, Signs, Extra-Signs
hxxp://s3.postimage.org/qxkqq7no/SM_Standard.jpg
hxxp://s3.postimage.org/qxfs466c/SM_Extra.jpg
hxxp://s3.postimage.org/qxj36v5w/SM_Schilder.jpg
hxxp://s3.postimage.org/qxhfnio4/SM_Extra_Schilder.jpg

So to create a new tab you've to go to Administrate-forum-smileys- reorder smileys
That is how it works...
hxxp://s3.postimage.org/qxati4p0/SM_Administrate.jpg

to create a new tab, mark now one smiley and then click the last icon as shown in that screenshot.
hxxp://s3.postimage.org/qxe4ktok/SM_Change_create_new_tab.jpg

Greets inti31
Title: Re: Tabbed smileys
Post by: miDnIghtEr20C on May 23, 2011, 08:13:23 PM
everything on my site went great... i'm on 1.1.13... except for i have no idea how to get those damn smileys to change.    every time i go to the edit smileys... i want to put one group of smileys  in each tab.     but when i change the smileys.... it's always my default smileys that are moving from tab to tab.   not my other 4 groups of smileys i have.         i don't know what i'm doing wrong.   i bet it's something right in front of my face.

thanks for the help.

btw... we are giving away a free xbox kinect, and 2 kinect games on my site. 

http://showtimeforfree.com/index.php?topic=3956.0

again, thanks for the help... i don't know what the hell i'm doing wrong.
Title: Re: Tabbed smileys
Post by: emanuele on May 24, 2011, 02:52:37 AM
Probably you have 4 smiley sets. If it is the case you cannot show all of them at the same time, only one set at a time is allowed by SMF.
Title: Re: Tabbed smileys
Post by: miDnIghtEr20C on May 24, 2011, 08:20:33 PM
Quote from: emanuele on May 24, 2011, 02:52:37 AM
Probably you have 4 smiley sets. If it is the case you cannot show all of them at the same time, only one set at a time is allowed by SMF.
ahhhh.. so then the mod really won't work for me?     well, i guess i can use the option to let others change to whatever smileys they want to see/use.  :)
Title: Re: Tabbed smileys
Post by: akbora on June 26, 2011, 01:01:31 PM
I have only two tabs, how can I add more tabs?
Title: Re: Tabbed smileys
Post by: emanuele on June 26, 2011, 02:34:26 PM
I've updated the description with more details, basically go to edit smileys page (in the admin panel) and create a new row in the popup. ;)
Title: Re: Tabbed smileys
Post by: akbora on June 26, 2011, 05:57:41 PM
Quote from: emanuele on January 21, 2011, 10:59:47 AM
Yes...I used "hard-coded" text colour, you can edit "Subs.php" and search for this block:
<style type="text/css">
ul#tabs { overflow:auto;list-style-type: none; margin: 30px 0 0 0; padding: 1px 0 0 0; }
ul#tabs li { float:left;margin:0.3em 0.2em; }
ul#tabs li a { color: #000;border: 1px solid #ADADAD; border-bottom: none; padding: 0.3em; text-decoration: none; }
div.tabContent {border: 1px solid #ADADAD; width:95%; }
div.hide { display: none; }
</style>

there you can replace the (link) text colour by changing:

ul#tabs li a { color: #000;

In your case you can use for example a white:

ul#tabs li a { color: #FFF;

or anything else.
Thanks emanuele, I've created new rows.. But I can not change rows' and text color this way you told. How can I do?
Title: Re: Tabbed smileys
Post by: emanuele on June 27, 2011, 06:04:43 PM
In the same page you used to add the new tab there is a box where you can put the css needed to change tabs' color and aspect. ;)
Title: Re: Tabbed smileys
Post by: watchhorse on July 20, 2011, 12:05:02 PM
errorlog:

8: Undefined index: basic_smileys
Bestand:***Themes/default/GenericControls.template.php
Regel: 140

8: Undefined index: additional_smileys
Bestand:***/Themes/default/GenericControls.template.php
Regel: 142


The line is:


135:          function tab_name(idx){
136:          if(tab_names.length>idx && tab_names[idx] != \'\'){
137:          return tab_names[idx];
138:            }else{
139:          if(idx == 0){
==>140: return \'' . $txt['basic_smileys'] . '\';
141:         } else {
142:         return \'' . $txt['additional_smileys'] . ' \' + idx;
143:         }
144:          }


Is this a problem?
Title: Re: Tabbed smileys
Post by: emanuele on July 20, 2011, 12:47:54 PM
Version of SMF?

If it is 1.1.x it could be you need to put the translation in Modification.{yourlanguage}.php

Silly me...of course it's 2.0.

I'll check.

ETA: I can't see anything wrong in the code, please check if you have the two strings:
$txt['basic_smileys']
$txt['additional_smileys']

in you Modifications.english.php and in your language file.
Title: Re: Tabbed smileys
Post by: watchhorse on July 20, 2011, 02:42:36 PM
Quote from: emanuele on July 20, 2011, 12:47:54 PM
please check if you have the two strings:
$txt['basic_smileys']
$txt['additional_smileys']

in you Modifications.english.php and in your language file.

Stupid me ... i forgot my own language file.
Thanks
Title: Re: Tabbed smileys
Post by: emanuele on July 20, 2011, 02:58:54 PM
If they are in the English one it should not be a problem with SMF 2, but if there are these two errors maybe they are missing in English as well. Better check that too! ;)
Title: Re: Tabbed smileys
Post by: Sergioropase on July 21, 2011, 06:07:24 AM
hello and thank you for this wonderful mod author Emanuele, well the mod is installed correctly in the default theme, make appropriate modifications to the theme I use, but I can not display the tab with additional smilies, either in the default theme or my subject, I get the options, I get as renaming the tabs and I get the arrow that is supposed to be where I have to pass the smilies, smilies step, I get a new category, the move to this new category but I can not see the tabs, even when I look in the post, where I pop up appear below .... not that I am wrong ...

Pardon my English but use a translator
Title: Re: Tabbed smileys
Post by: emanuele on July 21, 2011, 08:00:48 AM
Can you provide me a link to your forum and a test account?
Title: Re: Tabbed smileys
Post by: Sergioropase on July 21, 2011, 08:40:05 AM
yeah, you command for the PM, if you want to change the default theme test
Title: Re: Tabbed smileys
Post by: Sergioropase on July 23, 2011, 06:35:52 AM
Hi, well I got it to work thanks to Emanuele this wonderful mod that is very useful.

I've also managed to appear on the quick response tabs smilies.

Now I have a small problem, when a post has few answers get a large space between BBCode and the quick response, this occurs from the modification I made to appear the tabs at the quick response and I should appear together, when the post is several respondents space is reduced.

not when I click on the smilie from the rapid response does not appear.

I put an image to see it better.

thanks

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fi740.photobucket.com%2Falbums%2Fxx44%2Fsergioropase%2Fsmilies.jpg%3Ft%3D1311417319&hash=1a9f530d180c744ae418361def3d3e178e87a002)
Title: Re: Tabbed smileys
Post by: emanuele on July 23, 2011, 07:35:21 AM
I suppose you used a mod to display the editor's elements in the quick reply, which one is it?
Title: Re: Tabbed smileys
Post by: Sergioropase on July 23, 2011, 07:55:57 AM
If this is, but not much head hot you the important thing is that the mod is working, but good if you could add to the quick response would be great


http://custom.simplemachines.org/mods/index.php?mod=883
Title: Re: Tabbed smileys
Post by: emanuele on July 23, 2011, 08:12:07 AM
Unfortunately I can't reproduce it.

Probably it depends on the theme and on the way you put the code in Display.template.php...
Title: Re: Tabbed smileys
Post by: Sergioropase on July 23, 2011, 09:22:06 AM
ok thank you very much, anyway does not matter what the quick response, I will try to fix it but if it is not okay either

Many thanks
Title: Re: Tabbed smileys
Post by: Yngwiedis on July 28, 2011, 04:14:59 AM
Hello...

Is there anyway to make the tabs centered ?
Just like the smilies ?

Thank you very very much.
Title: Re: Tabbed smileys
Post by: emanuele on July 28, 2011, 05:00:21 AM
I think so since I've seen them centred once.

SMF 1 or 2?
Title: Re: Tabbed smileys
Post by: Yngwiedis on July 28, 2011, 06:11:43 AM
SMF 2.0 Final...
Title: Re: Tabbed smileys
Post by: emanuele on July 30, 2011, 08:34:31 AM
Sorry for the late reply.

I'm not a big expert of styling and css, so I'm not sure if it will work on all the browsers.
Try changing the style of ul#tabs from
ul#tabs {
overflow:auto;
list-style-type: none;
margin: 30px 0 0 0;
padding: 1px 0 0 0;
}

to
ul#tabs {
overflow:auto;
list-style-type: none;
margin: 30px auto 0 auto;
padding: 1px 0 0 0;
display: table;
}
Title: Re: Tabbed smileys
Post by: Yngwiedis on July 30, 2011, 08:55:17 AM
Very nice.
Tabs are centered now, but i have another small problem.
In the quick reply tabs and smilies are centered now.
In the normal reply only tabs are centered and smilies are aligned to left.
Can we fix that too ?

Thank you very very much.
Title: Re: Tabbed smileys
Post by: emanuele on July 30, 2011, 09:05:50 AM
add:
text-align: center;
to the styles for div.tabContent should solve that too. :)
Title: Re: Tabbed smileys
Post by: Yngwiedis on July 30, 2011, 09:19:19 AM
Ehmmm... sorry for beeing a pain in the ass...
I use 2 themes in my forum and both of them are just a copy of the default theme with color changes.
In my "bright" theme everything is ok now.

But in my second "dark" theme i see this extra "table":

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.vinilio.com%2Ftabbed_smilies.jpg&hash=670403c19ad4a7f2fd10793a03f3b7894febae88)

What i do wrong ?

Thank you very very much.
Title: Re: Tabbed smileys
Post by: emanuele on July 30, 2011, 09:31:30 AM
It could be related to the windowbg2 class used used for (one of) the div containing the smiley (...but it was there before too...), try edit GenericControls.template.php (in the Themes/default directory, it should be the same for your other theme, but check if the file exists also in the directory of your dark theme) and search for:
boxHTML += \'</ul><div class="windowbg2" id="tab_smiley_content"></div>\'';
and replace it with:
boxHTML += \'</ul><div id="tab_smiley_content"></div>\'';
Title: Re: Tabbed smileys
Post by: Yngwiedis on July 30, 2011, 09:36:58 AM
I have only one GenericControls.template.php file in my Themes/default folder.
None of my other 2 themes folders have that file.
I dont want to mess up anything. Are you sure that i need to change that file ?
Dont you think of something else which go wrong ?

Thank you and sorry for all the trouble.
Title: Re: Tabbed smileys
Post by: emanuele on July 30, 2011, 09:46:12 AM
It's one the changes done by the mod.

It's not a particularly dangerous change (you are just removing a css class), of course, before edit the file you will do a copy of GenericControls.template.php and in the case something goes wrong you can always restore that backup. ;)
Title: Re: Tabbed smileys
Post by: Yngwiedis on July 30, 2011, 09:54:25 AM
Ok i did the change and the extra table is gone.
But.... (i am sure. you are going to kill me)
Tabs and Smilies are not align correct...

I give you a screenshot from my bright theme where you can see better what i mean:

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.vinilio.com%2Falign.jpg&hash=98650c287017dd997549b0e3c49390449a023524)

Take a look of the empty space before the smilies line and after the smilies line.

Thank you and sorryyyyyyy  :(
Title: Re: Tabbed smileys
Post by: emanuele on July 30, 2011, 10:25:28 AM
eheheheh
I could kill only for money...maybe women but I'm not that sure... :P

That should be related to the "width:95%;" applied to the div.tabContent, try removing it and see if it works. ;)
Title: Re: Tabbed smileys
Post by: Yngwiedis on July 30, 2011, 10:32:02 AM
Not perfect yet :(

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.vinilio.com%2Falign2.jpg&hash=8bb6a4c766fb9777a036f954e6cda559b88f4d33)
Title: Re: Tabbed smileys
Post by: emanuele on July 30, 2011, 11:00:27 AM
Do you mean the border?
Remove it! :P

That's how the entire editor is "centred" (including subject and bbcodes), I'm not sure how to change it...
A quick look in the structure with Opera's Dragonfly it seems you have to change the style applied to #smileyBox_message, removing the left margin and increasing the right to something like 0.75em. But again I'm not sure how this would affect other browsers. ;)
Title: Re: Tabbed smileys
Post by: Yngwiedis on July 30, 2011, 11:12:22 AM
OK then....

I cant have everything in this life :)

I leave it as it is.

Thank you very very very very much for everything and i am sorry for all the troubles.
Title: Re: Tabbed smileys
Post by: emanuele on July 30, 2011, 11:14:15 AM
No problem! ;)
Title: Re: Tabbed smileys
Post by: teh_Krall on September 06, 2011, 02:18:40 AM
Fantastic mod! I've been looking for something like this to organize the amount of smileys we have for sometime now. Thanks!
Title: Re: Tabbed smileys
Post by: ACAMS on September 16, 2011, 01:21:19 PM
I have a problem, I have SMF 2.0 and just installed this mod ..... which works great on my other forum, but not my new one.


I use this theme http://custom.simplemachines.org/themes/index.php?lemma=2472 (http://custom.simplemachines.org/themes/index.php?lemma=2472)


and when I want to tab my smileys they look like this .... I want them ALL to show without the slider, and also the [more] popup is still showing and should not.


(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Friggedonlinepoker.com%2FPics%2Ftabbedprob.png&hash=b4b0124823c2cb7520879b3656d8d442fda9c625)
Title: Re: Tabbed smileys
Post by: emanuele on September 16, 2011, 01:42:02 PM
Yea...I'm not that good with css...

Which version are you using? 0.3.7 or the beta one?
I think the beta. In that case you have two options:
1) use the other version,
2) edit the css (in the set smiley order page) and change:
      div.tabContent {
         width:100%;
         overflow:auto;
         height: 100px;
      }

height to whatever you want or remove it. The problem removing it is that changing the tab the textarea will move up and down depending on the amount of smiley you have in each tab (I think...).

Regarding the more button...not sure what could be the problem...if you want to create an account for me on your forum I can have a look directly there.
Title: Re: Tabbed smileys
Post by: ACAMS on September 16, 2011, 03:57:31 PM
I had the beta, and swapped over to the other and all is fixed except the [more] link.


I will PM you the PW to the test account and make it an admin.
Title: Re: Tabbed smileys
Post by: ACAMS on September 17, 2011, 05:58:44 PM
Thanks to emanuele all is fixed.

THANKS!!!
Title: Re: Tabbed smileys
Post by: MotRude on September 18, 2011, 11:11:21 AM
Just would like to know if this is now safe to install on the 2.0 and if all the problems have been solved?
Title: Re: Tabbed smileys
Post by: emanuele on September 18, 2011, 02:22:24 PM
AFAIK yes...the last code-related issue dates back to February.
Title: Re: Tabbed smileys
Post by: MotRude on September 18, 2011, 04:41:03 PM
Does it work with all Themes? I Use prince of Darkness.
Title: Re: Tabbed smileys
Post by: ACAMS on September 18, 2011, 04:49:54 PM
It works on my different themes .... 3 one one site, and 3 more one my other sites.
Title: Re: Tabbed smileys
Post by: MotRude on September 19, 2011, 01:44:36 PM
Whats the Difference between the beta version and the reg version?
Title: Re: Tabbed smileys
Post by: emanuele on September 19, 2011, 04:19:18 PM
It's written just below the red note. ;)
Title: Re: Tabbed smileys
Post by: MotRude on September 20, 2011, 12:50:52 AM
I Did not install the Beta version but installed the Regular version..Works Great!

Is there a way to remove the More Link?
Title: Re: Tabbed smileys
Post by: emanuele on September 20, 2011, 02:59:46 AM
I answered by PM and forgot to report here...
The option is in the same page of enable smileys: admin > forum > smiley and message icons > settings.
Title: Re: Tabbed smileys
Post by: MotRude on September 20, 2011, 12:39:54 PM
Thanks Alot...Great Mod! :)
Title: Re: Tabbed smileys
Post by: timetraveller on December 08, 2011, 05:05:49 PM
I tried to install the mod and it says it's not compatible with my version of smf - 2.0.1

Any advice as I could really do with getting my smileys under control  ;)
Title: Re: Tabbed smileys
Post by: Adrek on December 09, 2011, 01:53:08 AM
Read this: http://wiki.simplemachines.org/smf/How_can_install_a_mod_that_doesn't_work_in_my_SMF_version
Mod is compatible with SMF 2.0 so there shouldn't be problems with latest SMF 2.0.1 ;)
Title: Re: Tabbed smileys
Post by: timetraveller on December 09, 2011, 04:04:35 PM
Ah, OK - I've managed to do that before (shame it didn't log in the memory cells!!) I'll give it a go. Thank you :)
Title: Re: Tabbed smileys
Post by: timetraveller on December 09, 2011, 08:03:51 PM
Successfully installed  ;D

Couple of questions about the look.

(1) Can I change the tabs so they have rounded edges and a font to match the SMF2.0 default theme (Curve?)

(2) To the right of the tabs there is a tiny scroll bar - presumably something in the height of the tab bar box needs adjusting. Can I do this somewhere?
Title: Re: Tabbed smileys
Post by: emanuele on December 10, 2011, 04:30:07 AM
Quote from: timetraveller on December 09, 2011, 08:03:51 PM
(1) Can I change the tabs so they have rounded edges and a font to match the SMF2.0 default theme (Curve?)
Yes, unfortunately at the moment I cannot provide you an example...(time constrains)

Quote from: timetraveller on December 09, 2011, 08:03:51 PM
(2) To the right of the tabs there is a tiny scroll bar - presumably something in the height of the tab bar box needs adjusting. Can I do this somewhere?
Yes, you should be able to fix it increasing the margin or the padding in this css:
ul#tabs {
overflow:auto;
list-style-type: none;
margin: 30px 0 0 0;
padding: 1px 0 0 0;
}

I think... :-[
Title: Re: Tabbed smileys
Post by: chinaren on December 31, 2011, 05:44:08 AM
OMG.  You are a true hero!  Thousands will scream your name.  I've been looking for a mod like this since Smiley Pops died, and here it is!!


Many, many thanks!!!!  Works fine on my forum.  Now I just have several hours worth of Smiley arranging to do.   :laugh:
Title: Re: Tabbed smileys
Post by: timetraveller on January 09, 2012, 08:06:13 AM
I like mine too :)

You've reminded me it's time to remove the Christmas smileys :)
Title: Re: Tabbed smileys
Post by: shin111 on January 30, 2012, 12:47:24 AM
Anyone manage to get this working on 1.1.16?

If so, how did you do it?
Title: Re: Tabbed smileys
Post by: emanuele on January 30, 2012, 05:57:49 AM
Please try using the Version Emulate (http://custom.simplemachines.org/mods/index.php?mod=2113) mod and put 1.1.13 as version to emulate.
It installs as expected. ;)
Title: Re: Tabbed smileys
Post by: MrCreatoR on February 19, 2012, 06:13:34 PM
Russian translation...

russian-utf-8:
Quote <file name="$languagedir/Modifications.russian-utf8.php" error="skip">
<operation>
<search position="end" />
<add><![CDATA[
//Begin tabbed smileys
$txt['additional_smileys'] = 'Дополнительные смайлы';
$txt['basic_smileys'] = 'Базовые смайлы';
$txt['tabbed_smileys_tabsnames'] = 'Имена вкладок и отображение';
$txt['tabbed_smileys_tabsnames_description'] = 'Здесь вы можете указать имена вкладок, которые будут отображаться над формой ответа, при отправке нового сообщения в тему или личного сообщения.';
$txt['tabbed_smileys_row'] = 'ряд';
$txt['tabbed_smileys_tab'] = 'вкладка';
$txt['tabbed_smileys_style'] = 'Отображение вкладок';
$txt['hide_more_smiley'] = 'Прятать кнопку "Дополнительно"';
$txt['enable_tabbed_interface'] = 'Включить полный интерфейс вкладок';
$txt['tabbed_interface_off'] = 'Полностью отключено';
$txt['tabbed_interface_smiley'] = 'Только смайлы во вкладках';
$txt['tabbed_interface_fullon'] = 'Все элементы отправки сообщения во вкладках';
$txt['tabbed_smileys_two_lines'] = 'Показывать вкладки смайлов в отдельном ряду';
$txt['tabbed_formatting'] = 'Форматирование';
$txt['tabbed_attachments'] = 'Вложения';
// $txt['tabbed_attached'] = $txt['attached']; //reminder
$txt['tabbed_othersettings'] = 'Другие опции';
//End tabbed smileys
]]>
</add>
</operation>
</file>

russian:
Quote <file name="$languagedir/Modifications.russian.php" error="skip">
<operation>
<search position="end" />
<add><![CDATA[
//Begin tabbed smileys
$txt['additional_smileys'] = 'Дополнительные смайлы';
$txt['basic_smileys'] = 'Базовые смайлы';
$txt['tabbed_smileys_tabsnames'] = 'Имена вкладок и отображение';
$txt['tabbed_smileys_tabsnames_description'] = 'Здесь вы можете указать имена вкладок, которые будут отображаться над формой ответа, при отправке нового сообщения в тему или личного сообщения.';
$txt['tabbed_smileys_row'] = 'ряд';
$txt['tabbed_smileys_tab'] = 'вкладка';
$txt['tabbed_smileys_style'] = 'Отображение вкладок';
$txt['hide_more_smiley'] = 'Прятать кнопку "Дополнительно"';
$txt['enable_tabbed_interface'] = 'Включить полный интерфейс вкладок';
$txt['tabbed_interface_off'] = 'Полностью отключено';
$txt['tabbed_interface_smiley'] = 'Только смайлы во вкладках';
$txt['tabbed_interface_fullon'] = 'Все элементы отправки сообщения во вкладках';
$txt['tabbed_smileys_two_lines'] = 'Показывать вкладки смайлов в отдельном ряду';
$txt['tabbed_formatting'] = 'Форматирование';
$txt['tabbed_attachments'] = 'Вложения';
// $txt['tabbed_attached'] = $txt['attached']; //reminder
$txt['tabbed_othersettings'] = 'Другие опции';
//End tabbed smileys
]]>
</add>
</operation>
</file>
Title: Re: Tabbed smileys
Post by: FrizzleFried on March 29, 2012, 02:20:56 AM
Quote from: emanuele on December 10, 2011, 04:30:07 AM
Quote from: timetraveller on December 09, 2011, 08:03:51 PM
(1) Can I change the tabs so they have rounded edges and a font to match the SMF2.0 default theme (Curve?)
Yes, unfortunately at the moment I cannot provide you an example...(time constrains)

Could I trouble you to perhaps touch on this topic again?  Your mod is EXCELLENT... absolutely fantastic but it does stand out a slight bit from the curved theme of the forum I am running.  Any help is greatly appreciated.

THANKS!

Title: Re: Tabbed smileys
Post by: emanuele on March 29, 2012, 05:33:10 AM
Now that I think about it: use the "beta" version.
That inherit the Curve aspect. You can set it to "Only smileys in tabs" and it will be exactly the same as the current one, but with nice rounded edges...I hope. :P
Title: Re: Tabbed smileys
Post by: FrizzleFried on March 29, 2012, 05:34:11 AM
Figured it out (how to make rounded buttons)...

Add:

-moz-border-radius: 6px;

And

-webkit-border-radius: 6px;

to ul#tabs li a and you're golden.
Title: Re: Tabbed smileys
Post by: FrizzleFried on March 29, 2012, 05:35:03 AM
Quote from: emanuele on March 29, 2012, 05:33:10 AM
Now that I think about it: use the "beta" version.
That inherit the Curve aspect. You can set it to "Only smileys in tabs" and it will be exactly the same as the current one, but with nice rounded edges...I hope. :P

Unfortunately not... still square... but I just posted the solution.
Title: Re: Tabbed smileys
Post by: emanuele on March 29, 2012, 11:50:31 AM
ohh...that's because it's still beta "b", while I changed it in beta "c" that is the one I'm using on my test install...wondering if beta c works fine or not...don't remember...
Title: Re: Tabbed smileys
Post by: FrizzleFried on March 29, 2012, 12:22:42 PM
Is your solution more elegant?  Willing to shoot over beta C?  :)

Thanks!
Title: Re: Tabbed smileys
Post by: emanuele on March 29, 2012, 12:38:54 PM
Something like the attached picture.

I'll try to workout something in the next few days (at least put a license) and release it somehow. ;)
Title: Re: Tabbed smileys
Post by: emanuele on March 29, 2012, 04:10:01 PM
Done. The new (beta) version is available.
Title: Re: Tabbed smileys
Post by: FrizzleFried on March 29, 2012, 04:41:50 PM
May I ask the different between version 3.99b and 3.99d aside from the rounded corners?   I ask as I assume I will lose my tabs if I uninstall "b" and install "d"...and if the changes are only the rounded corners I've already taken care of that.

Thanks!
Title: Re: Tabbed smileys
Post by: emanuele on March 29, 2012, 04:56:43 PM
Quote from: FrizzleFried on March 29, 2012, 04:41:50 PM
I ask as I assume I will lose my tabs if I uninstall "b" and install "d"
As far as I know your assumption is wrong. ;)

Quote from: FrizzleFried on March 29, 2012, 04:41:50 PM
May I ask the different between version 3.99b and 3.99d aside from the rounded corners?
Honestly I don't remember... lol
Title: Re: Tabbed smileys
Post by: irishgal1971 on April 07, 2012, 02:28:18 AM
I successfully uploaded the mod with no errors and got the tabs named and smiles placed the way I want them. I then went to look at the post screen and I got a bunch of empty boxes under the tabbed area. Is there any way to get rid of them?

I included a screenshot with the boxes in between the parentheses I drew.

Any help would be greatly appreciated.  ;D


Christine
Title: Re: Tabbed smileys
Post by: emanuele on April 07, 2012, 06:42:45 AM
Hello irishgal1971 and welcome to sm.org!

This is a "common" problem (see here (http://www.simplemachines.org/community/index.php?topic=417533.msg2978819#msg2978819) and here (http://www.simplemachines.org/community/index.php?topic=417533.msg2989405#msg2989405) for example) due to...not sure about it, but most likely some (previous) error/problem with smiley handling.

The idea is that there are smile in the database that doesn't have a corresponding image file.
I'm not sure how this could happen (it could even be a bug in SMF...though I don't know how to replicate it).
Would be a problem for you to attach here (or send it to me somehow by PM) an export of your smf_smileys table?
Title: Re: Tabbed smileys
Post by: irishgal1971 on April 07, 2012, 11:37:48 AM
Here's my smileys table.
Title: Re: Tabbed smileys
Post by: emanuele on April 07, 2012, 01:10:23 PM
Then it was not something related to the database...
/me has a very bad memory...

May I ask you an account on your forum? (send me the data by pm, a simple user should be enough, if you want you can put it in a group with the permission "Manage smileys and message icons")
Title: Re: Tabbed smileys
Post by: shazoo! on April 07, 2012, 05:59:59 PM
I wasn't getting it at first, but now I see how it works.  Thank you for this mod!!!
Title: Re: Tabbed smileys
Post by: emanuele on April 07, 2012, 06:12:05 PM
Hello shazoo!,

when you are in the "set smiley order" page click on one of the smiley you want to move to another tab, then go to the very end of the list you will see the same situation represented in the picture I posted in the 1st post here. Clicking on the last arrow will create a new line for the popup and so a new tab.

Since you have 600 smiley I'd suggest you to create all the tabs you need with 1 smiley in each and then move to the "edit smiley" page, there it will be easier to move batch of smiley from a tab to another.

Hope that helps!
Good luck with the organization from scratch of 600 smiley!! :o
Title: Re: Tabbed smileys
Post by: timetraveller on April 08, 2012, 09:03:10 AM
And I thought I was bad with 200ish *polishes halo*  ;D
Title: Re: Tabbed smileys
Post by: shazoo! on April 08, 2012, 05:21:36 PM
Quote from: emanuele on April 07, 2012, 06:12:05 PM
Hello shazoo!,

when you are in the "set smiley order" page click on one of the smiley you want to move to another tab, then go to the very end of the list you will see the same situation represented in the picture I posted in the 1st post here. Clicking on the last arrow will create a new line for the popup and so a new tab.

Since you have 600 smiley I'd suggest you to create all the tabs you need with 1 smiley in each and then move to the "edit smiley" page, there it will be easier to move batch of smiley from a tab to another.

Hope that helps!
Good luck with the organization from scratch of 600 smiley!! :o
Thank you!!! I'm doing it 50 at a time.  I LOVE THIS MOD!!
Title: Re: Tabbed smileys
Post by: shazoo! on April 08, 2012, 06:36:13 PM
Is 16 rows the most I can do? I need 21

Nevermind, I consolidated :)
Title: Re: Tabbed smileys
Post by: emanuele on April 08, 2012, 07:00:36 PM
I can't see any limit (apart from the database one that should be...don't know 128 or 255 or something like that), you should be able to add more than 16 lines (I arrived at 18 to test).
Title: Re: Tabbed smileys
Post by: shazoo! on April 08, 2012, 07:47:01 PM
Quote from: emanuele on April 08, 2012, 07:00:36 PM
I can't see any limit (apart from the database one that should be...don't know 128 or 255 or something like that), you should be able to add more than 16 lines (I arrived at 18 to test).

I was able to ADD the rows, but the line never came up allowing me to name it, and it didn't show on the board.
It's ok, though, 21 tabs is pretty excessive in hindsight, so I just combined my tabs.
Title: Re: Tabbed smileys
Post by: neoxes on June 29, 2012, 06:10:49 PM
Hi, I've a problem with this mod because it's hiding my shoutbox in tinyportal. I fixed editing css in this way:
div#tab_smiley_content .tabContent {
width:100%;
overflow:auto;
padding-bottom: 10px;
}
div#tab_smiley_content .hide {
display: none;
}
div#tab_smiley_content .tabContent_spacer {
margin-top: 0.5em;
}

Is this correct? I'm not a ccs expert...
Title: Re: Tabbed smileys
Post by: emanuele on June 29, 2012, 06:21:32 PM
Quote from: neoxes on June 29, 2012, 06:10:49 PM
Is this correct? I'm not a ccs expert...
Me neither.
If it works it's correct! :P
Title: Re: Tabbed smileys
Post by: uge on July 01, 2012, 05:41:48 PM
i install this mod but i don´t find the configuration in admin panel. Where are it?

Sorry for my english

Regards
Title: Re: Tabbed smileys
Post by: emanuele on July 01, 2012, 06:16:17 PM
There isn't much admin interface, just when you set the position of the smileys into the popup, every row will be treated like a new tab...
Title: Re: Tabbed smileys
Post by: D.Joe on July 10, 2012, 04:06:32 PM
I have a problem: i've done how the pic says but still there is no tab, nothing is changed.
Title: Re: Tabbed smileys
Post by: emanuele on July 10, 2012, 04:15:13 PM
Can you provide an account with "manage smiley" permission?
Title: Re: Tabbed smileys
Post by: nax on August 02, 2012, 05:00:20 AM
I tried the original download and my system said it was not compatible (I am on SMF 2.0.2 | SMF © 2011, Simple Machines
Bright Forest Theme v2.3 by Aaron) I tried the beta and where I think I should be seeing smileys , the tabs appearance box I see this script:

div.tabContent {
         width:100%;
         overflow:auto;
         padding-bottom: 10px;
      }
      div.hide {
         display: none;
      }
      div.tabContent_spacer {
         margin-top: 0.5em;
      }

I have attached a screen shot, any ideas?
Title: Re: Tabbed smileys
Post by: emanuele on August 02, 2012, 08:14:52 AM
In the first post there is the explanation of how to use the mod.
That box you see there is just a place where you can easily change/set the appearance of the tabs, even though I should remove it...it's basically useless.
Title: Re: Tabbed smileys
Post by: nax on August 02, 2012, 03:28:00 PM
Thanks I understand it now.  Just found one issue, I have four tabs now buit when I click on the last tab (furthest to the right) That tab and it's contents become right justified, all the others are over to the left of the page.
Title: Re: Tabbed smileys
Post by: emanuele on August 02, 2012, 05:15:26 PM
mmm...that's probably an issue with the theme...
AFAIR in Curve the tabs should create a second line if they don't have enough space to stay on a single line.
No idea how to fix it, sorry... :(
Title: Re: Tabbed smileys
Post by: nax on August 03, 2012, 04:47:14 AM
Oh there is enough space, see the screen shots attached, it only hapens with the last tab.
Title: Re: Tabbed smileys
Post by: emanuele on August 03, 2012, 05:53:24 AM
Never seen something like that! lol

Could you provide me a test account?
Title: Re: Tabbed smileys
Post by: nax on August 06, 2012, 07:05:44 AM
Yes by all means, I will PM you the forum details.
Title: Re: Tabbed smileys
Post by: emanuele on August 06, 2012, 07:34:39 AM
In your index.ccs you have:
Code (index.css?fin20 (line 2138)) Select
.buttonlist, .buttonlist_bottom {
    float: right;
    margin-right: 1em;
}

and
Code (index.css?fin20 (line 1577)) Select

.buttonlist, .buttonlist_bottom {
    float: right;
    margin-right: 1em;
}

removing the two "float: right;" the issue should be fixed.

Please note that you also set the width of the tab to 1000%, you should use 100%. ;)
Title: Re: Tabbed smileys
Post by: nax on August 06, 2012, 11:28:22 AM
Thank you so much that seems to have fixed the problem.
Title: Re: Tabbed smileys
Post by: nax on August 08, 2012, 06:21:14 AM
One other thing has now arisen, smileys within nested quotes have disappeared. My forum playground is still open to you id you want to try posting and creating nested quotes with me.
Title: Re: Tabbed smileys
Post by: emanuele on August 08, 2012, 06:25:28 AM
That doesn't seem to have any connection with my mod, I tried a preview on your site and it seems to work...can you describe better the issue?
Title: Re: Tabbed smileys
Post by: nax on August 08, 2012, 06:29:45 AM
In nested quotes smiies posted within them seem to disappear for some if not all users, my users tell me they have only noticed it since I out the tabs in place.
Title: Re: Tabbed smileys
Post by: emanuele on August 08, 2012, 06:35:25 AM
This mod changes the mere aspect of the posting page, it doesn't interfere in any way with the posting or parsing of the message (AFAIR! :P).

Can you show me a page where the issue is visible and I can play with it?
I posted on your test site and it works fine. I even used the WYSIWYG editor to see if that was the problem but I can still see the smiley in nested quotes...
Title: Re: Tabbed smileys
Post by: nax on August 08, 2012, 06:39:16 AM
Let us post and repost that message including smilies so that we create a nested quote and see the outcome.

Thanks for your help BTW. ;)
Title: Re: Tabbed smileys
Post by: nax on August 08, 2012, 06:55:13 AM
I wonder if there is a conflict with another mod I have installed Align text with Smiley v1.2 as the code for the smilies seems to be eing stripped out of the nested quotes - have a look.
Title: Re: Tabbed smileys
Post by: emanuele on August 08, 2012, 08:04:44 AM
Okay, got it: I'd say it's a bug with the wyiwyg editor.
When the smiley contains a ">" (and most likely a "<") the editor fails at convert it to BBCode.
This is true for any kind of smiley in nested quotes or not.
So not a problem with my mod, but with SMF's editor. ;)
Title: Re: Tabbed smileys
Post by: nax on August 08, 2012, 09:18:51 AM
If you lok at he code for my animal smilies they all start with a # and no < or> is used.
Title: Re: Tabbed smileys
Post by: emanuele on August 08, 2012, 09:52:41 AM
Yes, just uninstall that mod (the align smiley) and it will work again (please also report the problem in the support topic).
The issue is visible even simply switching between WYSIWYG and normal a couple of times: all the smiley are wiped out.
Title: Re: Tabbed smileys
Post by: nax on August 08, 2012, 11:38:16 AM
((((((((((((((((((((((((((((((( Emanuele )))))))))))))))))))))))))))))

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.naxfun.com%2Ffunforest%2FSmileys%2FSoLoSMiLeYS1%2Flove0030.gif&hash=75463682a44ad70c0bcbcf13c3f456a6ed2093d0)
Title: Re: Tabbed smileys
Post by: emanuele on August 08, 2012, 11:43:32 AM
:o ???
Title: Re: Tabbed smileys
Post by: nax on August 08, 2012, 11:47:50 AM
Quote from: nax on August 08, 2012, 11:38:16 AM
((((((((((((((((((((((((((((((( Emanuele )))))))))))))))))))))))))))))

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fwww.naxfun.com%2Ffunforest%2FSmileys%2FSoLoSMiLeYS1%2Flove0030.gif&hash=75463682a44ad70c0bcbcf13c3f456a6ed2093d0)

The brackets mean BIG hug, thanks for your help.
Title: Re: Tabbed smileys
Post by: emanuele on August 08, 2012, 11:53:13 AM
Ahhhh!!!

You are welcome! ;)
Title: Re: Tabbed smileys
Post by: boo2 on August 27, 2012, 06:38:20 PM
I just used the parse information assuming I didn't need to actually upload the tar/gz thing to the package directory. So I edited all the files on the parse information page. And saw all the options in admin but then I worried that it might need that tar.gz for something other than editing the files.

So I uploaded it to the package directory anyway but noticed on the manage package page it shows up (with out) an UNinstall link.

All that shows is [ List Files ] [ Delete ]

Does that mean that it's already installed and it doesn't need anything else or does it mean that the tar.gz is not working?? I am so confused.

Ok now I replaced all the original files removing all the parsed edits, then uploaded the tar.gz to the package directory but it has no install link, or uninstall link.. ugh All that is showing is:

[ List Files ] [ Delete ]

Most of the mods I have installed worked with zip, could it be that it won't work for me with tar.gz? Is there a zip version? Or is it ok to just do the parse part and not have the tar.gz in the package manager at all?

I was worried that maybe the file had database entries it had to make or something other than just the file edits. Sorry hope I didn't confuse you too. I haven't had problems installing mods but because I did the parse alone this time I never thought that the tar.gz might have been a problem.


I see I am rather late to the party here, hope I am not to late to get help.
Title: Re: Tabbed smileys
Post by: boo2 on August 27, 2012, 10:19:05 PM
Never mind folks, I used the emulation thing in the advanced section of the package manager and got it installed under 2.0 since the install link wouldn't even show up under 2.0.2. Never used that before but got advice else where. So far so good.
Title: Re: Tabbed smileys
Post by: emanuele on August 28, 2012, 08:56:17 AM
Yep, that is one of my old mods with a "strict" version verification.
I don't remember any database change, so editing the files should be enough...I think.
Title: Re: Tabbed smileys
Post by: boo2 on August 29, 2012, 12:08:24 AM
Quote from: emanuele on August 28, 2012, 08:56:17 AM
Yep, that is one of my old mods with a "strict" version verification.
I don't remember any database change, so editing the files should be enough...I think.

As much as I loved the idea of your mod, it sure gave me hours of hair pulling aggravation. First I got two tabs made but then when I added the third and saved it, it didn't take so there were only 2 tabs. Then I thought I'd really like it for no icons to be showing at all, and just have the tabs full of them, so I created a tiny icon to put in the row that showed on top, then I added the others to the other rows. What I didn't know was that behind the scenes everything was going to hell quickly. I had my own smilie set created by me as the default, but for some reason this mod got it all messed up or I did, not even sure any more, but at one point I did only have a little plus graphic showing in the reply page, then you clicked the tabs to get all the others, that's the way I wanted it. Anyway I started over trying to get the 3rd and four tabs to take but they wouldn't, so I figure what the heck, i would just keep 3 tabs. The I turned my attention to your css you have showing there and assumed that is how you changed the look of the borders and stuff which I wanted to do. Ack, here came trouble. I changed it and only removed the bold items and clicked save.. Then I went to view the new topic and reply page and oh my word.. it was one big mess, the 2 extra tabs where gone, and the smilies were all boxes. I was terrified at that point.

Then I checked my error logs and noticed the errors such as these.

forums/index.php?action=admin;area=smileys;sa=editicon;icon=0
8: Undefined index: 0
File: public_html/forums/Sources/ManageSmileys.php
Line: 1761

forums/index.php?action=admin;area=smileys;sa=editicon;icon=1
The icon image could not be found in the default theme - please ensure the image has been uploaded and try again.

forums/index.php?action=admin;area=smileys;sa=editicon;icon=1
8: Undefined index: icon_filename
File: public_html/forums/Sources/ManageSmileys.php
Line: 1570

forums/index.php?action=admin;area=smileys;sa=editicon;icon=0
The icon image could not be found in the default theme - please ensure the image has been uploaded and try again.

forums/index.php?board=1.0
8: Undefined variable: topic
public_html/forums/Themes/default/languages/Gallery.english.php (main sub template - eval?)

Of course they may not all have to do with your mod, and this maybe all my fault, I wouldn't have a clue. LOL

I even thought, well if the mod is thinking the defaults are my default, then I will overwrite all the default ones with my own smilies and name them the same as the files in the default folder. Thinking that might trick it into working again, but I never thought about the default gifs being embedded into smf and now missing in the database ... I'm just rambling at this point because i really don't have any idea what really took place.

I went into advanced and put it back to 2.0 and uninstalled it hoping it would restore the default smilies in the database or what ever is wrong? But then you just said there were no database hooks or what ever there called in you mod. si not sure what's happening but I do know that now I dont' have any smilies in new topic and reply pages and not in the gallery where you add a photo and description using smilies, they are all gone too.

I'll attach a photo of how it looked when I had it working at least good enough, and before I edited that css and it blew up in my face.

Then the second attachment will show you what it looks like now after uninstall, which is the only thing that went well, actually, and probably having nothing to do with your mod, though I am pretty careful and do a lot of searching before I do anything most times. I do think there might be a problem with that css showing like that if it's not meant to be edited where it is.




Title: Re: Tabbed smileys
Post by: emanuele on August 29, 2012, 02:43:10 AM
I'm sorry for your troubles.

Apart from the first that I think I have already seen, but don't remember if it was here or somewhere else, the errors don't seem to be caused by this mod (of course without the full code it's difficult to say).
It's difficult to say also what is going of with the appearance, without having a first hand look at the post page and at the changes you did I can't tell you anything useful.
Title: Re: Tabbed smileys
Post by: boo2 on August 29, 2012, 10:42:10 AM
Well I have it Uninstalled and I got back my smiles by deleting them all in admin and starting over.. One thing good about what happened is that I realized that admin already had a popup solution which would have done part of what I wanted which was to keep the smilies out of view until needed. Though tabs is great it still takes up a lot of space on the topic and reply page.

I would have preferred a hide show divide of some kind, right in the page, but a popup will have to do until I can find something like that instead. Tabs would have been great but I don't want any smilies showing by default and when I put smilies all in the tabs I think that might have kept the newly created tabs from taking affect, I don't know that for a fact though. And when I  messed with that css that DID mess things up, the last thing i did was change that css and that is when I got all the empty boxes, but the tabs didn't stick either, and I don't have but a few mods and I don't load them until I see one is working well before I put in another, so they were working fine.

Adk topic button
Simple Audio Video Embedder
Bookmarks
SimplePortal
SMF Gallery Lite
Title: Re: Tabbed smileys
Post by: mgrmgr on September 08, 2012, 04:40:05 AM
I tested your beta version and it works charmingly for me. I like the tabs for other content in the posting window, I've just a small (?) suggestion:

Can the other tabs please be made selectable? With every other post i fall into the same trap: missing subject :( You know: out of sight - out of mind :)
Title: Re: Tabbed smileys
Post by: emanuele on September 08, 2012, 06:26:34 AM
Yep, that one is on the list of things to fix since forever... O:)
Though, since in 2.1 many thigs will change  for the editor, I'm not yet sure what I'll do with it.
Title: Re: Tabbed smileys
Post by: mgrmgr on September 08, 2012, 08:14:27 AM
Quote from: emanuele on September 08, 2012, 06:26:34 AM
Yep, that one is on the list of things to fix since forever... O:)

LOL - that seems to be the fate for to-do lists (own experience). Up to now I outlived all of my to-do lists :)

Quote from: emanuele on September 08, 2012, 06:26:34 AM
Though, since in 2.1 many thigs will change  for the editor, I'm not yet sure what I'll do with it.

I guess 2.1 will also take a couple of years until ready - time enough ?  O:)
Title: Re: Tabbed smileys
Post by: emanuele on September 08, 2012, 08:50:28 AM
I don't want to work on 2.1 for so long!! :P
Of course you can't expect it will be out tomorrow... O:)
Title: Re: Tabbed smileys
Post by: mgrmgr on September 10, 2012, 04:16:01 AM
Quote from: emanuele on September 08, 2012, 08:50:28 AM
...
Of course you can't expect it will be out tomorrow... O:)

For the time being I'd be happy if all modifications would work flawlessly with 2.0.2 and use the available hooks :)
Title: Re: Tabbed smileys
Post by: mgrmgr on September 26, 2012, 03:33:56 PM
After I was forced to re-intall my forum there is a problem suddenly: the formatting tab doesn't show anything, but the editir icons are present if I switch the module off. Even if I select only smileys in tabs - all formatting icons are gone  :'(

After two days of searching what happens where I now give up  :( Do you have a hint where to search? I compared the install.xml and the resulting php files, all changes seem to be there - except the formatting part :(
Title: Re: Tabbed smileys
Post by: emanuele on September 27, 2012, 01:30:06 PM
What do you mean by formatting tab?

Sorry, today I'm a bit dumb...can you post some screenshots?
Title: Re: Tabbed smileys
Post by: mgrmgr on September 27, 2012, 06:56:41 PM
Quote from: emanuele on September 27, 2012, 01:30:06 PM
What do you mean by formatting tab?
...

Hmm - for me it is the second tab labeled "formatting" where the BBC icons + color-/font selections used to show up (IIRC it's tab -4 :) ) Whenever I activate the tabbed interface that content does not show up - the content shows up with tabbed interface switched off :(. The other tabs Subject, Attachments, options, and basic smileys + some other smiley tabs work fine though.
Title: Re: Tabbed smileys
Post by: emanuele on September 28, 2012, 08:23:18 AM
You mean in the post page? AHHHhh... I thought you were talking about the admin panel...

It could be something related to javascript, send me the data of an account, I don't have any clean forum to test it right now... (and I'm too lazy to set one up :P)
Title: Re: Tabbed smileys
Post by: mgrmgr on September 29, 2012, 09:32:17 AM
Sorry, I forgot to mention it - that was just clear for me  :D

If you only need a regular member account: user: test, password: test.

For a higher rank you have to ask in a PM :)
Title: Re: Tabbed smileys
Post by: emanuele on September 29, 2012, 09:38:07 AM
Do I have the url of your forum?

/me doesn't remember...
Title: Re: Tabbed smileys
Post by: mgrmgr on October 02, 2012, 05:16:08 PM
Quote from: emanuele on September 29, 2012, 09:38:07 AM
Do I have the url of your forum?

/me doesn't remember...

/me neither

But try http://forum.michgeyer.de as a start :)
Title: Re: Tabbed smileys
Post by: emanuele on October 02, 2012, 06:01:12 PM
Can you also give me an account to see the issue? (normal user should be fine)
Title: Re: Tabbed smileys
Post by: mgrmgr on October 03, 2012, 07:29:19 AM
Quote from: mgrmgr on September 29, 2012, 09:32:17 AM
Sorry, I forgot to mention it - that was just clear for me  :D

If you only need a regular member account: user: test, password: test.

For a higher rank you have to ask in a PM :)
Title: Re: Tabbed smileys
Post by: emanuele on October 03, 2012, 07:32:30 AM
Forgive a completely sleepy developer... lol
Seems a good thing that are 2 or 3 days I don't write a single line of code for 2.1! :laugh:

Edit: could you also please enable the mod otherwise I can't see the issue... ;)
Title: Re: Tabbed smileys
Post by: mgrmgr on October 03, 2012, 12:48:45 PM
 Please forgive me too. I completely forgot that I switched off the mod :-[
Title: Re: Tabbed smileys
Post by: emanuele on October 03, 2012, 01:06:28 PM
In GenericControls.template.php, find:
Code (find) Select
            if(!empty($modSettings['hide_more_smiley']))
               echo 'document.getElementById(oSmileyBox_', $editor_id, '.opt.sUniqueId + \'_addMoreSmileys\').style.display = \'none\';';

and replace it with:
Code (replace with) Select
if(!empty($modSettings['hide_more_smiley']))
echo '
if (document.getElementById(oSmileyBox_', $editor_id, '.opt.sUniqueId + \'_addMoreSmileys\') != null)
document.getElementById(oSmileyBox_', $editor_id, '.opt.sUniqueId + \'_addMoreSmileys\').style.display = \'none\';';
Title: Re: Tabbed smileys
Post by: mgrmgr on October 03, 2012, 04:05:37 PM
Thanks, I'll try right now

The textstring 'hide_more_smiley' occurs only as $txt string in modification.xxx.php, in GenericControls.template I can only find $modsettings['enable_tabbed_interfac'] in

function tabbed_toggleElem(elem)

Sorry :(
Title: Re: Tabbed smileys
Post by: mgrmgr on October 06, 2012, 04:12:22 AM
Looks there is no new marker after editing a post :( I can't live without this modification. I reckon it is time that this feature makes it into the core of SMF 2.1.
Title: Re: Tabbed smileys
Post by: emanuele on October 06, 2012, 05:40:08 AM
May you attach your GenericControls.template.php?
Title: Re: Tabbed smileys
Post by: mgrmgr on October 06, 2012, 08:52:16 AM
Your wish is my command :)
Title: Re: Tabbed smileys
Post by: emanuele on October 06, 2012, 08:58:44 AM
I want 10'000 euro per month for the next 900 months. :P

Try the attached.
Title: Re: Tabbed smileys
Post by: mgrmgr on October 06, 2012, 11:19:21 AM
you aren't greedy, are you?

{{{{{{{{{{{{{{{{{{{{emanuele}}}}}}}}}}}}}}}}}}}}

Don't take my hug the wrong way :) - I can't express my gratitude in a better way in this forum - now I have to find out where the mistake was - grep helps :)
Title: Re: Tabbed smileys
Post by: emanuele on October 07, 2012, 06:53:54 AM
Quote from: mgrmgr on October 06, 2012, 11:19:21 AM
you aren't greedy, are you?
Nope, if I were greedy I would have asked 100'000. :P

I changed the code I posted in the message above, nothing else. ;)
Title: Re: Tabbed smileys
Post by: nax on October 10, 2012, 04:04:04 AM
I had a problem with aligning my smilies, which is resolved but has left me with another niggle.  Here was the code that was changed


Quote from: emanuele on August 06, 2012, 07:34:39 AM
In your index.ccs you have:
Code (index.css?fin20 (line 2138)) Select
.buttonlist, .buttonlist_bottom {
    float: right;
    margin-right: 1em;
}

and
Code (index.css?fin20 (line 1577)) Select

.buttonlist, .buttonlist_bottom {
    float: right;
    margin-right: 1em;
}

removing the two "float: right;" the issue should be fixed.

Please note that you also set the width of the tab to 1000%, you should use 100%. ;)

It has resulted in some column headings now being left aligned. The source of the page looks like this:-

<div id="readbuttons_top" class="readbuttons clearfix margintop">
      <div class="floatleft middletext">Pages: [<strong>1</strong>] </div>
      <div class="buttonlist_bottom">
         <ul class="reset clearfix">
            <li class="last"><a class="button_strip_markread" href="http://www.nyforum.com/funforest/index.php?action=markasread;sa=all;c923e8fcc07=be4849b248c37138c5db5e8befd1aab2"><span>Mark ALL messages as read</span></a></li>
         </ul>
      </div>

Pages
Title: Re: Tabbed smileys
Post by: nax on October 10, 2012, 04:04:48 AM
I had a problem with aligning my smilies, which is resolved but has left me with another niggle.  Here was the code that was changed


Quote from: emanuele on August 06, 2012, 07:34:39 AM
In your index.ccs you have:
Code (index.css?fin20 (line 2138)) Select
.buttonlist, .buttonlist_bottom {
    float: right;
    margin-right: 1em;
}

and
Code (index.css?fin20 (line 1577)) Select

.buttonlist, .buttonlist_bottom {
    float: right;
    margin-right: 1em;
}

removing the two "float: right;" the issue should be fixed.

Please note that you also set the width of the tab to 1000%, you should use 100%. ;)

It has resulted in some column headings now being left aligned. The source of the page looks like this:-

<div id="readbuttons_top" class="readbuttons clearfix margintop">
      <div class="floatleft middletext">Pages: [<strong>1</strong>] </div>
      <div class="buttonlist_bottom">
         <ul class="reset clearfix">
            <li class="last"><a class="button_strip_markread" href="http://www.nyforum.com/funforest/index.php?action=markasread;sa=all;c923e8fcc07=be4849b248c37138c5db5e8befd1aab2"><span>Mark ALL messages as read</span></a></li>
         </ul>
      </div>

Pages
Title: Re: Tabbed smileys
Post by: littleangel on October 13, 2012, 07:04:29 AM
Hello! sorry if you don't understand me well, but my english is not very good :-\

I have installed this mod, and it works ok in all themes, bur don't work with classicyabb.Classicyabb don't have managesmileys.template.php... is that the error? can you help me?

URL forum:www,patinajeartistico.es/foro
Forum version: 1.1.16
Title: Re: Tabbed smileys
Post by: emanuele on October 13, 2012, 07:25:26 AM
Quote from: nax on October 10, 2012, 04:04:48 AM
I had a problem with aligning my smilies, which is resolved but has left me with another niggle.  Here was the code that was changed
Not tested, put back things as they were when it was working properly and then try adding something like that to the end of index.css:
#smileyBox_message .buttonlist, #smileyBox_message .buttonlist_bottom {
    float: none;
}


Quote from: littleangel on October 13, 2012, 07:04:29 AM
I have installed this mod, and it works ok in all themes, bur don't work with classicyabb.Classicyabb don't have managesmileys.template.php... is that the error? can you help me?
If a file is not present in a custom theme, it means the equivalent from the default theme is used, so you don't need to do anything.
Title: Re: Tabbed smileys
Post by: littleangel on October 13, 2012, 07:36:05 AM
Quote from: emanuele on October 13, 2012, 07:25:26 AM

If a file is not present in a custom theme, it means the equivalent from the default theme is used, so you don't need to do anything.
but the mod don't work...There aren't any tabs, I only can see a "more" button, but when I click the smileys...nothing happen



Maybe a javascript problem?
Title: Re: Tabbed smileys
Post by: emanuele on October 13, 2012, 07:54:00 AM
ManageSmiles has nothing to do with actually see the smiley in the post interface.
So, what's the issue, please describe it exactly (even with screenshots if it helps).
Title: Re: Tabbed smileys
Post by: littleangel on October 13, 2012, 08:16:47 AM
Well...I have the screenhots(really sorry, but muy english...)
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimageshack.us%2Fa%2Fimg546%2F1140%2Fdibujohzg.png&hash=6d7d81d884d9fd52cae0235a730ec16872837a69) (http://imageshack.us/photo/my-images/546/dibujohzg.png/)

As you can see...there are any tabs...there ara a more(más in Spanish) button, but when I click in the smiley, nothing happen,the smiley don't show in the post...

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimageshack.us%2Fa%2Fimg145%2F5614%2Fdibujo2m.png&hash=89848d38b7b67fe32bbec9a6ce1691b2a1bc3538) (http://imageshack.us/photo/my-images/145/dibujo2m.png/)

Title: Re: Tabbed smileys
Post by: emanuele on October 13, 2012, 08:28:49 AM
Does it work in the default theme?
Did you change Post.template.php of your theme?
Title: Re: Tabbed smileys
Post by: littleangel on October 13, 2012, 08:37:21 AM
Yes,I change all the codes manually...and default theme works perfectly,also babylon theme works
Title: Re: Tabbed smileys
Post by: NanoSector on October 13, 2012, 09:00:38 AM
Did you install the theme after installing this mod?
Title: Re: Tabbed smileys
Post by: emanuele on October 13, 2012, 09:04:52 AM
If you changed the Post.template.php file in your custom theme then it should work...
A test account (normal user) would be nice.
Title: Re: Tabbed smileys
Post by: littleangel on October 13, 2012, 12:11:01 PM
ok, account details on PM

No, Yoshi2889, We install the theme two years ago, and the mod the last week
Title: Re: Tabbed smileys
Post by: emanuele on October 13, 2012, 03:03:47 PM
Not all the changes are present in the template.
Check the directory of the theme you are using, there should be another "Post.template.php", apply the changes to that file too.
Title: Re: Tabbed smileys
Post by: littleangel on October 14, 2012, 02:18:44 AM
two post.template??? or with another name? thank you, I will check the directory .

modify: well...I don't find anymore post.template....

The theme has this directories.
-images (folder)
-languages (folder)
-boardIndex.tempalte.php
-display.template.php
-index.php
-index.template.php
-Mesageindex.template.php
-post.template.php(this one is the one I have modified)
-recent.template.php
-style.ccs
-themeinfo.xml

I don't know what I must modify...
Title: Re: Tabbed smileys
Post by: NanoSector on October 14, 2012, 05:01:49 AM
Mind attaching the modified template in your next post?
Title: Re: Tabbed smileys
Post by: littleangel on October 14, 2012, 05:38:41 AM
Quote from: Yoshi2889 on October 14, 2012, 05:01:49 AM
Mind attaching the modified template in your next post?
ok, no problem, this is the file, maybe I did something wrong, or I have copied a wrong code,...
Title: Re: Tabbed smileys
Post by: emanuele on October 14, 2012, 07:31:07 AM
I may be wrong, but doing a comparison with a clean install the file you attached comes from the default theme and not from Classic.
Title: Re: Tabbed smileys
Post by: littleangel on October 14, 2012, 07:47:54 AM
No, you aren't wrong...I remember that ,when we customize the themes, two years ago, one of our admins changed this post.template for the default theme, i don't remember why, because the admin is not in the forum now.I remember that this admin customize the themes based in classic yabb, and another girl and me, the babylon one.
Is that the problem??? what can I do?

Wait...There are more classic yabb, with different colours...and another changes...I'm attaching another one,maybe this is different... :-\

Sorry...I must tell you this before...but i don't remenber...
Title: Re: Tabbed smileys
Post by: emanuele on October 14, 2012, 08:22:55 AM
The two files are identical and both have the proper modifications in place.
Unless there is yet another Post.template.php that you have around the only solution I can suggest (as temporary and because you already replaced the Classic post.template.php with the default one is to rename the Post.template.php you have in your theme directory to something like "Post.template-back.php". That way SMF will pick the post.template.php from the default template and it should work as expected.
Title: Re: Tabbed smileys
Post by: littleangel on October 14, 2012, 08:37:48 AM
ok, deleting post.template, the mod works perfectly...
Title: Re: Tabbed smileys
Post by: emanuele on October 14, 2012, 08:56:46 AM
Delete is the answer to most of the questions! :P
Title: Re: Tabbed smileys
Post by: littleangel on October 14, 2012, 10:58:08 AM
Thanks!!! ;)
Title: Re: Tabbed smileys
Post by: nax on October 15, 2012, 10:33:44 AM
Quote from: emanuele on October 13, 2012, 07:25:26 AM
Quote from: nax on October 10, 2012, 04:04:48 AM
I had a problem with aligning my smilies, which is resolved but has left me with another niggle.  Here was the code that was changed
Not tested, put back things as they were when it was working properly and then try adding something like that to the end of index.css:
#smileyBox_message .buttonlist, #smileyBox_message .buttonlist_bottom {
    float: none;
}



That didn't do anything but the source of the page shows where the smilies are configured :-

</script>
   <style type="text/css">
            
                div.tabContent {
         
                        width:100%;
         overflow:auto;
         padding-bottom: 10px;


      }
      div.hide {
         display: none;
      }
      div.tabContent_spacer {
         margin-top: 0.5em;
      }

                 
      #tab_smiley_content {
         padding-top:10px;
      }
      #tabs
      {
         margin-top:15px;
      }
   </style>


Could some statement be put in the template (whicherver it is in) to add a float left control - I'm no programmer (but I am trying.
Title: Re: Tabbed smileys
Post by: nax on October 16, 2012, 04:55:31 AM
Errr I think I had a lucky break and solve this myself.  In Admin/forum/smilieys/set smiley order I added a float:none; statement in the code window at the bottom of the screen and saved it - this seems to solve the problem.
Title: Re: Tabbed smileys
Post by: FragaCampos on March 03, 2013, 05:21:23 PM
Hi there.
Thank you for this nice mod. It seems to be working fine.

I have one question, though.
When I create a new topic or message, does the page load all the smileys or just those from the  first tab (the visible one)?
Title: Re: Tabbed smileys
Post by: FragaCampos on March 06, 2013, 03:25:25 PM
Anyone? ::)

C'mon... it's a simple question. :P
Title: Re: Tabbed smileys
Post by: Shambles on March 06, 2013, 03:34:49 PM

Ok, my basic (forum) smileys appear preloaded when I create a new topic. Only when I click the alternate (formerly "popup") tab do they 'flood in', so to speak.
Title: Re: Tabbed smileys
Post by: FrizzleFried on March 06, 2013, 06:25:18 PM
Quote from: FragaCampos on March 06, 2013, 03:25:25 PM
Anyone? ::)

C'mon... it's a simple question. :P

Each tab is loaded only when you select that tab.  When i click a different tab I can "quickly" see the "text tag" of each smiley change to the smiley itself telling me they are loading only when you select the tab...
Title: Re: Tabbed smileys
Post by: FragaCampos on March 06, 2013, 10:30:09 PM
Ok, that's all I wanted to know.

Thanks a lot for your help. ;)
Title: Re: Tabbed smileys
Post by: Skaty on March 27, 2013, 08:34:53 PM
Great mod!

Quick question about quick reply, how can i disable it in quick reply.  Thank you.
Title: Re: Tabbed smileys
Post by: Arantor on March 27, 2013, 08:37:22 PM
Um, smileys aren't shown in quick reply normally?
Title: Re: Tabbed smileys
Post by: Skaty on March 27, 2013, 08:57:15 PM
Quote from: Arantor on March 27, 2013, 08:37:22 PM
Um, smileys aren't shown in quick reply normally?

There are shown, but i want to keep quick reply simple like just basic smileys. Maybe i should have ask first, is this tabs and smileys in it effect page load time ?
Title: Re: Tabbed smileys
Post by: Arantor on March 27, 2013, 09:01:25 PM
Then you have something else involved; this mod does *not* add it to the quick reply...
Title: Re: Tabbed smileys
Post by: Skaty on March 27, 2013, 09:09:33 PM
Umm, i was installed WYSIWYG Quick Reply it is added because of this so.

I thing i find my question, thank you.

Quote from: FrizzleFried on March 06, 2013, 06:25:18 PM
Each tab is loaded only when you select that tab.  When i click a different tab I can "quickly" see the "text tag" of each smiley change to the smiley itself telling me they are loading only when you select the tab...

And thanks to emanuele again for creating this mod.

ps: thanks to all for improving my english :)
Title: Re: Tabbed smileys
Post by: emanuele on March 28, 2013, 06:11:35 AM
I know it's already answered, but is never too late to demonstrate the power of a search. :P
Quote from: FragaCampos on March 03, 2013, 05:21:23 PM
I have one question, though.
When I create a new topic or message, does the page load all the smileys or just those from the  first tab (the visible one)?
http://www.simplemachines.org/community/index.php?action=search2;search=load;topic=417533 6th result (well, now it may (or may not) be the 7th).
Title: Re: Tabbed smileys
Post by: dimspace on May 05, 2013, 12:58:32 PM
Finally got around to installing this and having a play around with it, mainly for the fact it can tabulate everything, attachments, options etc.

One small query/question.

how difficult would it be for the subject and icons tab to go.. and for the subject and post icons fields to appear permentantly above the buttons/tabs.

formatting/attachments/options/smileys is stunning as buttons, but ideally I would like to have the post subject appearing all the time (especially on new posts).

So that it appears something like the screengrab
Title: Re: Tabbed smileys
Post by: emanuele on May 16, 2013, 05:06:02 AM
Never tried, but something like this should work.

In GenericControls.template.php remove this
Code (find) Select
tab_names[-5] = \'' . ($context['current_action']!='pm' ? $txt['tabbed_subject_and_icons'] : $txt['tabbed_to_and_subject']) . '\';

and:
Code (find) Select
tabs_content[0] = \'<div id="tab_-5_elem"></div>\';
tabs_content[0] += \'<div id="tab_-4_elem"></div>\';

Code (replace with) Select

tabs_content[0] = \'<div id="tab_-4_elem"></div>\';

and remove:
Code (find) Select
buttons_i = document.getElementById(\'post_header\');
buttons_f = document.getElementById(\'tab_-5_elem\');
buttons_f.appendChild(buttons_i);


But I'm mostly guessing...
Title: Re: Tabbed smileys
Post by: Skaty on May 16, 2013, 08:00:40 AM
This mod is very usefull and i want to thank again :)
Title: Re: Tabbed smileys
Post by: dimspace on May 16, 2013, 01:12:40 PM
Quote from: emanuele on May 16, 2013, 05:06:02 AM
Never tried, but something like this should work.

In GenericControls.template.php remove this
Code (find) Select
tab_names[-5] = \'' . ($context['current_action']!='pm' ? $txt['tabbed_subject_and_icons'] : $txt['tabbed_to_and_subject']) . '\';

and:
Code (find) Select
tabs_content[0] = \'<div id="tab_-5_elem"></div>\';
tabs_content[0] += \'<div id="tab_-4_elem"></div>\';

Code (replace with) Select

tabs_content[0] = \'<div id="tab_-4_elem"></div>\';

and remove:
Code (find) Select
buttons_i = document.getElementById(\'post_header\');
buttons_f = document.getElementById(\'tab_-5_elem\');
buttons_f.appendChild(buttons_i);


But I'm mostly guessing...

Yeh, didnt manage it.. Left the initial tab as "undefined", the smileys didnt load and none of the buttons worked. Will have a dig around over the next few days.. should be fairly simple.. in theory..
Title: Re: Tabbed smileys
Post by: CheeseHead05 on May 27, 2013, 01:52:36 AM
I have a simple question,

I have installed this mod but am a bit confused. 1) Being that there is already a smileys folder inside the default folder, how do I know which ones I downloaded? What are the steps to get those smileys that I downloaded? 2) I am using a custom theme but noticed that there isnt a smileys folder yet there is an image folder. Do I dump the smileys in the image folder?

Thanks in advance!
Title: Re: Tabbed smileys
Post by: emanuele on June 01, 2013, 07:57:15 AM
Simple question, but probably wrong topic: this is not a smiley pack.

If you need assistance in installing other smiley, you may want to open a topic in the support board (http://www.simplemachines.org/community/index.php?board=147.0). ;)
Title: Re: Tabbed smileys
Post by: MIAUS on November 30, 2013, 07:30:07 PM
Hello,

I have so far used Smiley Pops (http://custom.simplemachines.org/mods/index.php?mod=944) but as this is spamming my error log and also being abandoned is there any chance I can use this great mod with smf 1.1.19? That would be brilliant!

Thanks a lot in advance :)

Daniela
Title: Re: Tabbed smileys
Post by: NanoSector on November 30, 2013, 07:46:40 PM
The mod should work just fine with 1.1.19.

In case it doesn't want to install: http://wiki.simplemachines.org/smf/How_can_I_install_a_mod_that_doesn%27t_work_in_my_SMF_version
Title: Re: Tabbed smileys
Post by: crash56 on January 18, 2014, 11:13:01 AM
WOW!  Great modification.  I got a little stupid with the installation and setting it up, so it took me a while to get it sorted out, but I love it.  Our members like a lot of smileys.  I think they're going to really enjoy this mod.  Thank you!
Title: Re: Tabbed smileys
Post by: GamePersia on April 23, 2014, 12:32:37 AM
saying The package you are trying to download or install is either corrupt or not compatible with this version of SMF.
using 2.0.7 smf v.
Title: Re: Tabbed smileys
Post by: 420Connect.co.uk on March 04, 2015, 12:14:44 PM
Sorry to bump this one..

I'm attempting to emulate to install this but no versions seem to work that have been suggested earlier on? :S
Title: Re: Tabbed smileys
Post by: Steve on March 04, 2015, 06:04:13 PM
I don't know how to help you with that because mine was manually installed by someone with more technical expertise than I but I did want to mention a couple of things.

You can try the updated version here: https://github.com/emanuele45/Tabbed-Smileys/releases

If you manually install this version, there is a crucial thing you absolutely must remember .... NEVER move a smiley from the first position in a tab ... there's a significant glitch that will randomize your smileys. To get around it, move another smiley to the first position, then move the smiley that was in the first spot but is now in the second to wherever you want.
Title: Re: Tabbed smileys
Post by: 420Connect.co.uk on March 05, 2015, 12:54:05 PM
Quote from: Steve on March 04, 2015, 06:04:13 PM
I don't know how to help you with that because mine was manually installed by someone with more technical expertise than I but I did want to mention a couple of things.

You can try the updated version here: https://github.com/emanuele45/Tabbed-Smileys/releases

If you manually install this version, there is a crucial thing you absolutely must remember .... NEVER move a smiley from the first position in a tab ... there's a significant glitch that will randomize your smileys. To get around it, move another smiley to the first position, then move the smiley that was in the first spot but is now in the second to wherever you want.

Thanks for the reply Steve!
We seem to use a lot of the same MOD's  :P
& I'll keep that in mind, for if I get it installed :)


Unfortunately, that's where I found the version I'm trying to use.. :(

I can't get a parser to tell me the edits either as no version seems to be compatible? :S
Title: Re: Tabbed smileys
Post by: Steve on March 05, 2015, 05:13:08 PM
Did you try here?

http://custom.simplemachines.org/mods/index.php?mod=2782

That parses for me for 2.0.9 ....
Title: Re: Tabbed smileys
Post by: 420Connect.co.uk on March 06, 2015, 12:00:28 PM
Quote from: Steve on March 05, 2015, 05:13:08 PM
Did you try here?

http://custom.simplemachines.org/mods/index.php?mod=2782

That parses for me for 2.0.9 ....


Somehow I hadn't actually tried that, yet - lol thank you!
(although the github version is newer than the version that parses :()

I'll try it out on a test site and see how I get on  O:)
Title: Re: Tabbed smileys
Post by: Steve on March 06, 2015, 12:42:22 PM
I'm not sure how the github version works. What the heck is Elkarte and is it something that's needed to make the mod work? I confuzzled. :P
Title: Re: Tabbed smileys
Post by: Rk2910 on March 10, 2015, 06:40:51 PM
Steve, do you have an example site that has the tabbed smileys?  I think it is a great idea and should make selecting the smileys easier and the members won't have to wait to see all of them load. That's the complaint I get mostly.
Title: Re: Tabbed smileys
Post by: Rk2910 on March 10, 2015, 07:27:53 PM
Quote from: Steve on March 06, 2015, 12:42:22 PM
I'm not sure how the github version works. What the heck is Elkarte and is it something that's needed to make the mod work? I confuzzled. :P
http://www.elkarte.net/ (http://www.elkarte.net/) (hope I don't get in trouble for this)

https://theadminzone.com/forums/elkarte.524/ (https://theadminzone.com/forums/elkarte.524/)
Title: Re: Tabbed smileys
Post by: Steve on March 10, 2015, 07:41:59 PM
Quote from: Rk2910 on March 10, 2015, 06:40:51 PM
Steve, do you have an example site that has the tabbed smileys?  I think it is a great idea and should make selecting the smileys easier and the members won't have to wait to see all of them load. That's the complaint I get mostly.

Just my private forum but I'll attach a couple of images so you can see what it looks like. :)

Quote from: Rk2910 on March 10, 2015, 07:27:53 PM(hope I don't get in trouble for this)

Naw, you shouldn't. I did ask so they can yell at me if'n they want. :P
Title: Re: Tabbed smileys
Post by: Rk2910 on March 10, 2015, 08:25:05 PM
So, I installed the 0.3.7 version and it wasn't compatible. I downloaded the Beta and it installed fine with no errors but all I could get is "more" out of it, no tabs and what the instructions said didn't work, i.e. I saw no additions to the Posts and Topics menu.
Oh well.  Yours looks like what I need though.
Title: Re: Tabbed smileys
Post by: Steve on March 11, 2015, 10:26:37 AM
I'm using the 0.3.7 version and it parses for all versions of smf through 2.0.9 (which I'm on) so I'm not sure why you say it's not compatible.
Title: Re: Tabbed smileys
Post by: Rk2910 on March 11, 2015, 07:47:39 PM
I tried to install it and it told me that it was not compatible.  I'm not sure on the parsing thing - I clicked that and it dumped a lot of code but I'm not sure what to do with it, not a programmer.  I can try, some looks easy enough.
Title: Re: Tabbed smileys
Post by: Rk2910 on March 11, 2015, 08:52:47 PM
As an update I did everything that the parse said to do except the non-english language ones.  Went ok. I think, No errors as I saved each one and the site is still up ;-)
Steve, can you show me a screenshot of your smileys and message page?
I've attached mine.
I see the Tabs names and appearance (like it was in the Beta) and the area above it where I think you move your smileys (also like it was in the Beta) - notice that it says something about a popup....
I "moved" a few smileys and it created a SmallSmileys2 Tab name but now I get a "more" link below the smileys I have when I post and those 5 show up in the popup. See 2nd attachment.  So how do I get the tabs?  I looked through the Post and Topics menu but don't see anything.
Title: Re: Tabbed smileys
Post by: Steve on March 12, 2015, 09:32:43 AM
You did uninstall the Beta before installing the other one, right?

The first image is what I see when I go to Admin/Forum/Smiley.

The second is what it looks like when I click Set Smiley Order. When you select one, you'll get an arrow after every smiley and you just click the one where you want it to go. If you click the very bottom one (in a row by itself), you'll get a new tab.

Don't worry about the Popup stuff except when you're adding new smileys. Once your basic row (the first tab) is set, select the popup even though you'll have to move it to where you want after it uploads.

The third are my tabs.

Remember what I said about moving smileys from position 1 in a tab.
Title: Re: Tabbed smileys
Post by: Rk2910 on March 12, 2015, 07:33:57 PM
Quote from: Steve on March 12, 2015, 09:32:43 AM
You did uninstall the Beta before installing the other one, right?
Yup, best I remember - I've slept twice since then tough ;-) (See attached - notice that when I manually entered the parsed code it must have entered the .0.3.7 into the list??)

Quote from: Steve on March 12, 2015, 09:32:43 AM
The first image is what I see when I go to Admin/Forum/Smiley.
Same as mine

Quote from: Steve on March 12, 2015, 09:32:43 AM
The second is what it looks like when I click Set Smiley Order. When you select one, you'll get an arrow after every smiley and you just click the one where you want it to go.
I need to do some more playing with this - I'm not getting a tab, meaning in the post reply form.

Quote from: Steve on March 12, 2015, 09:32:43 AM
If you click the very bottom one (in a row by itself), you'll get a new tab.
Not sure what you mean.

Quote from: Steve on March 12, 2015, 09:32:43 AM
Don't worry about the Popup stuff except when you're adding new smileys. Once your basic row (the first tab) is set, select the popup even though you'll have to move it to where you want after it uploads.
Haven't got there yet.

Quote from: Steve on March 12, 2015, 09:32:43 AM
The third are my tabs.
I have 2 in the list but they don't show up in the reply page.   Your "Tabs appearance:" area is mucho different than mine.

Quote from: Steve on March 12, 2015, 09:32:43 AM
Remember what I said about moving smileys from position 1 in a tab.
When I get that far, I will.
Title: Re: Tabbed smileys
Post by: Steve on March 12, 2015, 07:43:40 PM
I'm not sure how to advise you from here without being able to see what's going on. And I'm not suggesting you give me access, just in case anyone thinks that. It looks like you're doing things right from what I can tell from the images. :-\
Title: Re: Tabbed smileys
Post by: Rk2910 on March 12, 2015, 07:51:34 PM
QuoteYour "Tabs appearance:" area is mucho different than mine.
Wonder where that is populated from? Notice it didn't change from the two images I posted - one with default and one with SmallSmiley2.

Yeah, I'm not getting anywhere now.  I can keep adding icons to the SmallSmileys2" tab (popup) but I can't get another tab to appear in the list.  Weird.
Title: Re: Tabbed smileys
Post by: Steve on March 12, 2015, 07:58:58 PM
Did you move a smiley to the very last down arrow? That should create a new tab. I'll get a screenshot of what I'm talking about in a sec.

Edit: screenshot added
Title: Re: Tabbed smileys
Post by: Rk2910 on March 12, 2015, 08:07:31 PM
I see that the "Tabs appearance:" is coming from Sources\Subs.php
I just did that but nothing happened - I'll try again.

Edit: I found the down arrow you're talking about and it did make a new "tab" - maybe now I'll see tabs?
Title: Re: Tabbed smileys
Post by: Rk2910 on March 12, 2015, 08:11:27 PM
See "Edit:" post above.  Thanks man.
So each "row" in the "Popup" area is a new tab? Does that mean you have to keep the number in each tab to a limit, so it doesn't go to a new row?
Title: Re: Tabbed smileys
Post by: Steve on March 12, 2015, 08:21:45 PM
Each row is not necessarily a new tab. The two rows of smileys in my last screenshot is actually one tab. My dancing bananas tab is 3 or 4 rows long on my widescreen monitor. :P

It's just the very bottom one that creates a new tab and you can rename them if scroll down to the bottom which shows all the 'Popup' rows ... again, don't worry about the word 'popup', they're actually tabs.

Btw, these tabs don't show in the quick reply box without another mod if I recall correctly.
Title: Re: Tabbed smileys
Post by: Rk2910 on March 12, 2015, 08:23:02 PM
ok, I have 3 "tabs" now but I can't get them to show up anywhere - am I missing where you enable it?

Edit:
I attached a capture of the "Popup" area and the "Tab" area
Title: Re: Tabbed smileys
Post by: Steve on March 12, 2015, 08:24:53 PM
Sorry, I edited ... are you looking for them in the normal reply box or the quick reply?
Title: Re: Tabbed smileys
Post by: Rk2910 on March 12, 2015, 08:27:42 PM
Me too. ;-)
I am only looking in the reply page, not quick reply.
Does your "popup" area look like a bunch of smileys (all the ones that used to be above)?
Title: Re: Tabbed smileys
Post by: Steve on March 12, 2015, 08:32:18 PM
When I click on 'Set Smiley Order', the attached is what I see.
Title: Re: Tabbed smileys
Post by: Rk2910 on March 12, 2015, 08:47:47 PM
That's what I thought - they all end up there and the ones left above are shown above the post area.
I think I am going to copy back out the original files and try again.  When I click on the "Edit smileys" menu I get this now, so something is wrong:
QuoteParse error: syntax error, unexpected 'if' (T_IF), expecting ',' or ';' in /home/classica/public_html/smf/Sources/ManageSmileys.php(989) : runtime-created function on line 5

Fatal error: Function name must be a string in /home/classica/public_html/smf/Sources/Subs-List.php on line 135

I think it's worth the start over to make sure I follow the parse again to make sure I didn't mess up.
Title: Re: Tabbed smileys
Post by: Rk2910 on March 12, 2015, 09:10:11 PM
Ok, I replaced all the original files, deleted both of the version out of the Package Manager and then moved all the smileys out of the "popup" area moving from farthest out back to the last remaining (first) with no problems.  So I will try it again, maybe tomorrow.  Thanks for your help Steve.
Title: Re: Tabbed smileys
Post by: Rk2910 on March 13, 2015, 05:27:17 AM
Steve, can you post a code shot of what is in the "Tabs appearance:" area at the bottom of the Set Smiley Order?  Maybe that will help me out??
Title: Re: Tabbed smileys
Post by: Steve on March 13, 2015, 08:54:34 AM
I already did, twice. :P

I've never changed anything there.
Title: Re: Tabbed smileys
Post by: Rk2910 on March 13, 2015, 06:20:16 PM
That area in your images - one doesn't show a scroll bar and one does.  Can you click inside and copy all that is in it and then post that in a "code" BBC here?  It seems that yours is way different than mine and I wanted to compare the two - if you would be so kind.  I'm thinking it must have something to do with why I get no tabs.
Title: Re: Tabbed smileys
Post by: Steve on March 13, 2015, 08:51:01 PM
ul#tabs {
overflow:auto;
list-style-type: none;
margin: 30px 0 0 0;
padding: 1px 0 0 0;
}
ul#tabs li {
float:left;
margin:0.3em 0.2em;
}
ul#tabs li a {
color: #000;
border: 1px solid #ADADAD;
border-bottom: none;
padding: 0.3em;
text-decoration: none;
}
div.tabContent {
border: 1px solid #ADADAD;
width:95%;
}
div.hide {
display: none;
}
Title: Re: Tabbed smileys
Post by: Steve on March 14, 2015, 07:04:28 PM
Making any progress Rk?
Title: Re: Tabbed smileys
Post by: Rk2910 on March 15, 2015, 10:01:28 AM
I haven't yet Steve - been out doing more fun things, i.e. sanding the bottom of my boat ;-)
Title: Re: Tabbed smileys
Post by: Steve on March 15, 2015, 11:30:28 AM
Lol ... priorities priorities ... ;D
Title: Re: Tabbed smileys
Post by: tpgames on April 21, 2016, 08:25:07 PM
 This is the official support for Tabbed Smileys and here is my issues:
1. It does not work with 2.0.11
2. Tabs link does not show up so that we can click on it to see a empty tab.
3. It is nearly impossible to move smileys because if I click on the smiley, I do not get the choice to move it to tab because Location does not give me that option. However, I might have a CSS issue that is covering up some option on that original page for "edit smileys".

4. I did find where i the code you would edit the php to make something work for real (not his mod). I had to find it myself as some people really want us to use a mod that does NOT work! And, I just want something to work.

5. I am fully aware that the person behind this mod, may have moved on to another unmentioned forum. (Which I did install, but do not have enough smileys in to even see if it works there.) I prefer SMF. I know SMF, I know where everything is and it just works for me. The mods that do work for 2.0.11 works.

Thus, I am learning PHP so that I can fix a  broken mod that does not work and will not ever do what I need. I need more than 12 silly smileys per tab or we will be clicking through 75 pages, as we will have around 900 smileys or more. Besides, I'd rather have all 60 Kanji smileys on one tab and all my fantasy smileys on another tab, and futhark-gothic on another tab, etc.
Title: Re: Tabbed smileys
Post by: Arantor on April 22, 2016, 12:42:30 AM
Um, it does more than 12 per tab as the screenshots indicate...
Title: Re: Tabbed smileys
Post by: Steve on April 22, 2016, 08:04:07 AM
Quote from: tpgames on April 21, 2016, 08:25:07 PM
This is the official support for Tabbed Smileys and here is my issues:
1. It does not work with 2.0.11

It absolutely does work with 2.0.11 ... I'm using it with no problem.

Quote2. Tabs link does not show up so that we can click on it to see a empty tab.

Not sure what you mean here.

Quote3. It is nearly impossible to move smileys because if I click on the smiley, I do not get the choice to move it to tab because Location does not give me that option. However, I might have a CSS issue that is covering up some option on that original page for "edit smileys".

When you click a smiley, does the screen not refresh and then show your smileys with a down arrow next to each?

Quote5. I need more than 12 silly smileys per tab or we will be clicking through 75 pages, as we will have around 900 smileys or more.

As Arantor said, you can put more than 12 on a tab. The attached is just one of my tabs.
Title: Re: Tabbed smileys
Post by: Arantor on April 22, 2016, 11:37:03 AM
All that happens is what the manage smileys page considers to be a row is where it delineates a new tab, the idea being to make fewer edits to the code where possible rather than making many edits for a "nicer" admin experience.
Title: Re: Tabbed smileys
Post by: tpgames on April 23, 2016, 03:35:13 PM
Here is my experience, in a fresh install test forum. those links are still not showing up to choose between tabs. Is there a setting I need to click to enable these tabs?

Forget the below. I forgot to save after every move of one smiley. :P lol (Have a laugh at me instead.)
I had finished moving smileys - Kanji. And all went well there, but when I moved another smiley and pressed the down arrow at the very bottom, it made a 3rd row. Fine. Then when I went to move another smiley, it went bezerko and rearranged all the kanji, deleted the 3rd tab from options. I was not moving the 1st smiley either, in either case. Allso, smileys A-Z went missing completely.
Title: Re: Tabbed smileys
Post by: tpgames on April 28, 2016, 01:34:43 PM
I switched to default smf theme, and mod does not work. I had uninstalled it and reinstalled it. I still get the old css sheet, as its not fully deleting, and it still does not show tabs. I even went behind the scenes into the package folder, and tabbed smileys was deleted from there.

I also moved all but 14 smileys to the pop-up, hoping that would help.

What do I need to do to get this mod to work? I went back to my preferred theme. Metin 2 blue. I also uninstalled a mod (ultimate menu).

Here is the CSS:
      div.tabContent {
         width:100%;
         overflow:auto;
         padding-bottom: 10px;
                        color: #0000ff;
      }
      div.hide {
         display: none;
      }
      div.tabContent_spacer {
         margin-top: 0.5em;
                        color: #0000ff;
      }

Note that I added text colour just to be sure that the links would show up regardless of which theme I used. I will change that colour once I get it working, as I don't use bright blue anymore.

List of Mods: Only the * ones are installed.
*1.   Bakers Dozen Pages   1.2     [ Uninstall ] [ List Files ] [ Delete ]
*2.   Fanfics System   1.3     [ Uninstall ] [ List Files ] [ Delete ]
*3.   Tabbed smileys   0.3.99c     [ Uninstall ] [ List Files ] [ Delete ]
*4.   Login Security   1.0.3     [ Uninstall ] [ List Files ] [ Delete ]
*5.   SMF Quiz   1.1.1 beta1     [ Uninstall ] [ List Files ] [ Delete ]
6.   MathJax   1.3   [ Install Mod ] [ List Files ] [ Delete ]
*7.   Yet Another YouTube BBCode Tag   3.10     [ Uninstall ] [ List Files ] [ Delete ]
8.   More Genders   1.0.1   [ Install Mod ] [ List Files ] [ Delete ]
9.   cbi 1.0   1.8.1   [ Install Mod ] [ List Files ] [ Delete ]
*10.   Tagging System   3.0     [ Uninstall ] [ List Files ] [ Delete ]
*11.   To-Do List   2.0     [ Uninstall ] [ List Files ] [ Delete ]
*12.   Global Headers Footers   2.0.1     [ Uninstall ] [ List Files ] [ Delete ]
**13.   Tabbed smileys   0.3.99c     [ Uninstall ] [ List Files ] [ Delete ]
*14.   SA Chat   1.0a1 Rev120     [ Uninstall ] [ List Files ] [ Delete ]
*15.   [BBCode] Overline   1.1     [ Uninstall ] [ List Files ] [ Delete ]
*16.   Add Favicon.ico Support   1.3     [ Uninstall ] [ List Files ] [ Delete ]

Thanks in advance!
Title: Re: Tabbed smileys
Post by: MULITRI on February 17, 2017, 02:30:01 PM
Hello Steve,

I have installed your mod into SMFv.2.1.3 and it works almost perfect.

I have a couple problems, one minor, and the other maybe is not caused by you mod... i'll start with the minor problem.

The tabs i have created to organize my smileys (4 tabs) seems like it show at right hand by default, when a row of smileys is full. But when the row isn't full, as the smileys are placed showing from left hand by default, the row of tabs moves depending how long is the row of smileys. I have attached two screenshots for you can see what i meant (if i explained it correctly hehe)

What i would like is to get the tabs centered all the time no matter the tab i select and if the row of smileys is full or it has a couple smileys.


Now the other problem, which affect the Quick Reply function. Quick Reply has actualy installed two Mods:
http://custom.simplemachines.org/mods/index.php?mod=3246
http://custom.simplemachines.org/mods/index.php?mod=3891

The first mod allows smileys and some BBcode buttons appears on the Quick Reply box, but when a smiley is clicked it doesn't appears into the message box. I would like to know if you know it could be not compatible with your mod or if there is another issue. If I uninstall that mod, the smileys aren't shown in Quick Reply, so i can't know if it will work the smileys.

I hope i have explained well my doubts, i will appreciate your help, Thanks.
Title: Re: Tabbed smileys
Post by: Steve on February 17, 2017, 05:06:00 PM
First, it's not my mod, it's emanuele's.

And second, do you mean 2.0.13 or 2.1 beta 3?
Title: Re: Tabbed smileys
Post by: MULITRI on February 17, 2017, 08:23:57 PM
Yes, sorry again, is 2.0.13
Title: Re: Tabbed smileys
Post by: FragaCampos on March 28, 2017, 03:27:16 PM
Hi there.

I've been using this mod for some years, but recently it stopped working. I mean, not totally, but almost.
I think this happened after adding a new smile to one tab's list, and now I can't seem to make it work again.
This is what happens now, the first tab is ok, but the others appear empty.  :(
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimagizer.imageshack.com%2Fimg924%2F116%2FZllOoY.png&hash=56668fffb8fff8b7c0d632b01900b293b5b3d202)

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimagizer.imageshack.com%2Fimg923%2F3410%2FXAOkIG.png&hash=1d0fa82f8e6f722a98a58e20c22a2e43e2f9a501)


Can anyone help me to try to pin down the problem?

Regards.
Title: Re: Tabbed smileys
Post by: Steve on March 29, 2017, 08:29:03 AM
Did you move a smiley from the first position in any tab section? When you go to 'Edit Smileys', are all your smileys listed?
Title: Re: Tabbed smileys
Post by: FragaCampos on March 29, 2017, 05:48:38 PM
It's probable, but I can't really remember. Meanwhile I redone the order of the smileys in the admin panel. All smileys are correctly listed there.
The tabs appear correctly in the forum's messages, but only the first one shows the smileys.
Title: Re: Tabbed smileys
Post by: Steve on March 29, 2017, 11:02:35 PM
I could take a look for you if you want but I'd need a temporary test account. If you're willing, pm me the url and account info.
Title: Re: Tabbed smileys
Post by: Steve on March 31, 2017, 01:48:46 PM
The first problem is that your forum is in a language I don't speak but I used mine to see where each link goes. :P

The bad news is, I have no idea what happened. All of your tabs are gone and I can't make it create new ones. Usually the tabs get messed up if a smiley is moved from the first position of any tab but I haven't seen it completely wipe them out before. Did you add any mods or themes just before this happened?

I'm at a loss as to how to help you short of suggesting uninstalling and reinstalling the mod. :(
Title: Re: Tabbed smileys
Post by: FragaCampos on March 31, 2017, 03:49:10 PM
Thank you for taking a look. You could switch the language to english in your profile. ;)

I believe you looked to my forum without the mod installed. Since the mod hasn't an on/off switch, I've uninstalled it, of course, because it's not working.
To see the problem, you'll have to install it.

If you have any difficulty, please contact me via PM so that we can arrange an hour to do it in sync.
Title: Re: Tabbed smileys
Post by: Steve on April 01, 2017, 08:39:47 AM
Oh! I didn't realize you had uninstalled the mod. I'd much rather take a look after you do the installation because you'll want to do backups first.
Title: Re: Tabbed smileys
Post by: FragaCampos on May 23, 2017, 11:46:23 AM
Just to note that the problem still persists.
Thank you for your help though, Steve.
Title: Re: Tabbed smileys
Post by: MadCityKaren on January 27, 2018, 03:35:09 PM
Does anyone know if this mod works with 2.0.15?  (Noting the version of the mod on github is 4 years old now ...)

I love this concept, but am leery of installing an 'older' mod.
Title: Re: Tabbed smileys
Post by: sam666 on January 27, 2018, 04:25:05 PM
0.3.99c is working fine here on 2.0.15 and PHP 7.1.13  :D
Title: Re: Tabbed smileys
Post by: inter on February 02, 2018, 09:44:43 AM
php 7.1
smf 2.0.15

Url: http://.../index.php?action=admin;area=smileys;sa=editsmileys;
Error: A non-numeric value encountered
File: /.../Sources/ManageSmileys.php(977) : runtime-created function
Line: 9
Title: Re: Tabbed smileys
Post by: kesulin on May 22, 2019, 05:05:01 AM
Quote from: MadCityKaren on January 27, 2018, 03:35:09 PM
Does anyone know if this mod works with 2.0.15?  (Noting the version of the mod on github is 4 years old now ...)

I love this concept, but am leery of installing an 'older' mod.
I try it and have problems with code in ManageSmileys.php. I force install and manual editing this part of code and work fine.
Title: Re: Tabbed smileys
Post by: shadav on August 15, 2019, 10:54:40 PM
just wanted to say thank you :) I installed the beta version on a 2.0.15, I used the package installer at first but I don't think it worked (then again I don't think I fully enabled it in the post settings :D ) so then i uninstalled and did a manual install... everything seems to be working just fine
everything is inside tabs now, so much better
Title: Re: Tabbed smileys
Post by: shadav on August 20, 2019, 09:32:43 PM
Quote from: emanuele on May 16, 2013, 05:06:02 AM
Never tried, but something like this should work.

In GenericControls.template.php remove this
Code (find) Select
tab_names[-5] = \'' . ($context['current_action']!='pm' ? $txt['tabbed_subject_and_icons'] : $txt['tabbed_to_and_subject']) . '\';

and:
Code (find) Select
tabs_content[0] = \'<div id="tab_-5_elem"></div>\';
tabs_content[0] += \'<div id="tab_-4_elem"></div>\';

Code (replace with) Select

tabs_content[0] = \'<div id="tab_-4_elem"></div>\';

and remove:
Code (find) Select
buttons_i = document.getElementById(\'post_header\');
buttons_f = document.getElementById(\'tab_-5_elem\');
buttons_f.appendChild(buttons_i);


But I'm mostly guessing...

Quote from: dimspace on May 16, 2013, 01:12:40 PM
Yeh, didnt manage it.. Left the initial tab as "undefined", the smileys didnt load and none of the buttons worked. Will have a dig around over the next few days.. should be fairly simple.. in theory..
I tried this but it didn't work :( same like dimspace said.....

any other ideas :D
i'd either like how dimspace said to exclude the subject and icon from being tabbed
or if it'd just default to the subject tab instead of the format tab

thank you  :)
Title: Re: Tabbed smileys
Post by: shadav on July 20, 2020, 10:31:52 PM
I think, I do say *think* I figured out how to make it automatically open on the subject tab
in GenericControls.template.php
find
tabbed_toggleElem(\'tab_', $modSettings['enable_tabbed_interface']==2 ? (empty($context['post_error']['no_to']) && empty($context['post_error']['no_subject']) && empty($context['post_error']['no_subject']) ? '-4' : '-5') : '0', '\');';
replace with
tabbed_toggleElem(\'tab_', $modSettings['enable_tabbed_interface']==2 ? (empty($context['post_error']['no_to']) && empty($context['post_error']['no_subject']) && empty($context['post_error']['no_subject']) ? '-5' : '-4') : '0', '\');';

need to test more but so far it seems to have worked
Title: Re: Tabbed smileys
Post by: shadav on February 03, 2021, 10:43:35 AM
this needs updated for 2.0.18  :P

I tried but.....

Sources/ManageSmileys.php

find
'function' => function($rowData) use ($txt)
{
if (empty($rowData['hidden']))
return $txt['smileys_location_form'];
elseif ($rowData['hidden'] == 1)
return $txt['smileys_location_hidden'];
else
return $txt['smileys_location_popup'];
},
'class' => 'windowbg',
),



replace
'function' => function($rowData) use ($txt,$modSettings)
{
if (empty($rowData['hidden']))
return $txt['smileys_location_form'];
elseif ($rowData['hidden'] == 1)
return $txt['smileys_location_hidden'];
else
return $txt['smileys_location_popup'] . ' (' . $txt['tabbed_smileys_tab']. ': ' . (!empty($modSettings['tabbed_smileys']['popup'][$rowData['smiley_row']+1]) ? $modSettings['tabbed_smileys']['popup'][$rowData['smiley_row']+1] : ($txt['additional_smileys'] . ' ' . $rowData['smiley_row']+1)) . ')';
},
'class' => 'windowbg',
),

*thanks to antechinus about removing the escaping
*thanks to vbgamer posting as well, I'd forgotten the $modSettings

now this "works" but with errors, which leads me to think it doesn't really work

https://4rearth.info/index.php?action=admin;area=smileys;sa=addsmiley;d09f57ca07=f431d589b62f7f89057007b9bf7f94ef
2: count(): Parameter must be an array or an object that implements Countable
File: /Themes/default/ManageSmileys.template.php
Line: 409

same error on
Line: 405


before I saw vbgamers post with the modsetting added I was also getting this error but it hasn't shown up since adding modsettings

https://4rearth.info/index.php?action=admin;area=smileys;sa=editsmileys;e4574a5d2d=6cc4fb60517be7505f10dc5de49737cd
2: A non-numeric value encountered
File: /Sources/ManageSmileys.php
Line: 1029

so well hopefully someone else can figure it out
Title: Re: Tabbed smileys
Post by: FragaCampos on March 27, 2021, 02:39:00 PM
This (https://www.simplemachines.org/community/index.php?topic=577252.msg4085655#msg4085655) change by Kindred worked for me.


I also changed the ($text) to ($txt, $modSettings).
Title: Re: Tabbed smileys
Post by: shadav on March 27, 2021, 05:40:42 PM
see the post above yours, the one that I linked you to... ;) you'll also need to add the modsettings

and well there's still some errors popping up in the logs, but at least it works
Title: Re: Tabbed smileys
Post by: FragaCampos on March 27, 2021, 07:08:47 PM
I did add the modsettings and I have no errors in the log...
Title: Re: Tabbed smileys
Post by: FrizzleFried on March 05, 2022, 08:24:21 AM
My userbase loved this mod on 2.0.x .... I'd love to see it modified to work with 2.1.x..

Title: Re: Tabbed smileys
Post by: Steve on March 05, 2022, 08:26:39 AM
Heck, I'd just like to see it updated at all.
Title: Re: Tabbed smileys
Post by: FrizzleFried on April 18, 2022, 07:41:41 PM
Really missing this mod.  The pop-up "page" that the stock system uses is a pretty weak substitute for those of us who have lots of smileys.
Title: Re: Tabbed smileys
Post by: Steve on April 19, 2022, 05:21:06 AM
+1
Title: Re: Tabbed smileys
Post by: sam666 on April 22, 2022, 04:44:43 AM
This is the one mod that's stopping me from using 2.1.1  :(
Title: Re: Tabbed smileys
Post by: FrizzleFried on April 22, 2022, 08:39:21 AM
SMF 2.1.x is worth the upgrade without the mod.  That said... it would be REAL NICE to get this mod working for 2.1.x or come up with something similar.  I've cut out about 1/2 of our smileys and even then you have to scroll down the "single page" that pops up with the stock system... to get to the exit button.

This is probably now close to if now the top mod I'd love seen re-worked.
Title: Re: Tabbed smileys
Post by: FrizzleFried on April 22, 2022, 11:32:50 AM
Heck... if this was reworked in to a hooks-only mod,  I'm sure it could be sold for a few bucks... i'd cough up a few bucks for this functionality...
Title: Re: Tabbed smileys
Post by: Steve on April 22, 2022, 12:16:13 PM
You and me both.
Title: Re: Tabbed smileys
Post by: shadav on April 22, 2022, 12:22:37 PM
+1
I really really need this for 2.1  :P
Title: Re: Tabbed smileys
Post by: Steve on April 22, 2022, 05:54:21 PM
Considering it never completely worked with 2.0 I don't hold out much hope.
Title: Re: Tabbed smileys
Post by: FrizzleFried on April 22, 2022, 06:00:08 PM
Really?  I had zero problems with my install.  That said,  admittedly,  my 2.0.x forum stopped at 2.0.9...

;)

Title: Re: Tabbed smileys
Post by: Steve on April 22, 2022, 06:01:07 PM
The install wasn't the problem. It had glitches, especially when moving smileys.
Title: Re: Tabbed smileys
Post by: MIAUS on November 20, 2022, 04:14:01 PM
I would also love to see this in 2.1 - I'd pay for this!
Title: Re: Tabbed smileys
Post by: Steve on November 20, 2022, 06:13:25 PM
Quote from: MIAUS on November 20, 2022, 04:14:01 PMI would also love to see this in 2.1 - I'd pay for this!
Please don't double post.