Simple Machines Community Forum

Customizing SMF => Modifications and Packages => Topic started by: OutofOrder on June 17, 2009, 10:08:41 AM

Title: Good Post/Bad Post Mod
Post by: OutofOrder on June 17, 2009, 10:08:41 AM
Good Post/Bad Post Mod v2.0.4
- click to go to the download page  - (http://custom.simplemachines.org/mods/index.php?mod=1890)
Updated: December 11th 2010

This Mod will add post voting to your forum in a user-moderated fashion. The outcome is a bit of help to the forum moderators, with the nice extra that it resembles democracy a little. It gives members and moderators a general idea of who's a worthy poster and who isn't.

Features
The following features are supported in both SMF 1.1.x and SMF 2 RC3+:
New in GP/BP v2.0+!
SMF 2 RC3+ installations also support these features:

Languages supported
GP/BP v2.0+ is currently supporting these languages:
GP/BP v1.1.3 is currently supporting these languages:
New/Updated translations are welcomed and very appreciated. :D

Much special thanks to Php Coder Turkish, kakanika & Bugo for the Turkish, French and Russian translations respectively!



Changelog
Version 2.0.4 - December 11 2010
Version 2.0.3 - September 30 2010
Version 2.0.2 - September 29 2010
Version 2.0.1 - March 11 2010
Version 2.0 - March 5 2010
Version 1.1.3 - February 19 2010
Version 1.1.2 - July 15 2009
Version 1.1.1 - June 26 2009
Version 1.1 - June 20 2009
Version 1.0 - June 17 2009
Title: Re: Good Post/Bad Post Mod
Post by: Antes on June 17, 2009, 10:45:46 AM
Sweet Mod ...

Link To Mod (//http://) Missing

and >
Title: Re: Good Post/Bad Post Mod
Post by: heinandar on June 17, 2009, 12:29:43 PM
Hoping for 1.1.9
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on June 17, 2009, 12:35:12 PM
Hi Antes, thanks for trying it out.
Edit: judging by the screenshot, it looks like you haven't given the proper permissions to vote (if you wanted the arrows to show up). Please enable the Good Post/Bad Post permissions for those membergroups you want to participate with it.

I'm going to add a guide for forum admins to make this mod work with custom themes. :) I'll soon have an update on this.


Quote from: heinandar on June 17, 2009, 12:29:43 PM
Hoping for 1.1.9
Hello heinandar. I have not considered to make a 1.1.9 version of it, mainly because having to support the two versions is a task I'm not sure I want to do yet.
Title: Re: Good Post/Bad Post Mod
Post by: franklinrony on June 17, 2009, 02:33:05 PM
excellent job like social websites
Title: Re: Good Post/Bad Post Mod
Post by: Özgür on June 17, 2009, 06:00:53 PM
Finally! Thanks OutofOrder. Can i translate to turkish ?
Title: Re: Good Post/Bad Post Mod
Post by: 4Kstore on June 17, 2009, 06:56:12 PM
Thanks, this is a nice mod!!!
Title: Re: Good Post/Bad Post Mod
Post by: Sakae on June 17, 2009, 11:38:39 PM
Great MOD!! I was hoping for this for a long time... I was using Thank-o-Matic, and wanted to install it twice to use one as "Thank you" (original) and other as "Get out" (as opposite).

I believe I can do it with this MOD now!
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on June 18, 2009, 08:14:37 AM
Thanks for your comments everyone.
Quote from: [Daydreamer] on June 17, 2009, 06:00:53 PM
Finally! Thanks OutofOrder. Can i translate to turkish ?
Yes, please go ahead :) New mod translations are welcome.


Edit: i'm planning to update this Mod in order to make it friendlier with custom Themes. It currently works well with themes that are based on the default theme layout, but it needs much tweaking when installed in other themes.
Title: Re: Good Post/Bad Post Mod
Post by: Antes on June 18, 2009, 08:35:10 AM
Quote from: OutofOrder on June 18, 2009, 08:14:37 AM
Thanks for your comments everyone.
Quote from: [Daydreamer] on June 17, 2009, 06:00:53 PM
Finally! Thanks OutofOrder. Can i translate to turkish ?
Yes, please go ahead :) New mod translations are welcome.


Edit: i'm planning to update this Mod in order to make it friendlier with custom Themes. It currently works well with themes that are based on the default theme layout, but it needs much tweaking when installed in other themes.

Thx For Help , Can we edit this mod towards to "Only For Topic ?"

i want to mean > i'm playing eRepublik and this game had a newspaper system every News can get vote ( more vote goes ur news to upper ) ?

i'm trying to make a special space for "news" and this mod can help me about it :)
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on June 18, 2009, 08:54:53 AM
Quote from: Antes on June 18, 2009, 08:35:10 AM
Thx For Help , Can we edit this mod towards to "Only For Topic ?"

i want to mean > i'm playing eRepublik and this game had a newspaper system every News can get vote ( more vote goes ur news to upper ) ?

i'm trying to make a special space for "news" and this mod can help me about it :)
I'm not sure what you're asking, but it seems to be this: Do you want to change the order of the topics in the topic list? And order them using the votes each first post of the topic has?
Title: Re: Good Post/Bad Post Mod
Post by: Antes on June 18, 2009, 09:06:47 AM
Quote from: OutofOrder on June 18, 2009, 08:54:53 AM
Quote from: Antes on June 18, 2009, 08:35:10 AM
Thx For Help , Can we edit this mod towards to "Only For Topic ?"

i want to mean > i'm playing eRepublik and this game had a newspaper system every News can get vote ( more vote goes ur news to upper ) ?

i'm trying to make a special space for "news" and this mod can help me about it :)
I'm not sure what you're asking, but it seems to be this: Do you want to change the order of the topics in the topic list? And order them using the votes each first post of the topic has?

Simply yes xD Only Vote Topic ( but only +1 Vote ) +Closed News Vote became 0 , or Closed News not shown in Recent News Place
Title: Re: Good Post/Bad Post Mod
Post by: crazyASD on June 18, 2009, 10:16:16 AM
1.1.x version Please!!!!
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on June 18, 2009, 12:13:05 PM
Quote from: Antes on June 18, 2009, 09:06:47 AM
Quote from: OutofOrder on June 18, 2009, 08:54:53 AM
Quote from: Antes on June 18, 2009, 08:35:10 AM
Thx For Help , Can we edit this mod towards to "Only For Topic ?"

i want to mean > i'm playing eRepublik and this game had a newspaper system every News can get vote ( more vote goes ur news to upper ) ?

i'm trying to make a special space for "news" and this mod can help me about it :)
I'm not sure what you're asking, but it seems to be this: Do you want to change the order of the topics in the topic list? And order them using the votes each first post of the topic has?

Simply yes xD Only Vote Topic ( but only +1 Vote ) +Closed News Vote became 0 , or Closed News not shown in Recent News Place
Unfortunately, this mod is not meant to do this. :-[ It is not the idea for which it was made.
You could try the Topic ratings mod (http://custom.simplemachines.org/mods/index.php?mod=91), which lets you rate topics individually and sort the board by topic rating. Hope this helps.
Title: Re: Good Post/Bad Post Mod
Post by: Sakae on June 18, 2009, 12:19:16 PM
OutofOrder, what about a description instead of positive/negative numbers, would be possible?

I mean, if one post is rated 5 times negative, it shows simply "Bad post" instead of "-5". And for +5, it shows "Good post".

What do you think?
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on June 18, 2009, 01:07:48 PM
Quote from: softcore on June 18, 2009, 12:19:16 PM
OutofOrder, what about a description instead of positive/negative numbers, would be possible?

I mean, if one post is rated 5 times negative, it shows simply "Bad post" instead of "-5". And for +5, it shows "Good post".

What do you think?
It might work, but I'm not sure if the number should be replaced. The number is a reference to how much a post is worthy/not worthy according to the community.
Right now, if a post becomes a "Bad post", it is hidden by default so you would visually find out that it is in fact a "Bad post". Is there the need to even make it more clear?
Or perhaps you were thinking about a board set to bypass the "Bad posts" effects (hiding/greying-out) but still using post voting?
However, adding a "Good post!" (or a new icon) next to the number when it goes positive might be a nice option. :)
Title: Re: Good Post/Bad Post Mod
Post by: Paracelsus on June 18, 2009, 02:59:57 PM
Quote from: OutofOrder on June 17, 2009, 12:35:12 PM
Quote from: heinandar on June 17, 2009, 12:29:43 PM
Hoping for 1.1.9
Hello heinandar. I have not considered to make a 1.1.9 version of it, mainly because having to support the two versions is a task I'm not sure I want to do yet.

You could release a sort of "legacy" version for 1.1.9 that wouldn't get any support, just exist "as it is". For instance, I would very very pleased to be able to try this, because I can imagine it will still take many months for me to migrate to SMF 2.0.


Btw, one thing that I suggested before to Karma Mods that I think would be useful: the relative weight of voting for good and bad post according to membergroup. For instance, group A (let's say Admins) would have a weight of 10, group B (let's say Content Reviewers) a weight of 20 and group C (Regular Users) would weight just 1.
Title: Re: Good Post/Bad Post Mod
Post by: Sakae on June 19, 2009, 01:07:55 PM
Quote from: OutofOrder on June 18, 2009, 01:07:48 PM
It might work, but I'm not sure if the number should be replaced. The number is a reference to how much a post is worthy/not worthy according to the community.
Right now, if a post becomes a "Bad post", it is hidden by default so you would visually find out that it is in fact a "Bad post". Is there the need to even make it more clear?
Or perhaps you were thinking about a board set to bypass the "Bad posts" effects (hiding/greying-out) but still using post voting?
However, adding a "Good post!" (or a new icon) next to the number when it goes positive might be a nice option. :)

In matter of fact, my purpose of using this MOD is different from the original. My forum has some political boards, which may be a problem using this modification, since it's not "good/bad" what people think about the posts, but, like "agree/disagree" of them. I'll use just the system, but will translate different, get it? :)

That's why I don't use "disappear function" as default (therefore I had to reset all my members profile), but just some note of general opinion about the post (for -5 or less, "Post out of line" or whatever).

But if it's possible to do only with positive posts, I'll understand :)
Title: Re: Good Post/Bad Post Mod
Post by: Mystery? on June 19, 2009, 02:03:47 PM
Can you have an option, to increase/decrease overall karma.
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on June 19, 2009, 03:33:34 PM
Thanks everyone for the posts.

Quote from: Paracelsus on June 18, 2009, 02:59:57 PM
You could release a sort of "legacy" version for 1.1.9 that wouldn't get any support, just exist "as it is". For instance, I would very very pleased to be able to try this, because I can imagine it will still take many months for me to migrate to SMF 2.0.
Well, releasing a legacy version sounds like a good idea :) It won't be happening very soon though.
About your suggestions, what kind of forum would these apply to? Sounds like adding an entire new dimension to the mod.

Quote from: softcore on June 19, 2009, 01:07:55 PM
Quote from: OutofOrder on June 18, 2009, 01:07:48 PM
It might work, but I'm not sure if the number should be replaced. The number is a reference to how much a post is worthy/not worthy according to the community.
Right now, if a post becomes a "Bad post", it is hidden by default so you would visually find out that it is in fact a "Bad post". Is there the need to even make it more clear?
Or perhaps you were thinking about a board set to bypass the "Bad posts" effects (hiding/greying-out) but still using post voting?
However, adding a "Good post!" (or a new icon) next to the number when it goes positive might be a nice option. :)

In matter of fact, my purpose of using this MOD is different from the original. My forum has some political boards, which may be a problem using this modification, since it's not "good/bad" what people think about the posts, but, like "agree/disagree" of them. I'll use just the system, but will translate different, get it? :)

That's why I don't use "disappear function" as default (therefore I had to reset all my members profile), but just some note of general opinion about the post (for -5 or less, "Post out of line" or whatever).

But if it's possible to do only with positive posts, I'll understand :)
Now it makes more sense. :) I'll consider about it. I suppose there could be an option to change the semantic "Good/Bad" to "Agreed/Disagreed". The same with "Respect" changing to "General agreement" (I suppose you disabled the Respect counter). I wonder how often this kind of need would arise tho.

Quote from: Mystery? on June 19, 2009, 02:03:47 PM
Can you have an option, to increase/decrease overall karma.
In the future, there may be an advanced tool to edit users Respect and casted votes.
Title: Re: Good Post/Bad Post Mod
Post by: Paracelsus on June 19, 2009, 04:42:27 PM
Quote from: OutofOrder on June 19, 2009, 03:33:34 PM
About your suggestions, what kind of forum would these apply to? Sounds like adding an entire new dimension to the mod.

The suggestion is simple. Instead of 1 member / 1 vote, allow to customize the number of votes that each member can give, depending on which membergroup the user is in. Shouldn't be too complicated I think.
Title: Re: Good Post/Bad Post Mod
Post by: [Core] on June 19, 2009, 05:38:34 PM
Nice mod
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on June 20, 2009, 11:16:42 AM
I'm about to update the mod. The 1.0 version comes with a bug that breaks Profile.template.php, which I'm surprised hasn't been reported yet. It innocently sneaked in the release version without me noticing about it >:(
This has been fixed in version 1.1. It is recommended that you uninstall 1.0 first, and then install 1.1 (the Package parser currently behaves buggy when trying to uninstall an upgraded version in SMF 2 RC1-1).
Title: Re: Good Post/Bad Post Mod
Post by: Sakae on June 20, 2009, 01:22:00 PM
Quote from: OutofOrder on June 20, 2009, 11:16:42 AM
I'm about to update the mod. The 1.0 version comes with a bug that breaks Profile.template.php, which I'm surprised hasn't been reported yet. It innocently sneaked in the release version without me noticing about it >:(
This has been fixed in version 1.1. It is recommended that you uninstall 1.0 first, and then install 1.1 (the Package parser currently behaves buggy when trying to uninstall an upgraded version in SMF 2 RC1-1).

Sorry about that, I noticed this BUG but since I was installing a lot of MODs same time, didn't have time to see which MOD had it..
Title: Re: Good Post/Bad Post Mod
Post by: MaXiForum.cz on June 20, 2009, 03:11:10 PM
Realy nice mod :)
Congratulation ;)
Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on June 20, 2009, 07:02:23 PM
Very nice mod :)

Quote from: OutofOrder on June 19, 2009, 03:33:34 PM
... releasing a legacy version sounds like a good idea :) ...

Sweet!
Saves me time converting it myself lol ;)
Title: Re: Good Post/Bad Post Mod
Post by: Mystery? on June 21, 2009, 12:11:16 AM
Quote from: OutofOrder on June 19, 2009, 03:33:34 PM
Quote from: Mystery? on June 19, 2009, 02:03:47 PM
Can you have an option, to increase/decrease overall karma.
In the future, there may be an advanced tool to edit users Respect and casted votes.

I meant overall karma as in the karma system SMF uses. Like if you get 1 negative vote for a post it also decreases your karma by 1 point.
Title: Re: Good Post/Bad Post Mod
Post by: Dream of Omnimaga on June 21, 2009, 12:28:11 AM
wow really hoping for a 1.1.9 version in the future. I've been waiting for such mod for over 1 year now, but I don't want to migrate to 2.0 until it's completly finished.
Title: Re: Good Post/Bad Post Mod
Post by: Smitten on June 21, 2009, 12:49:30 AM
Yeaah, 1.1.9 version please!!

Excelent mod..
Title: Re: Good Post/Bad Post Mod
Post by: marciano on June 21, 2009, 01:30:48 PM
la version para 1.1.9 por favorrrrr
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on June 21, 2009, 02:25:55 PM
Thanks everyone for your posts.

Quote from: Mystery? on June 21, 2009, 12:11:16 AM
Quote from: OutofOrder on June 19, 2009, 03:33:34 PM
Quote from: Mystery? on June 19, 2009, 02:03:47 PM
Can you have an option, to increase/decrease overall karma.
In the future, there may be an advanced tool to edit users Respect and casted votes.

I meant overall karma as in the karma system SMF uses. Like if you get 1 negative vote for a post it also decreases your karma by 1 point.
Sorry, I understand now :) Actually, when I was planning the mod I considered to link post voting to the SMF karma system as an option, but discarded it soon because I'm not familiar with the karma scripts. Maybe in a future version, or if more people request this.

Quote from: everyone1.1.9
I've started to port this mod to SMF 1.1.x, so please check back soon ;)
Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on June 21, 2009, 02:33:49 PM
Quote from: OutofOrder on June 21, 2009, 02:25:55 PM
I've started to port this mod to SMF 1.1.x, so please check back soon ;)

Mate Ive been checking here everyday!! lol
Thank You for your efforts :)
Title: Re: Good Post/Bad Post Mod
Post by: Dream of Omnimaga on June 21, 2009, 03:03:34 PM
Cool, I just hope SMF won't release 2.0 like the day after you post a 1.1.9 update and decide to completly stop ever updating SMF 1.1.9 and tell everyone to upgrade to 2.0 (like PHPBB did a year ago with PHPBB2) x.x this would be rather frustrating for mod coders IMHO x.x
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on June 21, 2009, 07:40:54 PM
Haha well, for what I've read around these forums, there is going to be another RC release before SMF 2 goes final. So the chances of that happening by the time I finish this are none at all :P
Title: Re: Good Post/Bad Post Mod
Post by: goldenboy48 on June 22, 2009, 05:47:36 AM
looks very nice...hoping for support for 1.1.9
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on June 26, 2009, 12:06:59 PM
And it's done. :) Mod updated, added support for SMF 1.1.9.

No new features though. SMF 2 Admins don't need to upgrade this time, unless they want to keep up with the version number :)
Title: Re: Good Post/Bad Post Mod
Post by: marciano on June 26, 2009, 12:42:16 PM
gracias maestro
Title: Re: Good Post/Bad Post Mod
Post by: marciano on June 26, 2009, 01:25:53 PM
lo instale en foringa .... tuve que editar a mano (seguramente por tantos mods que tengo instalados) los archivos Subs.php y Load.php ambos de la carpeta sources y anduvo joya ..... sos un groso master
Title: Re: Good Post/Bad Post Mod
Post by: Paracelsus on June 26, 2009, 03:06:26 PM
Quote from: OutofOrder on June 26, 2009, 12:06:59 PM
And it's done. :) Mod updated, added support for SMF 1.1.9.

Great, I'll try it soon then.
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on June 26, 2009, 03:19:13 PM
Quote from: marciano on June 26, 2009, 01:25:53 PM
lo instale en foringa .... tuve que editar a mano (seguramente por tantos mods que tengo instalados) los archivos Subs.php y Load.php ambos de la carpeta sources y anduvo joya ..... sos un groso master
Me alegro mucho, un placer :)
Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on June 26, 2009, 06:52:07 PM
Quote from: OutofOrder on June 26, 2009, 12:06:59 PM
And it's done. :) Mod updated, added support for SMF 1.1.9.

Awesome!!  Thanks mate :)

Display.php
change

img_gpbp_up=new Image;img_gpbp_up.src=smf_images_url+"/images/gpbp_arrow_up.gif";img_gpbp_up_lit=new Image;img_gpbp_up_lit.src=smf_images_url+"/images/gpbp_arrow_up_lit.gif";img_gpbp_down=new Image;img_gpbp_down.src=smf_images_url+"/images/gpbp_arrow_down.gif";img_gpbp_down_lit=new Image;img_gpbp_down_lit.src=smf_images_url+"/images/gpbp_arrow_down.png";

to
img_gpbp_up=new Image;img_gpbp_up.src=smf_images_url+"/gpbp_arrow_up.gif";img_gpbp_up_lit=new Image;img_gpbp_up_lit.src=smf_images_url+"/gpbp_arrow_up_lit.gif";img_gpbp_down=new Image;img_gpbp_down.src=smf_images_url+"/gpbp_arrow_down.gif";img_gpbp_down_lit=new Image;img_gpbp_down_lit.src=smf_images_url+"/gpbp_arrow_down.gif";

;)
Title: Re: Good Post/Bad Post Mod
Post by: marciano on June 26, 2009, 08:51:24 PM
Quote from: Sabre™ on June 26, 2009, 06:52:07 PM
Quote from: OutofOrder on June 26, 2009, 12:06:59 PM
And it's done. :) Mod updated, added support for SMF 1.1.9.

Awesome!!  Thanks mate :)

Display.php
change

img_gpbp_up=new Image;img_gpbp_up.src=smf_images_url+"/images/gpbp_arrow_up.gif";img_gpbp_up_lit=new Image;img_gpbp_up_lit.src=smf_images_url+"/images/gpbp_arrow_up_lit.gif";img_gpbp_down=new Image;img_gpbp_down.src=smf_images_url+"/images/gpbp_arrow_down.gif";img_gpbp_down_lit=new Image;img_gpbp_down_lit.src=smf_images_url+"/images/gpbp_arrow_down.png";

to
img_gpbp_up=new Image;img_gpbp_up.src=smf_images_url+"/gpbp_arrow_up.gif";img_gpbp_up_lit=new Image;img_gpbp_up_lit.src=smf_images_url+"/gpbp_arrow_up_lit.gif";img_gpbp_down=new Image;img_gpbp_down.src=smf_images_url+"/gpbp_arrow_down.gif";img_gpbp_down_lit=new Image;img_gpbp_down_lit.src=smf_images_url+"/gpbp_arrow_down.gif";

;)


para que ese cambio?
Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on June 27, 2009, 01:15:08 AM
It is for the code written for smf 1.1.9

The first code points to a folder in the images folder named "images", which does not exist.
It would only work if the previous code were  src=smf_default_theme_url+"/images/gpbp_arrow_up.gif etc etc..
or by removing the search for the second images folder, as shown above.

Also changing gpbp_arrow_down.png to gpbp_arrow_down.gif


This got the "hide and shade" feature working for my custom themes.

Display.php
Changed
// Perhaps we'll just use the default template, then...
elseif (file_exists($settings['default_theme_dir'] . '/' . $template_name . '.template.php'))
$context['html_headers'] = '
<link rel="stylesheet" type="text/css" href="' . $settings['default_theme_url'] . '/gpbp.css' . '" />';


to
// Perhaps we'll just use the default template, then...
elseif (file_exists($settings['default_theme_dir'] . '/gpbp.css'))
$context['html_headers'] = '
<link rel="stylesheet" type="text/css" href="' . $settings['default_theme_url'] . '/gpbp.css' . '" />';


It may help for others experiencing problems with it displaying on their custom themes also :)
Title: Re: Good Post/Bad Post Mod
Post by: heinandar on June 27, 2009, 08:36:17 AM
Hi...
I want to show ' who vote this post' like thank you mod. How can i code that.
Anyone can help?
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on June 28, 2009, 06:27:32 PM
Quote from: Sabre™ on June 26, 2009, 06:52:07 PM
Quote from: OutofOrder on June 26, 2009, 12:06:59 PM
And it's done. :) Mod updated, added support for SMF 1.1.9.

Awesome!!  Thanks mate :)

Display.php
change

img_gpbp_up=new Image;img_gpbp_up.src=smf_images_url+"/images/gpbp_arrow_up.gif";img_gpbp_up_lit=new Image;img_gpbp_up_lit.src=smf_images_url+"/images/gpbp_arrow_up_lit.gif";img_gpbp_down=new Image;img_gpbp_down.src=smf_images_url+"/images/gpbp_arrow_down.gif";img_gpbp_down_lit=new Image;img_gpbp_down_lit.src=smf_images_url+"/images/gpbp_arrow_down.png";

to
img_gpbp_up=new Image;img_gpbp_up.src=smf_images_url+"/gpbp_arrow_up.gif";img_gpbp_up_lit=new Image;img_gpbp_up_lit.src=smf_images_url+"/gpbp_arrow_up_lit.gif";img_gpbp_down=new Image;img_gpbp_down.src=smf_images_url+"/gpbp_arrow_down.gif";img_gpbp_down_lit=new Image;img_gpbp_down_lit.src=smf_images_url+"/gpbp_arrow_down.gif";

;)

Oops. Thanks for pointing it out!

Quote from: heinandar on June 27, 2009, 08:36:17 AM
Hi...
I want to show ' who vote this post' like thank you mod. How can i code that.
Anyone can help?
Some guidelines: You can do that by fetching the voters list from the log_gpbp table. Search for votes for each message from distinct id_member fields (the voters). Gather them in an array (per message), then display them in your theme :)
Title: Re: Good Post/Bad Post Mod
Post by: heinandar on June 29, 2009, 01:44:41 AM


Quote from: heinandar on June 27, 2009, 08:36:17 AM
Hi...
I want to show ' who vote this post' like thank you mod. How can i code that.
Anyone can help?
Some guidelines: You can do that by fetching the voters list from the log_gpbp table. Search for votes for each message from distinct id_member fields (the voters). Gather them in an array (per message), then display them in your theme :)
[/quote]
Thanks for your reply. I can't do it by myself because i'm not a programmer and i don't know php well.
So pls... if you have time, pls help me.
Many Thanks
Title: Re: Good Post/Bad Post Mod
Post by: Paracelsus on June 29, 2009, 06:49:17 AM
Quote from: heinandar on June 27, 2009, 08:36:17 AM
Hi...
I want to show ' who vote this post' like thank you mod. How can i code that.
Anyone can help?

That would be nice... I'll wait for some programmer to patch this up.


Btw OutofOrder, there should exist a permission to allow / disallow to receive votes in posts. For example, if I want to avoid that Admin posts be hidden, it should be possible to select this group NOT to receive votes in their posts.
Title: Re: Good Post/Bad Post Mod
Post by: Paracelsus on June 29, 2009, 12:07:29 PM
The MOD works well in 1.1.9, although I had to make several changes in Display.Template.php due to the custom theme I'm using.

Still I get this error in Firebug's console:
PostVoting is not defined
var oVotePost = new PostVoting({
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on June 29, 2009, 08:57:40 PM
Quote from: Paracelsus on June 29, 2009, 12:07:29 PM
The MOD works well in 1.1.9, although I had to make several changes in Display.Template.php due to the custom theme I'm using.

Still I get this error in Firebug's console:
PostVoting is not defined
var oVotePost = new PostVoting({
Please check in Firebug that the browser has correctly loaded the gpbp.js file. If this is the case, clear your cache and reload the page.
You can do the check by going to the "Script" tab, then clicking on the script url (it will drop down the list of every JS scripts loaded) and selecting "gpbp.js". If it didn't load it properly, it will show an empty script.
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on June 29, 2009, 09:01:15 PM
Quote from: heinandar on June 29, 2009, 01:44:41 AM
Quote from: OutofOrder on June 28, 2009, 06:27:32 PM
Quote from: heinandar on June 27, 2009, 08:36:17 AM
Hi...
I want to show ' who vote this post' like thank you mod. How can i code that.
Anyone can help?
Some guidelines: You can do that by fetching the voters list from the log_gpbp table. Search for votes for each message from distinct id_member fields (the voters). Gather them in an array (per message), then display them in your theme :)
Thanks for your reply. I can't do it by myself because i'm not a programmer and i don't know php well.
So pls... if you have time, pls help me.
Many Thanks
Can you please show me a screenshot of the Thank you mod in action, displaying who used it?
I'm not sure how to add a list (that may be really long if the forum is active enough) and display it without disrupting the thread page or that turns out annoying for the user.

Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on June 29, 2009, 09:27:51 PM
You could make it permission based  eg.. only admins and/or mods can see who voted.
And to keep the board/thread clean, make it a dropdown so they are only viewable when clicked.

Just throwing in ideas ;)

Edit
You could look at [THIS] (http://custom.simplemachines.org/mods/index.php?mod=347) for an idea :)
Title: Re: Good Post/Bad Post Mod
Post by: Paracelsus on June 30, 2009, 03:27:14 AM
Quote from: OutofOrder on June 29, 2009, 08:57:40 PM
Quote from: Paracelsus on June 29, 2009, 12:07:29 PM
The MOD works well in 1.1.9, although I had to make several changes in Display.Template.php due to the custom theme I'm using.

Still I get this error in Firebug's console:
PostVoting is not defined
var oVotePost = new PostVoting({
Please check in Firebug that the browser has correctly loaded the gpbp.js file. If this is the case, clear your cache and reload the page.
You can do the check by going to the "Script" tab, then clicking on the script url (it will drop down the list of every JS scripts loaded) and selecting "gpbp.js". If it didn't load it properly, it will show an empty script.

You're right, it hasn't loaded gpbp.js file at all. The other scripts I run are related to google analytics and gfeedfetcher.js from DynamicDrive. Can it be a conflict between some of these scripts?
Title: Re: Good Post/Bad Post Mod
Post by: djkmmo on June 30, 2009, 05:12:34 AM
Hi!

I just installed this mod and it seems great. It's just one tiny thing: it fills up my error log with the following message:

8: Undefined variable: template_name
Fil: /home/djkmmo/gnubuntu.co.cc/forum/Sources/Display.php
Rad: 102


Line 102 is:
      elseif (file_exists($settings['default_theme_dir'] . '/' . $template_name . '.template.php'))
Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on June 30, 2009, 05:19:00 AM
Youre using smf 1.1.9 and a custom theme?
You could change that line to
      elseif (file_exists($settings['default_theme_dir'] . '/gpbp.css'))

There maybe another way to correct the error, but until someone mentions it, this is the way.
Title: Re: Good Post/Bad Post Mod
Post by: djkmmo on June 30, 2009, 05:45:56 AM
Quote from: Sabre™ on June 30, 2009, 05:19:00 AM
Youre using smf 1.1.9 and a custom theme?
You could change that line to
      elseif (file_exists($settings['default_theme_dir'] . '/gpbp.css'))

There maybe another way to correct the error, but until someone mentions it, this is the way.

Ok, but that has other side effects on the custom theme. The arrows and news banner is missplaced when I replace line 102 with that.
Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on June 30, 2009, 06:27:38 AM
hmmm ok..
Remove that code and put the other back then, you'll have to wait for OutofOrder to look into it.
It worked well on each theme I used, which is why I mentioned it.

Good luck :)
Title: Re: Good Post/Bad Post Mod
Post by: Sevgiformu.com on June 30, 2009, 07:17:30 AM
Very nice mod. thank you.

turkish translate.

./Themes/default/languages/Help.turkish.php

Find.

?>

Add Before.

// Good Post/Bad Post mod strings
$helptxt['gpbp_threshold'] = 'Her kullanıcı bağlı olarak \ 'Tema ve Düzen yapılandırması vardır, bu Modifiyeyi , git, ya da tümünü (tneden olabilir hata ?) silik görüntüleniyorsa. <br /> <br /> <b> Tekraklama yapma mesjalarda, normal haline geri dön.</b>';
$helptxt['gpbp_display_respect'] = 'Konudun Kalitesi İçin Kullanılan Oylama sistemidir, her konu ayrı değerlendirilir.';




./Themes/default/languages/Who.turkish.php

Find.

?>

Add Before.

// Good Post/Bad Post: it may be nice to let users know of this.
$txt['whotopic_gpbp'] = 'Oylama Bir İleti İçindir &quot;<a href="' . $scripturl . '?topic=%d.0">%s</a>&quot;.';





./Themes/default/languages/Modifications.turkish.php

Find.

?>

Add Before.

// Good Post/Bad Post permission strings.
$txt['permissiongroup_gpbp'] = 'Güzel Mesaj/Kötü Mesaj Modifikasyonu';
$txt['permissionname_gpbp_manage'] = 'Güzel Mesaj/Kötü Mesaj Modifikasyonu Ayarları';
$txt['permissionhelp_gpbp_manage'] = 'İzin ver';
$txt['cannot_gpbp_manage'] = 'Derecelendirmeye izin verilmesi.';
$txt['permissionname_gpbp_vote'] = 'Mesajlara Oyla (yukarı veya aşağı)';
$txt['permissionhelp_gpbp_vote'] = 'Olumlu veya olumsuz bir yazının sonucu değiştirmek için kullanım sağlar. Kurul da yapılandırılmış olması gerekir yazı oylama izin vermek gerekir. <br/> <br/> <strong> Not </ strong>: Konuyu Ziyaretçilerin Oylamasına \ 'izin ver';
$txt['cannot_gpbp_vote'] = 'Maalesef, mesaj oylama izniniz yok.';
$txt['permissionname_gpbp_reveal'] = 'Kötü mesajlar';
$txt['permissionhelp_gpbp_reveal'] = 'kullanıcı mesajları bir düşük oy skor nedeniyle gizli olduğunu görmek için.';
$txt['cannot_gpbp_reveal'] = 'genel oylama tarafından gizli erişim olamaz.';
// Managing area.
$txt['gpbp_manage'] = 'İyi mesaj/Kötü Mesaj';
$txt['gpbp_manage_title'] = 'Güzel Mesaj/Kötü Mesaj Yönetme';
$txt['gpbp_hide_action'] = 'Güzel Mesaj/Kötü Mesaj: ne yapmak istiyorsun?';
$txt['gpbp_hide_action_hide'] = 'Gizle.';
$txt['gpbp_hide_action_grey'] = 'Grileştir.';
$txt['gpbp_hide_action_none'] = 'Hiç birşey yapma.';
$txt['gpbp_settings'] = 'Güzel Mesaj/Kötü Mesaj (GP/BP) Ayarlar';
$txt['gpbp_bad_threshold'] = 'Kötü Mesaj Eşiğinde';
$txt['gpbp_bad_threshold_desc'] = 'Bu değeri şu anda herhangi bir yazı ya da aşağıdaki Kötü Mesaj olarak işaretlenir.';
$txt['gpbp_show_respect'] = ''Göster Dereceyi';
$txt['gpbp_show_respect_desc'] = 'Profil Özetinde Göster Derecelerini.';
$txt['gpbp_enable_boards'] = 'Etkinleştir GP/BP Kurallarda';
$txt['gpbp_enable_boards_desc'] = 'oylama olacak olan Komiteleri seçin. <br /> <br /> <strong> Not: </ strong> Yazı silindi asla oy verilmedi. Yeniden bir konu gönderilmesi oylama sağlayarak sadece önceki oy görüntülemeye yol açacak.';
$txt['gpbp_choose_boards'] = 'Seçebileceğiniz Yer';
$txt['gpbp_display_stats'] = 'İstatistiklerde Aktifleştir?';
$txt['gpbp_display_stats_desc'] = 'Görüntü Seçin <strong>Top 10 Mesaj Puanı</strong> listesi ve  <strong>10 En İyi Mesaj</strong> users.';
$txt['gpbp_users_choice'] = 'Kullanıcıların GP/BP kendi ayarları';
$txt['gpbp_users_choice_desc'] = 'Bu seçeneği üyeleri kendi ayarlarını seçmek için izin vermek için kontrol edin (gri gizlemek aşımı, hiçbir şey), ya da işaretini kaldırın Geçerli ayarları gücüne. <br /> <strong> Üye Seçenekler giderek geçerli tema ayarlarını değiştirebilirsiniz < Temalar yönetimi alanında / strong> bölümünde.';
$txt['gpbp_users_choice_none'] = 'kullanıcılar için tercih "Oysuz" Kötü Yayın';
$txt['gpbp_users_choice_none_desc'] = 'Kötü görüntülemeye izin vermeyi denetleyin Normal mesaj olarak Yayınlar. Bu bir tercihdir seçenekler geçersiz değildir, bu nedenle, yine de tamamen devre dışı bırakmak için üye tema seçenekleri düzenlemek zorunda.';
// Voting errors.
$txt['gpbp_lacks_msg'] = 'Belirttiğiniz (geçerli) mesajı puanla.';
$txt['gpbp_notinthisboard'] = 'Maalesef, bu kurulu değil \'t sonrası oylama etkinleştirdiyseniz.';
$txt['gpbp_msg_not_found'] = 'Belirttiğiniz Mesaj bulunamadı.';
$txt['gpbp_msg_own_voted'] = 'Üzgünüm, kendi yazılarına\'t oy veremessin.';
// General user interface.
$txt['gpbp_respect'] = 'Derece';
$txt['gpbp_post_score'] = 'Bu Yazının Şuanki Puanı.';
$txt['gpbp_vote_down'] = 'Kötü';
$txt['gpbp_vote_up'] = 'İyi';
$txt['gpbp_voted_down_alt'] = 'Oy Aşağı.';
$txt['gpbp_voted_up_alt'] = 'Oy Yukarı.';
$txt['gpbp_voted_down'] = 'Bu yazıya Kötü oy var. Tıklayınız .';
$txt['gpbp_to_vote_down'] = 'Bu yazının kötü oylaması.';
$txt['gpbp_voted_up'] = 'Bu yazıya İyi oy var. Tıklayınız.';
$txt['gpbp_to_vote_up'] = 'Bu yazının iyi oylaması.';
$txt['gpbp_hidden'] = 'Gizle.';
$txt['gpbp_show'] = 'Göster Yazıları.';
$txt['gpbp_member_hide_action'] = 'Oy lanan: mesajlar puanlama ile ne yapmak <strong>%s</strong> istiyorsun?';
$txt['gpbp_top_voters'] = 'Top 10 Mesajlar';
$txt['gpbp_most_respected'] = '10 En iyi Mesaj';




./Themes/default/languages/Help.turkish-utf8.php

Find.

?>

Add Before.

// Good Post/Bad Post mod strings
$helptxt['gpbp_threshold'] = 'Her kullanıcı bağlı olarak \ 'Tema ve Düzen yapılandırması vardır, bu Modifiyeyi , git, ya da tümünü (tneden olabilir hata ?) silik görüntüleniyorsa. <br /> <br /> <b> Tekraklama yapma mesjalarda, normal haline geri dön.</b>';
$helptxt['gpbp_display_respect'] = 'Konudun Kalitesi İçin Kullanılan Oylama sistemidir, her konu ayrı değerlendirilir.';




./Themes/default/languages/Who.turkish-utf8.php

Find.

?>

Add Before.

// Good Post/Bad Post: it may be nice to let users know of this.
$txt['whotopic_gpbp'] = 'Oylama Bir İleti İçindir &quot;<a href="' . $scripturl . '?topic=%d.0">%s</a>&quot;.';





./Themes/default/languages/Modifications.turkish-utf8.php

Find.

?>

Add Before.

// Good Post/Bad Post permission strings.
$txt['permissiongroup_gpbp'] = 'Güzel Mesaj/Kötü Mesaj Modifikasyonu';
$txt['permissionname_gpbp_manage'] = 'Güzel Mesaj/Kötü Mesaj Modifikasyonu Ayarları';
$txt['permissionhelp_gpbp_manage'] = 'İzin ver';
$txt['cannot_gpbp_manage'] = 'Derecelendirmeye izin verilmesi.';
$txt['permissionname_gpbp_vote'] = 'Mesajlara Oyla (yukarı veya aşağı)';
$txt['permissionhelp_gpbp_vote'] = 'Olumlu veya olumsuz bir yazının sonucu değiştirmek için kullanım sağlar. Kurul da yapılandırılmış olması gerekir yazı oylama izin vermek gerekir. <br/> <br/> <strong> Not </ strong>: Konuyu Ziyaretçilerin Oylamasına \ 'izin ver';
$txt['cannot_gpbp_vote'] = 'Maalesef, mesaj oylama izniniz yok.';
$txt['permissionname_gpbp_reveal'] = 'Kötü mesajlar';
$txt['permissionhelp_gpbp_reveal'] = 'kullanıcı mesajları bir düşük oy skor nedeniyle gizli olduğunu görmek için.';
$txt['cannot_gpbp_reveal'] = 'genel oylama tarafından gizli erişim olamaz.';
// Managing area.
$txt['gpbp_manage'] = 'İyi mesaj/Kötü Mesaj';
$txt['gpbp_manage_title'] = 'Güzel Mesaj/Kötü Mesaj Yönetme';
$txt['gpbp_hide_action'] = 'Güzel Mesaj/Kötü Mesaj: ne yapmak istiyorsun?';
$txt['gpbp_hide_action_hide'] = 'Gizle.';
$txt['gpbp_hide_action_grey'] = 'Grileştir.';
$txt['gpbp_hide_action_none'] = 'Hiç birşey yapma.';
$txt['gpbp_settings'] = 'Güzel Mesaj/Kötü Mesaj (GP/BP) Ayarlar';
$txt['gpbp_bad_threshold'] = 'Kötü Mesaj Eşiğinde';
$txt['gpbp_bad_threshold_desc'] = 'Bu değeri şu anda herhangi bir yazı ya da aşağıdaki Kötü Mesaj olarak işaretlenir.';
$txt['gpbp_show_respect'] = ''Göster Dereceyi';
$txt['gpbp_show_respect_desc'] = 'Profil Özetinde Göster Derecelerini.';
$txt['gpbp_enable_boards'] = 'Etkinleştir GP/BP Kurallarda';
$txt['gpbp_enable_boards_desc'] = 'oylama olacak olan Komiteleri seçin. <br /> <br /> <strong> Not: </ strong> Yazı silindi asla oy verilmedi. Yeniden bir konu gönderilmesi oylama sağlayarak sadece önceki oy görüntülemeye yol açacak.';
$txt['gpbp_choose_boards'] = 'Seçebileceğiniz Yer';
$txt['gpbp_display_stats'] = 'İstatistiklerde Aktifleştir?';
$txt['gpbp_display_stats_desc'] = 'Görüntü Seçin <strong>Top 10 Mesaj Puanı</strong> listesi ve  <strong>10 En İyi Mesaj</strong> users.';
$txt['gpbp_users_choice'] = 'Kullanıcıların GP/BP kendi ayarları';
$txt['gpbp_users_choice_desc'] = 'Bu seçeneği üyeleri kendi ayarlarını seçmek için izin vermek için kontrol edin (gri gizlemek aşımı, hiçbir şey), ya da işaretini kaldırın Geçerli ayarları gücüne. <br /> <strong> Üye Seçenekler giderek geçerli tema ayarlarını değiştirebilirsiniz < Temalar yönetimi alanında / strong> bölümünde.';
$txt['gpbp_users_choice_none'] = 'kullanıcılar için tercih "Oysuz" Kötü Yayın';
$txt['gpbp_users_choice_none_desc'] = 'Kötü görüntülemeye izin vermeyi denetleyin Normal mesaj olarak Yayınlar. Bu bir tercihdir seçenekler geçersiz değildir, bu nedenle, yine de tamamen devre dışı bırakmak için üye tema seçenekleri düzenlemek zorunda.';
// Voting errors.
$txt['gpbp_lacks_msg'] = 'Belirttiğiniz (geçerli) mesajı puanla.';
$txt['gpbp_notinthisboard'] = 'Maalesef, bu kurulu değil \'t sonrası oylama etkinleştirdiyseniz.';
$txt['gpbp_msg_not_found'] = 'Belirttiğiniz Mesaj bulunamadı.';
$txt['gpbp_msg_own_voted'] = 'Üzgünüm, kendi yazılarına\'t oy veremessin.';
// General user interface.
$txt['gpbp_respect'] = 'Derece';
$txt['gpbp_post_score'] = 'Bu Yazının Şuanki Puanı.';
$txt['gpbp_vote_down'] = 'Kötü';
$txt['gpbp_vote_up'] = 'İyi';
$txt['gpbp_voted_down_alt'] = 'Oy Aşağı.';
$txt['gpbp_voted_up_alt'] = 'Oy Yukarı.';
$txt['gpbp_voted_down'] = 'Bu yazıya Kötü oy var. Tıklayınız .';
$txt['gpbp_to_vote_down'] = 'Bu yazının kötü oylaması.';
$txt['gpbp_voted_up'] = 'Bu yazıya İyi oy var. Tıklayınız.';
$txt['gpbp_to_vote_up'] = 'Bu yazının iyi oylaması.';
$txt['gpbp_hidden'] = 'Gizle.';
$txt['gpbp_show'] = 'Göster Yazıları.';
$txt['gpbp_member_hide_action'] = 'Oy lanan: mesajlar puanlama ile ne yapmak <strong>%s</strong> istiyorsun?';
$txt['gpbp_top_voters'] = 'Top 10 Mesajlar';
$txt['gpbp_most_respected'] = '10 En iyi Mesaj';
Title: Re: Good Post/Bad Post Mod
Post by: Paracelsus on June 30, 2009, 07:28:35 AM
Quote from: djkmmo on June 30, 2009, 05:12:34 AM
Hi!

I just installed this mod and it seems great. It's just one tiny thing: it fills up my error log with the following message:

8: Undefined variable: template_name
Fil: /home/djkmmo/gnubuntu.co.cc/forum/Sources/Display.php
Rad: 102


Line 102 is:
      elseif (file_exists($settings['default_theme_dir'] . '/' . $template_name . '.template.php'))

I commented that out and it worked for me, like this:

// elseif (file_exists($settings['default_theme_dir'] . '/' . $template_name . '.template.php'))
// $context['html_headers'] = '
//<link rel="stylesheet" type="text/css" href="' . $settings['default_theme_url'] . '/gpbp.css' . '" />';


Of course, I've assured first that gpbp.css was in my custom theme directory.
Title: Re: Good Post/Bad Post Mod
Post by: djkmmo on June 30, 2009, 09:15:24 AM
Quote from: Paracelsus on June 30, 2009, 07:28:35 AM
I commented that out and it worked for me, like this:

// elseif (file_exists($settings['default_theme_dir'] . '/' . $template_name . '.template.php'))
// $context['html_headers'] = '
//<link rel="stylesheet" type="text/css" href="' . $settings['default_theme_url'] . '/gpbp.css' . '" />';


Of course, I've assured first that gpbp.css was in my custom theme directory.

That seems to have made it. Thanks!
Title: Re: Good Post/Bad Post Mod
Post by: Paracelsus on June 30, 2009, 11:16:29 AM
Quote from: Paracelsus on June 30, 2009, 03:27:14 AM
Quote from: OutofOrder on June 29, 2009, 08:57:40 PM
Quote from: Paracelsus on June 29, 2009, 12:07:29 PM
The MOD works well in 1.1.9, although I had to make several changes in Display.Template.php due to the custom theme I'm using.

Still I get this error in Firebug's console:
PostVoting is not defined
var oVotePost = new PostVoting({
Please check in Firebug that the browser has correctly loaded the gpbp.js file. If this is the case, clear your cache and reload the page.
You can do the check by going to the "Script" tab, then clicking on the script url (it will drop down the list of every JS scripts loaded) and selecting "gpbp.js". If it didn't load it properly, it will show an empty script.

You're right, it hasn't loaded gpbp.js file at all. The other scripts I run are related to google analytics and gfeedfetcher.js from DynamicDrive. Can it be a conflict between some of these scripts?

Found a solution, putting the gpbp.js script call in Display.template.php instead of Display.php.

Btw, I'm having trouble getting the script to show/hide what I want in my custom theme. In attachment is my display.template.php so you can take a look if you have the time. There are 2 problems: one is the fact that the message doesn't get hidden and the second is thast, even if I get it hidden (by placing some class code back and forth in different table td's), the link to unhide doesn't work (the only thing you get to unhide is actually the message ['id'] part).
Title: Re: Good Post/Bad Post Mod
Post by: Özgür on June 30, 2009, 11:20:53 AM
If topic moved, and you click to this topic, you get the db error.

http://www.rockayseri.net/rk/turkce-sozler/tasindi-radical-noise-sarki-sozleri/
Database error, given array of integer values is empty. (message_list)
Function: Display
File: ../Sources/Display.php
Line: 1145

1130: // Not a mistake! That's a single equals.
1131: if ($context['gpbp_enabled'] = $board_info['gpbp_enabled'])
1132:{
1133: // Display hidden message?
1134: $context['gpbp_revealed'] = !empty($_REQUEST['revealmsg']) && $context['reveal_bad_post'] ? (int) $_REQUEST['revealmsg'] : 0;
1135:// Gather any vote this user casted for each message.
1136: $request = $smcFunc['db_query']('', '
1137: SELECT id_msg, score
1138: FROM {db_prefix}log_gpbp
1139: WHERE id_msg IN ({array_int:message_list})
1140: AND id_member = {int:current}',
1141: array(
1142: 'message_list' => $messages,
1143: 'current' => $context['user']['id'],
1144: )
==>1145: );
1146: while ($row = $smcFunc['db_fetch_assoc']($request))
1147: $context['gpbp_votes'][$row['id_msg']] = $row['score'];
1148: $smcFunc['db_free_result']($request);
1149: }
1150:
1151: }
1152:
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on June 30, 2009, 12:11:33 PM
Thank you Php Coder Turkish, I'll sure be adding these :) Also, it would be great if there was another turkish speaker that could check those.

Thanks Sabre, djkmmo & [Daydreamer] for the spotted bugs. Looks like a new version fixing these problems is needed.

Parecelsus, the empty gpbp.js file bug seems to be a Firebug bug only. It doesn't happen with Firebug disabled or in any other browsers AFAIK.
I'll later take a look at your Display.template file, the bugfixes come first, so please hang on.
Title: Re: Good Post/Bad Post Mod
Post by: Dream of Omnimaga on June 30, 2009, 01:49:58 PM
happy to see 1.1.9 version! Thank you :D!
Title: Re: Good Post/Bad Post Mod
Post by: shanksta13 on July 02, 2009, 03:50:01 PM
One minor issue, other than that this is a terrific mod. For admins, this functions perfectly normal when you click on the arrow. The page refreshes and shows the post with the green up arrow. However, for regular members, they click on the arrow and nothing happens. The points are still added, but the users are not sure if it worked or not because it does not refresh and show the point added.

I also fully support the idea that you should be able to see who voted for a post.
Title: Re: Good Post/Bad Post Mod
Post by: akosiparusa on July 07, 2009, 09:20:55 AM
hi, need help here. i manually installed the codes on 1.1.9 because it is giving test fails using acp-packages.

anyway, whenever i click on ACP -> Good Post/Bad Post - I get a DB error

Quoteforum/Sources/GoodPostBadPost.php
Line: 237

and yeah, whenever i click the board id, i get an error again (wrong code leads to another):

QuoteUnknown column 'b.enable_gpbp' in 'field list'
the error message above is on a white page only.

sorry, im just a newbie.

TIA

Title: Re: Good Post/Bad Post Mod
Post by: ajrl on July 07, 2009, 12:02:20 PM
I'm getting a
"6.   Execute Modification   ./Sources/Profile.php   Test failed"
error.

I sure do want to add this mod.  What should I do now?
Title: Re: Good Post/Bad Post Mod
Post by: marciano on July 07, 2009, 02:16:08 PM
Quote from: akosiparusa on July 07, 2009, 09:20:55 AM
hi, need help here. i manually installed the codes on 1.1.9 because it is giving test fails using acp-packages.

anyway, whenever i click on ACP -> Good Post/Bad Post - I get a DB error

Quoteforum/Sources/GoodPostBadPost.php
Line: 237

and yeah, whenever i click the board id, i get an error again (wrong code leads to another):

QuoteUnknown column 'b.enable_gpbp' in 'field list'
the error message above is on a white page only.

sorry, im just a newbie.

TIA



Te faltó agregar la modificacion a tu base de datos
Title: Re: Good Post/Bad Post Mod
Post by: akosiparusa on July 07, 2009, 06:15:17 PM
thank you my spanish friend, i had to translate your post to english... hehehe
Title: Re: Good Post/Bad Post Mod
Post by: marciano on July 09, 2009, 12:16:27 AM
www.translate.google.com
Title: Re: Good Post/Bad Post Mod
Post by: akosiparusa on July 09, 2009, 02:33:17 AM
hey no problem, i used that link when you posted.
hey no hay problema, he usado ese vínculo cuando se envió.
Title: Re: Good Post/Bad Post Mod
Post by: jarik on July 12, 2009, 05:57:26 AM
First of all - thanks a lot for a good mod! :)

I'm using version for 1.1.9 and found a little 'bug': whitespace between arrows is inside the a tag, so if your template underlines a tags (in my case it underlines then on hover) then moving mouse over the arrow_down underlines the space between arrows. I repaired it by myself just adding the code below to my style css, but it would be nice if in the next release you would move that sapce between "a" tags.
/** Hack for good post/bad post mod to remove underlined whitespace*/
.gpbp_vote a, .gpbp_vote a:hover{text-decoration: none;}
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on July 14, 2009, 11:57:28 AM
Quote from: jarik on July 12, 2009, 05:57:26 AM
First of all - thanks a lot for a good mod! :)

I'm using version for 1.1.9 and found a little 'bug': whitespace between arrows is inside the a tag, so if your template underlines a tags (in my case it underlines then on hover) then moving mouse over the arrow_down underlines the space between arrows. I repaired it by myself just adding the code below to my style css, but it would be nice if in the next release you would move that sapce between "a" tags.
/** Hack for good post/bad post mod to remove underlined whitespace*/
.gpbp_vote a, .gpbp_vote a:hover{text-decoration: none;}

Noted, thanks for reporting.
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on July 15, 2009, 02:24:36 PM
New mod version is out :)
This is the most stable version for both SMF 1.1.x and SMF 2.0. Which means that, in the future, only the 2.0 version will be updated with new features.
Also, it supports the new 1.1.10 and 2.0 RC1.2 SMF versions.

I'm planning to include AJAX querying for the list of voting members when clicking on the vote number, displayed as a tooltip. Unless someone else has a better idea?
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on July 15, 2009, 05:22:45 PM
looks great!

one suggestion (even though i did it personally, but not well enough to publish) -
color the post rating (red/green), not just the arrows.
Title: Re: Good Post/Bad Post Mod
Post by: shanksta13 on July 21, 2009, 02:11:04 PM
I'm having some issues with this mod. I think it's because the database is still seeing the old version but the files from the new version are all present.
Title: Re: Good Post/Bad Post Mod
Post by: shanksta13 on July 21, 2009, 02:48:51 PM
Okay, I manually uninstalled the mod (took a while) and then deleted the smf_log_gpbp table from the database. However, when I try to reinstall, my ACP says that I'm about to upgrade to 1.1.2, instead of installing like normal. Is there anything else I have to delete in the database to get my package uploader to recognize that it isn't already installed?

Or is this mod just not compatible with SMF 2.0 RC1.2?
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on July 22, 2009, 08:41:16 AM
The mod IS compatible with SMF 2 RC1.2
But I don't really know how the package manager considers that a mod has been installed. ??? There are no checks from within the mod's code, that's for certain.
Perhaps some more experienced member can help you out...
Title: Re: Good Post/Bad Post Mod
Post by: dzinerfusion on July 22, 2009, 08:59:47 AM
Hi, i gotta question, where do i customize it and configurate it? :P Sorry, cant really find the area. I use 2.0 rc1.2
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on July 24, 2009, 07:06:17 AM
Quote from: bluesinjid on July 22, 2009, 08:59:47 AM
Hi, i gotta question, where do i customize it and configurate it? :P Sorry, cant really find the area. I use 2.0 rc1.2
Hello bluesinjid. I'm assuming the mod installed correctly in your forum.
For the general mod configurations: Admin page -> Forum -> Good Post/Bad Post
For the default visual settings: Admin page -> Configuration -> Themes and Layout -> Member Options -> Choose a theme then edit the options as you see fit.
Also, this mod requires that you toggle its permissions for your forum members. You can set them in the permissions area (Admin page -> Members -> Permissions -> General Permissions).
Finally, make sure that if you're not an Admin at least you've got the "Manage GP/BP mod" permission.
Hope this helped :)
Title: Re: Good Post/Bad Post Mod
Post by: markoal on July 29, 2009, 09:46:53 PM
Can anyone help me, i cant nothing almost understand at tutorial at pdf, i was compare in manual for theme and i see that i must do like it says in that tutorial in pdf(How To Ad GPBP...). :'( :'( :'( :'(

I have Nozie Template, i can upload some files, and if can someone edit it i really cant understand many things (im not from USA or UK).
Here is Display.template.php (attach)
So can anyone edit it like it must be and i will upload more files what must me edited, pls help, i really need this mod! ???
:-\ ;)
Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on July 30, 2009, 08:05:23 AM
Try the attached file and see how that works for you.
If you have any problems, then post back :)
Title: Re: Good Post/Bad Post Mod
Post by: markoal on July 30, 2009, 02:45:53 PM
Quote from: Sabre™ on July 30, 2009, 08:05:23 AM
Try the attached file and see how that works for you.
If you have any problems, then post back :)

Thanks a lot!
Man You help me A lot,  ;D ;) :D ;D
Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on July 30, 2009, 05:39:01 PM
My pleasure mate.
The mod is working for you then?
No need for other template edits?
I moved where the function is usually displayed, so it is more 'noticeable'.

If all is good, then enjoy  ;D
Title: Re: Good Post/Bad Post Mod
Post by: Eva on August 02, 2009, 03:02:35 PM
Hi! Great Mod!

Is there any way that the "thumbs up" & "thumbs down" will be displayed on the user's info separately, and not as a sum? (eg. Respect: +5/-2 or 5 likes/2 dislikes rather than Respect: 3)

That would make the mod just perfect for my needs!

thanks  :)
Title: Re: Good Post/Bad Post Mod
Post by: Alleks on August 06, 2009, 05:58:02 AM
Module working great until I switch forum to russian language it does not show "reputation under profile" and empty place in forum admin area.

I am ready to translate all needed phrases from English to Russian but please let me know what should I translate to make a russian translation for this great mod.
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on August 06, 2009, 10:29:15 AM
Quote from: Eva on August 02, 2009, 03:02:35 PM
Hi! Great Mod!

Is there any way that the "thumbs up" & "thumbs down" will be displayed on the user's info separately, and not as a sum? (eg. Respect: +5/-2 or 5 likes/2 dislikes rather than Respect: 3)

That would make the mod just perfect for my needs!

thanks  :)
Sounds like an option for a future update. (I actually intended to do this for the first version, but in the end decided to leave it out of the mod.)

Quote from: Alleks on August 06, 2009, 05:58:02 AM
Module working great until I switch forum to russian language it does not show "reputation under profile" and empty place in forum admin area.

I am ready to translate all needed phrases from English to Russian but please let me know what should I translate to make a russian translation for this great mod.
Hi Alleks, please check out this file
http://www.simplemachines.org/community/index.php?action=dlattach;topic=318290.0;attach=110098
And thank you in advance, your translation will be very welcomed.


I'd like to know, if someone could check for me, are the UTF-8 translations working allright in UTF-8 set forums? Please confirm this if you are able to.
Title: Re: Good Post/Bad Post Mod
Post by: Alleks on August 07, 2009, 03:01:35 AM
Attached file is russian translation for Good/Bad post mod.
Title: Re: Good Post/Bad Post Mod
Post by: Alleks on August 10, 2009, 03:43:49 AM
When we can expect GB/BP with russian language included?
Title: Re: Good Post/Bad Post Mod
Post by: telles0808 on August 13, 2009, 10:31:32 PM
Template Parse Error!

There was a problem loading the /Themes/default/Display.template.php template or language file. Please check the syntax and try again - remember, single quotes (') often have to be escaped with a slash (\). To see more specific error information from PHP, try accessing the file directly.

You may want to try to refresh this page or use the default theme.

Parse error: syntax error, unexpected ',' in .../Themes/default/Display.template.php on line 260
251: <tr', $context['gpbp_action'] == 'hide' ? ' id="gpbp_hidden_' . $message['id'] . '"' : '' ,'', $context['gpbp_action'] == 'hide' ? ' id="gpbp_hidden_' . $message['id'] . '"' : '' ,'><td style="padding: 1px 1px 0 1px;">';
252:
253: // Show the message anchor and a "new" anchor if this message is new.
254: if ($message['id'] != $context['first_message'])
255: echo '
256: <a name="msg', $message['id'], '"></a>', $message['first_new'] ? '<a name="new"></a>' : '';
257:
258: echo '
259: <table width="100%" cellpadding="3" cellspacing="0" border="0">
260: <tr><td class="', $context['gpbp_action'] == 'hide' ? 'gpbp_hider ' : '', $context['gpbp_bad_post'] && $context['gpbp_action'] != 'none' ? 'gpbp_greyed' : ($context['gpbp_action'] == 'hide' ? 'gpbp_hider ' : '', $context['gpbp_bad_post'] && $context['gpbp_action'] != 'none' ? 'gpbp_greyed' : ($message['alternate'] == 0 ? 'windowbg' : 'windowbg2')), '">';
261:
262: // Show information about the poster of this message.
263: echo '
264: <table width="100%" cellpadding="5" cellspacing="0" style="table-layout: fixed;">


after install it =\
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on August 14, 2009, 02:28:42 AM
Quote from: telles0808 on August 13, 2009, 10:31:32 PM

*snip*

260: <tr><td class="', $context['gpbp_action'] == 'hide' ? 'gpbp_hider ' : '', $context['gpbp_bad_post'] && $context['gpbp_action'] != 'none' ? 'gpbp_greyed' : ($context['gpbp_action'] == 'hide' ? 'gpbp_hider ' : '', $context['gpbp_bad_post'] && $context['gpbp_action'] != 'none' ? 'gpbp_greyed' : ($message['alternate'] == 0 ? 'windowbg' : 'windowbg2')), '">';

*snip*

after install it =\
I have to assume (by the looks of it and since you did not specify) that you've installed the SMF 1.1.x version of this mod. Did you manually edit Display.template.php?
Anyway, this should fix it for you:
Open /Themes/Default/Display.template.php
Code (Search for) Select
<tr><td class="', $context['gpbp_action'] == 'hide' ? 'gpbp_hider ' : '', $context['gpbp_bad_post'] && $context['gpbp_action'] != 'none' ? 'gpbp_greyed' : ($context['gpbp_action'] == 'hide' ? 'gpbp_hider ' : '', $context['gpbp_bad_post'] && $context['gpbp_action'] != 'none' ? 'gpbp_greyed' : ($message['alternate'] == 0 ? 'windowbg' : 'windowbg2')), '">';

Code (Replace with) Select
<tr><td class="', $context['gpbp_action'] == 'hide' ? 'gpbp_hider ' : '', $context['gpbp_bad_post'] && $context['gpbp_action'] != 'none' ? 'gpbp_greyed' : ($message['alternate'] == 0 ? 'windowbg' : 'windowbg2'), '">';


The bug looked like a repeated edit, as if you tried to install the mod more than once without uninstalling whatever modifications it would have done first.
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on August 14, 2009, 02:36:22 AM
Quote from: Alleks on August 10, 2009, 03:43:49 AM
When we can expect GB/BP with russian language included?
Thanks for your translations.
I am sorry but can not specify a date at the moment. I have also some questions regarding this: have you tested this translation? Do these work in a UTF-8 enabled SMF forum?
I have to be careful not to mess with the mod installer so it actually works for Russian admins.
Title: Re: Good Post/Bad Post Mod
Post by: telles0808 on August 14, 2009, 07:10:05 AM
I deleted the forum dir and replaced it with a brand new install. Now it's working right.
Title: Re: Good Post/Bad Post Mod
Post by: jak6868 on August 16, 2009, 01:42:01 PM
hi - the voting arrows do not appear on firefox running on osx. I've confirmed this on two different macs.
they do appear on everything else (on windows computers they appear on firefox or anything else; and on macs they do appear in safari).

any ideas? thanks
Title: Re: Good Post/Bad Post Mod
Post by: jak6868 on August 16, 2009, 02:20:38 PM
Quote from: jak6868 on August 16, 2009, 01:42:01 PM
hi - the voting arrows do not appear on firefox running on osx. I've confirmed this on two different macs.
they do appear on everything else (on windows computers they appear on firefox or anything else; and on macs they do appear in safari).

any ideas? thanks

actually, never mind.  When I upgraded to the latest firefox (3.5.2), it works fine.
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on August 19, 2009, 06:08:08 PM
wonderful mod, thanks!

any kind of coding i can do in order to allow guests to vote?
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on August 21, 2009, 03:39:28 AM
Thanks.
Quote from: IdanC on August 19, 2009, 06:08:08 PM
any kind of coding i can do in order to allow guests to vote?
You would have to implement IP-saving & IP-checking in order to prevent (at least a big part of) abuse, either from abusive users or unaware spider bots. This is the reason guests can't vote in this mod (i did consider guest voting at the beggining). It's some coding trouble.
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on August 22, 2009, 04:45:17 AM
yes, i tried, way out of my league... :)

but, i came across a new issue - i've used gpbp in a post i show on the index page. but each time the poor basterds vote, they are redirected to the actuall post.

i found this line in GoodPostBadPost.php
redirectexit(($score <= $modSettings['gpbp_hide_threshold'] ? 'revealmsg=' . $message .';' : '') . 'topic=' . $topic . '.msg' . $message . '#msg' . $message);


but if i disable it, i disable the mod.

any ideas?
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on August 23, 2009, 08:11:04 AM
The redirection happens because the javascript code needed for the AJAX requests to happen is not loaded in the index page.
If you want to enable AJAX voting, you'll have to make sure that the index page loads the gpbp.js file, and that the Javascript PostVoting object oVotePost is created. About the latter, look for this code at the bottom of Display.template.php:

,
$context['gpbp_enabled'] ? '

var oVotePost = new PostVoting({
iBoard: ' . $context['this_board'] . ',
iTopic: ' . $context['current_topic'] . ',
sVoteDownAlt: "' . $txt['gpbp_vote_down'] . '",
sVoteUpAlt: "' . $txt['gpbp_vote_up'] . '",
sVotedDownAlt: "' . $txt['gpbp_voted_down_alt'] . '",
sVotedUpAlt: "' . $txt['gpbp_voted_up_alt'] . '",
sVotedDown: "' . $txt['gpbp_voted_down'] . '",
sToVoteDown: "' . $txt['gpbp_to_vote_down'] . '",
sVotedUp: "' . $txt['gpbp_voted_up'] . '",
sToVoteUp: "' . $txt['gpbp_to_vote_up'] . '",
sScriptUrl: "' . $scripturl . '",
sImagesUrl: "' . $settings['images_url'] . '"
});' : '', '

Make sure it is also added in a <script> tag in the HTML output source of your index page.
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on August 23, 2009, 04:20:23 PM
* IdanC is doing the happy happy joy joy dance

thanks! works great!
Title: Re: Good Post/Bad Post Mod
Post by: Özgür on August 23, 2009, 11:15:56 PM
Quote from: OutofOrder on June 30, 2009, 12:11:33 PM
Thank you Php Coder Turkish, I'll sure be adding these :) Also, it would be great if there was another turkish speaker that could check those.

Thanks Sabre, djkmmo & [Daydreamer] for the spotted bugs. Looks like a new version fixing these problems is needed.

Parecelsus, the empty gpbp.js file bug seems to be a Firebug bug only. It doesn't happen with Firebug disabled or in any other browsers AFAIK.
I'll later take a look at your Display.template file, the bugfixes come first, so please hang on.


OutOfOrder New version coming soon ? (:

And how can i make a "Most liked posts" list?
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on August 26, 2009, 02:37:21 PM
Quote from: [Daydreamer] on August 23, 2009, 11:15:56 PM
Quote from: OutofOrder on June 30, 2009, 12:11:33 PM
Thank you Php Coder Turkish, I'll sure be adding these :) Also, it would be great if there was another turkish speaker that could check those.

Thanks Sabre, djkmmo & [Daydreamer] for the spotted bugs. Looks like a new version fixing these problems is needed.

Parecelsus, the empty gpbp.js file bug seems to be a Firebug bug only. It doesn't happen with Firebug disabled or in any other browsers AFAIK.
I'll later take a look at your Display.template file, the bugfixes come first, so please hang on.


OutOfOrder New version coming soon ? (:

And how can i make a "Most liked posts" list?
The version addressing this issues has already been released, please check the first post.
I can't say when a new version will come out, and I haven't done much since.
Title: Re: Good Post/Bad Post Mod
Post by: jak6868 on August 28, 2009, 01:49:33 AM
Quote from: jak6868 on August 16, 2009, 01:42:01 PM
hi - the voting arrows do not appear on firefox running on osx. I've confirmed this on two different macs.
they do appear on everything else (on windows computers they appear on firefox or anything else; and on macs they do appear in safari).

any ideas? thanks

hi all - i'm sorry to say this problem remains.  Here's what i'm seeing so far:
1) on g4 macs, if you update firefox to the current latest version, the vote buttons work normally. In safari they've worked normally.
2) But on intel macs, whether you use safari or FF, the vote buttons dont even show up. 

Any ideas? Anyone else on an intel mac seeing this problem? Thanks
Title: Re: Good Post/Bad Post Mod
Post by: Özgür on August 28, 2009, 07:02:47 AM
Thanks @OutofOrder, im missed that update.
Can you answer my second post =)
Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on August 28, 2009, 10:04:40 AM
I just manually updated to 1.1.2 and noticed this in the Display.php
img_gpbp_up.src=smf_images_url+"gpbp_arrow_up.gif";

You missed a lil something there mate ;)
img_gpbp_up.src=smf_images_url+"/gpbp_arrow_up.gif";
Title: Re: Good Post/Bad Post Mod
Post by: timmytimmy on September 04, 2009, 12:45:30 PM
Quote from: OutofOrder on July 24, 2009, 07:06:17 AM
For the default visual settings: Admin page -> Configuration -> Themes and Layout -> Member Options -> Choose a theme then edit the options as you see fit.

hi, how do i edit the default visual settings for a SMF 1.1 forum?  i did some googling and i saw that the equivalent of "member options" in 1.1 is "reset options" but i still don't see where i can customize this. 

any help would be appreciated!
Title: Re: Good Post/Bad Post Mod
Post by: Mush Man on September 14, 2009, 01:14:43 AM
Does the mod show who voted on each post? If not, could you please implement it? It'd look something like this. (http://palgn.com.au/viewtopic.php?t=42537) It'd be really useful for both administrators and members. :)
Also, does the mod log all votes of posts? This would also be a good feature if it's not presently available.
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on September 17, 2009, 07:56:28 PM
Quote from: Mush Man on September 14, 2009, 01:14:43 AM
Does the mod show who voted on each post? If not, could you please implement it?
It is planned for the next version.
Quote from: Mush Man on September 14, 2009, 01:14:43 AM
Also, does the mod log all votes of posts? This would also be a good feature if it's not presently available.
I'm not sure I understand your question. Votes, be them positive or negative, are kept in the database for each post for each voter. However unvoting is not logged: the vote is simply deleted.

Quote from: Sabre™ on August 28, 2009, 10:04:40 AM
I just manually updated to 1.1.2 and noticed this in the Display.php
img_gpbp_up.src=smf_images_url+"gpbp_arrow_up.gif";

You missed a lil something there mate ;)
img_gpbp_up.src=smf_images_url+"/gpbp_arrow_up.gif";
Thanks for telling. I keep messing up with those image preloads.
Title: Re: Good Post/Bad Post Mod
Post by: Dream of Omnimaga on September 18, 2009, 01:51:30 AM
If seeing who voted what is gonna be implemented, would it be possible to be able to disable this if we want voting to remain anonymous as they are now?
Title: Re: Good Post/Bad Post Mod
Post by: Mush Man on September 25, 2009, 11:47:34 AM
Thanks a lot for your reply!
Quote from: OutofOrder
Quote from: Me
Also, does the mod log all votes of posts? This would also be a good feature if it's not presently available.
I'm not sure I understand your question. Votes, be them positive or negative, are kept in the database for each post for each voter. However unvoting is not logged: the vote is simply deleted.
I'll rephrase that.
Is there a feature that allows administrators to see all historical voting actions? Say, when a member votes on another member's post, it's logged which member cast the vote, which member received the vote, which post was voted on and what time the vote took place? It, essentially, is where administrators can go if they suspect the voting system is being abused.

Also, will updating the mod reset the vote-counts? I want to implement this mod soon! :D
Title: Re: Good Post/Bad Post Mod
Post by: Sakurachan on September 25, 2009, 03:47:59 PM
Too bad this doesn't work for SMF 1.1.10..

I would use it than
Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on September 25, 2009, 11:15:08 PM
It works for smf 1.1.10, the mod author just hasn't updated to say that is does.
Title: Re: Good Post/Bad Post Mod
Post by: Mush Man on September 26, 2009, 02:56:45 AM
You can actually change the code to make it install for SMF 1.1.10.

Look inside "package-info.xml" and change "<install for="1.1.0-1.1.9">" to "<install for="1.1.0-1.1.10">" and it'll install fine (I'm pretty sure).
Title: Re: Good Post/Bad Post Mod
Post by: piggeh on September 30, 2009, 09:21:02 AM
Hi

I installed this mod onto SMF 2.0 RC1.2 - I have done this on xampp on my memory stick and it worked fine (with SMF 2.0 rc1.2). However, when I have installed it onto my webserver, it installed but it cannot find the settings page (it shows in the dropdown box but with no image next to it). I get a HTTP 500 error when I click on the link to open settings. Any idea on how to fix please?

Thanks

Piggeh
Title: Re: Good Post/Bad Post Mod
Post by: diablo3x.dk on October 13, 2009, 09:46:53 PM
I am a noob at this so looking for some help...

I really like this mod. It so much kicks karma's butt! The normal karma system is way too simple.

Is it possible to use it with any themes? I have this site - www.forum.diablo3x.dk - which uses a modified theme and Danish as default language. What would I have to do, to implement this awesome mod?I have nearly no PHP experience...


I really have no experience on modifying mods. If someone could help me out here, it would be really great.

If I can help with the translation into Danish I would like to offer this service :) I just don't know how to do it.
Title: Re: Good Post/Bad Post Mod
Post by: Mush Man on October 13, 2009, 09:49:26 PM
OutofOrder, could you please answer my questions in this post (http://www.simplemachines.org/community/index.php?topic=318290.msg2275731#msg2275731)?
Also, if I updated to the next version of the mod which displays which members have voted on a post,  would the votes that have already been made then display who made those votes?
Title: Re: Good Post/Bad Post Mod
Post by: smldmr on October 26, 2009, 09:06:38 AM
Hi, the turkish translation is not good. I think the translation is a machine translation, many gramatical failures and many code failures. Thats why i get some php errors, because of some ' signs.

Here is my edited version. You can copy-paste the text in the language files. It's not 100% correct, but better as before.
Title: Re: Good Post/Bad Post Mod
Post by: genenj on October 28, 2009, 04:49:52 PM
I get this error when trying to install this on 1.1.10 default theme. Same when I use a custom theme. Any advice?

Error in Package Installation
At least one error was encountered during a test installation of this package. It is strongly recommended that you do not continue with installation unless you know what you are doing, and have made a backup very recently. This error may be caused by a conflict between the package you're trying to install and another package you have already installed, an error in the package, a package which requires another package that you don't have installed yet, or a package designed for another version of SMF.


Install Actions
Installations actions for "Good Post/Bad Post Mod":
Installing this package will perform the following actions:
   Type    Action    Description
1.    Execute Code    gpbp_1.1.x_install.php    
2.    Execute Modification    ./index.php    Test successful
3.    Execute Modification    ./Sources/Display.php    Test failed
4.    Execute Modification    ./Sources/Load.php    Test successful
5.    Execute Modification    ./Sources/ManagePermissions.php    Test successful
6.    Execute Modification    ./Sources/Profile.php    Test successful
7.    Execute Modification    ./Sources/Stats.php    Test successful
8.    Execute Modification    ./Sources/Subs.php    Test failed
Title: Re: Good Post/Bad Post Mod
Post by: genenj on October 30, 2009, 03:03:35 AM
Anyone?
Title: Re: Good Post/Bad Post Mod
Post by: Alleks on November 04, 2009, 06:54:20 AM
Is there any way to allow post voting only to users with "x" amount of posts?
Title: Cannot install on SMF 1.1.7
Post by: PatriiickEmin on November 08, 2009, 04:58:02 AM
I know my forum version is a bit out of date (I have 1.1.7), but I cannot upgrade there is a permission error. So I am stuck with 1.1.7, that seems to make installing GoodPostBadPost impossible, the install won't launch. I can add the paquet, but when I apply the Mod, it says "cannot install" or something like that. Has someone installed it successfully on SMF 1.1.7? Thanks.
Title: Re: Good Post/Bad Post Mod
Post by: oleson92 on November 09, 2009, 05:49:19 PM
Is anyone looking at getting this mod updated for RC2?
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on November 11, 2009, 01:56:52 PM
Please excuse me for the absence.
Okay, one by one.

Quote from: Mush Man on September 25, 2009, 11:47:34 AM
Is there a feature that allows administrators to see all historical voting actions?
Also, will updating the mod reset the vote-counts? I want to implement this mod soon! :D
1. Every vote is logged, although regrets (like voting down after voting up) are not logged, ony the final vote is. The voter id, the voted poster id, and the post id data are kept. A tool to review voting by user/thread/poster is planned.
2. Updating the mod will not affect your current votes.

Quote from: Mush Man on September 26, 2009, 02:56:45 AM
You can actually change the code to make it install for SMF 1.1.10.
Look inside "package-info.xml" and change "<install for="1.1.0-1.1.9">" to "<install for="1.1.0-1.1.10">" and it'll install fine (I'm pretty sure).
This is indeed the correct hack in order to make this mod work in SMF 1.1.10.

Quote from: piggeh on September 30, 2009, 09:21:02 AM
I installed this mod onto SMF 2.0 RC1.2 - I have done this on xampp on my memory stick and it worked fine (with SMF 2.0 rc1.2). However, when I have installed it onto my webserver, it installed but it cannot find the settings page (it shows in the dropdown box but with no image next to it). I get a HTTP 500 error when I click on the link to open settings. Any idea on how to fix please?
I can only guess that your problem was that the mod did not install correctly. 500 errors usually mean server misconfiguration though (it's very unlikely that a PHP script failed this way).

Quote from: diablo3x.dk on October 13, 2009, 09:46:53 PM
I am a noob at this so looking for some help...

If I can help with the translation into Danish I would like to offer this service :) I just don't know how to do it.
Unfortunately, you need to know some basic PHP/HTML/CSS in order to modify your theme as needed.
If you want to translate to Danish, please download this file (http://www.simplemachines.org/community/index.php?action=dlattach;topic=318290.0;attach=110098), and edit the strings (after the equal signs).

Quote from: Mush Man on October 13, 2009, 09:49:26 PM
Also, if I updated to the next version of the mod which displays which members have voted on a post,  would the votes that have already been made then display who made those votes?
Yes.

Quote from: smldmr on October 26, 2009, 09:06:38 AM
Here is my edited version. You can copy-paste the text in the language files. It's not 100% correct, but better as before.
I was afraid this would happen. Thank you for your corrections. Or rather, teşekkür ederim :)

Quote from: genenj on October 28, 2009, 04:49:52 PM
I get this error when trying to install this on 1.1.10 default theme. Same when I use a custom theme. Any advice?
Chances are that you have another mod installed that conflicts with the modifications made by GPBP. So you have to edit both Sources/Display.php and Sources/Subs.php manually, following the mod's install instructions (http://custom.simplemachines.org/mods/index.php?action=parse;mod=1890;attach=106987;smf_version=1.1.10).
Please remember to backup your files before editing them. Also, before editing the files run the installer and choose to continue with the install despite the warnings. Of course, if you don't have experience with PHP code, i advice you request help in SMF Coding Discussion.

Quote from: Alleks on November 04, 2009, 06:54:20 AM
Is there any way to allow post voting only to users with "x" amount of posts?
You can do this using post count-based membergroup permissions ( Admin -> Permissions -> Settings -> Enable permissions for post count based groups ). Although this can be messy if you only enable this setting for the GPBP mod.
I'll consider this feature for a future update.

Quote from: Patriiick on November 08, 2009, 04:58:02 AM
I know my forum version is a bit out of date (I have 1.1.7), but I cannot upgrade there is a permission error.
I'm sorry but i'm not able to help you with this SMF version. Hopefully someone else managed to install this mod in a previous SMF version.

Quote from: oleson92 on November 09, 2009, 05:49:19 PM
Is anyone looking at getting this mod updated for RC2?
RC2 brought some changes that broke the GPBP installation. I can't tell you when the next mod version will be out, but i don't think it will be in less than two weeks.
Title: Re: Good Post/Bad Post Mod
Post by: Mush Man on November 17, 2009, 03:08:55 AM
I'm experiencing a strange bug.
For some reason, the value of Respect (I renamed it Smash Coins) doesn't show unless you click one of the arrows. I did edit "install_1.1.x.xml", but I'm pretty sure I didn't break anything.
Click here to view an example. (http://ninstar.co.cc/forum/index.php?topic=112.msg3704#msg3704)
Link to edited installation XML file. (http://rapidshare.com/files/308188072/install_1.1.x.xml)
Title: Re: Good Post/Bad Post Mod
Post by: Mush Man on November 23, 2009, 07:23:23 AM
I've also discovered this error listing itself probably thousands of times in my error log. In fact, I've uninstalled the mod now that I know it's producing so many errors.

8: Undefined index:  gpbp_respect<br />File: /home/ninstar/public_html/forum/Themes/default/Display.template.php (main sub template - eval?)<br />Line: 340

I've checked the original code against the current code and they both match. The code in Line 340 is:

', $txt['gpbp_respect'], ': <span class="gpbp_respect_count_', $message['member']['id'], '">', $message['member']['gpbp_respect'] > 0 ? '+' : '', $message['member']['gpbp_respect'], '</span><br />';


I'm using another theme, but it does not contain a different "Display.template.php".
Any ideas? :S
Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on November 23, 2009, 08:50:08 PM
Could you double check that $txt['gpbp_respect'] = 'Respect'; is in your Modifications.english.php, and any other language you maybe using.
If youre using utf8, then it will also need to be added to that file eg. Modifications.english-utf8.php and so on...
Title: Re: Good Post/Bad Post Mod
Post by: Mush Man on November 24, 2009, 02:25:28 AM
I checked, and the value reads $txt['gpbp_respect'] = 'Smash Coins';. The change from "Respect" to "Smash Coins" is intentional, as I was it to be called "Smash Coins" rather than "Respect".
Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on November 24, 2009, 02:30:35 AM
Double check the edits for your load.php
Title: Re: Good Post/Bad Post Mod
Post by: Mush Man on November 25, 2009, 01:26:38 AM
Actually, SMF did say that there was something wrong with load.php, but after backing up and installing, it appeared OK. Also, I didn't edit the installation area for load.php either.

From my "install_1.1.x" file...

<file name="$sourcedir/Load.php">
<operation>
<search position="before"><![CDATA[b.ID_THEME, b.override_theme, b.permission_mode, b.countPosts]]></search>
<add><![CDATA[,
b.enable_gpbp]]></add>
</operation>

<operation>
<search position="before"><![CDATA['posts_count' => empty($row['countPosts']),]]></search>
<add><![CDATA[
'gpbp_enabled' => !empty($row['enable_gpbp']),]]></add>
</operation>

<operation>
<search position="before"><![CDATA[mem.usertitle' : '');]]></search>
<add><![CDATA[
$select_columns .= ',
mem.gpbp_respect';]]></add>
</operation>

<operation>
<search position="before"><![CDATA[IF(mem.ID_GROUP = 0 OR mg.stars = '', pg.stars, mg.stars) AS stars, mem.passwordSalt";]]></search>
<add><![CDATA[
$select_columns .= ',
mem.gpbp_respect';]]></add>
</operation>

<operation>
<search position="before"><![CDATA['local_time' => timeformat(time() + ($profile['timeOffset'] - $user_info['time_offset']) * 3600, false),]]></search>
<add><![CDATA[
'gpbp_respect' => $profile['gpbp_respect'],]]></add>
</operation>
</file>


And I don't know what I'm looking for in load.php. Should I post it here?
Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on November 25, 2009, 01:31:49 AM
Yeah, if you could attach that file to your next post, we'll check it for you.
Title: Re: Good Post/Bad Post Mod
Post by: Mush Man on November 25, 2009, 08:34:02 AM
You guys are awesome. :D
Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on November 25, 2009, 05:46:19 PM
Try the attached
Title: Re: Good Post/Bad Post Mod
Post by: Mush Man on November 26, 2009, 12:33:57 AM
Whoo! It works now! It fixed the error problem and the problem where the amount of Respect wasn't appearing! Thanks a lot for that! :D :D
Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on November 26, 2009, 01:18:53 AM
My pleasure mate.
I knew exactly what wasn't working, and why.
It is a common thing with those that have the timezone mod installed.
Enjoy :)
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on November 27, 2009, 08:18:34 PM
Quote from: Sabre™ on November 26, 2009, 01:18:53 AM
My pleasure mate.
I knew exactly what wasn't working, and why.
It is a common thing with those that have the timezone mod installed.
Enjoy :)
If you can afford the time, could you be more specific? It would be much appreciated.
Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on November 27, 2009, 09:04:09 PM
Most mods edit the load.php without much hassle,
eg.
adding b.enable_gpbp   to   b.ID_THEME, b.override_theme, b.permission_mode, b.countPosts etc etc..

while others search for this line
'local_time' => timeformat(time() + ($profile['timeOffset'] - $user_info['time_offset']) * 3600, false),

The timezone mod re-writes that whole line to
'local_time' => $localTime,   etc.. etc.. etc..

I think it'd be better to select a line previous to that, just to cover that possibility. It doesn't matter whether the mod searches for another line, it will still function as designed.
This isn't the only mod to search for that line, which is why I'm familiar with it.
Title: Re: Good Post/Bad Post Mod
Post by: Angelotus on December 02, 2009, 08:07:32 AM
Hello,I have manually installed the plugin, as I use SMF 2.0 beta 3 (and not a release candidate).Problem is display.template.php which is heavily modified (please see attachment). Where do I have to put the codes in?
Title: Re: Good Post/Bad Post Mod
Post by: diablo3x.dk on December 12, 2009, 06:27:47 PM
I hope to see this mod compatible with RC2 soon. Great mod :)
Title: Re: Good Post/Bad Post Mod
Post by: smldmr on December 26, 2009, 07:15:26 PM
me too :)
Title: Re: Good Post/Bad Post Mod
Post by: herace on December 29, 2009, 09:26:50 PM
Please, update for RC2.
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on January 18, 2010, 12:19:28 PM
maybe there is a way i can help with the rc2.0 update? i'm too unctuous to wait
...
i'm not much of an expert, but i did fine (http://mila.fm)
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on January 22, 2010, 04:00:23 PM
 :(

anyone got anywere with the update? anyone pinned down the faulty part?
Title: Re: Good Post/Bad Post Mod
Post by: Stigmartyr on January 23, 2010, 01:15:16 PM
Quote from: IdanC on January 22, 2010, 04:00:23 PM
:(

anyone got anywere with the update? anyone pinned down the faulty part?

Please please - release update for SMF 2 RC2 +

What a wonderful mod I cannot use :(
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on January 23, 2010, 02:25:35 PM
its mentioned that this awsome mod worked well on RC1, and breaks on rc2.

do you think that using our collective talents as php nimrods we can find the problem?
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on January 27, 2010, 06:36:15 AM
hi again,

i don't mean to sound rude, but is this mod dead?

obviously i hope not, in my opinion it is one of the best mods available, and one my users keep bugging me about since i upgraded to 2.0rc2.

but if the answer is yes, i need to move on. i can't keep clinging like a teenage girl.

thanks!
Title: Re: Good Post/Bad Post Mod
Post by: Stigmartyr on January 27, 2010, 12:44:31 PM
Quote from: IdanC on January 27, 2010, 06:36:15 AM
hi again,

i don't mean to sound rude, but is this mod dead?

obviously i hope not, in my opinion it is one of the best mods available, and one my users keep bugging me about since i upgraded to 2.0rc2.

but if the answer is yes, i need to move on. i can't keep clinging like a teenage girl.

thanks!

You go on Indan, I'll cling for a while.. :-O
Title: Re: Good Post/Bad Post Mod
Post by: diablo3x.dk on January 28, 2010, 07:23:12 AM
Quote from: IdanC on January 27, 2010, 06:36:15 AM

obviously i hope not, in my opinion it is one of the best mods available, and one my users keep bugging me about since i upgraded to 2.0rc2.

thanks!

/Agreed
Title: Re: Good Post/Bad Post Mod
Post by: Stigmartyr on January 28, 2010, 06:57:53 PM
I can haz SMF 2.0 RC2 upgrade?


I'll get you date with Burt!
Title: Re: Good Post/Bad Post Mod
Post by: Stigmartyr on February 01, 2010, 08:31:11 PM
Quote from: Stigmartyr on January 28, 2010, 06:57:53 PM
I can haz SMF 2.0 RC2 upgrade?


I'll get you date with Burt!


Please!
Title: Re: Good Post/Bad Post Mod
Post by: Stigmartyr on February 04, 2010, 04:51:56 AM
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fgizmodo.com%2Fimages%2F2006%2F05%2Fteddybeargun.jpg&hash=f877822edc9a7b427845b2da5330c9adda23b1d3)

RC2 or the bear get's it..
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on February 04, 2010, 05:09:25 AM
i just spent like two days trying to make PostRating mod (the one with the stars) behave more to my liking, but it still not half as good as YOUR MOD!

please, come out of your shell and tell us something...
Title: Re: Good Post/Bad Post Mod
Post by: diablo3x.dk on February 05, 2010, 06:17:37 PM
Did anyone try to pm him?
Title: Re: Good Post/Bad Post Mod
Post by: Stigmartyr on February 05, 2010, 06:22:23 PM
Quote from: diablo3x.dk on February 05, 2010, 06:17:37 PM
Did anyone try to pm him?

Not yet.. didn't want to spam him.  Go for it though!  We need this for RC2
Title: Re: Good Post/Bad Post Mod
Post by: Snogmarr on February 05, 2010, 06:37:16 PM
http://www.simplemachines.org/community/index.php?topic=362862.360

suggest you read this first
Title: Re: Good Post/Bad Post Mod
Post by: tbk22 on February 05, 2010, 08:33:40 PM
This mod is sweet ... I would also love it for SMF 2 RC2
Title: Re: Good Post/Bad Post Mod
Post by: Stigmartyr on February 05, 2010, 08:34:38 PM
Quote from: xnathansxdadx on February 05, 2010, 06:37:16 PM
http://www.simplemachines.org/community/index.php?topic=362862.360

suggest you read this first

Looks like a big problem in little china, to me.  How does it relate to this mod?
Title: Re: Good Post/Bad Post Mod
Post by: Snogmarr on February 05, 2010, 10:55:09 PM
 Re: Good Post/Bad Post Mod
« Reply #133 on: November 27, 2009, 08:18:34 PM »

last time active on this thread?


February 01, 2010, 12:00:03 PM
Last time active on this site

Last time active prior
Dec 30th


don't hold your breath, thats all I am saying.

12 weeks and nothing?????????????????? hmmmmmmmmmmmmmmm!

Seen so many great mods dissapear into oblivion.
Title: Re: Good Post/Bad Post Mod
Post by: Stigmartyr on February 05, 2010, 10:56:58 PM
Quote from: xnathansxdadx on February 05, 2010, 10:55:09 PM
Re: Good Post/Bad Post Mod
« Reply #133 on: November 27, 2009, 08:18:34 PM »

last time active on this thread?


February 01, 2010, 12:00:03 PM
Last time active on this site

Last time active prior
Dec 30th


don't hold your breath, thats all I am saying.

12 weeks and nothing?????????????????? hmmmmmmmmmmmmmmm!

Seen so many great mods dissapear into oblivion.

I'd donate some money to its development even.  Nothing wrong with them saying their time is stretched with paying real bills.
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on February 06, 2010, 07:00:47 AM
i'd too be willing to put some money to it
Title: Re: Good Post/Bad Post Mod
Post by: Runevald on February 14, 2010, 06:50:08 PM
I will donate also.
Just get this working dude.
Title: Re: Good Post/Bad Post Mod
Post by: BxK on February 15, 2010, 09:22:39 PM
my attempt of fixing this mod... download the mod. visit here... http://www.empireofthesun.net/forum/index.php?topic=5641.0

If you recieve an error ect let me know! and I will fix!
Title: Re: Good Post/Bad Post Mod
Post by: Snogmarr on February 16, 2010, 12:54:10 PM
'fancyach_smf.messages'

error creating table,,,, this issue is still here and still the same as before/.
Title: Re: Good Post/Bad Post Mod
Post by: BxK on February 17, 2010, 07:56:25 PM
ok i will fix that i just noticed that.
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on February 18, 2010, 05:42:01 AM
 :D

make sure you put a link to donate some to show our appreciation
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on February 18, 2010, 10:09:40 PM
First of all, I deeply apologize for having created such expectations. I've been busy and then needed a break of coding.
But I'm back now, so I'll just resume the long-delayed mod update for SMF 2 RC2. ;) Expect an update soon.

Quote from: Stigmartyr on February 04, 2010, 04:51:56 AM
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fgizmodo.com%2Fimages%2F2006%2F05%2Fteddybeargun.jpg&hash=f877822edc9a7b427845b2da5330c9adda23b1d3)

RC2 or the bear get's it..
Please don't  :-\
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on February 19, 2010, 01:56:47 AM
Quote from: OutofOrder on February 18, 2010, 10:09:40 PM
First of all, I deeply apologize for having created such expectations. I've been busy and then needed a break of coding.
But I'm back now, so I'll just resume the long-delayed mod update for SMF 2 RC2. ;) Expect an update soon.

may god give you good crops  :)

Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on February 19, 2010, 08:19:28 AM
Unless someone comes with a good reason why I shouldn't, I'm going to change the way images are installed by this mod.
As of the current version, the mod installs images in the default template directory and uses them all over the forum. But this is going to change to a per-theme basis, allowing admins to customize button images to better work with their custom themes without breaking the visual style in other themes.
This also means that custom theme installs will take an additional step for forum admins: for each theme they use they will need to create a copy of the mod's images in their theme's /images folder.

Edit: If you excuse me, I will also drop mod support for SMF 2 RC1.x :(
Given the immense code overhaul that happened between RC1 and RC2 (plus the benefits of hundreds of bugfixes and new features), maintaining GPBP support for the older version is a really bad idea and possibly a waste of effort.
I don't intend to tell forum admins what to do, but there shouldn't be enough reason not to have updated to the most recent SMF 2 version.
I'll also test upgrading from SMF RC1.2 to SMF 2 with GPBP mod installed, and see if a special upgrading script is needed, for those that got caught in the process.
Title: Re: Good Post/Bad Post Mod
Post by: diablo3x.dk on February 19, 2010, 06:25:41 PM
Welcome back OutofOrder! Looking very much forward to your mod for RC2 :)
Have been checking this topic several times in hope of your arrival ;)
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on February 19, 2010, 10:15:31 PM
The mod was updated to 1.1.3, and now provides SMF 2 RC2 and SMF 1.1.11 compatibility. Please check the first post for more information.


For those using SMF 2 RC2 and the Core theme, here's a guide on the modifications needed for this theme.

FILE: Display.template.php
Search:
$ignoring = false;
Add after:

// If this post is a Bad Post take actions according to the theme settings.
$gpbp_badPost = false;
$gpbp_action = 'none';
if ($context['gpbp_enabled'])
{
$gpbp_badPost = $message['gpbp_score'] <= $modSettings['gpbp_hide_threshold'];
if ($gpbp_badPost)
{
/* The 'gpbp_hide_action' option may have one out of three values:
0: by default hide post contents,
1: display greyed-out post contents,
2: display post contents regardless.
Remember to force post display for certain Bad posts: own or chosen.
*/
if (($message['member']['id'] == $context['user']['id'] && !$message['member']['is_guest']) || $message['id'] == $context['gpbp_revealed'])
$gpbp_action = 'grey';
else
$gpbp_action = !empty($options['gpbp_hide_action']) ? ($options['gpbp_hide_action'] == 1 ? 'grey' : 'none') : 'hide';
}
}


Search:
<div class="bordercolor">';
Replace with:
<div class="bordercolor"', $gpbp_action == 'hide' ? ' id="gpbp_hidden_' . $message['id'] . '"' : '' ,'>';

Search:
($message['alternate'] == 0 ? 'windowbg' : 'windowbg2')
Replace with:
($gpbp_action == 'hide' ? 'gpbp_hider ' : '') . ($gpbp_badPost && $gpbp_action != 'none' ? 'gpbp_greyed' : ($message['alternate'] == 0 ? 'windowbg' : 'windowbg2'))

Search:
// Any custom fields to show as icons?
Add before it
// Show their amount of Respect.
if ($context['gpbp_enabled'] && !empty($modSettings['gpbp_display_respect']))
echo '
<li class="margintop">', $txt['gpbp_respect'], ': <span class="gpbp_respect_count_', $message['member']['id'], '">', $message['member']['gpbp_respect'] > 0 ? '+' : '', $message['member']['gpbp_respect'], '</span></li>';



Search:
echo '
</div>';

// Ignoring this user? Hide the post.

Add before it:
// Good Post/Bad Post score and voting.
if ($context['gpbp_enabled'])
{
$message['gpbp_score'] = ( $message['gpbp_score'] > 0 ? '+' : '' ) . $message['gpbp_score'];
echo '
<div class="gpbp_vote">
<span id="gpbp_score_', $message['id'], '" class="help" title="', $txt['gpbp_post_score'], '">', $message['gpbp_score'], '</span>';

if ($context['can_vote_gpbp'] && !$ignoring && $message['member']['id'] != $context['user']['id'])
{
echo '
<a onclick="oVotePost.vote(\'down\', \'', $message['id'], '\', \'', $context['session_id'], '\'); return false" href="', $scripturl, '?action=gpbp;sa=down;msg=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], ';board=', $context['this_board'], ';topic=', $context['current_topic'], '"><img class="gpbp_vote_img" id="gpbp_vote_down_', $message['id'], '" src="', $settings['images_url'], '/gpbp_arrow_down', $message['gpbp_img']['down']['lit_suffix'], '.gif" alt="', $txt[ $message['gpbp_img']['down']['alt'] ], '" title="', $txt[ $message['gpbp_img']['down']['title'] ], '" /></a>
<a onclick="oVotePost.vote(\'up\', \'', $message['id'], '\', \'', $context['session_id'], '\'); return false" href="', $scripturl, '?action=gpbp;sa=up;msg=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], ';board=', $context['this_board'], ';topic=', $context['current_topic'], '"><img class="gpbp_vote_img" id="gpbp_vote_up_', $message['id'], '" src="', $settings['images_url'], '/gpbp_arrow_up', $message['gpbp_img']['up']['lit_suffix'], '.gif" alt="', $txt[ $message['gpbp_img']['up']['alt'] ], '" title="', $txt[ $message['gpbp_img']['up']['title'] ], '" /></a>';
}

echo  '
</div>';
}



Search:
$message['body']
Replace with:
$gpbp_badPost && !$context['reveal_bad_post'] ? '' : $message['body']

Search:
echo '
</div>
<div class="moderatorbar">

Add before it:
// If a Bad Post must be hidden, only display its date and a "Show" link... nothing else.
if ($gpbp_badPost && $gpbp_action == 'hide')
echo '
</div>
<div class="postarea gpbp_do_show">
<div class="middletext">
', $message['time'], ' - <em>', $txt['gpbp_hidden'], '</em>', $context['reveal_bad_post'] ? ' <a class="gpbp_show" onclick="gpbp_show_post(\'' . $message['id'] . '\'); return false" href="' . $message['href_gpbp_show'] . '">' . $txt['gpbp_show'] . '</a>' : '', '
</div>';



Search:
echo '
// ]]></script>';

Add before it:
if ($context['gpbp_enabled'])
echo '
var oVotePost = new PostVoting({
sSessionVar: "', $context['session_var'], '",
iBoard: ', $context['this_board'], ',
iTopic: ', $context['current_topic'], ',
sVoteDownAlt: "', $txt['gpbp_vote_down'], '",
sVoteUpAlt: "', $txt['gpbp_vote_up'], '",
sVotedDownAlt: "', $txt['gpbp_voted_down_alt'], '",
sVotedUpAlt: "', $txt['gpbp_voted_up_alt'], '",
sVotedDown: "', $txt['gpbp_voted_down'], '",
sToVoteDown: "', $txt['gpbp_to_vote_down'], '",
sVotedUp: "', $txt['gpbp_voted_up'], '",
sToVoteUp: "', $txt['gpbp_to_vote_up'], '",
sScriptUrl: "', $scripturl, '",
sImagesUrl: "', $settings['images_url'], '"
});';




FILE: Stats.template.php
Search:
<td width="20%" align="right" valign="top" nowrap="nowrap">', $poster['time_online'], '</td>
</tr>';

Add after:

if (!empty($modSettings['gpbp_display_stats']))
{
echo '
</table>
</td>
</tr><tr>
<td class="catbg" colspan="2" width="50%"><b>', $txt['gpbp_top_voters'], '</b></td>
<td class="catbg" colspan="2" width="50%"><b>', $txt['gpbp_most_respected'], '</b></td>
</tr><tr>
<td class="windowbg" width="20" valign="middle" align="center"><img src="', $settings['images_url'], '/stats_posters.gif" width="20" height="20" alt="" /></td>
<td class="windowbg2" width="50%" valign="top">
<table border="0" cellpadding="1" cellspacing="0" width="100%">';
foreach ($context['gpbp_top_voters'] as $poster)
echo '
<tr>
<td width="60%" valign="top">', $poster['link'], '</td>
<td width="20%" align="left" valign="top">', $poster['votes'] > 0 ? '<img src="' . $settings['images_url'] . '/bar.gif" width="' . $poster['votes_percent'] . '" height="15" alt="" />' : '&nbsp;', '</td>
<td width="20%" align="right" valign="top">', $poster['votes'], '</td>
</tr>';
echo '
</table>
</td>
<td class="windowbg" width="20" valign="middle" align="center" nowrap="nowrap"><img src="', $settings['images_url'], '/stats_posters.gif" width="20" height="20" alt="" /></td>
<td class="windowbg2" width="50%" valign="top">
<table border="0" cellpadding="1" cellspacing="0" width="100%">';
foreach ($context['gpbp_most_respected'] as $poster)
echo '
<tr>
<td width="60%" valign="top">', $poster['link'], '</td>
<td width="20%" align="left" valign="top">', $poster['respect'] > 0 ? '<img src="' . $settings['images_url'] . '/bar.gif" width="' . $poster['respect_percent'] . '" height="15" alt="" />' : '&nbsp;', '</td>
<td width="20%" align="right" valign="top" nowrap="nowrap">', $poster['respect'], '</td>
</tr>';
}



FILE: Settings.template.php
Search:
2 => $txt['display_quick_mod_image'],
),
'default' => true,
),

Add after:
array(
'id' => 'gpbp_hide_action',
'label' => $txt['gpbp_hide_action'],
'options' => array(
0 => $txt['gpbp_hide_action_hide'],
1 => $txt['gpbp_hide_action_grey'],
2 => $txt['gpbp_hide_action_none'],
),
'default' => true,
),


Finally, download, unpack and upload the files from the attached zip file into the Core theme folder. That's it, you should get it up and running!
Title: Re: Good Post/Bad Post Mod
Post by: smldmr on February 19, 2010, 10:16:02 PM
Wow. Thank You for the update. I installed it immediately on my board.
Title: Re: Good Post/Bad Post Mod
Post by: diablo3x.dk on February 20, 2010, 09:12:00 AM
So, what if I want this to work with custom theme? :)
Title: Re: Good Post/Bad Post Mod
Post by: smldmr on February 20, 2010, 09:29:03 AM
Hello, now, after i installed this mod, my server have more than 1400 connections at the same time. All of the connection request are comming from the index.php.
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on February 20, 2010, 10:25:06 AM
I've updated the instructions to install this mod in custom themes.
Click here to download them (http://www.simplemachines.org/community/index.php?action=dlattach;topic=318290.0;attach=135322) ;)


Quote from: smldmr on February 20, 2010, 09:29:03 AM
Hello, now, after i installed this mod, my server have more than 1400 connections at the same time. All of the connection request are comming from the index.php.
Hi. I don't know how active your forums are, but is that too much for your normal activity? In that case, this may mean that you have bots registered in your forum and they're crawling the voting links in your threads.
Title: Re: Good Post/Bad Post Mod
Post by: Snogmarr on February 20, 2010, 11:05:21 AM
I appear to be having a problem,
I can see the hide grey out and do nothing option but nothing else,  I have looked in admin, mods, features options,, modify boards, and posts and topics and there is nothing? Running default theme in 2 rc2
Any advise please ?
Title: Re: Good Post/Bad Post Mod
Post by: diablo3x.dk on February 20, 2010, 12:45:52 PM
QuoteNote: If your custom theme doesn't include a Display.template.php file, it means there's nothing to edit for the
mod to properly work.

I use this theme: http://custom.simplemachines.org/themes/index.php?lemma=2049
No display.tamplate.php file as far as I'm concerned. Does this mean I can't use the mod?  :-[ Or is it just that I don't need to concern that part of the manual instructions?
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on February 20, 2010, 01:29:45 PM
Quote from: xnathansxdadx on February 20, 2010, 11:05:21 AM
I can see the hide grey out and do nothing option but nothing else,  I have looked in admin, mods, features options,, modify boards, and posts and topics and there is nothing? Running default theme in 2 rc2
Any advise please ?
I don't understand what your problem is. You don't see the voting buttons? Did the mod install without problems?

Quote from: diablo3x.dk on February 20, 2010, 12:45:52 PM
No display.tamplate.php file as far as I'm concerned.
Then it should be using the Display.template.php file from the Curve theme, which means you don't have to worry about that file :)
Title: Re: Good Post/Bad Post Mod
Post by: smldmr on February 20, 2010, 01:36:19 PM
Quote from: OutofOrder on February 20, 2010, 10:25:06 AM
Hi. I don't know how active your forums are, but is that too much for your normal activity? In that case, this may mean that you have bots registered in your forum and they're crawling the voting links in your threads.


Normally, my all server has about 400 connections (ther are 4 webcams, their connections are the most of them). How can i forbit it to the bots?
Title: Re: Good Post/Bad Post Mod
Post by: diablo3x.dk on February 20, 2010, 02:08:55 PM
QuoteThen it should be using the Display.template.php file from the Curve theme, which means you don't have to worry about that file :)

Cool. Will try it out. Thanks :)
Title: Re: Good Post/Bad Post Mod
Post by: Snogmarr on February 20, 2010, 03:02:25 PM
Quotedon't understand what your problem is. You don't see the voting buttons? Did the mod install without problems?

Yes it did but I then looked in the error log and received this


-http://-------------- Forums/index.php?/topic,18.0.html

8: Undefined index: gpbp_enabled

File: -------------------Member-Forums/Sources/Display.php
Line: 1492

Which shows this

1488:
   
// Good Post Bad Post mod 1489:
   
$context['this_board'] = $board; 1490:
   
$context['gpbp_votes'] = array(); 1491:
   
// Not a mistake! That's a single equals. ==>1492:
   
if ($context['gpbp_enabled'] = $board_info['gpbp_enabled']) 1493:
   
{
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on February 20, 2010, 07:02:20 PM
There's probably a bad edit in your Load.php file.
Please go to the mod page (http://custom.simplemachines.org/mods/index.php?mod=1890), open the mod installation instructions for your smf version and check that the 5 edits are in place, comparing to your own Load.php file.
Title: Re: Good Post/Bad Post Mod
Post by: diablo3x.dk on February 20, 2010, 08:21:21 PM
Got it working on my test page. Will install on main first thing tomorrow.
Title: Re: Good Post/Bad Post Mod
Post by: diablo3x.dk on February 21, 2010, 07:06:48 AM
:( Did not work on my main site. It uses the same theme as my test site. Strange.

/edit

After some edits it seems to work. But as you can see there is double up on the arrows :P
http://forum.diablo3x.dk/index.php?topic=1596.msg29390;topicseen#msg29390
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on February 21, 2010, 08:19:47 AM
Quote from: diablo3x.dk on February 21, 2010, 07:06:48 AM
:( Did not work on my main site. It uses the same theme as my test site. Strange.

/edit

After some edits it seems to work. But as you can see there is double up on the arrows :P
http://forum.diablo3x.dk/index.php?topic=1596.msg29390;topicseen#msg29390
Have you set membergroup permissions to allow voting?
If the mod installed without warnings, you shouldn't need any additional edits.
Title: Re: Good Post/Bad Post Mod
Post by: diablo3x.dk on February 21, 2010, 08:34:37 AM
Oh, I had to edit in admin and display.template.

And yes. It all works well. It is just the double up on arrows ;)

You got any suggestions? Can attach files if needed.
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on February 21, 2010, 09:08:12 AM
Quote from: diablo3x.dk on February 21, 2010, 08:34:37 AM
You got any suggestions? Can attach files if needed.
Please attach your Display.template.php file.
Title: Re: Good Post/Bad Post Mod
Post by: diablo3x.dk on February 21, 2010, 10:57:02 AM
Attached in this post.

I installed it once, then uninstalled. The installed again. I guess the problem is caused by that, although I thought I made sure to remove all edits from the mod.
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on February 22, 2010, 09:51:54 AM
Quote from: diablo3x.dk on February 21, 2010, 10:57:02 AM
I installed it once, then uninstalled. The installed again. I guess the problem is caused by that, although I thought I made sure to remove all edits from the mod.
Most edits were duplicate, so it possibly didn't correctly uninstall the first time.
Try with this file.
Title: Re: Good Post/Bad Post Mod
Post by: diablo3x.dk on February 22, 2010, 10:28:12 AM
Great! Everything is perfect now! Thanks alot for your great mod.
Are you planning on updating it with further features? I have a few in mind ;)
Title: Re: Good Post/Bad Post Mod
Post by: lsftim on March 04, 2010, 03:12:20 AM
tried for a couple of hours to get this to work and no bueno...im using the Fussilet template.. i don't know if theres something im doing wrong..can someone please help..
Title: Re: Good Post/Bad Post Mod
Post by: Tanks on March 05, 2010, 06:02:03 AM
This is a great mod, thanks for sharing.

Is it possible to show the score on the messageindex ?
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on March 05, 2010, 08:10:28 AM
First of all.
Good Post / Bad Post v2.0 is now available. ;D
This is a SMF 2 RC2+ only release. Please check the first post to know more about it.

I will later add updated files for adding this new version to custom themes, and also regarding translations and the new text files.

Edit: also, I earlier updated the v1.1.3 release because it had a missing xml file which should have broken the mod installation process in SMF 1.1.x, although no one ever reported this.


Quote from: lsftim on March 04, 2010, 03:12:20 AM
tried for a couple of hours to get this to work and no bueno...im using the Fussilet template.. i don't know if theres something im doing wrong..can someone please help..
Please at least mention what SMF version you're using, and add a link to the theme and perhaps you will be assisted. By someone.

Quote from: Tanks on March 05, 2010, 06:02:03 AM
Is it possible to show the score on the messageindex ?
Do you mean the score of the first post of a topic?
Title: Re: Good Post/Bad Post Mod
Post by: Tanks on March 05, 2010, 08:19:39 AM
Yeah showing the score of the first post inside each topic on the messageindex would be cool.

I am running a movies site and i could use this so the members could see if posted movies has good or bad score.

If you do not want it in the mod maybe you could show me the code to add to messageindex.template.php file :) Curve theme.

Cheers
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on March 05, 2010, 08:26:56 AM
Unfortunately, such feature would need more than just an edit in MessageIndex.template.php (although possibly not more than a simple edit in MessageIndex.php).

I will consider this feature for a future release, thanks.
Title: Re: Good Post/Bad Post Mod
Post by: Tanks on March 05, 2010, 08:53:16 AM
Ok fair enough :) Thank you for considering this feature :) Maybe it could show the overall score of all the scores in a topic ?
Title: Re: Good Post/Bad Post Mod
Post by: tbk22 on March 05, 2010, 08:59:54 AM
Is it possible to have like on member list or profile the members with most + on their posts or something like that?
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on March 05, 2010, 11:19:55 AM
GP/BP v2.0 added many new text strings, meaning that the previous translations available are outdated.
I have three incomplete translations for this version: Turkish, French and Russian (this one soon to be added to the older v1.1.3 release).
If anyone is willing to translate this mod to their language or to update the incomplete translations, please download this file
http://www.simplemachines.org/community/index.php?action=dlattach;topic=318290.0;attach=136539
Read the Readme.txt file and follow the instructions.

Thanks in advance.


Edit: Updated the theme customising guide for SMF 2. Check the first post!


Quote from: tbk22 on March 05, 2010, 08:59:54 AM
Is it possible to have like on member list or profile the members with most + on their posts or something like that?
Something like a fan list? Would there be a point in this? If a person receives enough votes from enough members, it won't really make a difference who are the two or three members that voted him most...
Title: Re: Good Post/Bad Post Mod
Post by: tbk22 on March 05, 2010, 04:03:50 PM
Quote from: OutofOrder on March 05, 2010, 11:19:55 AM


Quote from: tbk22 on March 05, 2010, 08:59:54 AM
Is it possible to have like on member list or profile the members with most + on their posts or something like that?
Something like a fan list? Would there be a point in this? If a person receives enough votes from enough members, it won't really make a difference who are the two or three members that voted him most...

No I was looking for somethings more like Thank you mod that can display on the profile the number of thans the user has received

It would be like a sign that the user was trustable on that forum depending on his good post/bad post stats
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on March 05, 2010, 06:15:52 PM
Quote from: tbk22 on March 05, 2010, 04:03:50 PM
Quote from: OutofOrder on March 05, 2010, 11:19:55 AM


Quote from: tbk22 on March 05, 2010, 08:59:54 AM
Is it possible to have like on member list or profile the members with most + on their posts or something like that?
Something like a fan list? Would there be a point in this? If a person receives enough votes from enough members, it won't really make a difference who are the two or three members that voted him most...

No I was looking for somethings more like Thank you mod that can display on the profile the number of thans the user has received

It would be like a sign that the user was trustable on that forum depending on his good post/bad post stats
Well if you disable negative votes then the number of Respect members have on their profiles will be exactly what you're asking. You could rename "Respect" to "Thanks received" in the language files and there you go. :)
Title: Re: Good Post/Bad Post Mod
Post by: Ryoki on March 07, 2010, 06:00:10 PM
i had liked to try it out, but it just does not do anything.
I have installed the mod without errors but nothing changed.

I just get this error log


http://www.weg-des-stifts.de/smf/index.php?action=admin;area=packages;sa=install2;package=GoodPostBadPost.2.0.zip;pid=0
8: Undefined index: theme
Datei: /var/www/web1168/html/smf/Sources/Packages.php
Zeile: 935


I hope you can help. :-)
Title: Re: Good Post/Bad Post Mod
Post by: Snogmarr on March 07, 2010, 08:43:49 PM
I wonder if you can help?
I have done all the edits manually because my site is heavily modded,

But I just cannot work out the below,, it is doing my head in.lol
All the edits and stumped by this.


Find: [Select]
$message['body']
Add Before: [Select]
$gpbp_badPost && !$context['reveal_bad_post'] ? '' :

Have attached my display template php
thanks
Title: Re: Good Post/Bad Post Mod
Post by: smldmr on March 08, 2010, 07:40:03 PM
If you allready installed the old version, on upgrade you will get a not functioning vote system. You must add the field "log_time" in the table smf_log_gpbp. after that, it is functioning.

but i can't chose the thumbset. i must do it manualy in phpmyadmin.

and in display.template.php, you wrote $settings['images_url'], '/gpbp', $gpbp_set, '_arrow_down', for image names. this generates file names like gpbp1_arrow_down.png etc. but the image files are named like gpbp_1_arrow_down.png
Title: Re: Good Post/Bad Post Mod
Post by: Snogmarr on March 08, 2010, 08:58:45 PM
Ah Ah sussed it

wow its a clever mod
Title: Re: Good Post/Bad Post Mod
Post by: KensonPlays on March 08, 2010, 09:22:01 PM
doesn't work for me! I did edit that failed in admin.php, and nothing changed in admin!
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on March 09, 2010, 10:08:23 AM
it looks like its working on rc3, i'm still testing, updates soon...
Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on March 09, 2010, 10:40:22 AM
It should work as it did in RC2.
There are no immediate changes needed to the code for compatibility, only to the install file to accommodate for RC3.
But even that isn't needed because of the 'advanced' feature in the SMF2 series.
Title: Re: Good Post/Bad Post Mod
Post by: KensonPlays on March 09, 2010, 11:10:39 AM
Still doesn't work :( :( :(
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on March 09, 2010, 11:22:54 AM
nevertheless, i came across a few issues, but managed to overcome them.

for the chance that i'm not the only one, here are my tip & tweaks -

ALTER TABLE `smf_messages` CHANGE `gpbp_score` `gpbp_score` SMALLINT( 6 ) NOT NULL DEFAULT '0'
Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on March 09, 2010, 11:43:54 AM
Nevertheless your issues have risen from a previous install, and not the version available.
It seems whatever version you were using, either didn't have a call to remove the db additions, or failed while uninstalling.
For those that do not know how to add fields etc into your db, just drop the old tables etc and install the new version of the mod.(if following the above post)

EDIT:
Quote from: IdanC on March 09, 2010, 11:22:54 AM
  • .... voting down gave a huge number....

I didnt check this, and you were right!
Thank You very much for the info :)

@ Kcmartz
Are there any errors in your log pertaining to this mod?
Are you using the default theme or a custom theme?
Did you install it manually or through the Package Manager, if so, were there any errors on installation?
Have you checked that the edits to your templates were made correct?
What exactly isn't working for you? Do you mean that a certain area isn't working, or the complete mod itself isn't?
And last but not least, if you think the sky was blue the last clear day of mid January, will Friday of the second week of next month at 7am be fine or overcast?
Title: Re: Good Post/Bad Post Mod
Post by: Bugo on March 09, 2010, 12:29:16 PM
Errors in Log:

QuoteUndefined index: gpbp_score
File: /Sources/Display.php
Line: 1409

Line 1409:
Quote'gpbp_score' => $message['gpbp_score'],
Title: Re: Good Post/Bad Post Mod
Post by: KensonPlays on March 09, 2010, 01:11:56 PM
Are there any errors in your log pertaining to this mod? Not that I can see
Are you using the default theme or a custom theme? Raven Theme, as well as default, and about 10 others
Did you install it manually or through the Package Manager, if so, were there any errors on installation? Through package manager, except for admin.php, which I had to try manually :(
Have you checked that the edits to your templates were made correct? Yes, I am sure (at least, 75%)
What exactly isn't working for you? Do you mean that a certain area isn't working, or the complete mod itself isn't? Maybe the whole mod, but it is the admin area that won't show!
And last but not least, if you think the sky was blue the last clear day of mid January, will Friday of the second week of next month at 7am be fine or overcast? I don't know!
Title: Re: Good Post/Bad Post Mod
Post by: Snogmarr on March 09, 2010, 05:05:36 PM
Just spent two hours checking this mod in RC3

It works perfectly well

Except for one minor issue.

If the voting is zero and you give a member a negative vote, the mod does not recognise -1
(minus one) so it defaults to the database max byte value!.... Ie it sets itself at +65535 or whatever 64bit systems max at.
So you get +65535 votes lol

Every time you give a + vote it increases this value by one and will not zero back, it jumps between 65534 and 65535.

whoops did not see IdanC had already put this!
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on March 10, 2010, 12:39:15 AM
People, DO NOT ASK FOR RC3 SUPPORT until the next GP/BP version is out. Or you're on your own.
That said, I want to thank all the brave RC3 compatibility testers. ;) I noticed there were some changes in Display.php and also in the Db-xxxxx.php sources which may have affected the mod's intallation and performance.
I hope to release an update soon.

Quote from: Ryoki on March 07, 2010, 06:00:10 PM
I have installed the mod without errors but nothing changed.
*snip*

http://www.weg-des-stifts.de/smf/index.php?action=admin;area=packages;sa=install2;package=GoodPostBadPost.2.0.zip;pid=0
8: Undefined index: theme
Datei: /var/www/web1168/html/smf/Sources/Packages.php
Zeile: 935

Hmm this error message doesn't really tell me anything :-X Looks more like a SMF bug.
After looking at the mentioned line Packages.php in RC2, I would guess that the mod did not install in any of your themes (or rather, in Curve). You're most likely going to have to edit the theme(s) manually.


Quote from: smldmr on March 08, 2010, 07:40:03 PM
but i can't chose the thumbset. i must do it manualy in phpmyadmin.
What happens if you try to change the button set? Does it give you an error or log an error?


Quote from: xnathansxdadx on March 08, 2010, 08:58:45 PM
Ah Ah sussed it
Meaning you solved your problem?


Quote from: Kcmartz on March 09, 2010, 11:10:39 AM
Still doesn't work :( :( :(
The only failed edit was in Admin.php? Then please upload this file, and maybe someone will look into it. Only if you're still using SMF 2 RC2. Otherwise, please wait for the next version.


Quote from: Sabre™ on March 09, 2010, 11:43:54 AM
EDIT:
Quote from: IdanC on March 09, 2010, 11:22:54 AM
  • .... voting down gave a huge number....
I didnt check this, and you were right!
:o
Title: Re: Good Post/Bad Post Mod
Post by: Sabre™ on March 10, 2010, 12:43:47 AM
 :o Problem? :o
If you cannot understand the comment, then read the complete post(s)
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on March 10, 2010, 06:48:35 AM
Quote from: Sabre™ on March 10, 2010, 12:43:47 AM
:o Problem? :o
If you cannot understand the comment, then read the complete post(s)
I did understand. Was just being surprised because of that bug. ;)


Quote from: xnathansxdadx on March 10, 2010, 12:48:25 AM
One more thing to make note of is that guests cannot vote,,,,,, all they see is a number,,,, and the voting list locks up,,,, check it out
Guests can not and will never be able to vote. This is not a mistake or a bug, it's how it was meant to be.
About the voter list problem, I can't figure out if your problem is because of permissions of because of sessions (or something else): please check your error log when a guest tries to access the voters list and paste the error here (there should be an error).
Title: Re: Good Post/Bad Post Mod
Post by: KensonPlays on March 10, 2010, 10:58:19 AM
OutofOrder, I will wait until update anyway...
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on March 10, 2010, 12:17:59 PM
A first impression is that SMF 2 RC3 is specifying the unsigned attribute to numerical columns when adding/updating columns. I've checked Db-packages but the code seems to be alright.
This is baffling. I've tried to explicitly set signed columns (as opposed to before when I just left it to the default value) but the result is the same: the new columns are always saved as unsigned numericals  >:(
I'm trying my best to find the problem in my own code before assuming it's a SMF bug. Oh well.

(Does anyone know if similar problems have arised in other mods that modify SMF database tables in RC3?)
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on March 11, 2010, 04:42:24 PM
In the end, I had to resort to a (not so elegant) workaround for this problem.
The new version GP/BP 2.0.1 is out, supporting RC3 and addressing the problems arised.

To all SMF 2 RC3 admins that had already installed this mod and experienced the "huge number" problem:
Please have in mind that the recounting process may be demanding for your server, depending on your server load and amount of votes sent (hundreds to thousands of votes). Enable Maintenance mode before attempting to run this tool.

Enjoy another GP/BP release.
And please report back of any problems, which hopefully there should be none. :)
Title: Re: Good Post/Bad Post Mod
Post by: Snogmarr on March 16, 2010, 06:33:42 PM
doubled up on everything,,,,
been through files just cant find script to remove?

see pic
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on March 16, 2010, 06:47:54 PM
Quote from: xnathansxdadx on March 16, 2010, 06:33:42 PM
doubled up on everything,,,,

shouldn't be too hard: most likely an uninstall couldn't remove the changes in display.template, and the reinstall just applied them again.

try editing Display.template.php, find the double piece of code and remove one of it...

but - i could be wrong...
Title: Re: Good Post/Bad Post Mod
Post by: Snogmarr on March 16, 2010, 07:03:43 PM
looked in every associated php file ,,, that's why I posted but will go look again just in case

Note
well bugger me must have missed that

Thanks  IdanC
Title: Re: Good Post/Bad Post Mod
Post by: Snogmarr on March 16, 2010, 07:17:53 PM
well bugger me, must have misswd that


thanks a lot  :-[
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on March 16, 2010, 07:18:49 PM
happy to help!  :)
Title: Re: Good Post/Bad Post Mod
Post by: TurtleKicker on March 25, 2010, 05:12:02 PM
I really want to try this out. I've installed it on my test SMF2 RC3 forum.

The install test only failed on one edit of one file (sources/Display.php) but it was a trivial and simple edit. However, I can't get the admin part to appear.

I'm using the Overview Light theme (and I did check the box to install into that theme too, which it did with no errors), but I also tried switching back to Curve and I still can't find the admin panel for this mod.

Suggestions?
Title: Re: Good Post/Bad Post Mod
Post by: wwwserfer on March 26, 2010, 11:16:40 AM
in SMF 2.0 this feature present:

Quote- Toggle voters lists to see who voted on a post (and what was the vote).

in SMF 1.1.11 possible to do:

- who & how voted list

Thanks!
Title: Re: Good Post/Bad Post Mod
Post by: TurtleKicker on March 26, 2010, 11:24:49 AM
Follow-up: I found the controls in the admin panel. I have SimplePortal installed and for some reason, it put the control panel under the SimplePortal menu as opposed to the Forum menu.

So I've got it working now but this is certainly a bug if a user has SP installed. It doesn't belong there.
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on March 27, 2010, 02:08:39 AM
Quote from: wwwserfer on March 26, 2010, 11:16:40 AM
in SMF 1.1.11 possible to do:
- who & how voted list
Hi. This mod won't be updated anymore for SMF 1.1.x except in the case a new SMF update breaks it. Thanks for your comment.
Quote from: sremick on March 26, 2010, 11:24:49 AM
Follow-up: I found the controls in the admin panel. I have SimplePortal installed and for some reason, it put the control panel under the SimplePortal menu as opposed to the Forum menu.

So I've got it working now but this is certainly a bug if a user has SP installed. It doesn't belong there.
Hello. Unfortunately I'm not familiar with the inner workings of SimplePortal. Maybe someone else has experimented this and found a workaround? Anyone?
Title: Re: Good Post/Bad Post Mod
Post by: MegaByte on March 27, 2010, 04:00:01 PM
Nice mod.  There's an easy-to-fix problem when running it on a PostgreSQL database:
Database Error: ERROR: column "m.real_name" must appear in the GROUP BY clause or be used in an aggregate function
LINE 2: SELECT l.id_member, COUNT(*) AS votes, m.real_name
^

SELECT l.id_member, COUNT(*) AS votes, m.real_name
FROM smf_log_gpbp l
LEFT JOIN smf_members m ON (m.id_member = l.id_member)
GROUP BY l.id_member
ORDER BY votes DESC
LIMIT 10

Just do what the error suggests and it works.

I also had some problems running the mod in conjunction with SMF caching (memcache).  Posts disappear or turn gray and counts are not updated until the cache is flushed.
Title: Re: Good Post/Bad Post Mod
Post by: wwwserfer on March 30, 2010, 07:14:35 AM
QuoteHi. This mod won't be updated anymore for SMF 1.1.x except in the case a new SMF update breaks it. Thanks for your comment.

too bad..  :-\ not possible select from the database values from gpbp table---> output in list?

In any case, thanks for the reply!

New question:

how admin can reset points to zero of any message (unhide message)?

sorry for my bad english  :-[

best wishes!
Title: Re: Good Post/Bad Post Mod
Post by: TurtleKicker on April 02, 2010, 09:42:46 AM
Thanks, [SiNaN]. Hopefully OutofOrder can incorporate that bugfix into the next version.

Also, a feature request:

Can we have the ability to re-collapse a hidden post after expanding it? Right now, expanding it is a slick AJAX function but re-collapsing it requires a page-reload.
Title: Re: Good Post/Bad Post Mod
Post by: balti27 on April 04, 2010, 07:24:45 PM
Hello everyone, Great script !!
I have maybe a small problem for u programmers , and that is GPBP only shows to the administrators: first attachmaint

and thise is how it looks for users, it shows only the number of respects "0" given in thise topic: second attachmaint

Can anyone redirect me to a topic which deals thise issue or tell me what i am doing wrong.
And i tryed all combinations, i enebeled all boards for GP/BP

Title: Re: Good Post/Bad Post Mod
Post by: Snogmarr on April 04, 2010, 08:43:14 PM
user permissions?
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on April 05, 2010, 06:27:32 AM
Quote from: MegaByte on March 27, 2010, 04:00:01 PM
Nice mod.  There's an easy-to-fix problem when running it on a PostgreSQL database:
Database Error: ERROR: column "m.real_name" must appear in the GROUP BY clause or be used in an aggregate function
LINE 2: SELECT l.id_member, COUNT(*) AS votes, m.real_name
^

SELECT l.id_member, COUNT(*) AS votes, m.real_name
FROM smf_log_gpbp l
LEFT JOIN smf_members m ON (m.id_member = l.id_member)
GROUP BY l.id_member
ORDER BY votes DESC
LIMIT 10

Just do what the error suggests and it works.
Thanks for the report.
QuoteI also had some problems running the mod in conjunction with SMF caching (memcache).  Posts disappear or turn gray and counts are not updated until the cache is flushed.
Ooh. A power user :) Are those the only symptoms?
I'm going to have to take a look at the cache functions to find out how to fix this, it shouldn't be too hard. The problem is i don't have a test site using caching, so it'd be blind guesses :-\

Quote from: [SiNaN] on March 31, 2010, 01:12:28 PM
*snip*
Thanks for the heads up. I'll try tweaking the installer.

Quote from: sremick on April 02, 2010, 09:42:46 AM
Can we have the ability to re-collapse a hidden post after expanding it? Right now, expanding it is a slick AJAX function but re-collapsing it requires a page-reload.
--> http://board.koffer.ee/files/what_has_been_seen_cannot_be_unseen_695.jpg
Seriously though, I can't really understand why a user would need to re-collapse a hidden post. Could you elaborate?

Quote from: balti27 on April 04, 2010, 07:24:45 PM
I have maybe a small problem
Indeed, your problem is because you haven't configured the GPBP permissions for your users.
Go to the permissions area and look for the Good Post Bad Post membergroup permissions.
Title: Re: Good Post/Bad Post Mod
Post by: TurtleKicker on April 05, 2010, 11:34:29 AM
Quote from: OutofOrder on April 05, 2010, 06:27:32 AM

Seriously though, I can't really understand why a user would need to re-collapse a hidden post. Could you elaborate?
Sometimes a user will be curious and want to see just what was in the post to make it "bad" (and perhaps if they want to also vote it down themselves). You can't vote on a post unless you can read it.

If the user then votes it down (or simply decides "yes, that was a bad post after all") they'll want it to return to "hidden" while they continue to read the rest of the thread.

It was something that not only occurred to me but also came up as a request from my test users.
Title: Re: Good Post/Bad Post Mod
Post by: PureBwa on April 05, 2010, 10:29:45 PM
Hey,

This seems like the perfect mod for my board, but I'm having some issues.  Apologies in advance if this has already been discussed.  I'm running SMF 1.1.11.  To install the mod, I downloaded the GoodPostBadPost.1.1.3.zip file.  I went through the Packages center in my admin dashboard>Download Packages>Upload a Package.  I uploaded the zip, applied it and everything.  The Good Post/Bad Post option appeared under my forum options, and I applied it to my board.

Additionally, I made sure the appropriate membergroups had the permissions to use Good Post/Bad Post.  The Top 10 Post Voters stats appear on my stats page.  Everything checks out.  Except the actual vote buttons!  They don't show up on any posts.  Based on some initial research, I'm thinking it has something to do with:

1) My theme settings (although I'm using Classic YaBB SE Theme with just some minor color tweaks)

2) CHMODing the file (which I kinda understand, just not sure where I do that, or what files I would have to CHMOD)

Any tips?  I'd love to implement this mod on my forum, but I'm growing frustrated trying to install it.  Would I be better off upgrading SMF to the lastest 2.0 build?  Thanks for your help, looking forward to figuring this out.
Title: Re: Good Post/Bad Post Mod
Post by: PureBwa on April 06, 2010, 11:38:31 AM
Quote from: PureBwa on April 05, 2010, 10:29:45 PM
Hey,

This seems like the perfect mod for my board, but I'm having some issues.  Apologies in advance if this has already been discussed.  I'm running SMF 1.1.11.  To install the mod, I downloaded the GoodPostBadPost.1.1.3.zip file.  I went through the Packages center in my admin dashboard>Download Packages>Upload a Package.  I uploaded the zip, applied it and everything.  The Good Post/Bad Post option appeared under my forum options, and I applied it to my board.

Additionally, I made sure the appropriate membergroups had the permissions to use Good Post/Bad Post.  The Top 10 Post Voters stats appear on my stats page.  Everything checks out.  Except the actual vote buttons!  They don't show up on any posts.  Based on some initial research, I'm thinking it has something to do with:

1) My theme settings (although I'm using Classic YaBB SE Theme with just some minor color tweaks)

2) CHMODing the file (which I kinda understand, just not sure where I do that, or what files I would have to CHMOD)

Any tips?  I'd love to implement this mod on my forum, but I'm growing frustrated trying to install it.  Would I be better off upgrading SMF to the lastest 2.0 build?  Thanks for your help, looking forward to figuring this out.

Made some progress, but still some issues:

1) I went through and manually installed it by adding the code myself.  As a result, the voting function is working.  Unfortunately, I'm not getting the arrow images to show up - just the text saying 'Vote Up/Down'.  This isn't a dealbreaker by any stretch, but I'd much prefer to figure out how to get the arrows to show up.  Any ideas?

2) The problem was certainly that I'm using the Classic theme as opposed to the default.  I was able to edit the corresponding files in the Classic folder, but some files do not match up (i.e. there are files in the Themes/default folder that are not there in the Themes/classic folder).  I think this might be part of my problem with the arrows not showing up.  Which part of the code controls that?

3) The Vote Up/Down links and the score are centered in the header bar of each post.  Any way to right justify them so they're directly next to my quote/modify/delete buttons?

Thanks for any help that anyone can offer.
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on April 07, 2010, 08:50:36 AM
Quote from: sremick on April 05, 2010, 11:34:29 AM
If the user then votes it down (or simply decides "yes, that was a bad post after all") they'll want it to return to "hidden" while they continue to read the rest of the thread.
Sorry to say I'm not really convinced by this explanation. A user that votes down a post doesn't really have to hide the post again in order to keep reading a thread. The post won't show again in the following visits.
However by your reasoning you could say that a user who votes down a post should still be able to hide it simply because he didn't like it, regardless if it has become a "Bad post". And I'm not sure this is really the point of GP/BP.

Still, I suppose it may be a valid case in certain boards where content tends to be NSFW, so I guess it could be implemented with this in mind.

Quote from: PureBwa on April 06, 2010, 11:38:31 AM
1) I went through and manually installed it by adding the code myself.  As a result, the voting function is working.  Unfortunately, I'm not getting the arrow images to show up - just the text saying 'Vote Up/Down'.  This isn't a dealbreaker by any stretch, but I'd much prefer to figure out how to get the arrows to show up.  Any ideas?

2) The problem was certainly that I'm using the Classic theme as opposed to the default.  I was able to edit the corresponding files in the Classic folder, but some files do not match up (i.e. there are files in the Themes/default folder that are not there in the Themes/classic folder).  I think this might be part of my problem with the arrows not showing up.  Which part of the code controls that?

3) The Vote Up/Down links and the score are centered in the header bar of each post.  Any way to right justify them so they're directly next to my quote/modify/delete buttons?
For the casual reader: these are troubleshooting instructions for the SMF 1.1.x version
1) Make sure the arrow images are installed in your default theme /images folder. (It should be Themes/default/images) Those are five files prefixed with "gpbp_".
2) Themes other than the default theme grab the missing files off the default one. This means that any missing file is actually not needed for the theme to work as expected, and that any new mod you install should always be working without problems in the default theme before you start modifications in other themes.
3) This is because the mod is trying to use the default gpbp.css stylesheet. Your custom theme most likely needs a stylesheet of its own. I suppose you're using an unmodified Classic theme, so i'll try to figure this out for you in my local installation.
BBS.
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on April 07, 2010, 09:06:34 AM
Quote from: OutofOrder on April 07, 2010, 08:50:36 AM
1) Make sure the arrow images are installed in your default theme /images folder. (It should be Themes/default/images) Those are five files prefixed with "gpbp_".
This is a bug, actually. It first tries to load the images from the default images folder, but after voting it tries to reload them from the current theme images folder.
In order to fix this, find in your custom theme's Display.template.php file

sImagesUrl: "' . $settings['images_url'] . '"

replace with

sImagesUrl: "' . $settings['default_images_url'] . '"


Edit:
here's the gpbp.css file modified to use in Classic YaBB SE. Simply install it in your /Themes/classic folder. It will fix the positioning of the voting buttons and score.
Title: Re: Good Post/Bad Post Mod
Post by: TurtleKicker on April 07, 2010, 09:52:38 AM
Quote from: OutofOrder on April 07, 2010, 08:50:36 AM
Sorry to say I'm not really convinced by this explanation.
That's unfortunate, since we have multiple people who independently feel like the feature would be useful. :)

QuoteA user that votes down a post doesn't really have to hide the post again in order to keep reading a thread.
Of course not, but if a post has been voted below the threshold to be "hidden", then it'd be nice for it to not clutter up the thread.

QuoteThe post won't show again in the following visits.
No, but why should the user have to re-load the page just to unclutter the thread? Especially when there's existing Javascript functionality to expand a hidden post without reloading the page.

QuoteHowever by your reasoning you could say that a user who votes down a post should still be able to hide it simply because he didn't like it, regardless if it has become a "Bad post". And I'm not sure this is really the point of GP/BP.
I agree, that's not the point of the mod. But that's not functionality I'm asking for either. ;)

Look at it this way:

The point of this mod is to allow certain posts to be hidden if the collective up/down votes fall below a certain threshold. If a post has already fallen below, it only takes 1 up vote to push it back above. So to allow the masses to push a truly bad post far below the threshold, far enough to make their opinion heard so that a few rogue up votes can't undo it, then they still need a convenient way to briefly view an already hidden post. Chances are, most of these hidden posts that they briefly view are going to indeed going to be "bad" posts, so why force them to leave them visible until next page reload, when the point of the mod is to be able to unclutter threads from these bad posts in the first place?

If a user has to reload the page just to hide them again, they're going to be less-inclined to briefly view them to see if they deserve to be pushed down with even more down votes, which means bad posts will more-easily rise back to the top again. Otherwise a person has to constantly be unhiding posts just to consider their vote, stuck with the posts visible and thereby making the mod worthless since nothing is ultimately being hidden for them.

I'm not sure if the above makes more sense, or is just rambling... it was obvious to me in the beginning, so I wasn't sure how to further explain it. :) Sorry!
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on April 07, 2010, 06:07:34 PM
Well, fair enough I guess.
Title: Re: Good Post/Bad Post Mod
Post by: Alleks on April 08, 2010, 09:28:11 AM
I installed mod but looks like script does not work.. when I (or any other on forum) click a voting button nothing happens. I catched Mozilla page error report. Here is it:

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; InfoPath.2; OfficeLiveConnector.1.4; OfficeLivePatch.1.3)
Timestamp: Thu, 8 Apr 2010 12:58:48 UTC


Message: Object required
Line: 27
Char: 2
Code: 0
URI: http://www.betonbasket.ru/forum/Themes/default/scripts/gpbp.js?2_0


Where could be a problem?
Title: Re: Good Post/Bad Post Mod
Post by: Alleks on April 09, 2010, 10:30:08 AM
any help? Looks like GPBP script does not load for some reason because it does not load when I click to view voters list.. why this happens? Maybe some conflicts with hosting or with russian version?
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on April 09, 2010, 01:51:24 PM
assuming your installation process was successful, try installing on a clean install of SMF, and see if it works.

if all is ok, than the problem is with one of your other mods. try installing each until you find it.
Title: Re: Good Post/Bad Post Mod
Post by: Alleks on April 12, 2010, 03:13:07 AM
Quote from: IdanC on April 09, 2010, 01:51:24 PM
assuming your installation process was successful, try installing on a clean install of SMF, and see if it works.

if all is ok, than the problem is with one of your other mods. try installing each until you find it.

Actually this happened after I upgraded forum from 1.1.11 to 2.0 RC3 by upgrading it so mods were there.. some old files from 1.1.11 were left on server and maybe they are conflicting with new ones...

I will try to have absolutely fresh install of SMF 2.0 RC3 and will see if this would work for me.. because on 1.1.11 version GPBP scripts worked well on this hosting and server.
Title: Re: Good Post/Bad Post Mod
Post by: Alleks on April 12, 2010, 07:53:16 AM
For a test I installed completely new 2.3 version with no mods and tried to install there GPBP all pre-tests were succesfull and after installation I was notified that everything was installed.. but when I started to browse folders I did not find any signs of GPBP existence on my forum. Looks like installation was succesful on paper but no scripts were extracted to scripts folder as well no language files were touched.. All files were with 777 chmoded permission, temp folder was created in Packages folder but this did not help..

Now I have returned to backup version with somehow installed GP BP but there I am still getting script error:

Message: Object required
Line: 27
Char: 2
Code: 0
URI: hxxp:www.betonbasket.ru/forum/Themes/default/scripts/gpbp.js?2_0 [nonactive]
Title: Re: Good Post/Bad Post Mod
Post by: Alleks on April 12, 2010, 08:10:47 AM
problem solved. I used upgrade files manually by uploading them into root folder and running them one by one. Not sure which one fixed this but it did. Hope my solo writing may help if someone will experience similar problem.
Title: Re: Good Post/Bad Post Mod
Post by: GreySkull-1 on April 25, 2010, 08:44:32 PM
Installed fine but my default theme is "Core" and this seems to have installed to "Curve".

Is there an easy way to have this mod also show in "Core"?

Thanks

(SMF 2.0 RC3)
Title: Re: Good Post/Bad Post Mod
Post by: GreySkull-1 on April 27, 2010, 03:59:38 PM
Hello?

Anyone out there?
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on April 27, 2010, 04:16:17 PM
Quote from: GreySkull-1 on April 27, 2010, 03:59:38 PM
Hello?

Anyone out there?
it's just a very basic question, i guess people assumed you did some minimal research and found the answer yourself.

Quote from: GreySkull-1 on April 25, 2010, 08:44:32 PM
Is there an easy way to have this mod also show in "Core"?
easy or hard, the only way i know is looking at the Manual Install Instructions, and follow them with the appropriate accommodation for your specific theme.
Title: Re: Good Post/Bad Post Mod
Post by: ilushkin on April 28, 2010, 02:14:23 AM
Please note the bug with this mode and SMF ver 2 RC3.

http://www.simplemachines.org/community/index.php?topic=373600.0
Title: Re: Good Post/Bad Post Mod
Post by: GreySkull-1 on April 28, 2010, 11:36:33 PM
Quote from: IdanC on April 27, 2010, 04:16:17 PM
it's just a very basic question, i guess people assumed you did some minimal research and found the answer yourself.

I did do minimal research and didn't find the answer.

My forum use to be on a PHPbb software and I have to say although i like SMF much better, the support seems to be thrown here and there, hidden under this, buried under that.
Not to mention that if one does delve into the mods, its a hit and miss as to whether it will work or not and a very good chance the creator of the mod has moved on and no longer supports it.

So, when a fellow user comes on and request help it would be nice to just get a simple, straight forward, mature response instead of expecting the person to go on a major time consuming hunt.

Thanks for the reply.

Guess I'll just steer clear of mods that can't be placed on other themes with the ease of a simple install.
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on April 29, 2010, 02:33:13 AM
i know how you feel, the community was'nt always like this. but recently, due to some sort of dispute over the rights that was handled poorly, most of the developers walked out of the project.

i wouldn't avoid manually editing the theme, it's just basic copy-paste. actually, i didn't even know php before i started working on my forum (http://mila.fm).
Title: Re: Good Post/Bad Post Mod
Post by: Arantor on April 29, 2010, 03:11:59 AM
Even putting aside the dispute in January, you will have exactly the same problem with mods being supported by their authors here as you will over on phpBB.

The (vast) majority of mods are contributed by their authors because they wrote them for their own sites, and when they're done with it they aren't beholden to support it evermore. They contributed it when it was done because they thought people could make use of it.

That said, a lot of mod authors are waiting for 2.0 final to emerge before doing anything around modding.
Title: Re: Good Post/Bad Post Mod
Post by: TurtleKicker on April 29, 2010, 09:35:17 AM
Quote from: Arantor on April 29, 2010, 03:11:59 AM
The (vast) majority of mods are contributed by their authors because they wrote them for their own sites, and when they're done with it they aren't beholden to support it evermore. They contributed it when it was done because they thought people could make use of it.

Which is all right and noble, except that unless that contribution also comes with a statement "if I ever disappear and stop supporting this mod, I give permission for someone else to take it over" then it's not a gift, it's a liability for anyone who invests in using it. They build their site around a mod, start depending on it, then the mod author vanishes and the mod starts breaking with new updates to SMF. But SMF won't let anyone else pick up the mod because the author didn't explicitly allow it.

A "gift" perhaps, but a poisoned gift without ensured longevity via a rights release.
Title: Re: Good Post/Bad Post Mod
Post by: Arantor on April 29, 2010, 09:37:20 AM
Oh, I'm not disagreeing with you at all. Many mods are, for this very reason, a liability unless you're willing to learn (or are already fluent in) PHP and ready to pull your sleeves up to fix issues yourself.

This is only one reason we ensured SimpleDesk has a F/OSS licence in case we all get hit by a bus or something.
Title: Re: Good Post/Bad Post Mod
Post by: Chon_Lee on April 29, 2010, 11:25:52 AM
When filtering results, when there is more than one page, when clicking the page 2 link of the filtered results, the filter does not hold and the mod will then then displays page 2 of the unfiltered list.
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on April 29, 2010, 01:40:17 PM
good points Arantor and sremic, is it too late to implement them? was'nt the January fiasco a wake up call that a deep change is needed?

and the lack of news and the overall glum feeling around the community (except you Arantor  - you're like an Energizer Bunny around the forums  :D) got me thinking that SMF2.0 will not see the light of day, was i wrong?

p.s.
i love smf, and even if this is the end, it was one hell of a ride.
Title: Re: Good Post/Bad Post Mod
Post by: Arantor on April 29, 2010, 01:42:37 PM
Well, SMF 2.0 is being actively moved forward with bug fixes being applied quite a lot recently (Norv has made a LOT of progress from what I can see), including some of the ones I helped solve, which is good.

"Is it too late to change the licence on a mod?"

That's down to the author. They need to establish what licence it's under and whether others can take it over.

SMF is far from dead! An individual mod may not continue to be developed but SMF itself is growing strong again with multiple people returning to the team.
Title: Re: Good Post/Bad Post Mod
Post by: TurtleKicker on April 29, 2010, 01:51:40 PM
Quote from: IdanC on April 29, 2010, 01:40:17 PM
good points Arantor and sremic, is it too late to implement them? was'nt the January fiasco a wake up call that a deep change is needed?

Yes, but not much was done... basically people waited until the chaos calmed down, then those who remained just moved on and tried to pretend it didn't happen. Of course, without the needed changes a similar incident is at risk of happening again in the future, but this is not the thread for that discussion.

Quoteand the lack of news and the overall glum feeling around the community (except you Arantor  - you're like an Energizer Bunny around the forums  :D) got me thinking that SMF2.0 will not see the light of day, was i wrong?

Perhaps. See here:
http://www.simplemachines.org/community/index.php?topic=377215.0
Title: Re: Good Post/Bad Post Mod
Post by: Arantor on April 29, 2010, 01:57:08 PM
That's actually part of the problem.

SMF can't change its licence without signoff from all contributors but a number of former contributors refuse to sign off on a licence change to anything else. It's complicated, messy and likely to result in more tears sometime in the future.
Title: Re: Good Post/Bad Post Mod
Post by: GreySkull-1 on May 02, 2010, 05:51:30 PM
Did I open up a can of worms or what?

You people got me looking for another forum software! Not seriously... but thinking I may need to. ???
Title: Re: Good Post/Bad Post Mod
Post by: Arantor on May 02, 2010, 05:56:23 PM
You do get mostly the same problem on any environment with unsupported modifications. It's not quite so bad for phpBB and MyBB, by having GPL-compatible licences, it forces modifications to have a compatible licence, meaning that anyone can pick up and fork the modifications.

SMF doesn't have that deal; modifications are often not licenced meaning it's straight IP/copyright with an implication (note: it's IMPLIED, not EXPLICIT) to use a licence similar to SMF's own licence. Meaning that authors are within their rights to remove mods and bar further changes to them.

Thus mods that are unsupported are something of a liability unless someone else is willing to take them over and support them, which unfortunately doesn't happen. I'd point out that this is an issue for vBulletin "hacks" too.
Title: Re: Good Post/Bad Post Mod
Post by: Jade Elizabeth on May 08, 2010, 09:02:21 PM
Hey there, I'm trying to integrate a custom mod into this and to be honest I'm lost in the mess of ternary operations in the code. I tried to make my own but I think I'm getting something wrong...

<div', $gpbp_action == 'hide' ? ' id="gpbp_hidden_' . $message['id'] . '"' : '' ,' class="', $message['approved'] ? ($gpbp_action == 'hide' ? 'gpbp_hider ' : '') . ($gpbp_badPost && $gpbp_action != 'none' ? 'gpbp_greyed' : ($message['alternate'] == 0 ? 'windowbg' : 'windowbg2')) : 'approvebg', '" style="' , $message['approved'] && ($gpbp_action != 'hide') && ($gpbp_badPost && $gpbp_action = 'none') ? $color : '' , '">

My part is this tiny bit:
style="' , $message['approved'] && ($gpbp_action != 'hide') && ($gpbp_badPost && $gpbp_action = 'none') ? $myvariable : '' , '">

Basically I'm trying to say that if the post is approved and the good post bad post doesnt want anything with it, then "myvariable". I was looking at the source and what was there to do it but I think I messed up lol. I was wondering if you could please help me?
Title: Re: Good Post/Bad Post Mod
Post by: [SiNaN] on May 09, 2010, 07:44:14 AM
I don't know what $gpbp_action can have but I guess intead of

$gpbp_action = 'none'

in your code you meant

$gpbp_action == 'none'

First one is assigning 'none' value to $gpbp_action, the other is checking whether $gpbp_action is equal to 'none' or not.
Title: Re: Good Post/Bad Post Mod
Post by: Jade Elizabeth on May 09, 2010, 08:35:48 PM
It still doesnt work. Honestly this is going on 16 hours of trying to work this out, not counting breaks to eat and sleep, etc.

For some reason every variable used in the beginning of that line comes up empty when attempted to be used again. Even $myvariable which is defined before the code is called.
Title: Re: Good Post/Bad Post Mod
Post by: TechPrince on May 15, 2010, 01:59:19 PM
Nice mod :) It would be nice to add a profile action as a repository for all the voted posts of that author and allow author of the post to see the voters list for his posts on topic view.
Title: Re: Good Post/Bad Post Mod
Post by: Bugo on May 18, 2010, 04:48:54 AM
This mod conflict with dQuoteSelection (http://custom.simplemachines.org/mods/index.php?mod=2086).
dQuoteSelection isn't work.
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on May 18, 2010, 06:00:53 AM
have anyone noticed that even when guests are given permission to view voter, clicking on the (https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fmila.fm%2FThemes%2Fdefault%2Fimages%2Fgpbp_voterslist.gif&hash=3ddff124ebf4a1dae384e55748f13bfd482e8a23) icon, does'nt work.

for registered members it works just fine.

any clues?
Title: Re: Good Post/Bad Post Mod
Post by: tbk22 on June 01, 2010, 02:29:47 PM
This is a great mod... ONe of the best... But Im having some problems installing it

Is this normal?

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fimg24.imageshack.us%2Fimg24%2F5350%2Ferrolq.jpg&hash=04b2ff0a4530ca0c42b3d17619f4824fbf585d39)

Should I mannually install?
Title: Re: Good Post/Bad Post Mod
Post by: Alpay on June 13, 2010, 07:04:48 AM
Turkish Translate :) For SMF 2 Rc 3


/Themes/default/languages/Help.turkish.php


$helptxt['gpbp_threshold'] = 'Üyeler Tema ve Düzenden Oy vermeyi düzenleyebilirler.Üyeler Kötü oy verilmemesini isteyebilirler.';
$helptxt['gpbp_display_respect'] = 'Tüm Saygı oylarının toplamıdır. Olumsuz oylar mevcut degildir.';




/Themes/default/languages/Who.turkish.php


// Good Post/Bad Post: it may be nice to let users know of this.
$txt['whotopic_gpbp'] = 'Oylama yapıyor, konu &quot;<a href="' . $scripturl . '?topic=%d.0">%s</a>&quot;.';



./Themes/default/languages/Modifications.turkish.php


// Good Post/Bad Post permission strings.
$txt['permissiongroup_gpbp'] = 'Güzel Mesaj/Kötü Mesaj Modifikasyonu';
$txt['permissiongroup_simple_gpbp'] = 'Güzel Mesaj/Kötü Mesaj İzinleri';
$txt['permissionname_gpbp_manage'] = 'Güzel Mesaj/Kötü Mesaj Modifikasyonu Ayarları';
$txt['permissionhelp_gpbp_manage'] = 'İzin ver';
$txt['cannot_gpbp_manage'] = 'Derecelendirmeye izin verilmesi.';
$txt['permissionname_gpbp_vote'] = 'Mesajlara Oyla (yukarı veya aşağı)';
$txt['permissionhelp_gpbp_vote'] = 'Olumlu veya olumsuz bir yazının sonucu değiştirmek için kullanım sağlar. Kurul da yapılandırılmış olması gerekir yazı oylama izin vermek gerekir. <br/> <br/> <strong> Not </ strong>: Konuyu Ziyaretçilerin Oylamasına \izin ver';
$txt['cannot_gpbp_vote'] = 'Maalesef, mesaj oylama izniniz yok.';
$txt['permissionname_gpbp_reveal'] = 'Kötü mesajlar';
$txt['permissionhelp_gpbp_reveal'] = 'kullanıcı mesajları bir düşük oy skor nedeniyle gizli olduğunu görmek için.';
$txt['cannot_gpbp_reveal'] = 'genel oylama tarafından gizli erişim olamaz.';
$txt['permissionname_gpbp_voterslist'] = 'Seçmen Listesini Görebilir';
$txt['permissionhelp_gpbp_voterslist'] = 'Kullanıcının konuyla ilgili oylama seçimlerini görmesini sağlar.';
$txt['cannot_gpbp_voterslist'] = 'Seçmen listesini görmeye yetkiniz yok.';
// Managing area.
$txt['gpbp_manage'] = 'İyi mesaj/Kötü Mesaj';
$txt['gpbp_managearea_basic'] = 'Temel Ayarlar';
$txt['gpbp_managearea_basic_desc'] = 'Güzel Mesaj/Kötü Mesaj Temel Ayarları';
$txt['gpbp_managearea_advanced'] = 'Gelişmiş Ayarlar';
$txt['gpbp_managearea_advanced_desc'] = 'Daha derin yapılandırma ayarlarını burada bulabilirsiniz.';
$txt['gpbp_managearea_tools'] = 'GPBP Araçları';
$txt['gpbp_managearea_tools_desc'] = 'Bu kısımda hızlıcana oy verenleri ve saygı seçimlerini manuel olarak değiştirme yapabilirsiniz.Not : Arama yaparkene oy üzerinde olmasına özen gösteriniz.';
$txt['gpbp_manage_title'] = 'Güzel Mesaj/Kötü Mesaj Yönetme';
$txt['gpbp_hide_action'] = 'Güzel Mesaj/Kötü Mesaj: ne yapmak istiyorsun?';
$txt['gpbp_hide_action_hide'] = 'Gizle.';
$txt['gpbp_hide_action_grey'] = 'Grileştir.';
$txt['gpbp_hide_action_none'] = 'Hiç birşey yapma.';
$txt['gpbp_settings'] = 'Güzel Mesaj/Kötü Mesaj (GP/BP) Ayarlar';
$txt['gpbp_bad_threshold'] = 'Kötü Mesaj Eşiği';
$txt['gpbp_bad_threshold_desc'] = 'Bu değeri şu anda herhangi bir yazı ya da aşağıdaki Kötü Mesaj olarak işaretlenir.';
$txt['gpbp_show_respect'] = 'Saygıyı Göster';
$txt['gpbp_show_respect_desc'] = 'Profil Özetinde Saygı Derecesini gösterir.';
$txt['gpbp_affected_boards'] = 'Aktif Olacak Bölümler';
$txt['gpbp_enable_boards'] = 'Etkinleştir GP/BP Kurallarda';
$txt['gpbp_enable_boards_desc'] = 'oylama olacak olan Komiteleri seçin. <br /> <br /> <strong> Not: </ strong> Yazı silindi asla oy verilmedi. Yeniden bir konu gönderilmesi oylama sağlayarak sadece önceki oy görüntülemeye yol açacak.';
$txt['gpbp_choose_boards'] = 'Seçebileceğiniz Yer';
$txt['gpbp_display_stats'] = 'İstatistiklerde Aktifleştir?';
$txt['gpbp_display_stats_desc'] = 'Görüntü Seçin <strong>Top 10 Mesaj Puanı</strong> listesi ve  <strong>10 En İyi Mesaj</strong> users.';
$txt['gpbp_show_best_topics'] = 'Ana Kısımda "Haftalık Gösterim":';
$txt['gpbp_show_best_topics_desc'] = '<strong>Forum İstatistikleri</strong> in üstünde, haftalık olarak gösterilir sizin belirleyeceginiz sayı ile.<br /><strong>unutmayın 0 olarak ayarlanırsa deaktif olur.</strong>';
$txt['gpbp_button_set'] = 'Gösterilecek buton tipi :';
$txt['gpbp_button_set_desc'] = 'Oylama buton sitil seçimi.';
$txt['gpbp_users_choice'] = 'Kullanıcıların GP/BP kendi ayarları';
$txt['gpbp_users_choice_desc'] = 'Bu seçeneği üyeleri kendi ayarlarını seçmek için izin vermek için kontrol edin (gri gizlemek aşımı, hiçbir şey), ya da işaretini kaldırın Geçerli ayarları gücüne. <br /> <strong> Üye Seçenekler giderek geçerli tema ayarlarını değiştirebilirsiniz < Temalar yönetimi alanında / strong> bölümünde.';
$txt['gpbp_users_choice_none'] = 'kullanıcılar için tercih "Oysuz" Kötü Yayın';
$txt['gpbp_users_choice_none_desc'] = 'Kötü görüntülemeye izin vermeyi denetleyin Normal mesaj olarak Yayınlar. Bu bir tercihdir seçenekler geçersiz değildir, bu nedenle, yine de tamamen devre dışı bırakmak için üye tema seçenekleri düzenlemek zorunda.';
$txt['gpbp_voters_list_limit'] = 'Seçmenlerin limitlenmesi:';
$txt['gpbp_voters_list_limit_desc'] = 'Üyeler bu oy vermişlerin listesinde alfebatik olarak sırılanmaz.<br /> <strong>Not:</strong> Javascript aktif olan tararıyıcılarda çalışır.';
$txt['gpbp_disable_negative_voting'] = 'Olumsuz oylamayı pasif et?';
$txt['gpbp_disable_negative_voting_desc'] = 'Sadece iyi oy veren kişileri istiyorsanız  <strong>bu şıkkı seçiniz</strong>.';
$txt['gpbp_post_count_limit'] = 'Oy kullanması için üyenizin kaç iletiye sahip olsun:';
$txt['gpbp_post_count_limit_desc'] = 'Üyelerin oy verebilrmesi için iletisi sınırlandırması işlemi .<br />Eğer 0 secerseniz Aktif Olmayacaktır.';
$txt['gpbp_vote_search'] = 'GPBP Oy Araaması';
$txt['gpbp_vote_search_filters'] = 'Filtre ederek özel oy araması. Boş değerler dikkate alınmayacaktır.';
$txt['gpbp_vote_search_filter_by'] = 'Fitre ...';
$txt['gpbp_vote_search_topic_id'] = 'Konu ID:';
$txt['gpbp_vote_search_msg_id'] = 'İleti ID:';
$txt['gpbp_vote_search_poster_name'] = 'İleti Sahibi kullanıcısı:';
$txt['gpbp_vote_search_voter_name'] = 'Oylayıcı Kullancısı:';
$txt['gpbp_vote_search_score'] = 'Puan:';
$txt['gpbp_vote_search_any_score'] = 'Herhangi bir puan.';
$txt['gpbp_vote_list'] = 'Oy Listesi';
$txt['gpbp_vote_list_showing'] = 'Gösterilen %s den %s toplam seçmen.';
$txt['gpbp_vote_list_poster'] = 'İleti Gönderen';
$txt['gpbp_vote_list_voter'] = 'Oy Veren';
$txt['gpbp_vote_list_vote'] = 'Oy';
$txt['gpbp_vote_list_check'] = 'Tüm seçmenleri Tıklayarak(Check) Edebilirsiniz.';
$txt['gpbp_vote_list_deleted'] = 'Silinsinmi?';
$txt['gpbp_vote_list_mdeleted'] = 'Silindi.';
$txt['gpbp_vote_list_account_deleted'] = 'Seçmen(üyelik) #%s silindi.';
$txt['gpbp_vote_list_subject'] = 'Konu Başlığı:';
$txt['gpbp_vote_list_topic_deleted'] = 'Konuyu Sil?';
$txt['gpbp_vote_list_no_votes'] = 'Herhangi bir oy bulunamadı.';
$txt['gpbp_votes_deleted_s'] = '%s oy silindi.';
$txt['gpbp_votes_reversed_s'] = '%s oy tersine döndürüldü.';
$txt['gpbp_votes_deleted'] = '%s oy silindi.';
$txt['gpbp_votes_reversed'] = '%s oy tersine döndürüldü.';
$txt['gpbp_votes_delete'] = 'Sil';
$txt['gpbp_votes_reverse'] = 'Puanları Tersine Döndür';
$txt['gpbp_votes_all_checked'] = 'Tüm oylar kontrol et.';
$txt['gpbp_votes_also_update'] = 'Saygı güncenllenmesi güncellendi.';
$txt['gpbp_filtered_edit'] = 'Düzenlenmediki Tüm Filtre Sonuçları';
$txt['gpbp_filtered_edit_desc'] = 'Eğer sonuçlardaki tüm verileri düzenlemek istiyorsanız aşağıdaki formu kullanınız. <em>Yalnızca bir kaç oy düzenleyecekseniz üst kısımı kullanabilirsiniz.</em>';
$txt['gpbp_filtered_delete'] = 'Aramadaki Tüm oyları Sil.';
$txt['gpbp_filtered_reverse'] = 'Ters sonuçların tümünü ara.';
$txt['gpbp_filtered_confirm'] = 'Tümünü düzenlemeye ve %s oylar için eminmisiniz?';
$txt['gpbp_votes_deleted_filter'] = '%s oy silindi. %s ve üye saygı güncellenmesi. %s ileti skoru silindi.';
$txt['gpbp_votes_reversed_filter'] = '%s ters oy. %s üye saygı güncellenmesi. %s ileti skoru güncellenmesi.';
$txt['gpbp_respect_success'] = 'Saygı değiştirildi %s.';
$txt['gpbp_respect_not_needed'] = 'Herhangi bir değer seçilmedi';
$txt['gpbp_score_success'] = 'Yazı puan güncellendi #%s';
$txt['gpbp_orphaned_title'] = 'Boşda kalan Oy temizleme';
$txt['gpbp_orphaned_desc'] = 'İletisi silinmiş(veritabanında) ve boşda kalmış oyları ayarlamaya yarar. top 10 ve saygıyı etkileyecektir';
$txt['gpbp_orphaned_report'] = 'Sonuç <strong>%s</strong> boşda kalmış oy var.';
$txt['gpbp_orphaned_go'] = 'Boşda kalmış oyları sil.';
$txt['gpbp_orphaned_success'] = '%s oy silindi.';
$txt['gpbp_totals'] = 'Toplamı Say';
$txt['gpbp_totals_success'] = 'Yeniden sayma işlemi bitti %s üye %s ileti mevcut.';
$txt['gpbp_totals_desc'] = 'Yeniden sayma işlemi saygı,ileti ve üyelerin tüm puanlarını yapar.<br /><strong>Not: </strong>Bu işlem uzun ve sitenizi zorlayabilir. Lütfen işlemi başlatmadan önce <em>Bakım moduna</em> almanız önerilir.';
// Managing area errors.
$txt['gpbp_names_not_found'] = 'Aradığınız üye üye listesinde bulunamadı.';
$txt['gpbp_voter_not_found'] = 'Aradığınız Oy verici bulunamadı.';
$txt['gpbp_poster_not_found'] = 'Aradaığınız iletici/ileti bulnamadı.';
$txt['gpbp_vote_not_sent'] = 'Oy seçilmedi.Lüfen yeniden deneyiniz';
$txt['gpbp_filter_edit_needed'] = 'Herhangi bir işlem türü secilmedi. Geri dönerek lütfen tekrar deneyiniz';
$txt['gpbp_chosenmember_not_found'] = 'Üye adı yalnış lütfen geri dönerek lütfen tekrar deneyiniz.';
$txt['gpbp_message_not_found'] = 'Belirttiğiniz ID bulunamadı.';
// Voting errors.
$txt['gpbp_lacks_msg'] = 'Belirttiğiniz (geçerli) mesajı puanla.';
$txt['gpbp_notinthisboard'] = 'Maalesef, bu kurulu değil \'t sonrası oylama etkinleştirdiyseniz.';
$txt['gpbp_msg_not_found'] = 'Belirttiğiniz Mesaj bulunamadı.';
$txt['gpbp_msg_not_approved'] = 'İleti moderatör tarafından oylananada tek oy seçimi yapamazsınız.';
$txt['gpbp_msg_own_voted'] = 'Üzgünüm, kendi yazılarınıza oy veremessin.';
$txt['gpbp_can_not_vote_down'] = 'Üzgünüm, Oy aşağı indiremezsiniz.';
$txt['gpbp_must_fill_field'] = 'Lütfen daha cok alanı doldurunuz.';
// General user interface.
$txt['gpbp_respect'] = 'Saygı';
$txt['gpbp_post_score'] = 'Bu Yazının Şuanki Puanı.';
$txt['gpbp_vote_down'] = 'Kötü';
$txt['gpbp_vote_up'] = 'İyi';
$txt['gpbp_voted_down_alt'] = 'Oy Aşağı.';
$txt['gpbp_voted_up_alt'] = 'Oy Yukarı.';
$txt['gpbp_voted_down'] = 'Yazıdan oyumu geri al.';
$txt['gpbp_to_vote_down'] = 'Yazıyı beğenmedim.';
$txt['gpbp_voted_up'] = 'Yazıdan oyumu geri al.';
$txt['gpbp_to_vote_up'] = 'Yazıyı beğendim.';
$txt['gpbp_hidden'] = 'Gizle.';
$txt['gpbp_show'] = 'Göster.';
$txt['gpbp_member_hide_action'] = 'Oy lanan: mesajlar puanlama ile ne yapmak <strong>%s</strong> istiyorsun?';
$txt['gpbp_top_voters'] = 'Top 10 Mesajlar';
$txt['gpbp_most_respected'] = '10 En iyi Mesaj';
$txt['gpbp_show_voters'] = 'Oy verenleri Göster';
$txt['gpbp_voters_list'] = 'Oy verenler:';
$txt['gpbp_no_voters'] = 'Oy verilmemiş.';
// The following strings are meant to be used in "Respect was/was not updated" below.
$txt['gpbp_was'] = 'oldu';
$txt['gpbp_was_not'] = 'olmadı';
// Moderation log
$txt['modlog_ac_gpbp_deleted_votes'] = 'GP/BP: Silindi {amount} ileti oyu. Saygı <strong>{respect}</strong> güncellendi.';
$txt['modlog_ac_gpbp_reversed_votes'] = 'GP/BP: Ters {amount} ileti oyu. Saygı <strong>{respect}</strong> güncellendi.';
$txt['modlog_ac_gpbp_score_updated'] = 'GP/BP: Skor değişti {score} ve iletisi #{msg}';
$txt['modlog_ac_gpbp_respect_updated'] = 'GP/BP: Saygısı değiştirildi {respect} ve üye {membername}';
$txt['modlog_ac_gpbp_clean_orphaned'] = 'GP/BP: boşta kalmış oylar {orphaned} silindi.';
$txt['modlog_ac_gpbp_basic_settings'] = 'GP/BP: Temel Ayarlar Güncellendi.';
$txt['modlog_ac_gpbp_boards'] = 'GP/BP: Aktif olacak bölümler güncellendi.';
$txt['modlog_ac_gpbp_advanced_settings'] = 'GP/BP: Gelişmiş ayarlar güncellendi.';
// End of Good Post / Bad Post strings.



and :)

..
Manual changes
Edit the score of a post ...  GPBPManage.template.php

no $txt .

untranslate :)
Title: Re: Good Post/Bad Post Mod
Post by: outsider147 on June 21, 2010, 06:24:06 PM
Hi,

what I was wondering. Is there a possibility to recreate the code into the fact that the topicstarter can vote his post and all others just vote on his post and not on their own.
I'm looking for a system where people can vote  a good or bad call on webshops. If a topicstarter has a bad experience with a seller he should be able to vote on this shop. If all other posters can do the same in his post, you get an upcount or downcount in just one posting so everybody can see the average of this shop.

Can anyone help me out on this one?

Lars
Title: Re: Good Post/Bad Post Mod
Post by: tbk22 on June 22, 2010, 04:27:56 PM
After the install I had this error on my forum index

Quote
Ocorreu um erro! (an error occured)
Database error, given array of integer values is empty. (id_msgs)

I installed something manually cuz it gave an error through package parser so maybe I did some mistake

But then by going directly to a topic link and voting 1 post up/down I reloaded de forum index and it was ok after that...

So Im guessing the error had to do with having no votes at the beggining, still might be some  error I made in the manual install

How can I fix it?

Can you know where my mistake was?
Title: Re: Good Post/Bad Post Mod
Post by: Calamita on June 28, 2010, 05:02:54 PM
Hi,

I have installed this Mod a few minuts ago, but now I see, that only Administratores can vote Posts. Is this normal? Because my members want to vote too. I am die only one who can vote now.

Has anyone an idea and can help me?
Title: Re: Good Post/Bad Post Mod
Post by: diablo3x.dk on June 29, 2010, 09:34:37 PM
Just installed this mod on rc3 with SimplePortal. Everything went smooth but no gp/bp menu anywhere. Not even in the SimplePortal menu as someone described earlier.

So; installed perfectly (no errors and installed in custom theme) but nowhere to play around with the options of the mod. Maybe I can access the gp/bp options some other way? I mean, it seems like it installed perfectly.

Can someone please help? Thanks.
Title: Re: Good Post/Bad Post Mod
Post by: Verbist on July 07, 2010, 01:37:37 PM
@Calamita, you may have already figured this out on your own, but under Advanced Configuration in GPBP, check the "Restrict voting to members with at least this many forum posts" value. That could be your problem.
Title: Re: Good Post/Bad Post Mod
Post by: Verbist on July 07, 2010, 01:42:23 PM
Does anyone know, is there a way to automatically delete posts, not just hide them, based on a number of downvotes?
Title: Re: Good Post/Bad Post Mod
Post by: anidea on July 12, 2010, 11:23:50 PM
Hi!  Cool mod, now can I get it to work?  hehehe

smf 2 RC3.  The whole thing was a manual install.  I've been over the edits in load.php about 20 times now...

I'm getting the following error:

"Database error, given array of integer values is empty. (id_msgs)"

Please someone help?

Title: Re: Good Post/Bad Post Mod
Post by: Bugo on July 13, 2010, 05:55:01 AM
Quote from: anidea on July 12, 2010, 11:23:50 PM
I'm getting the following error:

"Database error, given array of integer values is empty. (id_msgs)"

Please someone help?
Are you change Display "Messages of the week" option?
Try change it to "0" and save settings.
Title: Re: Good Post/Bad Post Mod
Post by: anidea on July 13, 2010, 09:36:12 AM
Quote from: Bugo on July 13, 2010, 05:55:01 AM
Are you change Display "Messages of the week" option?
Try change it to "0" and save settings.
Thank you, Bugo :)

It totally was that.  I think it might've errored on the fact that it had just been installed and nobody had voted yet.  My ultimate solution was to comment out the messages of the week (hadn't realized that just turning it off would work lol) then I put in some votes, un-commended, and the error went away!
Title: Re: Good Post/Bad Post Mod
Post by: Calamita on July 15, 2010, 05:00:23 PM
Quote from: Verbist on July 07, 2010, 01:37:37 PM
@Calamita, you may have already figured this out on your own, but under Advanced Configuration in GPBP, check the "Restrict voting to members with at least this many forum posts" value. That could be your problem.

Hi, thanks for your answer, but that isn that problem. The number in the value is "0".

Can someone else help me? Only administratores can vote posts. I can vote with my account, which has more dann 4000 posts and also with my Test-Account, wo has only one post.
Title: Re: Good Post/Bad Post Mod
Post by: Klaudo on July 22, 2010, 10:32:25 PM
How do i get the code to show messages of the weeks ??

I want to show it in my portal.. Please help Me :'( :'(
Title: Re: Good Post/Bad Post Mod
Post by: anidea on August 26, 2010, 11:01:00 PM
Hi!  This is an awesome mod!  A few questions, if anyone has the time....

I like the idea of members sort of moderating themselves with this mod (ie. vote a post down & it goes away).  BUT we've had the problem of retaliatory voting, which has become a nightmare for me, 'cause every time it happens, I have to go and erase votes lol.

So in an attempt to prevent retaliatory voting, is there any way I could:

1. Limit users to, say, 3 negative votes per day?
2. Have a member's total respect be based on positive voting only, and only use the negative voting in the post? 
(the reason being that the forum is very new and users are earning negative respect, which is hurting their delicate sensibilities)

Thanks!
Title: Re: Good Post/Bad Post Mod
Post by: unformatted_ on August 29, 2010, 03:51:49 PM
I'm using Tinyportal.
Its possible to have 2 modules, on rght side of forum, with the 10 most respected, and 10 top post voters?
Title: Re: Good Post/Bad Post Mod
Post by: unformatted_ on August 31, 2010, 06:47:52 AM
Hi!

How can I place the messages of the week, on top of the forum? before the boards.
Title: Re: Good Post/Bad Post Mod
Post by: Makar on September 03, 2010, 10:45:22 AM
And when will be
added adding voices to the karma
separate display of positive and negative votes
the ability to output messages of the week to block the portal
Title: Re: Good Post/Bad Post Mod
Post by: rocknroller on September 03, 2010, 03:24:50 PM
Thank you, for this great mod.   :)

I use this mode as LIKE on the facebook. This mod is very cool for that, it will be more cool if somehow, users can recive notification for changes value in their own post. Maybe notifycation like PM.

Is it possable?  :D

Title: Re: Good Post/Bad Post Mod
Post by: Riddlah on September 15, 2010, 10:46:14 PM
Quote from: Bugo on July 13, 2010, 05:55:01 AM
Quote from: anidea on July 12, 2010, 11:23:50 PM
I'm getting the following error:

"Database error, given array of integer values is empty. (id_msgs)"

Please someone help?
Are you change Display "Messages of the week" option?
Try change it to "0" and save settings.

I tried this and it didn't work.... any other work-around for this? I even went into the board index and rated a couple of posts, but still the same error with id_msgs.

I am on 2.0 RC3.

I didn't manually install the entire mod, just the parts where the test failed on Admin.php and BoardIndex.php....

Thanks.
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on September 29, 2010, 02:03:56 AM
Good Post/Bad Post mod has been updated!
QuoteVersion 2.0.2 - September 29 2010

  • Fixed Board Index bug ("Database error") in inactive/unvoted forums.
  • Fix: Removed duplicate minus symbol in MOTW.
  • Dropped support for SMF2 RC2.
  • Added: Change displayed icon when hovering a voting button.
  • Added: Allow users to hide a manually revealed Bad Post.
Emphasis on the Board Index bugfix.

Quote from: IdanC on May 18, 2010, 06:00:53 AM
have anyone noticed that even when guests are given permission to view voter, clicking on the (https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fmila.fm%2FThemes%2Fdefault%2Fimages%2Fgpbp_voterslist.gif&hash=3ddff124ebf4a1dae384e55748f13bfd482e8a23) icon, does'nt work.
I'll be taking care of this next time.

Quote from: diablo3x.dk on June 29, 2010, 09:34:37 PM
Just installed this mod on rc3 with SimplePortal. Everything went smooth but no gp/bp menu anywhere. Not even in the SimplePortal menu as someone described earlier.
*snip*
I made a change in the install script for 2.0.2, after the recommendation given from SiNaN (now シナン  ;D), which should hopefully fix the compatibility problem with SimplePortal.

Quote from: Verbist on July 07, 2010, 01:42:23 PM
Does anyone know, is there a way to automatically delete posts, not just hide them, based on a number of downvotes?
Hmm. This could be a (rather drastic) feature of the GPBP tools. Maybe in the future.

Quote from: anidea on August 26, 2010, 11:01:00 PM
So in an attempt to prevent retaliatory voting, is there any way I could:
1. Limit users to, say, 3 negative votes per day?
2. Have a member's total respect be based on positive voting only, and only use the negative voting in the post? 
(the reason being that the forum is very new and users are earning negative respect, which is hurting their delicate sensibilities)
You can do 2. already assuming you're under SMF 2. Just disable negative voting under Advanced options.

Quote from: Makar on September 03, 2010, 10:45:22 AM
And when will be
added adding voices to the karma
separate display of positive and negative votes
the ability to output messages of the week to block the portal
1) Voices to the karma?
2) Maybe in the future.
3) ... to block the portal?

Quote from: rocknroller on September 03, 2010, 03:24:50 PM
This mod is very cool for that, it will be more cool if somehow, users can recive notification for changes value in their own post. Maybe notifycation like PM.

Is it possable?  :D
It is possible. It may turn to be very annoying if you receive many votes though, in a very active forum at least.
Title: Re: Good Post/Bad Post Mod
Post by: Bugo on September 29, 2010, 02:45:52 AM
Nice, hardcoded text in BoardIndex.template.php ("Messages of the Week", "by", "in")...

    // Good Post/Bad Post: Show most recently voted topics...
    if (! empty($modSettings['gpbp_show_best_topics']) && ! empty($context['gpbp_best_topics']))
    {
        echo '
            <h4 class="titlebg"><span class="left"></span>
                <img class="icon" src="', $settings['images_url'], '/icons/gpbp_motw.gif" alt="MOTW" />
                <span>Messages of the Week</span>
            </h4>';
        $odd = 0;
        foreach ($context['gpbp_best_topics'] as $message)
            echo '
            <p class="inline windowbg', $odd++ % 2 ? '' : '2','">
                <a href="', $scripturl, '?topic=', $message['topic'], '.msg', $message['msg'], '#msg', $message['msg'], '">', $message['subject'], '</a>
                by ', ! empty($message['member_id']) ? '<a href="' . $scripturl . '?action=profile;u=' . $message['member_id'] . '"><strong>' : '', $message['member_name'], ! empty($message['member_id']) ? '</strong></a>' : '', '
                (', $message['score'] > 0 ? '+' : '', $message['score'], ')
                in <em>', $message['board_name'], '</em>
            </p>';
    }


Hardcoded text in GPBPManage.template.php, lines: 292, 399, 403, 424, 429, 430, 440, 444, 449, 450...
Title: Re: Good Post/Bad Post Mod
Post by: parvaz on September 29, 2010, 05:57:06 AM
Hi OutofOrder,
i would like to translate this wonderful mod for smf rc3 but don't know exactly which files to translate. well...those strings in install.xml should be translated, right? but what about those in upgarde_2.0.xml ? or the others in upgarde_accumulated_2.0.1.xml ?

Title: Re: Good Post/Bad Post Mod
Post by: IdanC on September 29, 2010, 07:12:01 AM
Quote from: OutofOrder on September 29, 2010, 02:03:56 AM
Quote from: IdanC on May 18, 2010, 06:00:53 AM
have anyone noticed that even when guests are given permission to view voter, clicking on the (https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fmila.fm%2FThemes%2Fdefault%2Fimages%2Fgpbp_voterslist.gif&hash=3ddff124ebf4a1dae384e55748f13bfd482e8a23) icon, does'nt work.
I'll be taking care of this next time.
thanks, i'll take the new version for a run this weekend.
Title: Re: Good Post/Bad Post Mod
Post by: anidea on September 29, 2010, 11:53:55 AM
Quote from: OutofOrder on September 29, 2010, 02:03:56 AM
Good Post/Bad Post mod has been updated!
Quote from: anidea on August 26, 2010, 11:01:00 PM
So in an attempt to prevent retaliatory voting, is there any way I could:
1. Limit users to, say, 3 negative votes per day?
2. Have a member's total respect be based on positive voting only, and only use the negative voting in the post? 
(the reason being that the forum is very new and users are earning negative respect, which is hurting their delicate sensibilities)
You can do 2. already assuming you're under SMF 2. Just disable negative voting under Advanced options.

Hi, and thanks for the response and the update!  Can't wait to try it.  Congrats!

But my question re: request #2 is: I don't want to disable negative voting, because I want users to be able to censor themselves.

What I'd like to do is to keep negative voting, but then have total respect based on positive votes only.

Is this possible?  Or is this what the disable negative voting does?
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on September 29, 2010, 02:53:53 PM
Quote from: Bugo on September 29, 2010, 02:45:52 AM
Nice, hardcoded text in BoardIndex.template.php ("Messages of the Week", "by", "in")...
*snip*
Hardcoded text in GPBPManage.template.php, lines: 292, 399, 403, 424, 429, 430, 440, 444, 449, 450...
Hmm. Oops. ;D Thanks for reporting.

Quote from: parvaz on September 29, 2010, 05:57:06 AM
Hi OutofOrder,
i would like to translate this wonderful mod for smf rc3 but don't know exactly which files to translate. well...those strings in install.xml should be translated, right? but what about those in upgarde_2.0.xml ? or the others in upgarde_accumulated_2.0.1.xml ?
Please wait until i re-upload the updated localisation files. I'll also add the missing strings from above.

Quote from: anidea on September 29, 2010, 11:53:55 AM
What I'd like to do is to keep negative voting, but then have total respect based on positive votes only.
Hmm. That's an interesting idea. And easy to implement too. Sit tight.
Title: Re: Good Post/Bad Post Mod
Post by: Makar on September 29, 2010, 03:38:15 PM
Quote from: OutofOrder on September 29, 2010, 02:03:56 AM
QuoteAnd when will be
added adding voices to the karma
separate display of positive and negative votes
the ability to output messages of the week to block the portal
1) Voices to the karma?
2) Maybe in the future.
3) ... to block the portal?

vote for a message and the user is added or subtracted karma
yes
it is in the portal block, rather than at the bottom of the forum

I very much hope that this future will come very soon
Title: Re: Good Post/Bad Post Mod
Post by: arty5 on September 29, 2010, 09:18:18 PM
Great mod mate
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on September 29, 2010, 10:17:07 PM
Good Post/Bad Post mod has been updated!
QuoteVersion 2.0.3 - September 30 2010

  • Fixed: Guests couldn't view voters lists even if allowed to.
  • Fixed: Some strings left out of the language files.
  • Added: Allow counting only positive votes towards user Respect.


I remind to anyone willing to translate this mod, that there's a zip file attached to the starting post (http://www.simplemachines.org/community/index.php?action=dlattach;topic=318290.0;attach=158037) containing the files with the strings needing translations. You can open them with any text editor.
Also, the French and Russian translations are halfway done, they only lack the v2.0 translations. The same goes for the Turkish translation, and this one has been partially submitted by Alpay (click to go to the post) (http://www.simplemachines.org/community/index.php?topic=318290.msg2665352#msg2665352). It still needs the latest translations.
Title: Re: Good Post/Bad Post Mod
Post by: lakechurch on September 30, 2010, 01:55:22 PM
I just want to say that this is a great mod! It works fantastic and I quickly disabled karma because all you need is this mod, very nice!
Title: Re: Good Post/Bad Post Mod
Post by: Bugo on September 30, 2010, 06:03:35 PM
Russian translation.
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on October 01, 2010, 01:16:16 AM
Thank you very much Bugo. :)
I'll wait a little before including this in the release, just to see if the Turkish translation (or any other) is also suddendly completed.
Title: Re: Good Post/Bad Post Mod
Post by: Makar on October 01, 2010, 07:22:15 AM
How to do the separate show of positive and negative voices ?

look at
Title: Re: Good Post/Bad Post Mod
Post by: DistantJ on October 16, 2010, 07:24:59 PM
Request: I'd love the option to have the good post/bad post buttons affect Karma instead of having it's own Respect system.
Title: Re: Good Post/Bad Post Mod
Post by: anidea on October 16, 2010, 08:12:17 PM
Quote from: OutofOrder on September 29, 2010, 10:17:07 PM
Good Post/Bad Post mod has been updated!
Version 2.0.3 - September 30 2010

  • Fixed: Guests couldn't view voters lists even if allowed to.
  • Fixed: Some strings left out of the language files.
  • Added: Allow counting only positive votes towards user Respect.

Woo hoo!  I can't wait to update, this is great!  Thanks!

(originally I manually installed this, don't remember why, but I suppose I have to manually uninstall and then re-install?)
Title: Re: Good Post/Bad Post Mod
Post by: Mk-Fr on October 28, 2010, 07:35:36 AM
Don't Work with Core theme in RC3  :-\
Title: Re: Good Post/Bad Post Mod
Post by: ccondrup on October 28, 2010, 02:33:02 PM
Thanks for a nice mod. I sure miss a lot of the new features exclusive for 2.x, but it seems you've made up your mind ;)

Norwegian translation attached. Warning: Only tested on 1.1.11, I don't have a 2.x install to test on (after all, it's not final yet)
Title: Re: Good Post/Bad Post Mod
Post by: uniektekniek on October 29, 2010, 12:00:47 AM
lovin this mod.. great work!

is there any chance of having some sort of alert system built into a future release so it notifies the poster when someone likes or dislikes their comment?
Title: Re: Good Post/Bad Post Mod
Post by: Riddlah on November 06, 2010, 10:02:53 PM
Any plans for SMF 2.0 RC4?

My forum members are getting a kick out of this mod so I don't want to upgrade until (unless) this will be supported....
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on November 07, 2010, 06:29:10 AM
works great on rc4, just emulate rc3 and you're good to go.

no errors, working just fine.
Title: Re: Good Post/Bad Post Mod
Post by: balti27 on November 07, 2010, 11:13:30 AM
How to emulate ?
Title: Re: Good Post/Bad Post Mod
Post by: IdanC on November 07, 2010, 12:00:59 PM
click advanced at the bottom of the package list, and replace rc4 with rc3
Title: Re: Good Post/Bad Post Mod
Post by: Riddlah on November 08, 2010, 10:46:48 AM
Excellent!

Thanks, I always forget about that option.


Yes, it works great....
Title: Re: Good Post/Bad Post Mod
Post by: Bruno Rotermund on November 10, 2010, 01:47:58 PM
Is this MOD compatible with SMF 1.1.12 ?

I'm a brazilian user and I need this working until Sunday  :-\
Can anyone help me please!?

Thanks guys ....
Title: Re: Good Post/Bad Post Mod
Post by: Bugo on November 10, 2010, 01:51:21 PM
Quote from: OutofOrder on October 01, 2010, 01:16:16 AM
Thank you very much Bugo. :)
I'll wait a little before including this in the release, just to see if the Turkish translation (or any other) is also suddendly completed.
How long Russian should wait for Turks? :)
Title: Re: Good Post/Bad Post Mod
Post by: Makar on November 11, 2010, 04:00:39 PM
Quote from: Bugo on November 10, 2010, 01:51:21 PM
How long Russian should wait for Turks? :)

Roast until the rooster will not peck  блин пока жареный петух в одно место не клюнет
Title: Re: Good Post/Bad Post Mod
Post by: tbk22 on November 13, 2010, 01:40:46 PM
Im getting this error everywhere

QuoteDatabase error, given array of integer values is empty. (id_msgs)

Quote
http://www.xxxxxxxx.com/forum/index.php?
Database error, given array of integer values is empty. (id_msgs)
Function: gpbp_getBestTopics

Ficheiro: /home/xxxxxxx/public_html/xxxxxxx.com/forum/Sources/GoodPostBadPost.php
Linha: 367

Please help me
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on November 14, 2010, 06:17:28 PM
Quote from: tbk22 on November 13, 2010, 01:40:46 PM
Im getting this error everywhere

QuoteDatabase error, given array of integer values is empty. (id_msgs)

Quote
http://www.xxxxxxxx.com/forum/index.php?
Database error, given array of integer values is empty. (id_msgs)
Function: gpbp_getBestTopics

Ficheiro: /home/xxxxxxx/public_html/xxxxxxx.com/forum/Sources/GoodPostBadPost.php
Linha: 367

Please help me
Sounds like you're not using the latest version of the mod, or have not updated correctly.


Well, new version coming soon supporting SMF2 RC4 from the go. Also in Russian. :P
Title: Re: Good Post/Bad Post Mod
Post by: mecfs on November 26, 2010, 01:23:25 PM
I have installed this mod on 2.0 RC3 but only administrators can see the post voting buttons. Why?
Title: Re: Good Post/Bad Post Mod
Post by: Bugo on November 26, 2010, 01:54:59 PM
Chew it over :) (Admin » Permissions)
Title: Re: Good Post/Bad Post Mod
Post by: Bruno Rotermund on November 29, 2010, 01:56:20 PM
WHY CAN'T I RUN THIS ON 1.1.12???  :'(

I've searched everywhere, and i just can't find a way to make it work...
I've used the normal mod uploader, but there is no way to make it work. Can anyone pleaaaase teach me how to install it?

A Brazilian member,
Bruno Werner
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on December 11, 2010, 07:59:39 PM
Good Post/Bad Post mod updated.
GP/BP v2: Installing now works without emulating the older SMF version. Also added the Russian translation (kudos to Bugo).
GP/BP v1: Installing now works in SMF 1.1.12.
Title: Re: Good Post/Bad Post Mod
Post by: Bugo on December 12, 2010, 04:05:21 AM
// Good Post/Bad Post permission strings.
$txt['permissiongroup_gpbp'] = '����� ������� ��� ���� "������� ����/������ ����"';
$txt['permissiongroup_simple_gpbp'] = '����� ������� ��� ���� "������� ����/������ ����"';
$txt['permissionname_gpbp_manage'] = '���������� ����������� ���� "������� ����/������ ����"';
$txt['permissionhelp_gpbp_manage'] = '��� ���������� �������� ��������� ����� �������� ��/��; ����� ��������, � ������� ���� ��� ������ ��������.';
$txt['cannot_gpbp_manage'] = '��� �� ��������� ���������� ����������� ���� "������� ����/������ ����".';
$txt['permissionname_gpbp_vote'] = '����������� �� ��������� (������ ��� �������)';
$txt['permissionhelp_gpbp_vote'] = '������������ ����� ��������� ��������� � ������������ ��� ������������. � �������, ���������� ���������, ������ ���� ��������� ����������� (� ���������� ����).<br/><br/><strong>����������</strong>: ����� �� ����� ����� ���������� (�������� �� ��� ����������).';
$txt['cannot_gpbp_vote'] = '��������, ��� �� ��������� ��������� ���������.';
$txt['permissionname_gpbp_reveal'] = '����������� "������" ������';
$txt['permissionhelp_gpbp_reveal'] = '������������ ����� ������������� ���������, ������� ���� ������ ��-�� �� ������ ������.';
$txt['cannot_gpbp_reveal'] = '�� �� ������ ������� � ����������, ������� � ���������� �� ������ ������.';
$txt['permissionname_gpbp_voterslist'] = '������ ������������';
$txt['permissionhelp_gpbp_voterslist'] = '������������ ����� ������������� ������ ���, ��� ������������ (� ������, ��� � ��� ������������).';
$txt['cannot_gpbp_voterslist'] = '� ��� ��� ������� � ������ ���������� �����������.';
// Managing area.

It's not russian...
Title: Re: Good Post/Bad Post Mod
Post by: tartenpoint on December 12, 2010, 07:55:08 AM
Hello, Thank you for this great mod.

I have a big problem. It doesn't work ... With IE8 I have this error message


Message : Objet requis
Ligne : 28
Caractère : 2
Code : 0
URI : http://www.boudu.org/Themes/default/scripts/gpbp.js?2_0_2



And when I click on an arrow to vote, I have this error message : (with firefox & safari)

Unknown column 'log_time' in 'field list'
Fichier: /mounted-storage/home23b/sub003/sc27620-FXZT/www/Sources/GoodPostBadPost.php
Ligne: 181


Can you help me?? Thank you!

SMF 2.0 RC4

My website : http://www.boudu.org
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on December 13, 2010, 02:10:41 AM
Quote from: Bugo on December 12, 2010, 04:05:21 AM
It's not russian...
It seems there was a problem with character encoding on my end. I've updated the installer and hopefully it's solved now, please let me know if it's still bugged.

Quote from: tartenpoint on December 12, 2010, 07:55:08 AM
Can you help me?? Thank you!
I have updated the installer of GPBP v2.0.4. Please try reinstalling the mod.
Have you upgraded this mod by the way? Were you using v1 before (ever)?
Title: Re: Good Post/Bad Post Mod
Post by: Bugo on December 13, 2010, 02:17:00 AM
$txt['gpbp_show'] = 'Ïîêàçàòü ñîîáùåíèå.';
$txt['gpbp_member_hide_action'] = 'Ïîñòû ñ îöåíêàìè: ÷òî äåëàòü ñ ñîîáùåíèÿìè, îöåíêà êîòîðûõ <strong>%s</strong> èëè ìåíüøå?';
$txt['gpbp_top_voters'] = 'Ïåðâàÿ äåñÿòêà ïðîãîëîñîâàâøèõ';
$txt['gpbp_most_respected'] = 'Äåñÿòêà íàèáîëåå óâàæàåìûõ ïîëüçîâàòåëåé';
$txt['gpbp_show_voters'] = 'Ïîêàçàòü ïðîãîëîñîâàâøèõ';
$txt['gpbp_voters_list'] = 'Ñïèñîê ãîëîñîâàâøèõ:';
$txt['gpbp_no_voters'] = 'Íåò ãîëîñîâ.';
$txt['gpbp_hide_again'] = 'Êëèêíèòå äëÿ ïîâòîðíîãî <strong>ñêðûòèÿ</strong> ýòîãî ñîîáùåíèÿ.';
$txt['gpbp_motw'] = 'Ëó÷øèå ñîîáùåíèÿ íåäåëè';
// The following strings are meant to be used in "Respect was/was not updated" below.
$txt['gpbp_was'] = 'áûëî';
$txt['gpbp_was_not'] = 'íå áûëî';
// Moderation log
$txt['modlog_ac_gpbp_deleted_votes'] = 'Óäàëåíî îöåíîê: {amount}. Çíà÷åíèå ïàðàìåòðà "Óâàæåíèå" <strong>{respect}</strong> îáíîâëåíî.';
$txt['modlog_ac_gpbp_reversed_votes'] = 'Îòìåíåíî îöåíîê: {amount}. Çíà÷åíèå ïàðàìåòðà "Óâàæåíèå" <strong>{respect}</strong> îáíîâëåíî.';
$txt['modlog_ac_gpbp_score_updated'] = 'Äëÿ ñîîáùåíèÿ #{msg} ðåçóëüòàò áûë èçìåíåí íà {score}';
$txt['modlog_ac_gpbp_respect_updated'] = '"Óâàæåíèå" ïîëüçîâàòåëÿ {membername} áûëî èçìåíåíî íà {respect}';
$txt['modlog_ac_gpbp_clean_orphaned'] = '"Âèñÿ÷èå" ãîëîñà óäàëåíû ({orphaned}).';
$txt['modlog_ac_gpbp_basic_settings'] = 'Áàçîâûå íàñòðîéêè îáíîâëåíû.';
$txt['modlog_ac_gpbp_boards'] = 'Ñïèñîê ðàçäåëîâ îáíîâë¸í.';
$txt['modlog_ac_gpbp_advanced_settings'] = 'Ðàñøèðåííûå íàñòðîéêè îáíîâëåíû.';
$txt['modlog_ac_gpbp_totals'] = 'Îáùèé ñ÷¸ò îöåíîê è "Óâàæåíèå" áûëè ïåðåñ÷èòàíû.';

It's not russian too. I've send you two separate files (russian.xml and russian-utf8.xml), why do you merge them into one?
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on December 13, 2010, 02:52:33 AM
Because I am incompetent.
Anyway the installer has been fixed for the last time, now it's using the original cyrillic-encoded xml file for the Russian language strings. ("Russian UTF-8" is already in a UTF-8-encoded xml file). :)
Title: Re: Good Post/Bad Post Mod
Post by: Bugo on December 13, 2010, 03:03:37 AM
Thanks :)
Title: Re: Good Post/Bad Post Mod
Post by: Makar on December 13, 2010, 06:58:37 AM
when will come the future? 8) ::)
http://www.simplemachines.org/community/index.php?topic=318290.msg2772184#msg2772184
http://www.simplemachines.org/community/index.php?topic=318290.msg2801160#msg2801160
http://www.simplemachines.org/community/index.php?topic=318290.msg2803333#msg2803333


may stop shaving?
and begin to grow a beard?

Title: Re: Good Post/Bad Post Mod
Post by: tartenpoint on December 13, 2010, 04:06:32 PM
 :o :o
Can somebody help me please??

When I click on "good post" or "bad post" in a post, nothing happends!

When I click with the right mouse button and "open in a new window" I have this error code??
Unknown column 'log_time' in 'field list'Fichier: /mounted-storage/home23b/sub003/sc27620-FXZT/www/Sources/GoodPostBadPost.phpLigne: 181
Where does this issue come from??
I'd really like to have this mod on my website!!
Thank you for your answers.

Kind regards
Tartenpoint
Title: Re: Good Post/Bad Post Mod
Post by: parvaz on December 16, 2010, 10:33:08 AM
This is an awesome mod. Me and my members love it.
It would look wonderful if the mod could get integrated in a portalsystem.
I know nothing about PHP, that's why i ask you guys:

Could someone write a php code for a portal block so that the current "messages of the week" (which now could be shown in info center of the forum by default) can be viewed in the portal?

I'll appreciate any help and support.
Thank you for this nice mod
Title: Re: Good Post/Bad Post Mod
Post by: tartenpoint on December 16, 2010, 03:43:15 PM
Quote from: tartenpoint on December 13, 2010, 04:06:32 PM
When I click with the right mouse button and "open in a new window" I have this error code??
Unknown column 'log_time' in 'field list'Fichier: /mounted-storage/home23b/sub003/sc27620-FXZT/www/Sources/GoodPostBadPost.phpLigne: 181


And with IE I have this message error :

Message : Objet requis
Ligne : 28
Caractère : 2
Code : 0
URI : http://www.boudu.org/Themes/default/scripts/gpbp.js?2_0_2


What's wrong with my gpbp mod installation??

Thank you
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on December 20, 2010, 06:42:02 PM
tartenpoint, I have already replied to your question a week ago...
Quote from: OutofOrder on December 13, 2010, 02:10:41 AM
I have updated the installer of GPBP v2.0.4. Please try reinstalling the mod.
Have you upgraded this mod by the way? Were you using v1 before (ever)?
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on December 20, 2010, 06:46:06 PM
Quote from: parvaz on December 16, 2010, 10:33:08 AM
It would look wonderful if the mod could get integrated in a portalsystem.
...
Could someone write a php code for a portal block so that the current "messages of the week" (which now could be shown in info center of the forum by default) can be viewed in the portal?
By portalsystem do you mean the TinyPortal mod? I don't understand your request (sounds like Makar's request which I don't understand either).
Title: Re: Good Post/Bad Post Mod
Post by: Makar on December 21, 2010, 01:51:43 PM
Simple Portal

and better function
which can be inserted anywhere in the template
type in Simple Ads

examp. <?php template_ad_position('in_block_sp_futer'); ?>
Title: Re: Good Post/Bad Post Mod
Post by: parvaz on December 22, 2010, 09:53:39 AM
Quote from: OutofOrder on December 20, 2010, 06:46:06 PM
Quote from: parvaz on December 16, 2010, 10:33:08 AM
It would look wonderful if the mod could get integrated in a portalsystem.
...
Could someone write a php code for a portal block so that the current "messages of the week" (which now could be shown in info center of the forum by default) can be viewed in the portal?
By portalsystem do you mean the TinyPortal mod? I don't understand your request (sounds like Makar's request which I don't understand either).
Sorry that i didn't express myself clear.
Actually it could be used for any Portal. But i meant for SimplePortal.
Title: Re: Good Post/Bad Post Mod
Post by: searchgr on December 22, 2010, 10:36:14 AM
Is this mod compatible to smf2 rc2?
Title: Re: Good Post/Bad Post Mod
Post by: eyo on December 28, 2010, 01:35:55 AM
Parse error: syntax error, unexpected '[' in /home/myname/public_html/Sources/BoardIndex.php on line 128


seemed to copy the right code. rc4 here. please help
Title: Re: Good Post/Bad Post Mod
Post by: genehtc on December 28, 2010, 11:35:04 PM
Hi Out of Order,

Love your mod when we had it running on rc3, but now we upgraded to RC4 and after install we log into the forum and get a database error "Unknown Tables" pointing to Goodpostbadpost.php line 370.  Only thing on line 370 is '). We tried a number of fixes we found while reading through the thread. Emulating rc3 kills other mods we have installed as they can't run under rc3. The two mods that return errors after emulating rc3 are Enhanced side menus and Quote removal tool.

Any ideas or any further info i can provide?

Thanks
Gene
Title: Re: Good Post/Bad Post Mod
Post by: willerby on January 02, 2011, 07:08:37 PM
OofO, great Mod, works really well on RC4 and almost exactly what I was looking for...

I'm only interested in positive ratings (more like Facebook's 'likes this' comment) so have disabled the negative ratings. Rather than present in the header of each post as +1 then a thumbsup or positive icon then an icon for the who's voted link, I'd prefer the results for each post to be shown in the bottom left of each post (just above the signature opposite the right had side moderator report icons), something like this from the facebook Like mod:

http://custom.simplemachines.org/mods/index.php?action=download;mod=2543;id=163427;image

ie.

17 members liked this.  Like

or

You and 17 members liked this.  Unlike

Perhaps run the list of who had voted of a hyperlink on the '17 members'. Could you help me with manual edits to display the results on the display.template.php in this way? I appreciate the Facebook mod referred to above does this but it doesn't keep everything within SMF and you can't run the stats options that you have cleverly built into this mod.

Its just a presentational thing... sorry! Great work though - love the mod and works like a dream

W
Title: Re: Good Post/Bad Post Mod
Post by: searchgr on January 03, 2011, 12:53:14 AM
willerby, i think that you need this mod: http://custom.simplemachines.org/mods/index.php?mod=710
Title: Re: Good Post/Bad Post Mod
Post by: impreza on January 03, 2011, 01:15:25 AM
Mod looks good, I'll test it at home, thanks
Title: Re: Good Post/Bad Post Mod
Post by: willerby on January 03, 2011, 02:25:57 AM
Quote from: searchgr on January 03, 2011, 12:53:14 AM
willerby, i think that you need this mod: http://custom.simplemachines.org/mods/index.php?mod=710

Looks more like what I'm after but support for RC4 slow coming...
Title: Re: Good Post/Bad Post Mod
Post by: willerby on January 03, 2011, 08:21:30 AM
OofO, no need to respond to my earlier post, I managed to find a way with trial error to move the existing icons to where I wanted them, then amended the display.template to reflect what I was looking for by trial and error...

Great Mod

Thanks

W
Title: Re: Good Post/Bad Post Mod
Post by: searchgr on January 03, 2011, 12:05:49 PM
Can you please explain me the 'Messages of the week' that appear in the info center? A new week came but the messages are the same as previous week.
Title: Re: Good Post/Bad Post Mod
Post by: Bugo on January 04, 2011, 09:26:00 AM
Please update russian translation.
Title: Re: Good Post/Bad Post Mod
Post by: searchgr on January 04, 2011, 12:40:03 PM
Quote from: searchgr on January 03, 2011, 12:05:49 PM
Can you please explain me the 'Messages of the week' that appear in the info center? A new week came but the messages are the same as previous week.


Also, this mod should have spam protection.

Daily limit per user for voting.
Title: Re: Good Post/Bad Post Mod
Post by: tartenpoint on January 04, 2011, 02:06:39 PM
Quote
I have updated the installer of GPBP v2.0.4. Please try reinstalling the mod.
Have you upgraded this mod by the way? Were you using v1 before (ever)?


Yes sure, I have uninstalled the old version, and re-installed the last GPBP.
I used a version for smf 2.0 rc3 before (It didn't work too)

You can see it on my website: www.boudu.org
"+" & "-" appear but I can't click on them!

Can you help me please??
Thank you very much  O:)
Title: Re: Good Post/Bad Post Mod
Post by: impreza on January 04, 2011, 02:33:05 PM
A very fun twist, thanks for the add
Title: Re: Good Post/Bad Post Mod
Post by: Custoo on January 06, 2011, 08:02:09 AM
I'm using SMF 2.0 RC4 and I tried to install this MOD. One test didn't pass on install and the result was that no voting options on posts nor any new options appeared in the admin panel. The failed test was this:
6.   Execute Modification   ./Sources/ManagePermissions.php   Test failed
   3.   Replace   ./Sources/ManagePermissions.php   Test failed

Is there anything I can do about this?
Title: Re: Good Post/Bad Post Mod
Post by: tartenpoint on January 07, 2011, 09:08:22 AM
Hi,
I found what was wrong!
I had a problem with the database...

Thanks for the support and this great mod  :P
Title: Re: Good Post/Bad Post Mod
Post by: blow on January 22, 2011, 05:07:38 PM
Quote from: DistantJ on October 16, 2010, 07:24:59 PM
Request: I'd love the option to have the good post/bad post buttons affect Karma instead of having it's own Respect system.
Is it possible to do that with some kind of simple changes?
I mean... isn't it possible to simply change the DB destiny in order to make the points accumulate on Karma variable?
Title: Re: Good Post/Bad Post Mod
Post by: jcxtom on January 23, 2011, 09:26:45 AM
Hi!
I Would like to translate this mod to german. I would be very glad if you would help me doing so, so that i can have this nice tool on my Forums as well. Thanks!
Title: Re: Good Post/Bad Post Mod
Post by: blow on January 24, 2011, 10:39:29 AM
Quote from: blow on January 22, 2011, 05:07:38 PM
Quote from: DistantJ on October 16, 2010, 07:24:59 PM
Request: I'd love the option to have the good post/bad post buttons affect Karma instead of having it's own Respect system.
Is it possible to do that with some kind of simple changes?
I mean... isn't it possible to simply change the DB destiny in order to make the points accumulate on Karma variable?
(I managed to solve that myself.  :D)

-----

I've got a problem here, the permission to let a membergroup "Manage GPBP mod settings" is not working. My sub-admins can't see the GPBP area on admin panel. What should I do?
Title: Re: Good Post/Bad Post Mod
Post by: OutofOrder on January 25, 2011, 07:19:36 PM
Quote from: searchgr on January 03, 2011, 12:05:49 PM
Can you please explain me the 'Messages of the week' that appear in the info center? A new week came but the messages are the same as previous week.
Messages of the week are those messages that have gotten most votes anytime in the past 7 days. If a week passes by and the same messages are still shown there, it has to be because people keep voting the same messages during a whole week or more.

Quote from: searchgr on January 04, 2011, 12:40:03 PM
Also, this mod should have spam protection.
Daily limit per user for voting.
Do you mean protection against bots? Or against happy-button-clicking users?  :)

Quote from: Bugo on January 04, 2011, 09:26:00 AM
Please update russian translation.
Thanks for the update. Hopefully will be up soon. :D

Quote from: blow on January 24, 2011, 10:39:29 AM
I've got a problem here, the permission to let a membergroup "Manage GPBP mod settings" is not working. My sub-admins can't see the GPBP area on admin panel. What should I do?
Looks like a bug to fix in the next version :o 

Quote from: jcxtom on January 23, 2011, 09:26:45 AM
I Would like to translate this mod to german. I would be very glad if you would help me doing so, so that i can have this nice tool on my Forums as well. Thanks!
Hi, thanks for volunteering. I have sent you a PM on this matter. :)

About GP/BP and Karma: I've yet to look into SMF's karma system.
I'm not willing to do a half-assed change with the knowledge that there's a possibility to abuse it. If the mod gets linked to SMF's Karma, it has to be done thoroughly: linking changes done from the Admin GP/BP area to the Karma levels, and such.
And I'm sorry but, please don't expect this to happen soon.
Title: Re: Good Post/Bad Post Mod
Post by: Armen on February 10, 2011, 05:35:18 PM
Little problem with russification of mod(see screenshot) It don't want to show russian symbols properly.
Title: Re: Good Post/Bad Post Mod
Post by: tbk22 on February 11, 2011, 12:32:51 AM
I would like to translate to portuguese

Please send me the files to translate
Title: Re: Good Post/Bad Post Mod
Post by: parvaz on February 11, 2011, 09:19:13 AM
This is an awesome mod and my members love it.
some weeks ago i asked whether is it possible to have the "message of the week" in the Portal of the forum instead of "infocenter".
I use simpleportal like many others. Could someone share the PHPcode for a Block.

I really appreciate it
Title: Re: Good Post/Bad Post Mod
Post by: eyo on February 26, 2011, 08:26:59 PM
im very picky about mods but this mod is one of the best mods in smf
Title: Re: Good Post/Bad Post Mod
Post by: Alleks on March 01, 2011, 07:56:46 AM
Getting this error when trying to enter administration panel of GPBP:

Fatal error: Call to undefined function GPBP_Manage() in /usr/home/****/forum/Sources/Admin.php on line 588

Version of forum RC4

Line:

'function' => 'RepairBoards',

What to do?

Title: Re: Good Post/Bad Post Mod
Post by: enac on March 04, 2011, 11:30:50 AM
Will this mod get updated to work with RC5?
Title: Re: Good Post/Bad Post Mod
Post by: Makar on March 07, 2011, 07:21:20 AM
Quote from: Armen on February 10, 2011, 05:35:18 PM
Little problem with russification of mod(see screenshot) It don't want to show russian symbols properly.

not the encoding, see the first post Bugo on this page http://www.simplemachines.org/community/index.php?topic=318290.msg2901645#msg2901645
Title: Re: Good Post/Bad Post Mod
Post by: unformatted_ on March 08, 2011, 08:39:18 AM
Hi!
I would like to offer something to the best topic/messages of the month. How can I see the best (more votes) topics/posts of last month?

thanks
Title: Re: Good Post/Bad Post Mod
Post by: MikeMS on March 08, 2011, 12:07:07 PM
When I try to apply this mod (in 1.1.13) it tells me it's corrupt.
Title: Re: Good Post/Bad Post Mod
Post by: Fotoforofos.com on March 15, 2011, 04:19:15 AM
Quote from: enac on March 04, 2011, 11:30:50 AM
Will this mod get updated to work with RC5?

Have you tried it emulating version 2.0 RC4 before installing? Perhaps it can be installed this way ...
Title: Re: Good Post/Bad Post Mod
Post by: Fotoforofos.com on March 15, 2011, 04:51:00 AM
Could you add an option so the admin can choose to enable this mod only in the first post of a topic? This way this mod could be used as a Good Topic/Bad Topic ... and yes, i know "Rate That Topic" mod, but it's not the same because it shows the average votes ...

What do you think?
Title: Re: Good Post/Bad Post Mod
Post by: Motahhari on March 20, 2011, 12:57:09 PM
GPBP doesn't work in SMF2 RC5. it is installed correctly and buttons are shown. But the vote button doesn't work. Is there anyway to fix it? Could you please release the new version?
Title: Re: Good Post/Bad Post Mod
Post by: h4k on March 24, 2011, 02:25:55 PM
I forced the installation on 2.0 RC5 but it doesnt work, didnt show buttons or nothing, please make an update for this mod.
Title: Re: Good Post/Bad Post Mod
Post by: orlandoryo on March 26, 2011, 12:35:26 PM
I need this mod so bad for RC5!!!  :-\
Title: Re: Good Post/Bad Post Mod
Post by: Cristian10 on March 30, 2011, 04:50:43 AM
Could you make it for 1.1.13 smf version plzz?
Title: Re: Good Post/Bad Post Mod
Post by: appi on March 30, 2011, 08:00:28 AM
Hi update smf version 2.0 rc5 please thank you very much I was using 1.1.13, but in 2.0. but everything about making the transition to rc5 did not vote for that word, I click the left click event does nothing Can you help please?
Title: Re: Good Post/Bad Post Mod
Post by: tatkyatgyi on March 30, 2011, 11:24:19 AM
Thanks and I like this mod a lot .
But can we put this (up/down arrow button)  at the bottom of the post instead of the top. Because our members need to read the post before voting that post. After reading the post they need to scroll up for the voting.
Title: Re: Good Post/Bad Post Mod
Post by: PLAYBOY on April 02, 2011, 04:41:02 PM
Quote from: Cristian10 on March 30, 2011, 04:50:43 AM
Could you make it for 1.1.13 smf version plzz?

Same here please!!!
I need it so bad!
Title: Re: Good Post/Bad Post Mod
Post by: appi on April 05, 2011, 06:33:24 AM
plz. update smf version 2.0 rc5 ??????? reality
Title: Re: Good Post/Bad Post Mod
Post by: Stern on April 13, 2011, 10:07:08 PM
Quote from: OutofOrder on June 18, 2009, 12:13:05 PM
Quote from: Antes on June 18, 2009, 09:06:47 AM
Quote from: OutofOrder on June 18, 2009, 08:54:53 AM
Quote from: Antes on June 18, 2009, 08:35:10 AM
Thx For Help , Can we edit this mod towards to "Only For Topic ?"

i want to mean > i'm playing eRepublik and this game had a newspaper system every News can get vote ( more vote goes ur news to upper ) ?

i'm trying to make a special space for "news" and this mod can help me about it :)
I'm not sure what you're asking, but it seems to be this: Do you want to change the order of the topics in the topic list? And order them using the votes each first post of the topic has?

Simply yes xD Only Vote Topic ( but only +1 Vote ) +Closed News Vote became 0 , or Closed News not shown in Recent News Place
Unfortunately, this mod is not meant to do this. :-[ It is not the idea for which it was made.
You could try the Topic ratings mod (http://custom.simplemachines.org/mods/index.php?mod=91), which lets you rate topics individually and sort the board by topic rating. Hope this helps.
Thank you for great Mod, OutofOrder!
I also need to vote only in the first post of the topic.
Topic ratings mod is not supported since 2007 - does not appear any way to specify in the settings of a map of this possibility only for the first post (as, for example, in the Share This Topic (http://custom.simplemachines.org/mods/index.php?mod=2111) - "You can enable/disable every button and it will appear inside the first or every post of every thread")?


Quote from: appi on April 05, 2011, 06:33:24 AM
plz. update smf version 2.0 rc5 ??????? reality
appi, this mod great work not only RC5, but and 1.1.13 too! - checked!))
Title: Re: Good Post/Bad Post Mod
Post by: PLAYBOY on April 14, 2011, 03:22:07 AM
So does it install on 1.1.3 automatically?
Title: Re: Good Post/Bad Post Mod
Post by: Stern on April 15, 2011, 04:12:20 PM
Quote from: PLAYBOY on April 14, 2011, 03:22:07 AM
So does it install on 1.1.3 automatically?
did you mean 1.1.13? - no, I'm correct one file - $_your_forum/Themes/$_your_themedir/Display.template.php manually/
It's simple and works fine
Title: Re: Good Post/Bad Post Mod
Post by: PLAYBOY on April 15, 2011, 04:17:00 PM
Quote from: Stern on April 15, 2011, 04:12:20 PM
Quote from: PLAYBOY on April 14, 2011, 03:22:07 AM
So does it install on 1.1.3 automatically?
did you mean 1.1.13? - no, I'm correct one file - $_your_forum/Themes/$_your_themedir/Display.template.php manually/
It's simple and works fine

What do you mean? I didnt understand.
Title: Re: Good Post/Bad Post Mod
Post by: Dreko on April 15, 2011, 04:52:09 PM
I installed everything correctly on my forum but no buttons appear, is a custom theme
Title: Re: Good Post/Bad Post Mod
Post by: live627 on April 15, 2011, 05:31:07 PM
Quote from: Dreko on April 15, 2011, 04:52:09 PM
I installed everything correctly on my forum but no buttons appear, is a custom theme
which SMF version?
Title: Re: Good Post/Bad Post Mod
Post by: appi on April 19, 2011, 02:51:58 AM
Do you have what Stern is better?
Title: Re: Good Post/Bad Post Mod
Post by: Stern on April 21, 2011, 10:28:35 AM
Quote from: PLAYBOY on April 15, 2011, 04:17:00 PM
Quote from: Stern on April 15, 2011, 04:12:20 PM
Quote from: PLAYBOY on April 14, 2011, 03:22:07 AM
So does it install on 1.1.3 automatically?
did you mean 1.1.13? - no, I'm correct one file - $_your_forum/Themes/$_your_themedir/Display.template.php manually/
It's simple and works fine

What do you mean? I didnt understand.
I ask you again:
Did you mean version 1.1.13?

On it and 2.5 this mod are given NOT automatically. you must manually edit one file - Display.template.php
If you not understand me again - ask in russian, please!)
Title: Re: Good Post/Bad Post Mod
Post by: PLAYBOY on April 21, 2011, 04:21:53 PM
I use 1.1.13.
I think you are saying that i need to manually edit one file which is Display.template.php
ok. I can do that.
Title: Re: Good Post/Bad Post Mod
Post by: tatkyatgyi on April 25, 2011, 01:22:45 PM
Quote from: tatkyatgyi on March 30, 2011, 11:24:19 AM
Thanks and I like this mod a lot .
But can we put this (up/down arrow button)  at the bottom of the post instead of the top. Because our members need to read the post before voting that post. After reading the post they need to scroll up for the voting.

I did it by myself  manually edit one file which is Display.template.php.
I want to know one more thing can we show negative vote also same time with positive vote? where can I edit for that?
Title: Re: Good Post/Bad Post Mod
Post by: poetra on April 26, 2011, 12:56:28 PM
Still unsupport for RC5 version??
Title: Re: Good Post/Bad Post Mod
Post by: live627 on April 27, 2011, 03:08:31 AM
Apparently not because the author hasn't logged in for a few months. However, did you try to emulate version?
Title: Re: Good Post/Bad Post Mod
Post by: poetra on April 27, 2011, 04:08:52 AM
installed succesfull on emulate ver,,..  :)
Title: Re: Good Post/Bad Post Mod
Post by: Riddlah on May 01, 2011, 10:00:26 PM
Anybody know how to make the GPBP Tools --> GPBP Vote Search feature work when paging through?

The first page works fine but when you click page forward/backward the filters are cleared and you no longer see a particular voter/poster.


I know how to get this from the database but as the owner of the site I don't want to give the other 2 admins access to that. They aren't very technical and besides I'm not giving anyone access to accidentally destroy the database.
Title: Re: Good Post/Bad Post Mod
Post by: roonekoos on May 06, 2011, 05:59:20 PM
Hi,

I installed the mod and all works fine but one problem, the messages of the week don't show in the info centre.

I hope someone can help me, I have 2.0RC4

http://metal-world.biz

Thanks.
Title: Re: Good Post/Bad Post Mod
Post by: roonekoos on May 09, 2011, 09:26:42 AM
help needed please :)
Title: Re: Good Post/Bad Post Mod
Post by: TurtleKicker on June 14, 2011, 05:07:06 PM
Although the author has not been active here in a while, he is still alive. I've tracked him down and emailed him, asking if he'd kindly either update this mod or release it to the public domain. So we shall see. :)
Title: Re: Good Post/Bad Post Mod
Post by: Motahhari on June 15, 2011, 11:55:07 AM
Hi
I tested this mod on final version of SMF. It works !
Title: Re: Good Post/Bad Post Mod
Post by: Motahhari on June 16, 2011, 07:26:51 PM
Hi
I found the way you can fix GPBP to work with smf RC5 and final ! The main problem is that there are some changes in database.

go to your database manager (phpmyadmin)

Open your database and go to smf_log_gpbp

you will see this :

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fs1.picofile.com%2Ffile%2F6817614684%2Fbefore.jpg&hash=2b31f4b85461d2f1ea5c07e06a2aec18c51426a8)

You must change it to this :

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fs1.picofile.com%2Ffile%2F6817613678%2Fafter.jpg&hash=ab89e2fde5dd5bec01b8f751276d05b1a551f365)


As you see these name are changed in Field and Indexes:
ID_MSG > id_msg
ID_MEMBER > id_member
ID_POSTER > id_poster


also you must add a new row to structure. for adding a new row use this query :

ALTER TABLE smf_log_gpbp ADD COLUMN log_time CHAR(10) NULL AFTER id_poster;

then modify it like this :

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fs1.picofile.com%2Ffile%2F6817615690%2Fgv.jpg&hash=e1fb326e533613002bf421b18335c0df16c074ef)

Finish !  :laugh:
Title: Re: Good Post/Bad Post Mod
Post by: woodsters on June 16, 2011, 07:36:21 PM
Install did not work for 1.1.14... says its corrupt...
Title: Re: Good Post/Bad Post Mod
Post by: FANAT on June 21, 2011, 06:04:29 PM
Обновите версию для 2.0 final
Update version for 2.0 final
Title: Re: Good Post/Bad Post Mod
Post by: Donovan` on June 27, 2011, 09:16:42 PM
Installed successfully with emulated 2.0 RC4, but got this error when trying to click "thumbs up" on a post:

Unknown column 'log_time' in 'field list'
File: /var/www/siteaddress/public_html/forum/Sources/GoodPostBadPost.php
Line: 181

any help?
Title: Re: Good Post/Bad Post Mod
Post by: sss on June 28, 2011, 03:27:27 PM
wich file i have to modify to see instead of most popular mssges of week, the 10 worst or , both worst and best messagges on the week.

any idea?-
Title: Re: Good Post/Bad Post Mod
Post by: Jessica. on June 28, 2011, 07:43:56 PM
really good mod. Didn't know that till now. Now I have it on my test forum :D
Title: Re: Good Post/Bad Post Mod
Post by: PLAYBOY on June 29, 2011, 03:45:47 AM
It doesnt install on 2.0 gold
will it be updated for 2.0?
Title: Re: Good Post/Bad Post Mod
Post by: Jessica. on June 30, 2011, 02:49:28 PM
Quote from: PLAYBOY on June 29, 2011, 03:45:47 AM
It doesnt install on 2.0 gold
will it be updated for 2.0?

if you emulate it, it should install. I have it installed and I use 2.0 gold
Title: Re: Good Post/Bad Post Mod
Post by: PLAYBOY on June 30, 2011, 02:53:56 PM
nah... I d ratter wait for the update.
Title: Re: Good Post/Bad Post Mod
Post by: Altzone on July 01, 2011, 01:02:08 AM
Quote from: Jessica. on June 30, 2011, 02:49:28 PM
Quote from: PLAYBOY on June 29, 2011, 03:45:47 AM
It doesnt install on 2.0 gold
will it be updated for 2.0?

if you emulate it, it should install. I have it installed and I use 2.0 gold

How do you "emulate it"?
I'm using 2.0 release version and would love to have this.
BTW, are there any similar mods that allow posts to be "voted up" and display a "popular posts" on the index page?

Thanks
Dave.
Title: Re: Good Post/Bad Post Mod
Post by: Jessica. on July 01, 2011, 02:21:50 PM
In Browse Packages, go to the very bottom where you see "Advanced"

emulate it to 2.0 RC4 and Install Mod should appear.
Title: Re: Good Post/Bad Post Mod
Post by: atarnotes on July 30, 2011, 09:47:10 AM
Using emulated version on 2.0 final and it works perfectly. How would I go about adding the post score and members whom voted to the 'Show Posts' page on user profiles?
Title: Re: Good Post/Bad Post Mod
Post by: manicbe on August 14, 2011, 07:34:57 AM
hi, how did you manage to have the emulated version working on 2.0 final? When I try it I have: "
An Error Has Occurred!
You cannot download or install new packages because the Packages directory or one of the files in it are not writable!"

any advise on which files/folders I should set to writeable?
I don't have any issues when installing genuine 2.0 final mods
Title: Re: Good Post/Bad Post Mod
Post by: Ihmeliö on September 09, 2011, 03:45:03 PM
Any hope of a feature listing all posts that have received at least *** upvotes?

Or at least "top 100 (or whatever) posts of all time"?

More statistics = always good.

(does someone know if there's still going to be updates for this mod?)
Title: Re: Good Post/Bad Post Mod
Post by: JohnWayne999 on October 09, 2011, 01:44:16 AM
Hi guys, hope what I'm going to say is useful to some people. I am running SMF 1.1.15 and successfully installed GoodPostBadPost1.1.3a.zip using the package manager. However I made some minor changes described as follows:

When I asked package manger to take on the original GoodPostBadPost1.1.3a.zip, the manager told me something like "version incompatible" or "may be corrupt".  So I unzipped the file and took a quick look myself.

I first looked at gpbp_1.1.x_install.php which looked like it's creating database/tables. Nothing interesting so I closed it.
Next I looked at install_1.1.x.xml. Looked like it's a mega find and insert machine. More like a patcher. Nothing interesting. Close it too.

Before I decided to giveup, I had a quick look in package-info.xml, and it contained version information. So what I tried was nothing tricky, I just changed all instances of 1.1.3 to 1.1.15. For example:  <install for="1.1-1.1.3"> became    <install for="1.1-1.1.15">.
Then I zipped up the whole thing (I called it GoodPostBadPost1.1.15.zip, attached to this post).

I was happy to guess that's the information the package manager used to check against SMF version. Apparently it must have taken the range 1.1-1.1.3 and compared against my SMF's 1.1.15 and then decided not to proceed. So after what I changed, hopefully the manager will now be fooled to go ahead with the rest of the installation. And I was right. I fed the package manager my modified zip and this time there was no complaint about version incompatibility.  However upon doing a simulation run on the package, the simulation complained of one failed test namely "Execute Modification --- ./Sources/ManagePermissions.php   --- Test failed". Didn't really care about it. Worse comes the worst I can just tweek that file manually myself. Anyway cut long story short, I just ignored the warning and proceeded to install the mod. Installed fine and the good feedback / bad feedback function worked smoothly for user logged in as admin.

But hang on. When I test logged in as a newbie, I couldn't leave good/bad feedbacks. I tried to set permissions to allow newbies to leave feedbacks but there's nothing for me to choose from in the permissions menu. It occurred to me, must be the Sources/ManagePermissions.php that's screwing around with me. So back I went to check install_1.1.x.xml inside which is this section about how to modify Sources/ManagePermissions.php:

<file name="$sourcedir/ManagePermissions.php">
<operation>
<search position="before"><![CDATA['edit_news' => false,]]></search>
<add><![CDATA[
'gpbp_manage' => false,]]></add>
</operation>

<operation>
<search position="after"><![CDATA[ )
),
'board' => array(]]></search>
<add><![CDATA[ ),
'gpbp' => array(
'gpbp_vote' => false,
'gpbp_reveal' => false,
]]></add>
</operation>

<operation>
<search position="before"><![CDATA['send_mail',]]></search>
<add><![CDATA[
'gpbp_manage',
'gpbp_vote',]]></add>
</operation>
</file>


I checked with the copy of ManagePermission.php on the server and only two spots were modified, not the required three.
This part is missing:
'gpbp' => array(
'gpbp_vote' => false,
'gpbp_reveal' => false,
                                )


So I manually added it in. Cut long story short, you should replace this
'chat' => array(
'chat_access' => false,
'chat_mod' => false,
'shout_view' => false,
'shout_access' => false,
'shout_mod' => false,
)


with this
'chat' => array(
'chat_access' => false,
'chat_mod' => false,
'shout_view' => false,
'shout_access' => false,
'shout_mod' => false,
),
                        'gpbp' => array(
'gpbp_vote' => false,
'gpbp_reveal' => false,
                        )


This time everything worked fine. First time around you need to log in as admin -> ADMIN -> Members -> Permission -> Once in, set normal users to be allowed to "Vote on posts (up or down)" and be allowed to "Reveal bad posts" -> Then confirm by clicking on "Set permissions" button. Now you are really done. Everything should work now. Admin and normal users can both leave positive or negative feedbacks.

Most people are probably fine with installing GoodPostBadPost to their SMF. Just in case you are like me using 1.1.15 and have no idea how to get past the Package Manager first time, I've attached to this post my modified and rezipped version. I called it GoodPostBadPost1.1.15.zip. See if works for you. Note you still need to do that last bit of modification to the ManagePermissions.php as described above, because I am too lazy to incoporate that into the zip. Also don't forget to backup everything beforehand as always.

So in a nutshell I just changed the version check information in the package, and I manually added a bit of detail into Sources/ManagePermissions.php that's all and the rest flowed on normally.

(By the way, people might want to consider FacebookLike MOD also. It's basically the same thing but each post can accumulate likes and no thumbs downs. http://custom.simplemachines.org/mods/index.php?mod=3105 )
Title: Re: Good Post/Bad Post Mod
Post by: girlfloyd on October 10, 2011, 10:52:18 AM
I made this install in 2.0.1 by modifying the versions in the package-info.xml as JohnWayne999 said. However, there were no issues with the ./Sources/ManagePermissions.php file for me. The problem was with ./Sources/Display.php.

Find this:

m.id_msg_modified < {int:new_from} AS is_read, k.message AS is_repped

Replace with:

m.id_msg_modified < {int:new_from} AS is_read, gpbp_score, k.message AS is_repped

That should fix it so that it saves the ratings in 2.0.1.

Now I need to figure out how to make the ratings show in the topic titles listed in the forum...  Let me know if anyone can help with this! :P
Title: Re: Good Post/Bad Post Mod
Post by: Guillelmus on October 18, 2011, 02:26:17 PM
Installs fine on 2.0.1 just can't see the list of voters.  ??? Any ideas?
Title: Re: Good Post/Bad Post Mod
Post by: Guillelmus on October 18, 2011, 02:55:07 PM
Also code for hiding the number if zero would be nice. Let's see if I can figure it out myself...
Title: Re: Good Post/Bad Post Mod
Post by: Guillelmus on October 18, 2011, 03:13:32 PM
Quote from: Guillelmus on October 18, 2011, 02:55:07 PM
Also code for hiding the number if zero would be nice. Let's see if I can figure it out myself...
Ok.

In Display.template.php
Replace
echo '
<span id="gpbp_score_', $message['id'], '" class="help" title="', $txt['gpbp_post_score'], '">', $message['gpbp_score'], '</span>';

with

         if (!empty($message['gpbp_score']))  echo '
<span id="gpbp_score_', $message['id'], '" class="help" title="', $txt['gpbp_post_score'], '">', $message['gpbp_score'], '</span>';
Title: Re: Good Post/Bad Post Mod
Post by: Guillelmus on October 19, 2011, 06:46:03 AM
Quote from: Guillelmus on October 18, 2011, 02:26:17 PM
Installs fine on 2.0.1 just can't see the list of voters.  ??? Any ideas?
Oh, it was disabled in the options. Admin -> Forum/Good Post Bad Post -> Advanced configuration -> Amount of members to display in post voters list: must be greater than zero.

I'd like to see the names on mouse hover on though. :-)
Title: Re: Good Post/Bad Post Mod
Post by: Guillelmus on October 19, 2011, 06:51:34 AM
For hiding voters list if no-one has voted:

In Display.template.php
Find:
if ($context['reveal_voterslist'])
Replace with:
if (($context['reveal_voterslist'])&&(!empty($message['gpbp_score'])))
Title: Re: Good Post/Bad Post Mod
Post by: Guillelmus on October 19, 2011, 07:21:37 AM
Quote from: Guillelmus on October 19, 2011, 06:46:03 AM
I'd like to see the names on mouse hover on though. :-)
Quick and not very smart fix to this is to change onclick value to onmouseover

In Display.template.php

Find:
<a class="gpbp_voterslist" id="gpbp_voterslist_', $message['id'], '" onclick="oVotePost.voterslist(\'', $message['id'], '\'); return false"><img class="gpbp_vote_img" src="', $settings['images_url'], '/gpbp_voterslist.gif" alt="', $txt['gpbp_show_voters'], '" title="', $txt['gpbp_show_voters'], '" /></a>
Replace with:
<a class="gpbp_voterslist" id="gpbp_voterslist_', $message['id'], '" onmouseover="oVotePost.voterslist(\'', $message['id'], '\'); return false"><img class="gpbp_vote_img" src="', $settings['images_url'], '/gpbp_voterslist.gif" alt="', $txt['gpbp_show_voters'], '" title="', $txt['gpbp_show_voters'], '" /></a>
Title: Re: Good Post/Bad Post Mod
Post by: Guillelmus on October 19, 2011, 01:20:54 PM
Liked messages should be hidden from the Messages of the week list if they're on a board the user cannot read.
Title: Re: Good Post/Bad Post Mod
Post by: Major Wood on October 21, 2011, 06:12:01 PM
Every time that I click on install (to go to the page that tests the various operations, not the confirmation page) for this mod, I start getting 500 errors sitewide.
Any thoughts? Running 2.0.1
Title: Re: Good Post/Bad Post Mod
Post by: Gambi on October 30, 2011, 07:13:01 AM
Hi, is this mod supposed to refresh the page when you click the up or down arrow? It'll register it if you refresh manually but it'll be great if it could update instantly or refresh the page kind of like how karma works. I've tried but couldn't get it to work. Does anyone know how they'd alter the code below so it refreshes the page at that post or even just updated the arrows instantly. I'd appreciate the help.

// Good Post/Bad Post score and voting.
if ($context['gpbp_enabled'])
{
$message['gpbp_score'] = ( $message['gpbp_score'] > 0 ? '+' : '' ) . $message['gpbp_score'];
echo '
<div class="gpbp_vote normaltext">
<span id="gpbp_score_', $message['id'], '" class="help" title="', $txt['gpbp_post_score'], '">', $message['gpbp_score'], '</span>';

if ($context['can_vote_gpbp'] && $message['member']['id'] != $context['user']['id'])
{
echo '
<a onclick="oVotePost.vote(\'down\', \'', $message['id'], '\', \'', $context['session_id'], '\'); return false" href="', $scripturl, '?action=gpbp;sa=down;msg=', $message['id'], ';sesc=', $context['session_id'], ';board=', $context['this_board'], ';topic=', $context['current_topic'], '"><img class="gpbp_vote_img" id="gpbp_vote_down_', $message['id'], '" src="', $settings['default_images_url'], '/gpbp_arrow_down', $message['gpbp_img']['down']['lit_suffix'], '.gif" alt="', $txt[ $message['gpbp_img']['down']['alt'] ], '" title="', $txt[ $message['gpbp_img']['down']['title'] ], '" /></a>
<a onclick="oVotePost.vote(\'up\', \'', $message['id'], '\', \'', $context['session_id'], '\'); return false" href="', $scripturl, '?action=gpbp;sa=up;msg=', $message['id'], ';sesc=', $context['session_id'], ';board=', $context['this_board'], ';topic=', $context['current_topic'], '"><img class="gpbp_vote_img" id="gpbp_vote_up_', $message['id'], '" src="', $settings['default_images_url'], '/gpbp_arrow_up', $message['gpbp_img']['up']['lit_suffix'], '.gif" alt="', $txt[ $message['gpbp_img']['up']['alt'] ], '" title="', $txt[ $message['gpbp_img']['up']['title'] ], '" /></a>';
}

echo  '
</div>';
}

Title: Re: Good Post/Bad Post Mod
Post by: Interested bystander on November 05, 2011, 07:20:27 PM
I installed this on one of my 2.0.1 forums and it worked fine.   I just installed it on a second forum of the same version today and only the admin can see the arrows and cast votes.   Where should I start looking for my problem?   
Title: Re: Good Post/Bad Post Mod
Post by: Interested bystander on November 06, 2011, 01:52:05 AM
Never mind, I figured it out.
Title: Re: Good Post/Bad Post Mod
Post by: crazyASD on November 06, 2011, 06:58:29 AM
After installation Google +1 button, user scores (under user`s avatar) doesn`t shown, it shown again only if user clicking on good/bad post control.
Please fix it!
Title: Re: Good Post/Bad Post Mod
Post by: valpo04 on November 06, 2011, 07:44:02 PM
Trying to install this mod and I get an error with the modification of Load.php.  Every other modification is successful, except that one, it says "Test Failed."

Any ideas?
Title: Re: Good Post/Bad Post Mod
Post by: Major Wood on November 07, 2011, 08:17:07 AM
Quote from: Major Wood on October 21, 2011, 06:12:01 PM
Every time that I click on install (to go to the page that tests the various operations, not the confirmation page) for this mod, I start getting 500 errors sitewide.
Any thoughts? Running 2.0.1

Bump! Anyone?
Title: Re: Good Post/Bad Post Mod
Post by: Gambi on November 08, 2011, 12:49:51 PM
Quote from: Gambi on October 30, 2011, 07:13:01 AM
Hi, is this mod supposed to refresh the page when you click the up or down arrow? It'll register it if you refresh manually but it'll be great if it could update instantly or refresh the page kind of like how karma works. I've tried but couldn't get it to work. Does anyone know how they'd alter the code below so it refreshes the page at that post or even just updated the arrows instantly. I'd appreciate the help.

// Good Post/Bad Post score and voting.
if ($context['gpbp_enabled'])
{
$message['gpbp_score'] = ( $message['gpbp_score'] > 0 ? '+' : '' ) . $message['gpbp_score'];
echo '
<div class="gpbp_vote normaltext">
<span id="gpbp_score_', $message['id'], '" class="help" title="', $txt['gpbp_post_score'], '">', $message['gpbp_score'], '</span>';

if ($context['can_vote_gpbp'] && $message['member']['id'] != $context['user']['id'])
{
echo '
<a onclick="oVotePost.vote(\'down\', \'', $message['id'], '\', \'', $context['session_id'], '\'); return false" href="', $scripturl, '?action=gpbp;sa=down;msg=', $message['id'], ';sesc=', $context['session_id'], ';board=', $context['this_board'], ';topic=', $context['current_topic'], '"><img class="gpbp_vote_img" id="gpbp_vote_down_', $message['id'], '" src="', $settings['default_images_url'], '/gpbp_arrow_down', $message['gpbp_img']['down']['lit_suffix'], '.gif" alt="', $txt[ $message['gpbp_img']['down']['alt'] ], '" title="', $txt[ $message['gpbp_img']['down']['title'] ], '" /></a>
<a onclick="oVotePost.vote(\'up\', \'', $message['id'], '\', \'', $context['session_id'], '\'); return false" href="', $scripturl, '?action=gpbp;sa=up;msg=', $message['id'], ';sesc=', $context['session_id'], ';board=', $context['this_board'], ';topic=', $context['current_topic'], '"><img class="gpbp_vote_img" id="gpbp_vote_up_', $message['id'], '" src="', $settings['default_images_url'], '/gpbp_arrow_up', $message['gpbp_img']['up']['lit_suffix'], '.gif" alt="', $txt[ $message['gpbp_img']['up']['alt'] ], '" title="', $txt[ $message['gpbp_img']['up']['title'] ], '" /></a>';
}

echo  '
</div>';
}



And while you're at it, this as well.
Title: Re: Good Post/Bad Post Mod
Post by: krazytim on December 04, 2011, 09:21:28 PM
Any chance that this will be updated for SMF 2.0.1 any time soon??
Title: Re: Good Post/Bad Post Mod
Post by: Guillelmus on December 05, 2011, 03:14:25 AM
Quote from: krazytim on December 04, 2011, 09:21:28 PM
Any chance that this will be updated for SMF 2.0.1 any time soon??
Works just fine on 2.0.1. Install emulating SMF 2.0.
Title: Re: Good Post/Bad Post Mod
Post by: krazytim on December 05, 2011, 09:00:15 AM
Thanks for the tip! :) I actually had to emulate using "SMF 2.0 RC4" instead.

Had trouble finding the settings at first, but everything appears to be working just fine. :)

Gonna remove the "0" score I think, there are some useful tips in this thread for sure.
Title: Re: Good Post/Bad Post Mod
Post by: tbk22 on December 06, 2011, 01:42:46 PM
I would love an official update to 2.0.1
Title: Re: Good Post/Bad Post Mod
Post by: Guillelmus on December 06, 2011, 02:10:50 PM
Any code for showing latest votes?
Title: Re: Good Post/Bad Post Mod
Post by: rollsroyals on December 07, 2011, 07:29:29 AM
Quote from: tbk22 on December 06, 2011, 01:42:46 PM
I would love an official update to 2.0.1

That would be great!
Title: Re: Good Post/Bad Post Mod
Post by: guddone on December 29, 2011, 04:28:48 AM
I use SMF 2.0 RC5 and this modification is not compatible with it but i really need this modification as it keeps the forum interactive . I would love to know if anyone can make this compatible with smf2.0 rc5 . The creator of the mod appears to have been offline for months now
Title: Re: Good Post/Bad Post Mod
Post by: CedarMill on January 03, 2012, 10:36:23 AM
Please write this mod Good Post/Bad Post Mod 2.0.4 will work on SMF 2.0.2?
Title: Re: Good Post/Bad Post Mod
Post by: Guillelmus on January 03, 2012, 11:31:31 AM
Feature request: Best posts by member.
Title: Re: Good Post/Bad Post Mod
Post by: Guillelmus on January 12, 2012, 07:30:30 AM
Featuer req: Latest votes.  :)
Title: Re: Good Post/Bad Post Mod
Post by: ABREWCADABREW on January 18, 2012, 11:33:17 PM
Please, please update this mod for 2.02 - dying for it!  :'(
Title: Re: Good Post/Bad Post Mod
Post by: radioshack on January 20, 2012, 01:37:49 AM
Hi

I have tried to emulate with SMF2.0 RC4 in SMF 2.02

Only had one error in the Admin.php in default theme, but made the change as was required.

Admin setting pages comes up and works..
Settings for users work and setup....
Boards setup....

...but I still do not see that icons for good or bad post

Any suggestions maybe...or version 2.10 for SMF 2.02  ;)
Title: Re: Good Post/Bad Post Mod
Post by: ABREWCADABREW on January 21, 2012, 07:36:27 PM
Quote from: radioshack on January 20, 2012, 01:37:49 AM

Any suggestions maybe...or version 2.10 for SMF 2.02  ;)

Please, please update this mod for 2.02 - dying for it!  :'(
Title: Re: Good Post/Bad Post Mod
Post by: PSM on February 01, 2012, 09:59:08 AM
Damn, I upgraded to 2.0.2 from a 1.X version almost entirely because I wanted this mod, but it says it's either corrupt or not compatible with my version.  Looking forward to an update that will work.  This looks like a great mod.
Title: Re: Good Post/Bad Post Mod
Post by: searchgr on February 03, 2012, 02:44:49 PM
Personally i replaced the GPBP mod with the SMF Likes Pro Mod (http://www.smfpacks.com/likes) and i'm very satisfied.
Title: Re: Good Post/Bad Post Mod
Post by: Nucleorion on February 07, 2012, 08:44:24 AM
Is possible rank replies for amount of votes?
Title: Re: Good Post/Bad Post Mod
Post by: Guillelmus on February 12, 2012, 11:20:49 AM
Quote from: searchgr on February 03, 2012, 02:44:49 PM
Personally i replaced the GPBP mod with the SMF Likes Pro Mod (http://www.smfpacks.com/likes) and i'm very satisfied.
I just like the looks of GPBP mod more. It's less intruisive. Though, if SMF Likes could be modded to look more like GPBP...

Anyway, I'm mostly satisifed with GPBP. There are a few features, I'd like to see though:
List latest votes
List most voted posts of topic
List most voted posts by user

I might take a look into the code and write some of those myself, though.
Title: Re: Good Post/Bad Post Mod
Post by: bokiromanista on February 17, 2012, 05:24:51 PM
can someone adopt for 2.0.2
Title: Re: Good Post/Bad Post Mod
Post by: valmount on March 01, 2012, 11:19:14 PM
QuoteInstallations actions for "Good Post/Bad Post Mod"
The package you are trying to download or install is either corrupt or not compatible with this version of SMF.

im using SMF 2.0.2 | SMF © 2011, Simple Machines and download from http://custom.simplemachines.org/mods/index.php?mod=1890
Title: Re: Good Post/Bad Post Mod
Post by: tsis_k on March 25, 2012, 12:36:31 AM
This mod is exactly what my members have been asking for.  I would greatly appreciate if someone can get this mod to work for SMF 1.1.16
Title: Re: Good Post/Bad Post Mod
Post by: Prime32 on March 30, 2012, 05:10:19 AM
Running in 2.0.1, the permission for letting users access the mod settings doesn't work.
Title: Re: Good Post/Bad Post Mod
Post by: GlitchPC on April 02, 2012, 06:53:51 PM
Currently running this mod on an SMF 2.0.2 board.  During install...it failed on a couple of files but, with minimal editing...was able to fix in no time, at all.

So far...so good...with only one issue:

On topics with long titles, the image for voting and displaying who voted gets moved from position 1 to position 2.  (See attached image)

I'd like to move the display of the voting...along with who voted to position 3.

Can anyone with coding knowledge help me accomplish this?  I certainly would appreciate it.


Thanks, in advance...
Title: Re: Good Post/Bad Post Mod
Post by: tsis_k on April 03, 2012, 05:49:02 PM
Any way to get the voter list and disable negative vote features to work for smf 1.1.x?

I also would like to see negative and positive votes kept separate in future version of this mod.

Title: Re: Good Post/Bad Post Mod
Post by: GlitchPC on April 06, 2012, 08:21:48 PM
Modest bump...

http://www.simplemachines.org/community/index.php?topic=318290.msg3305579#msg3305579

Anyone?
Title: Re: Good Post/Bad Post Mod
Post by: Vahid‎‎ ‎Damanafshan on April 07, 2012, 07:54:39 PM
Is there a way to change the order of answers (of the first post) in a topic with regard to the number of positive votes they get?
For example, in websites based on OSQA (http://www.osqa.net), the best answers come automatically  to the top of the page and therefore the users in the future doesn't have to read all answers (posts) to find their answers.
Title: Re: Good Post/Bad Post Mod
Post by: virtualsimple on April 12, 2012, 06:03:33 PM
HELP!
Guests can not vote!
I need it to work with Meridian theme, it only seems to work with Curves theme.
Votes for the topics too please!
I agree with the previous reply about auto ordering the answers by votes.
[email protected]
Title: Re: Good Post/Bad Post Mod
Post by: Krusty McNugget on May 16, 2012, 09:50:50 AM
Set my 2.0.2 forum in "emulated" mode to look like it was version 2.0 RC4 - Mod gave me troubles on permessions (all other mods install just fine) made a temp folder manually and got the installer to run, got the messege that the mod had been installed without issues, however the mod never show's up in admin section so i cant config it.


Giving up on making it work for my forums... which is too bad cus this is exactly what we where looking for.

Edit: holy f'k its annyoing that i have to do a verification to post wth.
Title: Re: Good Post/Bad Post Mod
Post by: kak2z on May 19, 2012, 04:32:54 PM
Very nice mod! Please upgrade version! Thank you!
Title: Re: Good Post/Bad Post Mod
Post by: Etcher on June 07, 2012, 12:25:00 AM
Quote from: GlitchPC on April 06, 2012, 08:21:48 PM
Modest bump...

http://www.simplemachines.org/community/index.php?topic=318290.msg3305579#msg3305579

Anyone?
Can you show the minor edits you made to make it fully working for 2.0.2?
Title: Re: Good Post/Bad Post Mod
Post by: Biology Forums on June 28, 2012, 04:54:19 PM
I successfully converted this mod to: Spam, not spam instead of Good/bad...

Thanks for the wonderful idea.
Title: Re: Good Post/Bad Post Mod
Post by: kak2z on July 11, 2012, 10:25:11 AM
Quote from: Liam_michael on June 28, 2012, 04:54:19 PM
I successfully converted this mod to: Spam, not spam instead of Good/bad...

Thanks for the wonderful idea.

share with the public)
Title: Re: Good Post/Bad Post Mod
Post by: Viaja on July 28, 2012, 04:41:34 PM
Quote from: Etcher on June 07, 2012, 12:25:00 AM
Quote from: GlitchPC on April 06, 2012, 08:21:48 PM
Modest bump...

http://www.simplemachines.org/community/index.php?topic=318290.msg3305579#msg3305579

Anyone?
Can you show the minor edits you made to make it fully working for 2.0.2?

Yeah, I would like to know too.

Please, I need it works on 2.0.2 :(
Title: Re: Good Post/Bad Post Mod
Post by: Biology Forums on July 28, 2012, 04:51:09 PM
Quote from: kak2z on July 11, 2012, 10:25:11 AM
Quote from: Liam_michael on June 28, 2012, 04:54:19 PM
I successfully converted this mod to: Spam, not spam instead of Good/bad...

Thanks for the wonderful idea.

share with the public)

Well, I changed the language files for that good post = Like, and bad post = Spam.
Title: Re: Good Post/Bad Post Mod
Post by: merlyn333 on August 02, 2012, 04:43:20 PM
Hello folks:

I would like to thank you for sharing this mod.

But now, I'm here asking for help because it wasn't clear for me what files should I modify when in the installation the script could not modify the theme files.

I guess that is why I can't see the mod working.

Thanks for your answers.
Title: Re: Good Post/Bad Post Mod
Post by: Arantor on August 02, 2012, 04:51:25 PM
If you go to the mod's page, select the version you were using with emulation, then press Parse, it'll tell you exactly what it's trying to modify where.
Title: Re: Good Post/Bad Post Mod
Post by: merlyn333 on August 02, 2012, 04:52:41 PM
OK. Thanks!
Title: Re: Good Post/Bad Post Mod
Post by: merlyn333 on August 03, 2012, 05:29:13 PM
I have made almost every thing what I read there. I just didn't understand what should I do with the gpbp_install.php file. The mod is not working right know. Can any one help me making a remote connection to share my screen with TeamViewer?
Title: Re: Good Post/Bad Post Mod
Post by: Arantor on August 03, 2012, 05:59:15 PM
You should upload it to your server somewhere accessible, preferably in the folder where SSI.php is, then browse to it (yourforum.com/gpbp_install.php) so its code can be executed.

(Please note that most people here will not provide support via TeamViewer, because they prefer to give support on the forum where it benefits everyone, and not just the person asking for support. It's about being unselfish mostly.)
Title: Re: Good Post/Bad Post Mod
Post by: maciek1994 on August 04, 2012, 10:52:25 AM
Hello,
is it possible to add the list of people who voted the post? I mean in the version for 1.1.x.
Title: Re: Good Post/Bad Post Mod
Post by: sayl3r on August 11, 2012, 04:35:14 PM
we installed the good and bad post mode on our forum, now we got a problem, and that is that when someone's post is like or disliked, he cant see which posts are liked/disliked in his profile, and has to see the original post to undrestand if the post is liked or not, and who has liked it. we wanted to see if its possible that the users could see themselves in their profiles which of their posts are thanked.
what change should we make in the codes?
Title: Re: Good Post/Bad Post Mod
Post by: kak2z on August 15, 2012, 12:05:59 PM
I think the author left the SMF.
pity that the authors have good mods thrown their support
Title: Re: Good Post/Bad Post Mod
Post by: Jessica. on August 15, 2012, 10:56:19 PM
Quote from: maciek1994 on August 04, 2012, 10:52:25 AM
Hello,
is it possible to add the list of people who voted the post? I mean in the version for 1.1.x.

I thought there was already a list. for me, I can see a list

ex: http://testinggrounds.net84.net/index.php?topic=4.0
Title: Re: Good Post/Bad Post Mod
Post by: maciek1994 on August 18, 2012, 06:34:51 AM
Quote from: Jessica. on August 15, 2012, 10:56:19 PM
Quote from: maciek1994 on August 04, 2012, 10:52:25 AM
Hello,
is it possible to add the list of people who voted the post? I mean in the version for 1.1.x.

I thought there was already a list. for me, I can see a list

ex: http://testinggrounds.net84.net/index.php?topic=4.0
Gosh... I wrote SMF 1.1.X.
Title: Re: Good Post/Bad Post Mod
Post by: Jessica. on August 18, 2012, 06:07:50 PM
saw that, but for some reason I didn't process it. sorry >_>
Title: Re: Good Post/Bad Post Mod
Post by: sayl3r on August 19, 2012, 06:54:45 PM
Quote from: kak2z on August 15, 2012, 12:05:59 PM
I think the author left the SMF.
pity that the authors have good mods thrown their support
no,i want to be a list in the profile like Thank-O-Matic mod.
Title: Re: Good Post/Bad Post Mod
Post by: Blackburn on August 19, 2012, 07:16:15 PM
very good mod thank you ;)
Title: Re: Good Post/Bad Post Mod
Post by: arminsl on August 25, 2012, 04:31:54 AM
Great Mod !
I want a list of voters(for each user in all user's posts) in user profile.
how?
Please help me!
Title: Re: Good Post/Bad Post Mod
Post by: Major Wood on August 28, 2012, 10:32:19 PM
I can't seem to disable Show Respect gathered by users. I uncheck the box, hit save and it shows up checked again. Any ideas?

I can edit out where it actually displays, but I would prefer to make it work properly.
Title: Re: Good Post/Bad Post Mod
Post by: vizzini on September 26, 2012, 06:03:42 PM
Has anyone successfully installed this mod on 2.0.2?
Title: Re: Good Post/Bad Post Mod
Post by: mehrtadbir on September 28, 2012, 11:45:41 AM
Hi
please update this mod to 2.0.2

thanks
Title: Re: Good Post/Bad Post Mod
Post by: Rain Forest on October 10, 2012, 09:39:22 AM
I have customized this and it works now for me on 2.0.2 :)

try at: http://www.bluetender.net

PM me if you want this for 2.0.2
Title: Re: Good Post/Bad Post Mod
Post by: Sermac on October 18, 2012, 12:52:40 PM
Quote from: Major Wood on August 28, 2012, 10:32:19 PM
I can't seem to disable Show Respect gathered by users. I uncheck the box, hit save and it shows up checked again. Any ideas?

I can edit out where it actually displays, but I would prefer to make it work properly.

Hit the right save button! There are two of them, one for the basic setting and one for tha board setting.
Title: Re: Good Post/Bad Post Mod
Post by: diablo3x.dk on November 14, 2012, 07:36:23 AM
Hi there.

I recently tried to install this modification. The installation went smooth with no errors showing up. Afterwards I was able to navigate to the modfication settings and manage all of the features of the modification. However, when I tried to access the forum, I got an error with no specific details.

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fdiablo3x.dk%2Fimages%2Fcapture.jpg&hash=6c3f268f807666e2e6b3c8fae25f7592f6771189)
Sorry. Danish.

Translation:

"Server error. The website found an error trying to get http://diablo3x.dk/index.php?action=forum. It may be caused by maintenance or wrong configuration"

I have no clue where to start looking for the error. It might have something to do with some other installed modfications such as Simple Portal - not sure. I am able to view topics and the SimplePortal front site (www.diablo3x.dk).

Maybe I should add that I installed the modification (version 2.0 rc4) by emulating that version. I don't know if that is of any importance.

Below a list of other installed modifications:

Aeva Media
Archive Shouts as Posts
AvatarSelect
BoardColor
Customized Profile
Site Menu
Default Avatar
Enhanced About Page
Global Message Box By Smfsimple.com
Good Post/Bad Post Mod
Add GooglePlus to Posts
Guest Closed Topic
Images On Board
Invitation Message In Your Face (IMIYF)
Join date and Location in Posts
Leet Mod
Member Group Icons
Member Color Link
Menu Editor Lite
Menu Order
PM to New Members
Related Topics
RSS Feed Poster
SimplePortal
SimplePortal
Sitemap
SMF 2.0.1 Update
SMF 2.0.2 Update
Spoiler Tag
Welcome Topic Mod

I would really appreciate any help on this. Might even pay a little. Thank you!
Title: Re: Good Post/Bad Post Mod
Post by: Blackylol on November 25, 2012, 12:32:12 AM
Is there a way to make the buttons disappear after you voted ?
Title: Re: Good Post/Bad Post Mod
Post by: Skaty on January 02, 2013, 12:17:03 AM
This is a great mod but it is need a little regulation.  Can we do something top comment like Youtube ?
Title: Re: Good Post/Bad Post Mod
Post by: tdot on January 04, 2013, 08:10:18 AM
Has anyone figured out how to display a separate count for positive and negative votes?

The mod only has a total tally for each post, not positive and negative votes but it does keep track of the number of votes so the number of positive and negative votes could be worked out... If only I could figure out how.
Title: Re: Good Post/Bad Post Mod
Post by: Skaty on January 06, 2013, 08:38:50 PM
Quote from: Skaty on January 02, 2013, 12:17:03 AM
This is a great mod but it is need a little regulation.  Can we do something top comment like Youtube ?

Any chance for this ?
Title: Re: Good Post/Bad Post Mod
Post by: Pr07o7yp3 on April 11, 2013, 10:18:23 PM
Can you update this mod? I need it for 2.0.4. Thanks. :)
Title: Re: Good Post/Bad Post Mod
Post by: GZ06 on May 16, 2013, 03:08:35 AM
Quote from: Pr07o7yp3 on April 11, 2013, 10:18:23 PM
Can you update this mod? I need it for 2.0.4. Thanks. :)

I too.
Title: Re: Good Post/Bad Post Mod
Post by: CheeseHead05 on May 17, 2013, 12:52:55 AM
Hi,

I would like to know how do I make it possible for every member to be able to vote on a post because currently I am the only able to do so.

PS
I have installed the SMF Gallery Mod on my forum and want to know if there is a way that I can add GP/BP to the gallery so that members can like/dislike each picture post in the gallery (with this mod I will be able to keep track on how many likes/dislikes)..

Thanks in advance!
Title: Re: Good Post/Bad Post Mod
Post by: TheListener on May 17, 2013, 01:06:57 AM
QuoteI would like to know how do I make it possible for every member to be able to vote on a post because currently I am the only able to do so

Have you checked the permissions?
Title: Re: Good Post/Bad Post Mod
Post by: GZ06 on May 18, 2013, 01:14:28 PM
Quote from: CheeseHead05 on May 17, 2013, 12:52:55 AM
Hi,

I would like to know how do I make it possible for every member to be able to vote on a post because currently I am the only able to do so.


go to admin panel and look at member groups permissions.
Title: Re: Good Post/Bad Post Mod
Post by: TheListener on May 18, 2013, 01:18:17 PM
Quote from: GZ06 on May 18, 2013, 01:14:28 PM
Quote from: CheeseHead05 on May 17, 2013, 12:52:55 AM
Hi,

I would like to know how do I make it possible for every member to be able to vote on a post because currently I am the only able to do so.


go to admin panel and look at member groups permissions.

Er I suggest you read the previous post.

::)
Title: Re: Good Post/Bad Post Mod
Post by: CheeseHead05 on May 19, 2013, 07:00:34 PM
Old Fossil,

I went into the membergroups' permission and saw nothing in reference to GPBP. I dont even know what and what not to check..Im stuck!
Title: Re: Good Post/Bad Post Mod
Post by: re1lazz on May 23, 2013, 09:44:43 AM
how to make "Respect points" only show on profile?
Title: Re: Good Post/Bad Post Mod
Post by: re1lazz on May 24, 2013, 03:42:22 PM
UP  :(
Title: Re: Good Post/Bad Post Mod
Post by: CheeseHead05 on May 27, 2013, 01:32:28 AM
Does anyone know if it is possible to hook the GP/BP mod up to SMF gallery?

Thanks in advance!
Title: Re: Good Post/Bad Post Mod
Post by: G6 on May 30, 2013, 02:00:37 PM
 Is it possible to order topics in a board based to their votes? For example i have a board where people can make topics and upvote/downvote them, and i want to order them by their votes, 1st topic has +20, 2nd has +12, 3rd has +7 and so on, and of course the opposite, 1st -2, 2nd -1, 3rd 2. If it's not it would be an awesome update.

Problem, cannot install it.
I use SMF 2.0.4 on a local server, i tried the latest version of "Good Post/Bad Post Mod" and it says "The package you are trying to download or install is either corrupt or not compatible with this version of SMF.". Dunno what's wrong.

Nevermind, i just emulated the mod to SMF 2.0 RC4 and it worked.
Title: Re: Good Post/Bad Post Mod
Post by: Jorge D. Fuentes on June 12, 2013, 11:43:59 PM
Is there a way to reset EVERYONE's Respect Values back to Zero?

I installed this mod and we've had some issues with it, because I enabled negative posting in addition to anonymous voting....
In hindsight, I should have realized things would go awry:

-It seems that people are creating drone/duplicate accounts just to +1 themselves, or to -1 someone they dislike.  Even with a minimum post count, this still happens.  There's no real way to check.
-People are starting to derail topics whenever their posts get -1'd, "Who the hell -1'd me!?  Show yourself!"
-Some people are purposely trolling in order to see who can have the highest negative score.

So I'd like to reset everyone to Zero, then disable negative posting, and enable showing who posted.
I feel that, if I enable showing who posted, it'll only generate more forum strife between members.

I'm using GP/BP 2.0.4, and my SMF is version 2.0.3.
Title: Re: Good Post/Bad Post Mod
Post by: CheeseHead05 on June 13, 2013, 07:11:03 PM
Does anyone know why when I install this mod and turn it on, it turns the board grey. But when I uninstall the mod, my board goes back to white...Any ideas? Also, it collapses posts and reads "hidden show this post." which I dont want.
Title: Re: Good Post/Bad Post Mod
Post by: TheListener on June 13, 2013, 07:17:31 PM
From what I can see judging by the images on the mods first post that is supposed to happen.

:)
Title: Re: Good Post/Bad Post Mod
Post by: CheeseHead05 on June 13, 2013, 07:43:38 PM
but y is it grey?
Title: Re: Good Post/Bad Post Mod
Post by: TheListener on June 13, 2013, 07:56:17 PM
Quote from: CheeseHead05 on June 13, 2013, 07:43:38 PM
but y is it grey?

These would possibly be the bad rated posts.
Title: Re: Good Post/Bad Post Mod
Post by: CheeseHead05 on June 13, 2013, 08:34:08 PM
Oooookkkkkk! Gotcha! It worked! Thanks Old
Title: Re: Good Post/Bad Post Mod
Post by: Bigiain on July 02, 2013, 08:21:06 AM
Does anyone know a way I can include top posts in a SimplePortal block? Is there a quick snippet of BBC or PHP I can drop in?
Title: Re: Good Post/Bad Post Mod
Post by: Skaty on July 02, 2013, 11:00:00 AM
Quote from: Bigiain on July 02, 2013, 08:21:06 AM
Does anyone know a way I can include top posts in a SimplePortal block? Is there a quick snippet of BBC or PHP I can drop in?

i wonder that too
Title: Re: Good Post/Bad Post Mod
Post by: DeroZ on July 04, 2013, 04:17:20 AM
anyone can help me?, i want move  to the right of check box.

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fi1146.photobucket.com%2Falbums%2Fo528%2FJocla2%2Fmovevote.png&hash=46d605407cde6bfc0326a26e3c0b21670b5d1a49)

Title: Re: Good Post/Bad Post Mod
Post by: DarthRiddle on July 14, 2013, 01:00:17 PM
Can anyone update this so it works with the new SMF 2.0.4?
Title: Re: Good Post/Bad Post Mod
Post by: Skaty on July 15, 2013, 02:05:35 PM
i think there is no options to give a time limit for votes ?
Title: Re: Good Post/Bad Post Mod
Post by: orlandoryo on July 19, 2013, 10:10:58 AM
Years later and nothing on 2.0.4...  :-\
Title: Re: Good Post/Bad Post Mod
Post by: CheeseHead05 on July 27, 2013, 01:05:25 AM
I installed a new theme. my GP/BP icons are not showin up on my forum but I transferred all the files to my theme's "image" folder. I have even tried adding the files to the default/images as well as my custom theme's images/posts folder but nothing..any ideas?
Title: Re: Good Post/Bad Post Mod
Post by: InSanitySA on July 30, 2013, 09:12:04 AM
This mod looks awesome cant someone make something similiar for 2.0.4 ?
Title: Re: Good Post/Bad Post Mod
Post by: TheListener on July 31, 2013, 11:51:41 AM
Have a read of the Mod Emulate link in my signature.
Title: Re: Good Post/Bad Post Mod
Post by: CheeseHead05 on July 31, 2013, 08:24:12 PM
I re-installed this mod and now I cant get rid of the "Respect" that shows in the post area under my name..(Even after I unchecked the box and hit save). Any suggestions?
Title: Re: Good Post/Bad Post Mod
Post by: Skaty on August 13, 2013, 05:10:19 PM
How can i show the votes seperately ? Minus and plus seperately. Not like -1,+1 = 0, but seperately to show like id it is -1,+1 it will show both.

Thank you.
Title: Re: Good Post/Bad Post Mod
Post by: CheeseHead05 on August 13, 2013, 07:12:37 PM
Is it possible that I can have only the arrows on the very first post and that's it? Or once I install this mod, the arrows are on all posts?
Title: Re: Good Post/Bad Post Mod
Post by: Skaty on August 14, 2013, 04:54:01 AM
How can i see the most good post of all time ?

i have 3 questions now :D
Title: Re: Good Post/Bad Post Mod
Post by: Skaty on September 18, 2013, 05:10:53 PM
aand 4 question :D  how  can i bereave member to give vote ?
Title: Re: Good Post/Bad Post Mod
Post by: Ventic on September 23, 2013, 09:33:40 AM
What  about a option for a limit vote?
Title: Re: Good Post/Bad Post Mod
Post by: Wilz on September 24, 2013, 12:21:53 PM
When I try to install this mod it says

The package you are trying to download or install is either corrupt or not compatible with this version of SMF.

My SMF version is 2.0.5 and I've downloaded 2.0.4a mod from this version.

Already checked this http://wiki.simplemachines.org/smf/How_can_install_a_mod_that_doesn%27t_work_in_my_SMF_version but it isn't working. Any help?
Title: Re: Good Post/Bad Post Mod
Post by: Ventic on September 24, 2013, 02:23:34 PM
Open packageinfo.xml find smf versions and change all of them to 2.0.5.It works fine.
I uploaded mine,which works fine.
Title: Re: Good Post/Bad Post Mod
Post by: Wilz on September 24, 2013, 02:45:29 PM
I can only  view it, not edit. Any other solution/s?
Title: Re: Good Post/Bad Post Mod
Post by: margarett on September 24, 2013, 02:58:48 PM
Version emulation doesn't work?! Any errors?
Quote from: Wilz on September 24, 2013, 02:45:29 PM
I can only  view it, not edit. Any other solution/s?
That's a zip file with text files inside, how come you can't edit it?
Title: Re: Good Post/Bad Post Mod
Post by: Ventic on September 24, 2013, 03:10:23 PM
Quote from: Wilz on September 24, 2013, 02:45:29 PM
I can only  view it, not edit. Any other solution/s?
download my attach.its ready for you
Title: Re: Good Post/Bad Post Mod
Post by: Wilz on October 11, 2013, 09:36:11 AM
I have a problem with this. After I installed this mod (with help above) I always get double arrows and I don't know why. I mean I get four arrows and I can vote twice. Is there any way to disable this? So I can vote only one time (up or down)?
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fi.imgur.com%2FVzxbyQz.png&hash=76715e9d00fb5d88a77fcadc1829d9eee8930976)
Title: Re: Good Post/Bad Post Mod
Post by: DeVIL-I386 on November 02, 2013, 05:29:35 PM
This mod has problems displaying in a dark theme with gray font color (http://www.dzinerstudio.com/index.php?action=downloads;sa=view;down=139).
Title: Re: Good Post/Bad Post Mod
Post by: Bodom on January 13, 2014, 09:33:09 AM
Is there anything else like this, but maybe newer and updated?
Also, it doesn't seem to be displaying for forum admins and mods.. Just has a 0 with no arrows.


And can you hide the "Respect: 0" from under Karama?
Title: Re: Good Post/Bad Post Mod
Post by: dand on March 04, 2014, 09:55:06 AM
Hi guys,
I installed this mod before for version 1.1.x and it worked fine.
Now I upgraded my forum to 2.0.7 and installed this mod again (emulated 2.0 RC4). It installed fine, but now the problem: when I click the up or down arrows - it doesn't increase the count.

I checked permissions. I also tried logged in as admin. Still doesn't work.


I found the error log says:
Database error: Unknown column 'log_time' in 'field list'
FIle: /var/www/vhosts/mydomain.com/httpdocs/forum/Sources/GoodPostBadPost.php
Line: 181

Here is the line 181:

else
{
// Wipe out empty scores.
$amount = $_REQUEST['sa'] == 'up' ? 1 : -1;
$success = $_REQUEST['sa'] == 'up' ? 'up' : 'down';
$opposite = 0;
$smcFunc['db_insert']('insert',
'{db_prefix}log_gpbp',
array(
'id_msg' => 'int', 'id_member' => 'int', 'score' => 'int', 'id_poster' => 'int', 'log_time' => 'int'
),
array(
$message, $context['user']['id'], $amount, $id_poster, time()
),
array()
);
}



And here is the same peace of code in previous versino that I used in smf 1.1.x:

else
{
// Wipe out empty scores.
$amount = $_REQUEST['sa'] == 'up' ? 1 : -1;
$success = $_REQUEST['sa'] == 'up' ? 'up' : 'down';
$opposite = 0;
db_query("
INSERT INTO {$db_prefix}log_gpbp
(ID_MSG, ID_MEMBER, score, ID_POSTER)
VALUES
(" . $message . ", " . $context['user']['id'] . ", " . $amount . ", " . $id_poster . ")",__FILE__,__LINE__);
}


What could have gone wrong?
Title: Re: Good Post/Bad Post Mod
Post by: dand on March 04, 2014, 10:47:12 AM
OK, resolved it by adding "log_time" column to SMF database table "smf_log_gpbp".


After starting command line "mysql" tool I selected my SMF database like so:

mysql -u "admin" -p
show databases;
use my_smf_database;
show tables;
show columns from smf_log_gpbp;



and I used the following command to add the missing column to "gpbp" table:


ALTER TABLE smf_log_gpbp ADD log_time INTEGER;


I hope I nailed it.
Now it works.
Title: Re: Good Post/Bad Post Mod
Post by: Biology Forums on March 04, 2014, 12:45:11 PM
Thanks for posting the fix. I might change my forum to 2.x sometime later. I'm sure this will help.
Title: Re: Good Post/Bad Post Mod
Post by: rik300 on March 23, 2014, 10:13:56 AM
Any plans to  make it work on 2.0.7 ?
Title: Re: Good Post/Bad Post Mod
Post by: CedarMill on April 21, 2014, 12:38:01 PM
rik300, this module works on SMF 2.0.7 8)
Title: Re: Good Post/Bad Post Mod
Post by: NEOne15 on May 05, 2014, 06:53:44 PM
'// Good Post/Bad Post: it may be nice to let users know of this. $txt['whotopic_gpbp'] = 'Voting a message from "%s".';'

This appears at the top of my Administrative Panel index, but on no other pages.
Title: Re: Good Post/Bad Post Mod
Post by: margarett on May 05, 2014, 06:58:52 PM
Check for that text in Modifications.english.php after the final ?>
Title: Re: Good Post/Bad Post Mod
Post by: Moniker on May 12, 2014, 11:31:48 AM
Quote from: CedarMill on April 21, 2014, 12:38:01 PM
rik300, this module works on SMF 2.0.7 8)

I have tried changing the versions as described previously and I am not able to get it to install. I'm running 2.0.7.

Anyone get it going in 2.0.7? Is there a fix or modification to the files that I missed?

If anyone can help, I would really appreciate it.

Edit: I got it working by emulating version 2.0.4 - see: http://wiki.simplemachines.org/smf/How_can_I_install_a_mod_that_doesn%27t_work_in_my_SMF_version
Title: Re: Good Post/Bad Post Mod
Post by: Moniker on May 16, 2014, 04:20:01 AM
Quote from: NEOne15 on May 05, 2014, 06:53:44 PM
'// Good Post/Bad Post: it may be nice to let users know of this. $txt['whotopic_gpbp'] = 'Voting a message from "%s".';'

This appears at the top of my Administrative Panel index, but on no other pages.
I am getting this very same thing and can't find the cause.

Quote from: margarett on May 05, 2014, 06:58:52 PM
Check for that text in Modifications.english.php after the final ?>
I looked here and found nothing that resolved the problem.




Anyone else experiencing this? Anyone know if a fix?
Title: Re: Good Post/Bad Post Mod
Post by: margarett on May 16, 2014, 06:15:23 AM
Check Who.english.php
According the manual installation instructions, that's where that text is.
Title: Re: Good Post/Bad Post Mod
Post by: ExSpirit on May 27, 2014, 03:10:14 AM
Currently each user had total "Respect" shown, but I would like to show number of "Good posts" and number of "Bad posts". Can someone help me where I can get those numbers from?

It would also be great if we could specific in permissions page who can vote up and who can vote down (not it's only 1 permission for both), this way normal members can only vote up, and special members also down...
Title: Re: Good Post/Bad Post Mod
Post by: DDDD11 on July 07, 2014, 04:48:16 PM
I just did the mod installation and it said successful. I can click on the basic and advanced configuration settings but when I click on GPBP Tools it gives this error:

Table 'forums.smf_log_gpbp' doesn't exist
File: /var/www/html/forums/Sources/GoodPostBadPost.php
Line: 505

Also, if I enable GP / BP on any board I get his error when clicking on a post:

Table 'forums.smf_log_gpbp' doesn't exist
File: /var/www/html/forums/Sources/Display.php
Line: 1161

Here is partial log from the mysql.

140707 13:37:26   127 Connect   root@localhost on
                 
                  127 Query     CREATE TABLE smf_log_gpbp
(
        `id_msg` int(10) unsigned NOT NULL ,
        `id_member` mediumint(8) unsigned NOT NULL ,
        `score` smallint(2) NOT NULL ,
        `id_poster` mediumint(8) unsigned NOT NULL ,
        `log_time` int(10) unsigned NOT NULL ,
        KEY id_member (id_member),
        KEY id_poster (id_poster),
        PRIMARY KEY (id_msg,id_member)) TYPE=MyISAM
                  127 Query     SHOW FIELDS
                FROM `smf_messages`
                  127 Query     ALTER TABLE smf_messages
                        ADD `gpbp_score` smallint(6) NOT NULL default '0'
140707 13:37:28   127 Query     SHOW FIELDS
                FROM `smf_members`
                 
It looks like the tables are removed: here is the smf_log_packages log:

a:4:{i:0;a:2:{i:0;s:12:"remo
ve_table";i:1;s:12:"smf_log_gpbp";}i:1;a:3:{i:0;s:13:"remove_column";i:1;s:10:"smf_boards";i:2;s:11:"enable_gpbp";}i:2;a:3:{i:0;s:13:"remove_colu
mn";i:1;s:12:"smf_messages";i:2;s:10:"gpbp_score";}i:3;a:3:{i:0;s:13:"remove_column";i:1;s:11:"smf_members";i:2;s:12:"gpbp_respect";

So what is going on with this?
Title: Re: Good Post/Bad Post Mod
Post by: DDDD11 on July 08, 2014, 03:30:26 PM
Quote from: DDDD11 on July 07, 2014, 04:48:16 PM
I just did the mod installation and it said successful. I can click on the basic and advanced configuration settings but when I click on GPBP Tools it gives this error:

Table 'forums.smf_log_gpbp' doesn't exist
File: /var/www/html/forums/Sources/GoodPostBadPost.php
Line: 505

Also, if I enable GP / BP on any board I get his error when clicking on a post:

Table 'forums.smf_log_gpbp' doesn't exist
File: /var/www/html/forums/Sources/Display.php
Line: 1161

Here is partial log from the mysql.

140707 13:37:26   127 Connect   root@localhost on
                 
                  127 Query     CREATE TABLE smf_log_gpbp
(
        `id_msg` int(10) unsigned NOT NULL ,
        `id_member` mediumint(8) unsigned NOT NULL ,
        `score` smallint(2) NOT NULL ,
        `id_poster` mediumint(8) unsigned NOT NULL ,
        `log_time` int(10) unsigned NOT NULL ,
        KEY id_member (id_member),
        KEY id_poster (id_poster),
        PRIMARY KEY (id_msg,id_member)) TYPE=MyISAM
                  127 Query     SHOW FIELDS
                FROM `smf_messages`
                  127 Query     ALTER TABLE smf_messages
                        ADD `gpbp_score` smallint(6) NOT NULL default '0'
140707 13:37:28   127 Query     SHOW FIELDS
                FROM `smf_members`
                 
It looks like the tables are removed: here is the smf_log_packages log:

a:4:{i:0;a:2:{i:0;s:12:"remo
ve_table";i:1;s:12:"smf_log_gpbp";}i:1;a:3:{i:0;s:13:"remove_column";i:1;s:10:"smf_boards";i:2;s:11:"enable_gpbp";}i:2;a:3:{i:0;s:13:"remove_colu
mn";i:1;s:12:"smf_messages";i:2;s:10:"gpbp_score";}i:3;a:3:{i:0;s:13:"remove_column";i:1;s:11:"smf_members";i:2;s:12:"gpbp_respect";

So what is going on with this?

Okay so I just manually added the table back into the database without the "TYPE=MyISAM" and it works.

Can we get an updated version that replace

TYPE=MyISAM

with

ENGINE=MyISAM

due to MySQL updates? Also, if anyone knows which file this is defines I would appreciate it, searching each one is proving a pain.

I'm thinking this is edited in the MySQL file. Hmm, I will get back.
Title: Re: Good Post/Bad Post Mod
Post by: DDDD11 on July 11, 2014, 05:39:53 PM
Quote from: DDDD11 on July 08, 2014, 03:30:26 PM
Quote from: DDDD11 on July 07, 2014, 04:48:16 PM
I just did the mod installation and it said successful. I can click on the basic and advanced configuration settings but when I click on GPBP Tools it gives this error:

Table 'forums.smf_log_gpbp' doesn't exist
File: /var/www/html/forums/Sources/GoodPostBadPost.php
Line: 505

Also, if I enable GP / BP on any board I get his error when clicking on a post:

Table 'forums.smf_log_gpbp' doesn't exist
File: /var/www/html/forums/Sources/Display.php
Line: 1161

Here is partial log from the mysql.

140707 13:37:26   127 Connect   root@localhost on
                 
                  127 Query     CREATE TABLE smf_log_gpbp
(
        `id_msg` int(10) unsigned NOT NULL ,
        `id_member` mediumint(8) unsigned NOT NULL ,
        `score` smallint(2) NOT NULL ,
        `id_poster` mediumint(8) unsigned NOT NULL ,
        `log_time` int(10) unsigned NOT NULL ,
        KEY id_member (id_member),
        KEY id_poster (id_poster),
        PRIMARY KEY (id_msg,id_member)) TYPE=MyISAM
                  127 Query     SHOW FIELDS
                FROM `smf_messages`
                  127 Query     ALTER TABLE smf_messages
                        ADD `gpbp_score` smallint(6) NOT NULL default '0'
140707 13:37:28   127 Query     SHOW FIELDS
                FROM `smf_members`
                 
It looks like the tables are removed: here is the smf_log_packages log:

a:4:{i:0;a:2:{i:0;s:12:"remo
ve_table";i:1;s:12:"smf_log_gpbp";}i:1;a:3:{i:0;s:13:"remove_column";i:1;s:10:"smf_boards";i:2;s:11:"enable_gpbp";}i:2;a:3:{i:0;s:13:"remove_colu
mn";i:1;s:12:"smf_messages";i:2;s:10:"gpbp_score";}i:3;a:3:{i:0;s:13:"remove_column";i:1;s:11:"smf_members";i:2;s:12:"gpbp_respect";

So what is going on with this?

Okay so I just manually added the table back into the database without the "TYPE=MyISAM" and it works.

Can we get an updated version that replace

TYPE=MyISAM

with

ENGINE=MyISAM

due to MySQL updates? Also, if anyone knows which file this is defines I would appreciate it, searching each one is proving a pain.

I'm thinking this is edited in the MySQL file. Hmm, I will get back.

Okay so I can't find the SQL file in the Mod that is setting this. Anyone know anything  :'(
Title: Good Post/Bad Post simple modification
Post by: Uardo on November 29, 2014, 11:06:36 AM
Hey Guys

I couldn't request this modification on mod topic where it was posted because it was locked.

I would like to know if someone can make this mod "  Good Post/Bad Post  (http://custom.simplemachines.org/mods/?mod=1890) " so at the message of the week that displays in the Info center at the board index, including the most voted messages of the past few days will not display messages from topics that has been locked. So i am not a scripter nor i have any knowledge how php works, if anyone willing to make it please add a code that will ignore locked topic from displaying in messages of the week.

Sorry if sometimes i explain myself bad, so if I'm confusing or not clear... tell me.

-Thanks
Title: Re: Good Post/Bad Post simple modification
Post by: Uardo on December 05, 2014, 11:31:37 AM
None willing to help?  :-X
Title: Re: Good Post/Bad Post simple modification
Post by: margarett on December 05, 2014, 02:22:57 PM
Gave a quick look at the code, it's not a direct task...

The function that gathers that content isn't checking, in any point, the "topics" table, which is the only place where you know a topic is locked.
In order to do that, you would need to join both the messages and topics tables to the first query and then exclude locked topics. I'm not sure about the performance implications on that...
Title: Re: Good Post/Bad Post simple modification
Post by: Uardo on December 05, 2014, 05:14:46 PM
Thank you for replying,
but as i said above i have no idea how scripting stuffs work, if it is possible please write the code that you already explained above and tell me where i should exactly add it. If you believe you can do it, please do it, it's not an issue the performance implication for me.

Thank You in Advance!
Title: Re: Good Post/Bad Post Mod
Post by: margarett on December 10, 2014, 01:57:45 PM
I merged this into the MOD's support topic.

So, you can do this by editing Sources/GoodPostBadPost.php, find:
$request = $smcFunc['db_query']('','
SELECT SUM(score) AS score, id_msg AS msg
FROM {db_prefix}log_gpbp
WHERE log_time >= {int:weekago}
GROUP BY msg
ORDER BY score DESC
LIMIT {int:limit}',
array(
'weekago' => $aWeekAgo,
'limit' => $modSettings['gpbp_show_best_topics']
)
);

And replace with this:
$request = $smcFunc['db_query']('','
SELECT SUM(log.score) AS score, log.id_msg AS msg
FROM {db_prefix}log_gpbp AS log
JOIN {db_prefix}messages AS mess ON (mess.id_msg = log.id_msg)
JOIN {db_prefix}topics AS top ON (mess.id_topic = top.id_topic)
WHERE log.log_time >= {int:weekago}
AND top.locked = 0
GROUP BY msg
ORDER BY score DESC
LIMIT {int:limit}',
array(
'weekago' => $aWeekAgo,
'limit' => $modSettings['gpbp_show_best_topics']
)
);

It worked here in my short tests.

Anyway, do note that this information isn't cached and will be loaded on every page load of your board index. It's not a pretty query :P

Keep a backup of your original file before you mess it, will you? :P
Title: Re: Good Post/Bad Post Mod
Post by: Arantor on December 10, 2014, 02:20:05 PM
Are you intending INNER or LEFT joins there?
Title: Re: Good Post/Bad Post Mod
Post by: margarett on December 10, 2014, 02:22:46 PM
INNER. All fields have to exist in every table ;)
Title: Re: Good Post/Bad Post Mod
Post by: Arantor on December 10, 2014, 02:36:50 PM
That's what I thought, but it's always best to clarify... we didn't have a debate about this in one of the other boards today about this :P
Title: Re: Good Post/Bad Post Mod
Post by: vallejo on December 21, 2014, 11:52:36 AM
Buenas me pueden colaborar, porque no puedo instalar este MOD, mi SMF es V 2.0.9 trato de emularlo a la 2.0.4 e inferior y me dice que puede estar dañado el archivo gracias..!
Title: Re: Good Post/Bad Post Mod
Post by: Myth_72 on March 05, 2015, 04:05:34 PM
How to uninstall this mod, it haven't option for uninstall?
Title: Re: Good Post/Bad Post Mod
Post by: Myth_72 on March 13, 2015, 07:40:16 AM
Someone to help me? How to uninstall this mod? There isn't option "uninstall" only "delete".
Title: Re: Good Post/Bad Post Mod
Post by: NHWD on March 14, 2015, 04:32:33 AM
Quote from: Myth_72 on March 13, 2015, 07:40:16 AM
Someone to help me? How to uninstall this mod? There isn't option "uninstall" only "delete".
If you emulated the version number to install the mod then you have to do the same to uninstall it.
Title: Re: Good Post/Bad Post Mod
Post by: Low on July 04, 2015, 09:43:02 AM
Does this work on 2.0.9 and/or 2.0.10?
Title: Re: Good Post/Bad Post Mod
Post by: MESWEB on July 04, 2015, 02:06:58 PM
Yes! But only with old Themes. Redsy not support this mod but just simple adding codes to file php should work with not support themes.
Title: Re: Good Post/Bad Post Mod
Post by: Motahhari on February 12, 2016, 05:39:31 AM
I have about 2500,000 scores in my database. When I use recount tool, i get a white page! What is the problem?
Title: Re: Good Post/Bad Post Mod
Post by: Dreadaxe on April 25, 2016, 01:38:04 PM
Possibility to send notification when a post is like?

I can do french version I you want.
Title: Re: Good Post/Bad Post Mod
Post by: kcthelegend on May 16, 2016, 08:53:22 AM
OMG......CAN SOMEONE just give me the file and i will replace it....idk how to install it
Title: Re: Good Post/Bad Post Mod
Post by: Atomixx on March 29, 2017, 09:16:43 PM
Trying to install this mod, have emulated to 2.0.4 and 2.0 RC3 but I keep getting this error

You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'FROM smf_log_packages
WHERE package_id = 'OutofOrder:GoodPostBadPost'
AND i' at line 2
File: /storage/h7/475/1127475/public_html/Sources/Packages.php
Line: 248


Any ideas?
Title: Re: Good Post/Bad Post Mod
Post by: Castagna on April 16, 2017, 10:56:02 PM
Hello!

I need help. I'm using SMF 2.0.10, and I want this mod so bad. I tried emulating 2.0.4 via Package Manager and nothing. Is there any manual fix or something I could try?

Thanks you.